On Wed, 15 May 2024 08:21:36 GMT, Christoph Langer wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> c
On Wed, 15 May 2024 08:21:36 GMT, Christoph Langer wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> c
On Tue, 7 May 2024 08:43:09 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 7 May 2024 08:43:09 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Wed, 8 May 2024 08:06:03 GMT, Christoph Langer wrote:
> Looks reasonable. Give us some time to test that in our CI.
@dfuch May I merge now?
-
PR Comment: https://git.openjdk.org/jdk/pull/18884#issuecomment-2107481714
On Tue, 7 May 2024 15:19:14 GMT, Daniel Fuchs wrote:
> Looks reasonable. Give us some time to test that in our CI.
Our CI testing looks good. Please let me know when you are done.
-
PR Comment: https://git.openjdk.org/jdk/pull/18884#issuecomment-201686
On Tue, 7 May 2024 08:43:09 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 7 May 2024 07:08:55 GMT, Jaikiran Pai wrote:
> Hello Christoph, the latest changes look fine to me. I've added a trivial
> comment about reading the inputstream in one of the test, but you can leave
> it in its current form if you prefer to. Please run `tier2` tests once before
> integ
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
On Wed, 1 May 2024 20:45:27 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Wed, 1 May 2024 20:45:27 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 30 Apr 2024 15:07:52 GMT, Daniel Fuchs wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> co
On Tue, 30 Apr 2024 15:04:37 GMT, Daniel Fuchs wrote:
>> I've thought about this, too. However, I see the only critical point why it
>> could merit a `/othervm` test is this thing with querying the thread CPU
>> time of the Keep-Alive-SocketCleaner thread. But I think the likelihood of
>> this
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
On Sat, 27 Apr 2024 13:15:37 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Thu, 25 Apr 2024 08:04:16 GMT, Christoph Langer wrote:
>> test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java line 154:
>>
>>> 152:
>>> 153: // if Keep-Alive-SocketCleaner consumes more than
>>> 50% of cpu then we
>>> 154: // can assume a recursive
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
On Wed, 24 Apr 2024 07:01:52 GMT, Jaikiran Pai wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
>>
>> Co-authored-by: Andrey Turbanov
>
> test/
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
On Wed, 24 Apr 2024 06:47:55 GMT, Jaikiran Pai wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
>>
>> Co-authored-by: Andrey Turbanov
>
> test/
On Tue, 23 Apr 2024 08:39:56 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 23 Apr 2024 08:39:56 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 23 Apr 2024 08:39:56 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 23 Apr 2024 08:39:56 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
On Mon, 22 Apr 2024 11:06:57 GMT, Christoph Langer wrote:
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> reso
While working in that area I found some potential for cleanup of a few tests.
Most notably:
B5045306.java:
- does not need to run in othervm
- the executor service that it uses should be shut down eventually to free
resources
B8291637.java:
- use just one instead of two test VM invocations
Keep
28 matches
Mail list logo
