On Tue, 7 May 2024 07:08:55 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Hello Christoph, the latest changes look fine to me. I've added a trivial
> comment about reading the inputstream in one of the test, but you can leave
> it in its current form if you prefer to. Please run `tier2` tests once before
> integrating.
Thanks for the review. I added your suggestion. Will run it once more through
our test suite tonight and then integrate tomorrow if all is good.
> test/jdk/sun/net/www/http/KeepAliveCache/B8291637.java line 144:
>
>> 142: int c;
>> 143: byte[] buf = new byte[256];
>> 144: while ((c = i.read(buf)) != -1) {
>
> Given that the server response is just a hello world message, I think you can
> just replace this entire code within the try block with something like:
>
>
> int count;
> try (InputStream i = urlc.getInputStream()) {
> count = i.readAllBytes().length;
> }
>
>
> If you prefer to leave it in the current form, that's fine too.
Done.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18884#issuecomment-2097761466
PR Review Comment: https://git.openjdk.org/jdk/pull/18884#discussion_r1592043468
