On Sat, 27 Apr 2024 13:15:37 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
>> resources
>>
>> B8291637.java:
>> - use just one instead of two test VM invocations
>> KeepAliveTimerThread.java:
>> call to grp.destroy() at the end is pointless (API is void & deprecated for
>> removal)
>>
>> Generally:
>> The deprecated URL constructor is used. It can be switched to the handy
>> URIBuilder
>> Some more try with resources here and there
>
> Christoph Langer has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains seven additional
> commits since the last revision:
>
> - Merge branch 'master' into keepalivetests
> - Fix two URLs
> - Merge branch 'master' into keepalivetests
> - Jaikiran's comments
> - Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
>
> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
> - Copyright year
> - JDK-8330814
test/jdk/sun/net/www/http/KeepAliveCache/B8291637.java line 153:
> 151: }
> 152: System.out.println("Read " + count);
> 153: try {
Maybe the `try {` line should be moved just after `server.start()`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18884#discussion_r1584997690
