On Tue, 30 Apr 2024 15:07:52 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into keepalivetests
>> - Fix two URLs
>> - Merge branch 'master' into keepalivetests
>> - Jaikiran's comments
>> - Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Copyright year
>> - JDK-8330814
>
> test/jdk/sun/net/www/http/KeepAliveCache/B8291637.java line 153:
>
>> 151: }
>> 152: System.out.println("Read " + count);
>> 153: try {
>
> Maybe the `try {` line should be moved just after `server.start()`
good point. I enhanced this a little bit more. 😄
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18884#discussion_r1586803643
