> While working in that area I found some potential for cleanup of a few tests. > > Most notably: > > B5045306.java: > - does not need to run in othervm > - the executor service that it uses should be shut down eventually to free > resources > > B8291637.java: > - use just one instead of two test VM invocations > KeepAliveTimerThread.java: > call to grp.destroy() at the end is pointless (API is void & deprecated for > removal) > > Generally: > The deprecated URL constructor is used. It can be switched to the handy > URIBuilder > Some more try with resources here and there
Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Fix two URLs ------------- Changes: - all: https://git.openjdk.org/jdk/pull/18884/files - new: https://git.openjdk.org/jdk/pull/18884/files/a89416f0..42a55baa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18884&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18884&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18884.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18884/head:pull/18884 PR: https://git.openjdk.org/jdk/pull/18884