Re: stable vs. master branches

2022-02-22 Thread Aaron Schrab
At 18:17 -0800 22 Feb 2022, "Kevin J. McCarthy" wrote: On Tue, Feb 22, 2022 at 04:27:25PM -0800, Kevin J. McCarthy wrote: On Tue, Feb 22, 2022 at 07:07:42PM -0500, Aaron Schrab wrote: 955d281f6 (Add missing period in a comment., 2021-04-08) [...] That was a merge request from

stable vs. master branches

2022-02-22 Thread Aaron Schrab
Just now after updating my build (based on master) after the release of 2.2.1, I decided to look at the commits that aren't included in the stable branch. Other than the merges of stable back into master I see only one commit: 955d281f6 (Add missing period in a comment., 2021-04-08) Doing a

Re: Crashes in recent builds from master

2021-09-08 Thread Aaron Schrab
At 09:39 -0700 08 Sep 2021, "Kevin J. McCarthy" wrote: On Wed, Sep 08, 2021 at 09:09:03AM -0700, Kevin J. McCarthy wrote: On Wed, Sep 08, 2021 at 03:56:56AM -0700, Kevin J. McCarthy wrote: To trigger the QRESYNC failure, delete some messages in the mailbox using mutt. Sync and exit the mailbo

Re: Crashes in recent builds from master

2021-09-07 Thread Aaron Schrab
At 18:00 -0700 07 Sep 2021, "Kevin J. McCarthy" wrote: On Tue, Sep 07, 2021 at 07:15:16PM -0400, Aaron Schrab wrote: Since updating from a build based on bcdb61560 (Add %T status format for $sort_thread_groups., 2021-08-05) to one based on 27e61da56 (Merge branch 'stable

Crashes in recent builds from master

2021-09-07 Thread Aaron Schrab
Since updating from a build based on bcdb61560 (Add %T status format for $sort_thread_groups., 2021-08-05) to one based on 27e61da56 (Merge branch 'stable', 2021-08-24) I've been experiencing some sporadic crashes. After getting coredumps enabled, it seems that there are a couple of different i

Re: [PATCH] Add skip_quoted_context option

2021-06-13 Thread Aaron Schrab
At 10:06 -0700 13 Jun 2021, "Kevin J. McCarthy" wrote: I need to get through a backlog of other things before I look too closely at this. However, I'd like others' opinions on the usefulness of the option. My initial impression is that it's not generally useful (i.e., if you need context the

Re: Mutt && handling of SIGCHLD while starting $sendmail

2020-11-07 Thread Aaron Schrab
At 14:49 +0100 07 Nov 2020, Matthias Apitz wrote: Can you please elaborate a bit what's not a good idea with this patch? It deals exactly with returning waitpid() -1 and errno=ECHILD, i.e. with the exact problem we have here, why ever the child was and/or SIG_CHLD was lost. Thanks Mutt isn't j

Re: Expanding relative paths

2020-08-30 Thread Aaron Schrab
At 13:34 -0700 30 Aug 2020, "Kevin J. McCarthy" wrote: I've taken a closer look, and I believe this issue only affects $signature and the source command. I've just pushed a fix turning off relative expansion for those cases when the value ends with a pipe. That's working so far, and I don't

Expanding relative paths

2020-08-30 Thread Aaron Schrab
Commit 0f455d513 (Change expand_path() to expand relative paths., 2020-07-26) caused my configuration to break. I was using the following command: source "exec $HOME/.mutt/expand_muttrc detect mboxes |" With that change mutt now prepends the current directory to `exec`, causing the `sourc

Re: [PATCH] Change hardcoded subject of replies

2020-07-23 Thread Aaron Schrab
At 19:15 +0300 23 Jul 2020, Maxim Tarasov wrote: First, "Re: your mail" sounds like a spam mail heading and doesn't convey any useful information. I'd say that both of those points would still apply with the proposed change. Second, setting the subject to just "Re:" will enable the user to

Re: CVE status and regression in 1.14.3 release

2020-06-22 Thread Aaron Schrab
At 17:54 -0700 21 Jun 2020, "Kevin J. McCarthy" wrote: For master branch, I'll add a new option, something like $tunnel_is_secure, defaulting "yes". That will turn off STARTTLS for tunneled imap, pop3, and smtp connections (a possibly breaking change). It will also disable the "IMAP PREAUTH"

Re: LF to CRLF translation responsibility

2020-05-10 Thread Aaron Schrab
At 11:10 -0400 10 May 2020, Remco Rijnders wrote: Well, the problem might originate in msmtp, but I think opensmtpd also has an issue here in that it breaks / locks up / hangs when presented with this unexpected input, with possible security implications. I'd disagree. Rather than being locked

Re: Upcoming freeze for 1.14 release

2020-04-09 Thread Aaron Schrab
At 13:45 -0700 09 Apr 2020, "Kevin J. McCarthy" wrote: For those who haven't tried out git master in a while, now would be a great time to do so. I gave an overview of some of the new features a couple weeks ago while announcing 1.13.5: I finally got around to trying the new background editi

Re: $send_multipart_alternative

2019-11-03 Thread Aaron Schrab
At 11:02 +0800 02 Nov 2019, "Kevin J. McCarthy" wrote: On Sat, Nov 02, 2019 at 09:18:14AM +0800, Kevin J. McCarthy wrote: I don't want to over-complicate the code, but if there is a quick fix, I'll see what I can do about this. I won't have a chance to work on it until later this week though.

$send_multipart_alternative

2019-11-01 Thread Aaron Schrab
Just a couple thoughts after playing around a little bit with the $send_multipart_alternative option recently added to master. I think it would be nice to support some "magic" MIME type that the filter could return to indicate that no alternative should be generated. I may want to use this fo

Re: Add format attribute for buffer_printf functions

2019-04-11 Thread Aaron Schrab
At 07:17 -0700 11 Apr 2019, "Kevin J. McCarthy" wrote: On Wed, Apr 10, 2019 at 07:44:45PM -0400, aaron+m...@schrab.com wrote: Let compilers know that `mutt_buffer_printf()` and `mutt_buffer_add_printf()` expect the second argument to be a `printf`-style format string with the arguments for the

Re: Problem with mutt version.sh script

2018-04-17 Thread Aaron Schrab
At 15:27 +0200 17 Apr 2018, Vincent Lefevre wrote: I suppose that -r should work since .git must be readable to be useful. That's not actually true. When it's a directory, a large number of operations can be done without it being readable (in my testing I haven't come across anything that fa

Re: Problem with mutt version.sh script

2018-04-16 Thread Aaron Schrab
At 15:41 +0200 16 Apr 2018, Gero Treuner wrote: On Mon, Apr 16, 2018 at 07:53:56AM -0500, Paul Keusemann wrote: { [ -e ".git" ] && command -v git >/dev/null 2>&1; } \ || exec cat VERSION does not work when run in a bourne shell.  The -e option is not supported in I'd prefer using an option

Re: Switch to git and gitlab in progress

2017-12-11 Thread Aaron Schrab
At 19:37 -0800 10 Dec 2017, "Kevin J. McCarthy" wrote: Sorry things have been so quiet. I've been pretty busy on other stuff, but what time I have had available has been working on migrating Mutt to git. Nice. As someone who's been building mutt from a git clone for years, this is definitel

Re: [SPAM?] [PATCH] doc: A css fix to ease reading the manual on big screens

2016-09-04 Thread Aaron Schrab
At 18:07 +0300 03 Sep 2016, Alexander Gromnitsky wrote: That's actually a great idea. The 2nd version of the patch adds another media query that moves the TOC to the left if the viewport >= 1100px. In my experience, most of these types of breakpoints are determined by using em values rather

Re: Adds mailboxrx (and unmailboxrx) command

2016-08-31 Thread Aaron Schrab
. This is lacking in documentation, but I've been using this for a couple of years now with only minor changes (including adding sidebar support), and it has served me well. commit 8ec89e0 Author: Aaron Schrab Date: Mon May 23 20:47:23 2016 -0400 Add mailbox_prefix command Allow user

Re: Add subjectrx command to replace matching subjects with something else

2016-08-31 Thread Aaron Schrab
7b2 Author: Aaron Schrab Date: Sat Aug 10 21:34:44 2013 -0400 Allow removing all entries from replace lists Allow * to be used as the argument to unmailboxrx and unsubjectrx commands to remove all entries. This is useful for clearing the configuration before starting

Re: Preserve pager position only for ops that redirect back to the same message.

2016-08-14 Thread Aaron Schrab
At 07:32 -0700 13 Aug 2016, "Kevin J. McCarthy" wrote: I can confirm the behavior, but I can not confirm any regression. Again, I am seeing the same behavior in 1.6.0, 1.5.24, and 1.5.23: toggling the headers does *not* go back to the top of the message. Are you two absolutely sure you are seei

Re: Preserve pager position only for ops that redirect back to the same message.

2016-08-12 Thread Aaron Schrab
At 07:32 -0700 12 Aug 2016, "Kevin J. McCarthy" wrote: On Fri, Aug 12, 2016 at 08:09:00AM -0400, Aaron Schrab wrote: I rebuilt my copy yesterday based on the tip at that time, and noticed a bit of a regression a little while ago. Previously using (default binding `h`) from th

Re: Preserve pager position only for ops that redirect back to the same message.

2016-08-12 Thread Aaron Schrab
At 12:31 -0700 08 Aug 2016, "Kevin J. McCarthy" wrote: I'm going to push the second version of the patch. I don't think an uproar will ensue, but if so we can evaluate what to do. It's a small commit. I rebuilt my copy yesterday based on the tip at that time, and noticed a bit of a regressi

Re: [PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-14 Thread Aaron Schrab
At 08:17 -0700 14 Jun 2016, "Kevin J. McCarthy" wrote: I'll have more time later today to actually test this, but I think this patch should fix the problem. I moved the "new" flag resetting inside the status processing, and somehow missed the *giant* comment saying it wouldn't be statusing the

Re: [PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-14 Thread Aaron Schrab
At 14:19 -0700 08 Jun 2016, "Kevin J. McCarthy" wrote: Add new boolean option $mail_check_stats (default off) and $mail_check_stats_interval. The first turns extended buffy on. The second sets the amount of time in between extended buffy checks (defaulting to 60 seconds). [snip] (Part 4 of

Re: Neomutt - Release 20160404 (Mutt-1.6.0)

2016-04-07 Thread Aaron Schrab
At 18:50 -0700 06 Apr 2016, "Kevin J. McCarthy" wrote: On Tue, Apr 05, 2016 at 11:04:59AM -0700, David Champion wrote: OK - that's a good track to have. The thing that made me think otherwise was the removal of hg-related components. Kevin has the final say now but we've never discussed moving

Re: Folder aliases?

2015-03-22 Thread Aaron Schrab
At 09:26 -0400 21 Mar 2015, Gregory Seidman wrote: folder-alias archive ~/archived-email/`date +%Y-%m` Does anyone find this objectionable as a feature? Is anyone interested in working on it? If no one is I can try to find time myself, but free time has been in short supply since kids...

Re: imap partial fetch in mutt

2014-02-02 Thread Aaron Schrab
At 15:29 +0100 02 Feb 2014, Tilman WEIERS wrote: Here comes the patch with the -ru options enabled. This patch seems much shorter than I'd expect for what would seem to be a major enhancement. I'm also only seeing changes to a single file, commands.c. Is this missing changes to other files

Re: Fix segfault when sourcing file with error

2013-10-06 Thread Aaron Schrab
At 19:28 + 05 Oct 2013, Michael Elkins wrote: On Thu, Aug 22, 2013 at 03:10:36PM -0400, Aaron Schrab wrote: Indeed, I'd already completed the following patch before seeing this message. It replaces use of memset with mutt_buffer_init. Even if there's a later move to do more

Re: Fix segfault when sourcing file with error

2013-08-22 Thread Aaron Schrab
At 13:25 -0500 22 Aug 2013, Derek Martin wrote: In any event, having found the mutt_buffer_* functions (in protos.h and muttlib.c), I think the initializations should use those functions instead of calling memset(). Indeed, I'd already completed the following patch before seeing this message.

Re: Fix segfault when sourcing file with error

2013-08-22 Thread Aaron Schrab
At 10:51 -0500 22 Aug 2013, Derek Martin wrote: Given this code and the fix, it seems likely that the problem you ran into is that err.dptr is used uninitialized. Since err is half initialized in the code that follows, I personally think it would be slightly preferable to add: err.dptr = NUL

[PATCH] Fix segfault when sourcing file with error

2013-08-21 Thread Aaron Schrab
Clear newly allocated error buffer to avoid attempt to dereference an invalid pointer when reporting an error while sourcing a file. Without this change I was seeing segfaults when attempting to source a file containing a send2-hook with an invalid regexp in the pattern. --- commands.c |1 + 1

Re: [PATCH 2 of 3] Add subjectrx command to replace matching subjects with something else

2013-08-12 Thread Aaron Schrab
ds support for using '*' as the pattern to remove to specify that all replacement pairs are to be cleared out. This matches what is already supported for commands like unhook and unalias. And since it isn't a valid regexp it shouldn't cause any compatibility issues. commit b

Re: [PATCH 1/4] version.sh: cd to script's directory

2012-12-27 Thread Aaron Schrab
At 20:39 -0800 27 Dec 2012, Michael Elkins wrote: On Thu, Dec 13, 2012 at 03:42:08PM -0500, Aaron Schrab wrote: The fallback method of using `cat VERSION` was broken in this respect, it would not work when run from a different directory. Applied, thanks. It would have been better if the

Re: quoting of $HGROOT in version.sh

2012-12-27 Thread Aaron Schrab
At 19:31 -0800 27 Dec 2012, Michael Elkins wrote: If possible I would like to make it work with the older mercurial just to make it friendly for anyone using those systems, so I'd still like to know why $HGROOT can't be expanded at the time $HG is set. The first patch of the series I sent on

Re: FREE() and safe_free()

2012-12-16 Thread Aaron Schrab
At 12:55 -0600 16 Dec 2012, Derek Martin wrote: Wrong, there are 1,386 calls to FREE() that would need to be changed from passing a ** to passing just a *. So, back to my original thought. And that's just counting calls in the official repository. Changing that interface will break just abo

Re: [PATCH 2/4] Generate version string during make not configure

2012-12-14 Thread Aaron Schrab
At 19:25 -0600 14 Dec 2012, David Champion wrote: That's good. If mutt still supports non-GNU makes we should leave it that way. Building from CVS (hg) has required GNU for so long I no longer think of as optional. :/ I don't know if it actually works, but the `INSTALL` file implies that th

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-14 Thread Aaron Schrab
At 18:10 -0600 14 Dec 2012, David Champion wrote: This is good to add support for, but note that the ${a#b} and ${a%b} family of parameter expressions is nonportable. These are commonly accepted bashisms that also work in zsh, but not in xpg4 shells. Can you redo with seds, or something? I h

Re: [PATCH 2/4] Generate version string during make not configure

2012-12-14 Thread Aaron Schrab
At 18:06 -0600 14 Dec 2012, David Champion wrote: +version.h: FORCE + echo '#define MUTT_VERSION "'`sh "$(srcdir)/version.sh"`'"' > $@.tmp + (cmp -s $@ $@.tmp) && rm -f $@.tmp || mv $@.tmp $@ +FORCE: + .PHONY: version.h ? I did it that way to try to be more portable. The docs fo

[PATCH 4/4] version.sh: Get detailed version info from git

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab If not able to use mercurial to build a detailed version string, try using git to do so. --- version.sh | 26 ++ 1 file changed, 26 insertions(+) diff --git a/version.sh b/version.sh index 39709a0..54568ac 100644 --- a/version.sh +++ b/version.sh

[PATCH 1/4] version.sh: cd to script's directory

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab Use the directory where the version.sh script is located as the directory where it is run. Since this will be run in a separate shell anyway, there's no need to worry about changing current directory. This eliminates the need for the caller to specify where the s

[PATCH 3/4] version.sh: Move mercurial code into if block

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab Put the code to build a detailed version string using mercurial into an if block rather than immediately using the fallback if mercurial can't be used. This will allow checking for other sources of detailed version info, such as using git which will be supported

[PATCH 2/4] Generate version string during make not configure

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab Switch to generating the version string during make process rather than at configure time. This makes it easier to keep the detailed version string accurate when doing development which doesn't require that the configure script be rerun. --- .hgignore|

Cleanups and enhancements to generation of version strings

2012-12-13 Thread Aaron Schrab
The following series of commits provides some cleanups and enhancements to how the build process generates detailed version strings for builds done from a VCS. I initially did this looking to add support for builds from a git repository, but I believe that the first two commits in the series a

Re: Fix editing headers with format=flowed

2012-12-07 Thread Aaron Schrab
At 17:20 -0500 07 Dec 2012, Aaron Schrab wrote: At 13:54 -0800 07 Dec 2012, Michael Elkins wrote: I think the better solution would be to teach Vim how to disable auto reformat when editing in the email header, That would indeed be nice, but is likely to be difficult to get right. After

Re: Fix editing headers with format=flowed

2012-12-07 Thread Aaron Schrab
At 13:54 -0800 07 Dec 2012, Michael Elkins wrote: I think the better solution would be to teach Vim how to disable auto reformat when editing in the email header, That would indeed be nice, but is likely to be difficult to get right. because there are other cases where it will bite you. For

Re: Fix editing headers with format=flowed

2012-12-07 Thread Aaron Schrab
At 13:00 -0800 07 Dec 2012, Michael Elkins wrote: What is your use case? I set both text_flowed and edit_headers and haven't had any issues. Rewrapping the header manually is something I don't do, because it can be reflowed automatically by the receiver anyway, as defined by the relevant RFC

Re: Fix editing headers with format=flowed

2012-12-07 Thread Aaron Schrab
At 11:57 -0800 07 Dec 2012, Michael Elkins wrote: I think this change is somewhat controversial. I'm used to hitting 'A' in vim to append to those header lines, and with this change I'd have to type a space first. I'm sure there are others who would be annoyed by this as well. With the pat

Re: Parent match

2008-11-14 Thread Aaron Schrab
At 09:41 -0500 14 Nov 2008, Aaron Schrab <[EMAIL PROTECTED]> wrote: I made a somewhat similar patch several years ago. But rather than After reading Vincent's message I realize that I misread what the feature being discussed here does. So, it's not as close as I'd thought.

Re: Parent match

2008-11-14 Thread Aaron Schrab
I made a somewhat similar patch several years ago. But rather than adding a grouping operator, my version added a modifier that could be used with the match operators. Initially, the modifier was % ("percent" is close to "parent") but that was later changed to <. This would allow use of patt