Reviewed-by: Gurchetan Singh
Was there a second patch sent out?
On Thu, Sep 13, 2018 at 4:24 AM Gert Wollny wrote:
>
> From: Tomeu Vizoso
>
> Check if server supports version negotation by sending a PING_PROTOCOL_VERSION
> message right before a dummy RESOURCE_BUSY_WAIT. If
On Tue, Oct 2, 2018 at 12:08 AM Gert Wollny wrote:
>
> From: Tomeu Vizoso
>
> Pass the size of a resource when creating it so a backing can be kept in
> the other side.
>
> Also pass the required offset to transfer commands.
>
> This moves vtest closer to how virtio-gpu works, making it more usef
Reviewed-by: Gurchetan Singh
On Wed, Oct 3, 2018 at 2:53 AM Tapani Pälli wrote:
>
> From: "Chystiakov, Dmytro"
>
> In the same fashion as is done for glEGLImageTextureTarget2D.
>
> v2: share the fallback which sets baseformat and internalformat correctly
> whi
Texture buffers and SSBOs are always unclean, while other buffers
are not modified by compute/rendering.
This improves
dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw
from 9.58 MB/s to 451.17 MB/s.
Regression tested using
ers,
>
> -ilia
> On Tue, Nov 20, 2018 at 6:11 PM Gurchetan Singh
> wrote:
> >
> > Texture buffers and SSBOs are always unclean, while other buffers
> > are not mo
Tested running WebGL aquarium on Nvidia host (10,000 fishes)
This moves us from 7 fps to 9 fps. After quadrupling, performance
gains diminish.
Change-Id: Iba3a9929ba2d17cf5a38233b92391dd413b79bc2
---
src/gallium/drivers/virgl/virgl_winsys.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
We can mark the buffer unclean if it's ever bound as a TBO,
SSBO, ABO, or image.
This improves
dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw
from 9.58 MB/s to 451.17 MB/s.
v2: Using buffer bindings to track cleanliness
We flush everytime the command buffer (16 kB) is full, which is
quite costly.
This improves
dEQP-GLES3.performance.buffer.data_upload.function_call.buffer_data.new_buffer.usage_stream_draw
from 111.16 MB/s to 1930.36 MB/s.
In addition, I made the benchmark produce buffers from 0 -->
VIRGL_MAX_
We flush everytime the command buffer (16 kB) is full, which is
quite costly.
This improves
dEQP-GLES3.performance.buffer.data_upload.function_call.buffer_data.new_buffer.usage_stream_draw
from 111.16 MB/s to 1930.36 MB/s.
In addition, I made the benchmark produce buffers from 0 -->
VIRGL_MAX_
We can mark the buffer unclean if it's ever bound as a TBO,
SSBO, ABO, or image.
This improves
dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw
from 9.58 MB/s to 451.17 MB/s.
v2: Track buffer cleanliness as a function of b
Tested running WebGL aquarium on Nvidia host (10,000 fishes)
This moves us from 7 fps to 9 fps. After quadrupling, performance
gains diminish.
v2: Remove change ID (Erik)
Tested-By: Gert Wollny
---
src/gallium/drivers/virgl/virgl_winsys.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965" --with-
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965" --with-
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965" --with-
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965" --with-
Does this require libdrm 2.4.95 for virtio-gpu? With
platform_surfaceless, I keep getting "DRI2: failed to find EGLDevice"
and the failure is happening in "drmGetDevice2(fd, 0, &device)".On
Sat, Oct 20, 2018 at 11:46 PM Mathias Fröhlich
wrote:
>
> Hi Emil,
>
> On Wednesday, 3 October 2018 16:02:4
Thanks! Gentle ping for push from committers..
On Mon, Nov 26, 2018 at 11:52 AM Erik Faye-Lund
wrote:
>
> On Mon, 2018-11-26 at 09:54 -0800, Gurchetan Singh wrote:
> > Tested running WebGL aquarium on Nvidia host (10,000 fishes)
> >
> > This moves us from 7 fps to 9
On Mon, Dec 3, 2018 at 8:06 AM Emil Velikov
wrote:
> Hi Gurchetan,
>
> On Thu, 29 Nov 2018 at 23:41, Gurchetan Singh
> wrote:
> >
> > Does this require libdrm 2.4.95 for virtio-gpu? With
> > platform_surfaceless, I keep getting "DRI2: failed to find EGLDevic
With commit 89b479, we moved to tracking buffer cleanliness
when binding.
TEST=dEQP-GLES31.functional.image_load_store.buffer.load_store.r32ui
---
src/gallium/drivers/virgl/virgl_buffer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_buffer.c
b/src/gallium
Will be reused.
---
src/gallium/drivers/virgl/virgl_resource.h | 11 ---
src/gallium/drivers/virgl/virgl_texture.c | 19 ++-
2 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_resource.h
b/src/gallium/drivers/virgl/virgl_resou
Will be reused.
---
src/gallium/drivers/virgl/virgl_resource.c | 37 +++
src/gallium/drivers/virgl/virgl_resource.h | 4 ++
src/gallium/drivers/virgl/virgl_texture.c | 52 +-
3 files changed, 51 insertions(+), 42 deletions(-)
diff --git a/src/gallium/drivers/virg
It's used for all types of resources.
---
src/gallium/drivers/virgl/virgl_buffer.c | 4 ++--
src/gallium/drivers/virgl/virgl_context.c | 4 ++--
src/gallium/drivers/virgl/virgl_context.h | 2 +-
src/gallium/drivers/virgl/virgl_screen.c | 4 ++--
src/gallium/drivers/virgl/virgl_screen.h | 2 +-
We could allocate and destroy transfers in one place.
---
src/gallium/drivers/virgl/virgl_buffer.c | 2 +-
src/gallium/drivers/virgl/virgl_resource.c | 47 +++---
src/gallium/drivers/virgl/virgl_resource.h | 14 --
src/gallium/drivers/virgl/virgl_texture.c | 58 +---
util_format_get_blocksize returns 1 for R8 formats (all
PIPE_BUFFERs are R8).
---
src/gallium/drivers/virgl/virgl_resource.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_resource.c
b/src/gallium/drivers/virgl/virgl_resource.c
index ccbb
The ioctls don't even pass this (though they should).
Let's calculate this correctly in one place and then pass it down.
Note -- If anyone is using vtest with protocol version 1 (why?),
then you'll need this host side CL too since the layer stride
is forwarded for non-array textures.
https://git
We reuse the helpers we created.
---
src/gallium/drivers/virgl/virgl_buffer.c | 28 +++---
src/gallium/drivers/virgl/virgl_resource.h | 1 +
2 files changed, 10 insertions(+), 19 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_buffer.c
b/src/gallium/drivers/virgl/vir
Previously, we ignored the the glUnmap(..) operation and
flushed before we flush the cbuf. Now, let's just flush
the data when we unmap.
Neither method is optimal, for example:
glMapBufferRange(.., 0, 100, GL_MAP_FLUSH_EXPLICIT_BIT)
glFlushMappedBufferRange(.., 25, 30)
glFlushMappedBufferRange(.
Will be reused.
---
src/gallium/drivers/virgl/virgl_resource.c | 24 +++
src/gallium/drivers/virgl/virgl_resource.h | 3 +++
src/gallium/drivers/virgl/virgl_texture.c | 27 +-
3 files changed, 28 insertions(+), 26 deletions(-)
diff --git a/src/gallium/drivers
A resource is just a buffer with some metadata.
---
src/gallium/drivers/virgl/virgl_buffer.c | 51 +++--
src/gallium/drivers/virgl/virgl_context.c | 5 +-
src/gallium/drivers/virgl/virgl_resource.h | 21 +-
src/gallium/drivers/virgl/virgl_texture.c | 85 +++---
4 f
We can remove some duplicated code.
---
src/gallium/drivers/virgl/virgl_buffer.c | 33 +
src/gallium/drivers/virgl/virgl_resource.c | 84 +++---
src/gallium/drivers/virgl/virgl_resource.h | 16 ++---
src/gallium/drivers/virgl/virgl_texture.c | 70 ++
4 fi
On Mon, Dec 10, 2018 at 7:35 AM Elie Tournier
wrote:
> On Thu, Dec 06, 2018 at 05:20:42PM -0800, Gurchetan Singh wrote:
> > Previously, we ignored the the glUnmap(..) operation and
> > flushed before we flush the cbuf. Now, let's just flush
> > the data when we unmap.
Previously, we ignored the the glUnmap(..) operation and
flushed before we flush the cbuf. Now, let's just flush
the data when we unmap.
Neither method is optimal, for example:
glMapBufferRange(.., 0, 100, GL_MAP_FLUSH_EXPLICIT_BIT)
glFlushMappedBufferRange(.., 25, 30)
glFlushMappedBufferRange(.
:
> case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
> case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
> - case PIPE_CAP_TEXTURE_FLOAT_LINEAR:
> - case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR:
> case PIPE_CAP_DEPTH_BOUNDS_TEST:
> case PIPE_CAP_SHAREABLE_SHADERS:
> case PIPE_CAP_CLEAR
On Tue, Dec 11, 2018 at 2:49 PM Elie Tournier
wrote:
> On Mon, Dec 10, 2018 at 10:20:36AM -0800, Gurchetan Singh wrote:
> > Previously, we ignored the the glUnmap(..) operation and
> > flushed before we flush the cbuf. Now, let's just flush
> > the data when we unmap.
From: "gurchetansi...@chromium.org"
glBindBufferRange(..) in vrend_draw_bind_ubo is failing with
more than one uniform block. This is due to improper alignment
of the start of the second block. Let's query the proper
alignment from the driver and pass it back to Mesa.
Let's query for the texture
Any plans to merge this? This fixes Chrome not starting with Virgl.
Reviewed-by: Gurchetan Singh
Tested-by: Gurchetan Singh
On Mon, Nov 13, 2017 at 12:53 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes some dEQP tests that generated bad shaders.
>
> Fixes: b6f6ead
n Fri, Feb 9, 2018 at 1:28 AM, gurchetansi...@chromium.org
> wrote:
> > From: Gurchetan Singh
> >
> > Consider this series of events:
> >
> > glColorMask(GL_FALSE, GL_TRUE, GL_TRUE, GL_TRUE);
> > glClearColor(0.125f, 0.25f, 0.5f, 1.0f);
> > glClear(GL_C
On Thu, Feb 8, 2018 at 5:15 PM, Marek Olšák wrote:
>
> On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh
> wrote:
> > On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák wrote:
> >>
> >> This is not the correct fix.
> >>
> >> clear_with_quad c
On Thu, Feb 8, 2018 at 6:01 PM, Ilia Mirkin wrote:
> On Thu, Feb 8, 2018 at 8:58 PM, Ilia Mirkin wrote:
>> On Thu, Feb 8, 2018 at 8:36 PM, Gurchetan Singh
>> wrote:
>>> On Thu, Feb 8, 2018 at 5:15 PM, Marek Olšák wrote:
>>>>
>>>> On Fri, Feb
On Wed, Feb 14, 2018 at 3:57 PM, Marek Olšák wrote:
> Do you have commit access?
No, would appreciate a merge ;-)
> Marek
>
> On Thu, Feb 15, 2018 at 12:40 AM, gurchetansi...@chromium.org
> wrote:
>> From: Gurchetan Singh
>>
>> The ARB_viewport_arr
including
PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE there makes sense for now.
Reviewed-by: Gurchetan Singh
Tested-by: Gurchetan Singh
On Tue, Feb 13, 2018 at 6:58 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> The gallium query types changed, so we need to remap from the
> gallium
vtest_hdr[VTEST_CMD_LEN] += (data_size + 3) / 4;
>
> cmd[0] = handle;
> cmd[1] = level;
> --
> 2.16.4
>
Reviewed-by: Gurchetan Singh
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Oct 4, 2018 at 7:41 AM Gert Wollny wrote:
>
> From: Tomeu Vizoso
>
> Pass the size of a resource when creating it so a backing can be kept in
> the other side.
>
> Also pass the required offset to transfer commands.
>
> This moves vtest closer to how virtio-gpu works, making it more usefu
On Fri, Oct 5, 2018 at 1:04 AM Gert Wollny wrote:
>
> Am Donnerstag, den 04.10.2018, 10:48 -0700 schrieb Gurchetan Singh:
> >
> > The idea is to get rid of any adjustments on both the Mesa /
> > virglrenderer sides -- so transfer size is just what's needed to
>
Reviewed-by: Gurchetan Singh
On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund
wrote:
>
> The IOCTLs doesn't pass this along, so computing them in the first
> place is kinda pointless.
>
> Signed-off-by: Erik Faye-Lund
> ---
>
> This is just a cleanup I noticed based
Reviewed-by: Gurchetan Singh
On Tue, Jul 3, 2018 at 4:32 AM Gert Wollny wrote:
>
> Signed-off-by: Gert Wollny
> ---
> Note that I used (1 << 3) instead of (1 << 2) because Dave's experimental
> patch
> already uses the latter for computer shader caps
format == PIPE_FORMAT_R32G32B32_SINT ||
> + format == PIPE_FORMAT_R32G32B32_UINT) &&
> + target != PIPE_BUFFER)
> + return FALSE;
> +
> if (bind & PIPE_BIND_RENDER_TARGET) {
>if (format_desc->colorspace == UTIL_FORMAT_COLORSPACE_ZS)
>
Reviewed-by: Gurchetan Singh
On Tue, Jul 24, 2018 at 6:11 PM Chad Versace wrote:
>
> Problem 1: u_debug_stack_android.cpp transitively included
> "pipe/p_compiler.h", but src/gallium/include was missing from the C++
> include path.
>
> Problem 2: Add -std=c++
This series is:
Reviewed-by: Gurchetan Singh
On Tue, Jul 31, 2018 at 3:29 PM Dave Airlie wrote:
>
> From: Dave Airlie
>
> This hooks up compute shader creation and launch grid support.
> ---
> src/gallium/drivers/virgl/virgl_context.c | 55 ++--
>
This is virgl analogue to cf6dad.
Fixes:
dEQP-GLES31.functional.image_load_store.3d.atomic.*
Example test cases:
dEQP-GLES31.functional.image_load_store.3d.atomic.add_r32ui_return_value
dEQP-GLES31.functional.image_load_store.3d.atomic.min_r32ui_return_value
dEQP-GLES31.functional.image_l
On Tue, Aug 14, 2018 at 2:59 AM Erik Faye-Lund
wrote:
>
>
>
> On Tue, Aug 14, 2018 at 5:47 AM, Gurchetan Singh
> wrote:
>
> This is virgl analogue to cf6dad. Fixes:
> dEQP-GLES31.functional.image_load_store.3d.atomic.* Example test cases:
> dEQP-GLES31.
tl;dr
- Interested in porting the gfxstream virtualization solution to
Mesa and wondering how everyone feels about it
--
| Longer |
--
Dear all,
In an earnings call with investors, Santa Claus shared a grim
outlook for the North Pole. The Q4 2023 holiday season's yield of
milk
This change enables the creation of pbuffer
surfaces on the surfaceless platform.
---
src/egl/drivers/dri2/egl_dri2.h | 7 +-
src/egl/drivers/dri2/platform_surfaceless.c | 178 +++-
2 files changed, 180 insertions(+), 5 deletions(-)
diff --git a/src/egl/drive
With this change, to enable precise SIN and COS instructions
on Intel hardware, one can put
in the proper drirc file.
---
src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 +
src/mesa/drivers/dri/i965/brw_compiler.c| 2 --
src/mesa/drivers/dri/i965/brw_context.c | 3 +++
s
With classic DRI drivers, the DRI Configuration Infrastructure can be used
to read driver-specific parameters from XML files. The i965 driver
(src/mesa/drivers/dri/i965/intel_screen.c) uses this feature for instance.
In Gallium, the DRI Configuration Infrastructure is used to set common
options (
This change enables the creation of pbuffer
surfaces on the surfaceless platform.
V2: Use double-buffered pbuffer configuration
---
src/egl/drivers/dri2/egl_dri2.h | 8 +-
src/egl/drivers/dri2/platform_surfaceless.c | 219 +++-
2 files changed, 222 insertions
k with the default front render buffer a problem? If
so, what's the best way to fix the issue?
On Fri, May 6, 2016 at 9:27 PM, Chad Versace wrote:
> On 05/06/2016 03:39 PM, Stéphane Marchesin wrote:
> > On Fri, May 6, 2016 at 3:32 PM, Gurchetan Singh
> > wrote:
> >&
With this change, to enable precise SIN and COS instructions
on Intel hardware, one can put
in the proper drirc file.
V2: Make option name more generic
---
src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 +
src/mesa/drivers/dri/i965/brw_compiler.c| 2 --
src/mesa/drivers/dri/i9
breaking
things. I'll have an updated patch shortly.
Best wishes,
Gurchetan
On Mon, May 16, 2016 at 12:36 PM, Chad Versace
wrote:
> +Kristian, who also has an interest EGL
>
> On Tue 10 May 2016, Gurchetan Singh wrote:
> > Hi Chad,
> >
> > Thanks for the re
This change enables the creation of pbuffer
surfaces on the surfaceless platform.
v3: Going back to single-buffered pbuffer
plus additional code review changes
---
src/egl/drivers/dri2/egl_dri2.h | 7 +-
src/egl/drivers/dri2/platform_surfaceless.c | 213 +++-
The precise trig workaround is in NIR now, removing
the performance penalty that was the rationale behind
the option.
---
src/mesa/drivers/dri/i965/brw_compiler.c | 2 --
src/mesa/drivers/dri/i965/brw_compiler.h | 6 --
src/mesa/drivers/dri/i965/brw_nir.c | 3 +--
3 files changed, 1 inser
From: "gurchetansi...@chromium.org"
This is the SSBO analogue to fe0647. User supplied data must
be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT.
This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with
Nvidia hardware, but this patch standalone can applied to master. The
Thanks for the patch and review, merged!
On Thu, Aug 29, 2019 at 3:45 AM Tapani Pälli wrote:
>
> Reviewed-by: Tapani Pälli
>
> On 8/29/19 12:18 AM, Nataraj Deshpande wrote:
> > The patch adds support for 64 bit HAL_PIXEL_FORMAT_RGBA_FP16
> > for android platform.
> >
> > Fixes android.graphics.c
On Mon, Apr 1, 2019 at 12:39 PM Lepton Wu wrote:
>
> On Wed, Mar 20, 2019 at 2:26 PM Chia-I Wu wrote:
>
>> Reviewed-by: Chia-I Wu
>>
> Anything else to need for merging this? I think this is a straightforward
> leaking fix.
>
Merged. Thanks for the patch and review!
>
>
>>
>> On Mon, Mar 18
101 - 164 of 164 matches
Mail list logo
