On Mon, Dec 10, 2018 at 7:05 AM Erik Faye-Lund <erik.faye-l...@collabora.com> wrote:
> When I made sure that half-float texture-filtering was required for ES3, > I didn't realize that virgl doesn't report support for this correctly. > This regressed the GLES version available on top of several drivers, > including i965 from 3.2 to 2.0. > > This is going to need protocol changes to fix properly, so let's just > restore the previous behavior by enabling floating-point filtering > unconditionally for now. > > Signed-off-by: Erik Faye-Lund <erik.faye-l...@collabora.com> > Fixes: fcf9fcee3c8 "mesa/main: do not require float-texture filtering for > es3" > --- > src/gallium/drivers/virgl/virgl_screen.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/virgl/virgl_screen.c > b/src/gallium/drivers/virgl/virgl_screen.c > index 3d6424e39f6..b32c061491c 100644 > --- a/src/gallium/drivers/virgl/virgl_screen.c > +++ b/src/gallium/drivers/virgl/virgl_screen.c > @@ -255,6 +255,9 @@ virgl_get_param(struct pipe_screen *screen, enum > pipe_cap param) > return vscreen->caps.caps.v2.max_combined_atomic_counters; > case PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER_BUFFERS: > return vscreen->caps.caps.v2.max_combined_atomic_counter_buffers; > + case PIPE_CAP_TEXTURE_FLOAT_LINEAR: > + case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR: > + return 1; /* TODO: need to introduce a hw-cap for this */ > case PIPE_CAP_TEXTURE_GATHER_SM5: > case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT: > case PIPE_CAP_FAKE_SW_MSAA: > @@ -267,8 +270,6 @@ virgl_get_param(struct pipe_screen *screen, enum > pipe_cap param) > case PIPE_CAP_MULTISAMPLE_Z_RESOLVE: > case PIPE_CAP_RESOURCE_FROM_USER_MEMORY: > case PIPE_CAP_DEVICE_RESET_STATUS_QUERY: > - case PIPE_CAP_TEXTURE_FLOAT_LINEAR: > - case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR: > case PIPE_CAP_DEPTH_BOUNDS_TEST: > case PIPE_CAP_SHAREABLE_SHADERS: > case PIPE_CAP_CLEAR_TEXTURE: > Reviewed-by: Gurchetan Singh gurchetansi...@chromium.org > -- > 2.19.2 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
