On Mon, Apr 1, 2019 at 12:39 PM Lepton Wu <lep...@chromium.org> wrote:
> > On Wed, Mar 20, 2019 at 2:26 PM Chia-I Wu <olva...@gmail.com> wrote: > >> Reviewed-by: Chia-I Wu <olva...@gmail.com> >> > Anything else to need for merging this? I think this is a straightforward > leaking fix. > Merged. Thanks for the patch and review! > > >> >> On Mon, Mar 18, 2019 at 4:40 PM Lepton Wu <lep...@chromium.org> wrote: >> >>> This fd was create in virgl_drm_screen_create and should be closed >>> in virgl_drm_screen_destroy. >>> >>> Signed-off-by: Lepton Wu <lep...@chromium.org> >>> --- >>> src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c >>> b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c >>> index 01811a0e997..5501fe3ed48 100644 >>> --- a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c >>> +++ b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c >>> @@ -973,6 +973,7 @@ virgl_drm_screen_destroy(struct pipe_screen *pscreen) >>> if (destroy) { >>> int fd = virgl_drm_winsys(screen->vws)->fd; >>> util_hash_table_remove(fd_tab, intptr_to_pointer(fd)); >>> + close(fd); >>> } >>> mtx_unlock(&virgl_screen_mutex); >>> >>> -- >>> 2.21.0.225.g810b269d1ac-goog >>> >>> _______________________________________________ >>> mesa-dev mailing list >>> mesa-dev@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev >> >> _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev