Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 6f024b4..0d71617 100644
--- a/src/mesa/drivers/dri/i965
On Mon, Oct 14, 2013 at 11:05 AM, Matt Turner wrote:
> On Mon, Oct 14, 2013 at 10:12 AM, Anuj Phogat wrote:
>> diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml
>> index 5078f7b..4ec4749 100644
>> --- a/src/mapi/glapi/gen/GL3x.xml
>> +++ b/
On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote:
> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>> New builtins added by GL_ARB_sample_shading:
>> in vec2 gl_SamplePosition
>> in int gl_SampleID
>> in int gl_NumSamples
>> out int gl_SampleMask[]
>>
>&g
On Tue, Oct 15, 2013 at 1:49 PM, Kenneth Graunke wrote:
> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>> Implement the FS backend for new builtins added by the extension:
>> in vec2 gl_SamplePosition
>> in int gl_SampleID
>> in int gl_NumSamples
>> out int gl_Sampl
On Tue, Oct 15, 2013 at 3:28 PM, Kenneth Graunke wrote:
> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>> Implement the FS backend for new builtins added by the extension:
>> in vec2 gl_SamplePosition
>> in int gl_SampleID
>> in int gl_NumSamples
>> out int gl_Sampl
On Tue, Oct 15, 2013 at 1:54 PM, Ian Romanick wrote:
> On 10/15/2013 09:53 AM, Ian Romanick wrote:
>> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>>> @@ -852,6 +858,9 @@ append_token(char *dst, gl_state_index k)
>>> case STATE_TEXENV_COLOR:
>>>app
On Tue, Oct 15, 2013 at 3:48 PM, Kenneth Graunke wrote:
> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>> - Enable GEN7_WM_MSDISPMODE_PERSAMPLE, GEN7_WM_POSOFFSET_SAMPLE,
>> GEN7_WM_OMASK_TO_RENDER_TARGET as per extension's specification.
>> - Don't enable
On Tue, Oct 15, 2013 at 3:38 PM, Kenneth Graunke wrote:
> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>> - Enable GEN6_WM_MSDISPMODE_PERSAMPLE, GEN6_WM_POSOFFSET_SAMPLE,
>> GEN6_WM_OMASK_TO_RENDER_TARGET as per extension's specification.
>> - Don't enable
On Wed, Oct 16, 2013 at 3:20 PM, Ian Romanick wrote:
> On 10/16/2013 02:57 PM, Anuj Phogat wrote:
>> On Tue, Oct 15, 2013 at 3:48 PM, Kenneth Graunke
>> wrote:
>>> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>>>> - Enable GEN7_WM_MSDISPMODE
On Wed, Oct 16, 2013 at 3:49 PM, Ian Romanick wrote:
> On 10/16/2013 11:29 AM, Kenneth Graunke wrote:
>> On 10/16/2013 10:40 AM, Ian Romanick wrote:
>>> On 10/15/2013 07:50 PM, Kenneth Graunke wrote:
>> [snip]
Right, but gl_SampleMask is not an unsized array. It's statically sized
based
On Wed, Oct 16, 2013 at 11:25 PM, Kenneth Graunke wrote:
> On 10/16/2013 03:49 PM, Ian Romanick wrote:
> [snip]
>> You are completely correct here. We should check what other vendors do.
>> I think 5 tests will tell us everything we need to know (then we'll
>> probably submit some spec bugs). I
On Tue, Oct 15, 2013 at 5:42 PM, Anuj Phogat wrote:
> On Tue, Oct 15, 2013 at 1:49 PM, Kenneth Graunke
> wrote:
>> On 10/14/2013 10:12 AM, Anuj Phogat wrote:
>>> Implement the FS backend for new builtins added by the extension:
>>> in vec2 gl_SamplePosition
>
) works fine with this patch.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Anuj Phogat
Reported-by: Armin K
---
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
b/src/mesa/drivers/dri
On Fri, Oct 18, 2013 at 2:44 PM, Paul Berry wrote:
> On 14 October 2013 10:12, Anuj Phogat wrote:
>>
>> Number of samples will be required in fragment shader program by new
>> GLSL builtin uniform "gl_NumSamples".
>>
>> Signed-off-by: Anuj Phogat
&
On Sun, Oct 20, 2013 at 7:25 AM, Paul Berry wrote:
> On 14 October 2013 10:12, Anuj Phogat wrote:
>>
>> - Enable GEN6_WM_MSDISPMODE_PERSAMPLE, GEN6_WM_POSOFFSET_SAMPLE,
>> GEN6_WM_OMASK_TO_RENDER_TARGET as per extension's specification.
>> - Don't e
On Sun, Oct 20, 2013 at 7:37 AM, Paul Berry wrote:
> On 16 October 2013 15:20, Ian Romanick wrote:
>>
>> On 10/16/2013 02:57 PM, Anuj Phogat wrote:
>> > On Tue, Oct 15, 2013 at 3:48 PM, Kenneth Graunke
>> > wrote:
>> >> On 10/14/2013
On Fri, Oct 18, 2013 at 2:57 PM, Paul Berry wrote:
> On 14 October 2013 10:12, Anuj Phogat wrote:
>>
>> New builtins added by GL_ARB_sample_shading:
>> in vec2 gl_SamplePosition
>> in int gl_SampleID
>> in int gl_NumSamples
>> out int gl_Sample
On Sat, Oct 19, 2013 at 3:05 PM, Paul Berry wrote:
> On 14 October 2013 10:12, Anuj Phogat wrote:
>>
>> Implement the FS backend for new builtins added by the extension:
>> in vec2 gl_SamplePosition
>> in int gl_SampleID
>> in int gl_NumSamples
>> out i
idual patches are
listed in commit message. Following patches in this series need a
'reviewed-by'.
4/12, 6/12, 7/12, 8/12, 9/12, 10/12, 11,12
Anuj Phogat (12):
mesa: Add infrastructure for GL_ARB_sample_shading
mesa: Add new functions and enums required by GL_ARB_sample_shading
mesa:
This patch implements the common support code required for the
GL_ARB_sample_shading extension.
V2: Move GL_ARB_sample_shading to ARB extension list.
Signed-off-by: Anuj Phogat
Reviewed-by: Ian Romanick
Reviewed-by: Ken Graunke
---
src/glsl/glcpp/glcpp-parse.y| 3 +++
src/glsl
extra_gl40_ARB_sample_shading predicate to get.c.
Signed-off-by: Anuj Phogat
Reviewed-by: Ken Graunke
---
src/mapi/glapi/gen/ARB_sample_shading.xml | 19 +++
src/mapi/glapi/gen/GL4x.xml | 21 +
src/mapi/glapi/gen/Makefile.am| 4 +++-
src/mapi/glapi/gen
Number of samples will be required in fragment shader program by new
GLSL builtin uniform "gl_NumSamples".
V2: Use "state.numsamples" in place of "state.num.samples"
Use _NEW_BUFFERS flag in place of _NEW_MULTISAMPLE
Signed-off-by: Anuj Phogat
Reviewed-by:
Thsi function is used to test if we need to do per sample shading or
per fragment shading.
Signed-off-by: Anuj Phogat
---
src/mesa/program/program.c | 31 +++
src/mesa/program/program.h | 3 +++
2 files changed, 34 insertions(+)
diff --git a/src/mesa/program
SampleMask[] array.
- Make gl_SampleID and gl_SamplePosition system values.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
---
src/glsl/builtin_variables.cpp | 18 ++
src/mesa/main/mtypes.h | 10 +-
src/mesa/program/prog_print.c | 1 +
3 files changed, 28
This is required while adding builtin system value vec{2, 3, 4}
variables. For example:
(declare (sys) vec2 gl_SamplePosition)
Without this patch above glsl ir splits in to:
(declare (temporary) float gl_SamplePosition_x)
(declare (temporary) float gl_SamplePosition_y)
Signed-off-by: Anuj Phogat
V2:
- Update comments.
- Make changes to support simd16 mode.
- Add compute_pos_offset variable in brw_wm_prog_key.
- Add variable uses_omask in brw_wm_prog_data.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_context.h | 1 +
src/mesa/drivers/dri/i965/brw_fs.cpp
V2:
- Update comments
- Make changes to support simd16 mode.
- Add compute_sample_id variables in brw_wm_prog_key
- Add a special backend instruction to compute sample_id.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_defines.h| 1 +
src/mesa/drivers/dri/i965
V2:
- Update comments
- Use fs_reg(0x) in AND instruction to get the 16 bit
sample_mask.
- Add a special backend instructions to compute sample_mask.
- Add a new variable uses_omask in brw_wm_prog_data.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_context.h
e 279 for details.
V2: - Add a comment explaining why only SIMD8 mode is enabled with
MSDISPMODE_PERSAMPLE.
- Use shared function _mesa_get_min_invocations_per_fragment().
- Use brw_wm_prog_data variables: uses_pos_offset, uses_omask.
Signed-off-by: Anuj Phogat
---
src/mesa/driver
e 288 for details.
V2: - Add a comment explaining why only SIMD8 mode is enabled with
MSDISPMODE_PERSAMPLE.
- Use shared function _mesa_get_min_invocations_per_fragment().
- Use brw_wm_prog_data variables: uses_pos_offset, uses_omask.
Signed-off-by: Anuj Phogat
---
src/mesa/driver
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
Reviewed-by: Ken Graunke
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 803d090..88201bd
On Sun, Oct 27, 2013 at 7:42 AM, Paul Berry wrote:
> On 18 October 2013 17:24, Anuj Phogat wrote:
>>
>> Setting bilinear_filter flag in case of multisample blits with
>> GL_LINEAR filter causes incorrect behavior in translate_dst_to_src()
>> function. This broke Mod
On Mon, Oct 28, 2013 at 10:29 AM, Ian Romanick wrote:
> On 10/25/2013 04:44 PM, Anuj Phogat wrote:
>> New functions added by GL_ARB_sample_shading:
>> glMinSampleShadingARB()
>>
>> New enums:
>> GL_SAMPLE_SHADING_ARB
>> GL_MIN_SAMPLE_SHADING_VALUE_ARB
>&
On Mon, Oct 28, 2013 at 3:23 PM, Paul Berry wrote:
> On 25 October 2013 16:45, Anuj Phogat wrote:
>
>> V2:
>>- Update comments
>>- Make changes to support simd16 mode.
>>- Add compute_sample_id variables in brw_wm_prog_key
>>- Add a sp
On Mon, Oct 28, 2013 at 6:14 PM, Paul Berry wrote:
> On 25 October 2013 16:45, Anuj Phogat wrote:
>
>> - Enable GEN6_WM_MSDISPMODE_PERSAMPLE, GEN6_WM_POSOFFSET_SAMPLE,
>> GEN6_WM_OMASK_TO_RENDER_TARGET as per extension's specification.
>> - Only enable one of
On Mon, Oct 28, 2013 at 7:00 PM, Paul Berry wrote:
> On 28 October 2013 18:14, Paul Berry wrote:
>
>> On 25 October 2013 16:45, Anuj Phogat wrote:
>>
>>> - Enable GEN6_WM_MSDISPMODE_PERSAMPLE, GEN6_WM_POSOFFSET_SAMPLE,
>>> GEN6_WM_OMASK_TO_RENDER_TAR
On Tue, Oct 29, 2013 at 12:36 AM, Eric Anholt wrote:
> Anuj Phogat writes:
>
> > V2:
> >- Update comments.
> >- Make changes to support simd16 mode.
> >- Add compute_pos_offset variable in brw_wm_prog_key.
> >- Add variable uses_omask in brw
On Mon, Oct 28, 2013 at 6:48 PM, Paul Berry wrote:
> On 25 October 2013 16:45, Anuj Phogat wrote:
>
>> - Enable GEN7_WM_MSDISPMODE_PERSAMPLE, GEN7_WM_POSOFFSET_SAMPLE,
>> GEN7_WM_OMASK_TO_RENDER_TARGET as per extension's specification.
>> - Only enable one of
On Tue, Oct 29, 2013 at 4:31 PM, Paul Berry wrote:
> On 29 October 2013 15:59, Anuj Phogat wrote:
>
>>
>>
>>
>> On Mon, Oct 28, 2013 at 6:48 PM, Paul Berry wrote:
>>
>>> On 25 October 2013 16:45, Anuj Phogat wrote:
>>>
>>>&g
On Mon, Oct 28, 2013 at 5:10 PM, Paul Berry wrote:
> On 25 October 2013 16:45, Anuj Phogat wrote:
>
>> V2:
>>- Update comments
>>- Use fs_reg(0x) in AND instruction to get the 16 bit
>> sample_mask.
>>- Add a special backend instructions
On Tue, Oct 29, 2013 at 10:04 PM, Paul Berry wrote:
> On 29 October 2013 19:22, Anuj Phogat wrote:
>>
>>
>>
>>
>> On Mon, Oct 28, 2013 at 5:10 PM, Paul Berry
>> wrote:
>>>
>>> On 25 October 2013 16:45, Anuj Phogat wrote:
>>>&g
On Tue, Oct 29, 2013 at 9:29 PM, Paul Berry wrote:
> On 29 October 2013 21:28, Paul Berry wrote:
>
>> On 29 October 2013 17:16, Anuj Phogat wrote:
>>
>>>
>>>
>>>
>>> On Tue, Oct 29, 2013 at 4:31 PM, Paul Berry wrote:
>>>
s://github.com/aphogat/mesa.git branch: sample-shading-11
Anuj Phogat (12):
mesa: Add infrastructure for GL_ARB_sample_shading
mesa: Add new functions and enums required by GL_ARB_sample_shading
mesa: Pass number of samples as a program state variable
glsl: Add new builtins required by GL_ARB_
This patch implements the common support code required for the
GL_ARB_sample_shading extension.
V2: Move GL_ARB_sample_shading to ARB extension list.
Signed-off-by: Anuj Phogat
Reviewed-by: Ian Romanick
Reviewed-by: Ken Graunke
---
src/glsl/glcpp/glcpp-parse.y| 3 +++
src/glsl
V2:
- Update comments.
- Add compute_pos_offset variable in brw_wm_prog_key.
- Add variable uses_pos_offset in brw_wm_prog_data.
V3:
- Make changes to support simd16 mode.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/brw_context.h | 1
V2:
- Update comments
- Add compute_sample_id variables in brw_wm_prog_key
- Add a special backend instruction to compute sample_id.
V3:
- Make changes to support simd16 mode.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/brw_defines.h
x27;simd8 only' mode in case of non 1x per sample shading.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/gen7_wm_state.c | 61 ---
1 file changed, 56 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/ge
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
Reviewed-by: Ken Graunke
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index abc3176..5eae84f
This is required while adding builtin system value vec{2, 3, 4}
variables. For example:
(declare (sys) vec2 gl_SamplePosition)
Without this patch above glsl ir splits in to:
(declare (temporary) float gl_SamplePosition_x)
(declare (temporary) float gl_SamplePosition_y)
Signed-off-by: Anuj Phogat
This function is used to test if we need to do per sample shading or
per fragment shading.
V2: Use MAX2() to make sure the function returns a number >= 1.
Signed-off-by: Anuj Phogat
Reviewed-by: Ian Romanick
Reviewed-by: Paul Berry
---
src/mesa/program/program.c |
x27;simd8 only' mode in case of non 1x per sample shading.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/gen6_wm_state.c | 61 ---
1 file changed, 56 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/ge
SampleMask[] array.
- Make gl_SampleID and gl_SamplePosition system values.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
Reviewed-by: Ian Romanick
---
src/glsl/builtin_variables.cpp | 18 ++
src/mesa/main/mtypes.h | 10 +-
src/mesa/program/prog_print.c
extra_gl40_ARB_sample_shading predicate to get.c.
V3:
Fix make check failure.
Add checks for desktop GL.
Use GLfloat in place of GLclampf in glMinSampleShading().
Signed-off-by: Anuj Phogat
Reviewed-by: Ken Graunke
---
src/mapi/glapi/gen/ARB_sample_shading.xml | 19 +++
src/mapi/glapi/gen/GL4x.xml
.
Signed-off-by: Anuj Phogat
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/brw_context.h| 1 +
src/mesa/drivers/dri/i965/brw_defines.h| 1 +
src/mesa/drivers/dri/i965/brw_fs.h | 5 +++
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 42
Number of samples will be required in fragment shader program by new
GLSL builtin uniform "gl_NumSamples".
V2: Use "state.numsamples" in place of "state.num.samples"
Use _NEW_BUFFERS flag in place of _NEW_MULTISAMPLE
Signed-off-by: Anuj Phogat
Reviewed-by:
This patch make changes to correctly set up the Dispatch GRF Start
Register in case of 'SIMD16 only' FS dispatch.
This fixes an issue of incorrect rendering on dolphin emulator with
GL_SAMPLE_SHADING enabled.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/gen6_wm_st
X_f, Y_f, Xp_f, Yp_f variables are used just inside
translate_dst_to_src().So, they can be defined just as
local variables.
Signed-off-by: Anuj Phogat
---
I think I missed this change during the review of my single
sample scaled blit patches.
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 13
On Tue, Nov 12, 2013 at 5:51 PM, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_vec4_gs.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_gs.c
> b/src/mesa/drivers/dri/i965/brw_vec4_gs.c
> index b52
; -pop_force_sechalf();
> color.sechalf = false;
>}
> }
> @@ -2923,7 +2920,6 @@ fs_visitor::fs_visitor(struct brw_context *brw,
> this->nr_params_remap = 0;
>
> this->force_uncompressed_stack = 0;
> - this->force_sechalf_stack =
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/glformats.c | 67 +++
src/mesa/main/glformats.h | 3 +++
2 files changed, 70 insertions(+)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index b95ecea..8107757 100644
--- a/src
Fixes gles3 Khronos CTS test: texture_storage_texture_internal_formats
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstorage.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c
index 44b5374..897d589 100644
A compile error will be generated for redefinition of these macros.
Cc:
Signed-off-by: Anuj Phogat
---
src/glsl/glcpp/glcpp-parse.y | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y
index 9887583..2ddc8b9 100644
--- a/src/glsl
Fixes many failures in gles3 Khronos CTS test: packed_pixels
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 11b8439..a09d994 100644
--- a/src/mesa/main
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index b8627a3..03ebbd8 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -2262,7
Fixes gles3 Khronos CTS tests:
tokens_after_else_vertex
tokens_after_else_fragment
Cc:
Signed-off-by: Anuj Phogat
---
src/glsl/glcpp/glcpp-lex.l | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/glcpp/glcpp-lex.l b/src/glsl/glcpp/glcpp-lex.l
index 188e454..393db81 100644
--- a
This patch specifically fixes redefinition condition for white space
changes. #define and #undef functionality in GLSL follows the standard
for C++ preprocessors for macro definitions.
>From https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html:
These definitions are effectivel
Patches in this series fix few preprocessor bugs and GLES3 error conditions.
This series is also available on 'review' branch at:
https://github.com/aphogat/mesa.git
Anuj Phogat (15):
glsl: Add __FILE__ and __LINE__ as built-in macros
glsl: Do not allow undefining the built-in mac
Fixes few failures in gles3 Khronos CTS test: packed_pixels
Cc: "10.2"
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 03ebbd8..6474dba 100644
--- a/src
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/glformats.c | 37 +
src/mesa/main/glformats.h | 3 +++
2 files changed, 40 insertions(+)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 9bb341c..05a3842 100644
--- a/src/mesa/main
undefine_invalid_object_2_fragment
Cc:
Signed-off-by: Anuj Phogat
---
src/glsl/glcpp/glcpp-parse.y | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y
index 2ddc8b9..befd7d0 100644
--- a/src/glsl/glcpp/glcpp-parse.y
+++ b/src/glsl/glcpp/glcpp-parse.y
@@ -260,6
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/glformats.h | 3 +++
src/mesa/main/teximage.c | 12 ++--
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/glformats.h b/src/mesa/main/glformats.h
index af10899..5c3b2e3 100644
--- a/src/mesa/main/glformats.h
Fixes many failures in gles3 Khronos CTS test: packed_pixels
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 6474dba..c926a2f
Fixes gles3 Khronos CTS test: texture_storage_texture_targets
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstorage.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c
index 86c8f3c..44b5374 100644
--- a/src/mesa/main
Function is utilized by next patch in the series.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/glformats.c | 18 ++
src/mesa/main/glformats.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 05a3842
Fixes many failures in gles3 Khronos CTS test: packed_pixels
Khronos bug# 9807
Cc:
Signed-off-by: Anuj Phogat
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 45 -
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/src/mesa
On Fri, Jun 6, 2014 at 9:03 PM, Matt Turner wrote:
> On Fri, Jun 6, 2014 at 4:56 PM, Anuj Phogat wrote:
>> A compile error will be generated for redefinition of these macros.
>>
>> Cc:
>> Signed-off-by: Anuj Phogat
>> ---
>> src/glsl/glcpp/glcpp-parse.y
d.
>
> NOTE: This is a candidate for the stable branch
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56442
> Fixes: preprocess17_frag.test from oglconform
> Reviewed-by: Carl Worth (glcpp-parse.y)
> Acked-by: Ian Romanick
> Reviewed
On Fri, Jun 6, 2014 at 5:41 PM, Marek Olšák wrote:
> Since this seems to be a GLES-only limitation, the patch should use
> _mesa_is_gles3 or _mesa_is_gles.
>
These changes occur inside a 'if' block testing for gles3 context.
> Marek
>
> On Sat, Jun 7, 2014 at
On Mon, Jun 9, 2014 at 11:44 AM, Matt Turner wrote:
> On Mon, Jun 9, 2014 at 11:40 AM, Anuj Phogat wrote:
>> On Fri, Jun 6, 2014 at 9:42 PM, Ian Romanick wrote:
>>> I thought Matt already fixed this bug.
>> A basic testing shows that below commit fixed the "gar
g list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Did a basic testing with your branch. Things seem to work fine.
This series is: Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Adding mesa-dev in CC.
On Wed, Jun 11, 2014 at 10:39 AM, Courtney Goeltzenleuchter <
court...@lunarg.com> wrote:
>
>
>
> On Fri, Jun 6, 2014 at 5:57 PM, Anuj Phogat wrote:
>
>> Fixes many failures in gles3 Khronos CTS test: packed_pixels
>>
>> Khronos b
Adding mesa-dev to the conversation.
On Wed, Jun 11, 2014 at 10:52 AM, Anuj Phogat wrote:
>
> On Wed, Jun 11, 2014 at 10:28 AM, Courtney Goeltzenleuchter
> wrote:
>>
>> On Fri, Jun 6, 2014 at 5:57 PM, Anuj Phogat wrote:
>>>
>>> Fixes many failures i
GL_TEXTURE_CUBE_MAP is an allowed texture target in glTexStorage2D()
and is allowed to be used (like GL_TEXTURE_2D) with compressed internal
formats.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/teximage.c b/src
On Wed, Jun 11, 2014 at 5:32 PM, Carl Worth wrote:
> Anuj Phogat writes:
>> Fixes piglit tests in spec/glsl-es-3.00/compile:
>> undef-__FILE__.vert
>> undef-GL_ES.vert
>> undef-__LINE__.vert
>> undef-__VERSION__.vert
>
> I see the code that will fix __FILE_
On Wed, Jun 11, 2014 at 6:51 PM, Carl Worth wrote:
> Anuj Phogat writes:
> >> #if 0
> >> #else garbage
> >> #endif
> >>
> >> The Khronos test contains two tokens after #else. I'm not sure if that
> >> is the difference or not.
&
00644
> index 000..951581e
> --- /dev/null
> +++ b/src/glsl/glcpp/tests/124-preprocessing-numbers.c.expected
> @@ -0,0 +1,9 @@
> +
> +
> +
> +
> +
> +int n = 1e;
> +int p = 1xyz;
> +
> +
> --
> 2.0.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
0
> --- a/src/glsl/glcpp/tests/103-garbage-after-else.c.expected
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -0:2(7): preprocessor error: syntax error, unexpected IDENTIFIER, expecting
> NEWLINE
> -0:1(7): preprocessor error: Unterminated #if
> -
> -
> diff --git a/src/glsl/glcpp/tes
On Thu, Jun 12, 2014 at 11:42 PM, Tapani Pälli wrote:
> On 06/07/2014 02:57 AM, Anuj Phogat wrote:
>> Fixes gles3 Khronos CTS tests:
>> tokens_after_else_vertex
>> tokens_after_else_fragment
>>
>> Cc:
>> Signed-off-by: Anuj Phogat
>> ---
>&
): preprocessor error: Built-in (pre-defined) macro names can not be
> undefined.
> +0:3(1): preprocessor error: Built-in (pre-defined) macro names can not be
> undefined.
> +
> +
> +
> +
> --
> 2.0.0
>
> ___
> mesa-de
efinition of macro FOUR
> +
> +0:16(9): preprocessor error: Redefinition of macro SIX
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> --
> 2.0.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Jul 24, 2013 at 5:06 PM, Chad Versace
wrote:
> This patch is
> Reviewed-by: Chad Versace
> with the understanding that it depends on previous patches.
>
> I'll begin reviewing your Piglit tests now.
>
>
> On 07/24/2013 03:23 AM, Topi Pohjolainen wrote:
>>
>> Signed-off-by: Topi Pohjolaine
Fixes gles3 Khronos CTS test:
egl_create_context.egl_create_context
Cc:
Signed-off-by: Anuj Phogat
---
src/egl/main/eglcontext.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
index 70277ab..b8b30cb 100644
On Thu, Jun 12, 2014 at 5:18 PM, Anuj Phogat wrote:
> On Thu, Jun 12, 2014 at 3:13 PM, Carl Worth wrote:
>>
>> The preprocessor defines a notions of a "preprocessing number" that
>> starts with either a digit or a decimal point, and continues with zero
>&
t), will be
> passed on as-is from the preprocessor to the compiler proper.
>
> This fixes the following Khronos GLES3 CTS tests:
>
> preprocessor.basic.correct_phases_vertex
> preprocessor.basic.correct_phases_fragment
>
> v2. Thanks to Anuj Phogat for im
On Thu, Jun 19, 2014 at 6:11 AM, Tapani Pälli wrote:
> This fixes following tests in es3conform:
>
>shaders.switch.default_not_last_dynamic_vertex
>shaders.switch.default_not_last_dynamic_fragment
>
> and makes following tests in Piglit pass:
>
>glsl-1.30/execution/switch/fs-default-no
npot_pbo_tex_sub_image_2d
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 2ab0faa..b36ffc7
sions.
Signed-off-by: Anuj Phogat
Acked-by: Kristian Høgsberg
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 63 ++--
1 file changed, 10 insertions(+), 53 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index a3
,
> + { "glBlendFunci", 40, -1 },
> + { "glBlendFuncSeparatei", 40, -1 },
>
> /* GL 4.3 */
> { "glIsRenderbuffer", 43, -1 },
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
I agree with Ken's comment# 11 on bugzilla.
Acked-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
inst = emit(MOV(half(int_sample_y, 1),
> + fs_reg(suboffset(sample_pos_reg, 17;
>inst->force_sechalf = true;
> }
> /* Compute gl_SamplePosition.y */
> --
> 2.0.0
>
> ___
because depth texture data needs clamping to [0.0, 1.0]. Let the
_mesa_texstore() fallback to slower path.
Fixes Khronos GLES3 CTS tests:
shadow_execution_vert
shadow_execution_frag
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 4 ++--
1 file changed, 2 insertions(+), 2
401 - 500 of 1807 matches
Mail list logo
