On Mon, Sep 14, 2015 at 11:17 AM, Nanley Chery
wrote:
> From: Nanley Chery
>
> According to the extensions table and our glext headers,
> OES_compressed_ETC1_RGB8_texture is only supported in
> GLES1 and GLES2. Since we may give users a GLES3 context
> when a GLES2 context is requested, we also
On Tue, Sep 1, 2015 at 6:58 AM, Emil Velikov
wrote:
> Hi all
>
> On 21 August 2015 at 23:04, Anuj Phogat wrote:
> > We have a similar check in meta pbo path.
> >
> > Cc:
> > Signed-off-by: Anuj Phogat
> > ---
> > src/mesa/drivers/dri/i965/intel
gt;API == API_OPENGL_COMPAT &&
> + ctx->Extensions.ATI_texture_compression_3dc) {
>switch (internalFormat) {
>case GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI:
> return GL_LUMINANCE_ALPHA;
> --
> 2.5.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
e GL_UNSIGNED_SHORT:
> + case GL_UNSIGNED_INT:
>case GL_UNSIGNED_INT_24_8:
> if (!is_float_depth)
> return GL_NO_ERROR;
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/
On Thu, Sep 10, 2015 at 2:38 PM, Ville Syrjälä <
ville.syrj...@linux.intel.com> wrote:
> On Thu, Sep 10, 2015 at 12:20:10PM -0700, Chad Versace wrote:
> > On Wed 19 Aug 2015, Anuj Phogat wrote:
> > > V2:
> > > - Do the tile width/height computations in the new h
&& ctx->Extensions.OES_compressed_ETC1_RGB8_texture;
> + case MESA_FORMAT_LAYOUT_ETC2:
> + return _mesa_is_gles3(ctx) || ctx->Extensions.ARB_ES3_compatibility;
> + case MESA_FORMAT_LAYOUT_BPTC:
> + return _mesa_is_desktop_gl(ctx) &&
> + ctx->Extensions.ARB_texture_compression_bptc;
> + case MESA_FORMAT_LAYOUT_ASTC:
> + return ctx->Extensions.KHR_texture_compression_astc_ldr;
> default:
>return GL_FALSE;
> }
> --
> 2.5.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
It's a nice patch decluttering the switch. With no piglit, gles3 conformance
regressions:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
default:
> - ; /* fallthrough */
> - }
> - }
> -
> - if (ctx->API == API_OPENGLES) {
> - switch (internalFormat) {
> - case GL_PALETTE4_RGB8_OES:
> - case GL_PALETTE4_R5_G6_B5_OES:
> - case GL_PALETTE8_RGB8_OES:
> -
se GL_COMPRESSED_ALPHA:
> --
> 2.5.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
n/readpix.c
> @@ -963,6 +963,7 @@ read_pixels_es3_error_check(GLenum format, GLenum type,
> return GL_NO_ERROR;
> break;
>case GL_UNSIGNED_SHORT:
> + case GL_UNSIGNED_INT:
>case GL_UNSIGNED_INT_24_8:
> if (!is_flo
8,7 @@ _mesa_get_compressed_fetch_func(mesa_format format)
> case MESA_FORMAT_LAYOUT_FXT1:
>return _mesa_get_fxt_fetch_func(format);
> case MESA_FORMAT_LAYOUT_RGTC:
> + case MESA_FORMAT_LAYOUT_LATC:
>return _mesa_get_compressed_rgtc_func(format);
> case MESA_FORMAT_LAYOUT
Versace
Cc: Topi Pohjolainen
Signed-off-by: Anuj Phogat
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 82 ---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++
2 files changed, 64 insertions(+), 22 deletions(-)
diff --git a/src/mesa
Cc: Topi Pohjolainen
Signed-off-by: Anuj Phogat
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.cpp | 4 +++-
src/mesa/drivers/dri/i965/brw_misc_state.c| 20 +++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 31 ---
src
On Wed, Sep 16, 2015 at 4:30 PM, Chad Versace wrote:
> On Wed 19 Aug 2015, Anuj Phogat wrote:
>> This function isn't specific to miptrees. So, drop the "miptree"
>> from function name.
>>
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/dri
This function isn't specific to miptrees. So, drop the "miptree"
from function name.
V3: Add a comment explaining how the 1D Array texture height and
depth is interpreted by Intel hardware.
Cc: Chad Versace
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_fbo.
d that
> patch should be safe for stable.
>
> Signed-off-by: Ian Romanick
> Cc: Anuj Phogat
> Cc: Topi Pohjolainen
> Cc: Jordan Justen
> Cc: "10.6 11.0"
> ---
> This is currently running through our Jenkins server. There were no
> regressions on my BD
On Mon, Aug 10, 2015 at 11:20 AM, Anuj Phogat wrote:
> This condition restricts the use of fast copy blit to cases
> where starting pixel of src and dst is oword (16 byte) aligned.
>
> Many piglit tests (if using fast copy blit in Mesa) failed earlier
> because I missed adding this
On Mon, Aug 10, 2015 at 1:59 PM, Anuj Phogat wrote:
>
>
> On Mon, Aug 10, 2015 at 11:17 AM, Anuj Phogat wrote:
>>
>> Many piglit tests (if using fast copy blit in Mesa) failed earlier
>> because I missed adding this condition. Fast copy blit is currently
>> enabl
If gen9_use_linear_1d_layout() returns true, we discards the align_w
computed earlier and use fixed align_w = 64 in gen9_miptree_layout_1d().
So, avoid computing align_w when not required.
V2: Rebased on master.
Signed-off-by: Anuj Phogat
---
Bump for the series.
src/mesa/drivers/dri/i965
s a 4x4 grid as follows:
> +*
> + *-
> +*| 0 | 1 | 2 | 3 |
> +*-
> +*| 4 | 5 | 6 | 7 |
> +*-
> +*| 8 | 9 |10 |11 |
> +*-
> +*|12 |13 |14 |15 |
> +*-
> */
> uint8_t SampleMap2x[2];
> uint8_t SampleMap4x[4];
> uint8_t SampleMap8x[8];
> + uint8_t SampleMap16x[16];
>
> /** GL_ARB_shader_atomic_counters */
> GLuint MaxAtomicBufferBindings;
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
27;re supposed to get the per slot SampleID written to 15:0
bits in
R1.0. I used SSPI to compute the SampleID because I never got anything
useful
in these bits on IVB. Things might have changed on later platforms. So, I
think
it's worth trying to do what docs say. I'll send ou
On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote:
> Clarify that this bit extends the set of GL_MAP_*_BIT enums.
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> b/src/mesa/drivers
On Fri, Sep 25, 2015 at 12:44 PM, Anuj Phogat wrote:
> On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote:
>> Clarify that this bit extends the set of GL_MAP_*_BIT enums.
>> ---
>> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++
>> 1 file changed, 2 insertion
On Fri, Sep 25, 2015 at 4:27 PM, Chad Versace wrote:
> On Tue 22 Sep 2015, Anuj Phogat wrote:
>> This function isn't specific to miptrees. So, drop the "miptree"
>> from function name.
>>
>> V3: Add a comment explaining how the 1D Array texture heigh
ee *mt);
> +
> bool
> intel_miptree_alloc_non_msrt_mcs(struct brw_context *brw,
> struct intel_mipmap_tree *mt);
> --
> 2.5.0.342.g44e0223
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedes
This patch caused regressions on master. More work need to be done
before we skip computing align_w for linear 1d layouts. Dropping this
patch from the series. Rest of the patches still need review.
On Wed, Sep 23, 2015 at 4:53 PM, Anuj Phogat wrote:
> If gen9_use_linear_1d_layout() returns t
> -
> extern void
> _mesa_delete_nameless_texture(struct gl_context *ctx,
>struct gl_texture_object *texObj);
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
>
- assert(targetIndex < NUM_TEXTURE_TARGETS);
> texObj->TargetIndex = targetIndex;
>}
>
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
--git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c
> index 5a3282a..04b7d73 100644
> --- a/src/mesa/main/textureview.c
> +++ b/src/mesa/main/textureview.c
> @@ -681,6 +681,8 @@ _mesa_TextureView(GLuint texture, GLenum target, GLuint
> origtexture,
> texObj->Immutable = GL_TRUE;
> te
On Thu, Oct 8, 2015 at 11:01 AM, Brian Paul wrote:
> You tested with all 3 patches and everything's OK now?
>
> I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move
> gl_texture_object::TargetIndex initializations") from someone before
> pushing.
done.
>
> -Brian
>
>
> On 10/08/2015 11
> + if (brw->gen >= 9 || mt->num_samples == 1)
> + assert(mt->halign == 16);
> }
>
> uint32_t *surf = allocate_surface_state(brw, &offset, surf_index);
> --
> 2.5.0.342.g44e0223
>
> ___
> m
, \
> + GEN9_HW_INFO
> +
> +
> static const struct brw_device_info brw_device_info_skl_gt1 = {
> GEN9_FEATURES, .gt = 1,
> .num_slices = 1,
> --
> 2.6.4
>
> ______
vs_threads = 56,
> .max_hs_threads = 56,
> .max_ds_threads = 56,
> --
> 2.6.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> return;
> - if (!add_packed_varyings(shProg, output_stage))
> + if (!add_packed_varyings(shProg, output_stage, GL_PROGRAM_OUTPUT))
> return;
> }
>
> --
> 2.4.3
>
> ___
> mesa-dev mai
return true;
> }
>
> --
> 2.4.3
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
LGTM.
Reviewed-by: Anuj Phogat
Do we have a piglit test hitting this code?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
r->data.mode = ir_var_auto;
> }
>}
> }
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
demote_shader_inputs_and_outputs(sh_i, ir_var_shader_out);
> - demote_shader_inputs_and_outputs(sh_next, ir_var_shader_in);
> -
> - /* Eliminate code that is now dead due to unused outputs being demoted.
> - */
> - while (do_dead_code(sh_i->ir, false))
> - ;
> - while (do_dead_code(sh_next->ir, false))
> - ;
> -
>/* This must be done after all dead varyings are eliminated. */
>if (!check_against_output_limit(ctx, prog, sh_i))
> goto done;
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Looks like the right thing to do.
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
var_slot;
> + var_slot += 1;
> + }
> }
>
> return slots;
> @@ -1671,7 +1727,7 @@ assign_varying_locations(struct gl_context *ctx,
>reserved_varying_slot(producer, ir_var_shader_out) |
>reserved_varying_slot(consumer, ir_var_shader_in);
>
> - const unsigned slots_used = matches.assign_locations(reserved_slots,
> + const unsigned slots_used = matches.assign_locations(prog, reserved_slots,
>
> prog->SeparateShader);
> matches.store_locations();
>
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Acked-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
YING_SLOT_VAR0)
> continue;
>
>var_slot = var->data.location - VARYING_SLOT_VAR0;
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mes
te->es_shader && !state->EXT_blend_func_extended_enable) {
> _mesa_glsl_error(& @3, state, "index layout qualifier requires
> EXT_blend_func_extended");
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
/**
> + * Was an initial component explicitly set in the shader?
> + */
> + unsigned explicit_component:1;
> +
> + /**
> * Does this variable have an initializer?
> *
> * This is used by the linker to cross-validiate initializers of global
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
t;has no matching output\n",
> + _mesa_shader_stage_to_string(consumer->Stage),
> + input->name);
> + break;
> + }
> + idx++;
> }
>
_type *type = get_varying_type(var, stage);
>
>if (type->is_array()) {
> slots = 1;
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
wrote:
> This change checks for component overlap, including handling overlap of
> locations and components by doubles. Previously there was no validation
> for assigning explicit locations to a location used by the second half
> of a double.
>
> V2:
> VARYING_SLOT_VAR0];
> + output = explicit_locations[input->data.location -
> VARYING_SLOT_VAR0]
> +[input->data.location_frac];
>
> if (output != NULL){
> input->data.is_unmatched_generic_inout = 0;
uble.
>
> V3: simplify handling of doubles and fix double component aliasing
> detection
>
> V2: fix component matching for matricies
>
> Cc: Anuj Phogat
> ---
> src/glsl/link_varyings.cpp | 63
> ++
> 1 file changed, 52
> + _mesa_bitcount_64(reserved_slots);
> +
> matches.store_locations();
>
> for (unsigned i = 0; i < num_tfeedback_decls; ++i) {
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
>
ctions,
> - &new_variables);
> + &new_variables,
> + disable_varying_packing);
> visitor.run(shader);
> if (mode == ir_var_shader_out) {
>if (shader->Stage == MESA_SHADER_GEOMETRY) {
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
gs_input_vertices,
> &new_instructions,
> &new_variables,
> - disable_varying_packing);
> +
ds,
> - Neil
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Looks like the right thing to do.
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ata.location;
>existing->data.explicit_location = true;
> }
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
R
"overlapping location is assigned "
> @@ -2614,6 +2665,9 @@ assign_attribute_or_color_locations(gl_shader_program
> *prog,
> double_storage_locations |= (use_mask << attr);
> }
>
> + assigned[assigned_attr] = var;
> + assigned_attr++;
> +
> continue;
>}
>
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
nent.
>
> Cc: Anuj Phogat
> ---
> src/glsl/linker.cpp | 72
> +
> 1 file changed, 62 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
> index b81bfba..c66dcc4 100644
>
Timothy, Do you have a branch somewhere with the latest patches?
On Wed, Jan 13, 2016 at 10:58 AM, Anuj Phogat wrote:
> On Wed, Jan 13, 2016 at 1:19 AM, Timothy Arceri
> wrote:
>> V2: fix error checking for arrays and components. V1 was
>> only taking into account all the arra
2.5.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
LGTM.
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
der_out) {
> if (shader->Stage == MESA_SHADER_GEOMETRY) {
> -/* For geometry shaders, outputs need to be lowered before each
> - * call to EmitVertex()
> +/* For geometry shaders, outputs need to be lowered be
disable_varying_packing,
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
With the suggested changes:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
uts)
> {
> ir_function *main_func = shader->symbols->get_function("main");
> exec_list void_parameters;
> @@ -763,8 +763,15 @@ lower_packed_varyings(void *mem_ctx, unsigned
> locations_used,
> shader->Stage == MESA_SHADER_TESS_EVAL)) {
>exec_list *instructions = shader->ir;
>exec_list new_instructions, new_variables;
> +
> + bool is_outer_array_vert_idx = false;
> + if (mode == ir_var_shader_in &&
> + shader->Stage == MESA_SHADER_GEOMETRY) {
> + is_outer_array_vert_idx = true;
> + }
> +
>lower_packed_varyings_visitor visitor(mem_ctx, locations_used, mode,
> -gs_input_vertices,
> +is_outer_array_vert_idx,
> &new_instructions,
> &new_variables,
> base_location,
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
s.
> -*/
> - const glsl_type *type = var->type->without_array();
> - if (type->vector_elements == 4 && !type->is_double())
> - return false;
> - return true;
> -}
> -
>
> /**
> * Visitor that splices varying packing code before every use of EmitVertex()
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
this->is_outer_array_vert_idx);
>unpacked_var->insert_before(packed_var);
>this->packed_varyings[slot] = packed_var;
> } else {
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
__
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
wrote:
> ---
> src/glsl/lower_packed_varyings.cpp | 45
> +++---
> 1 file changed, 32 insertions(+), 13 deletions(-)
>
> diff --git a/src/glsl/lower_packed_varyings.cpp
> b/src/glsl/lower_packed_varyings.cpp
> index
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
wrote:
> This is needed now that we pack these type of varyings when they have a
> component layout qualifier.
> ---
> src/glsl/linker.cpp | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/src/glsl/linker.cpp b
On Wed, Jan 20, 2016 at 1:53 PM, Timothy Arceri
wrote:
> On Wed, 2016-01-20 at 09:32 -0800, Anuj Phogat wrote:
>> On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
>> wrote:
>> > ---
>> > src/glsl/lower_packed_varyings.cpp | 45
>> > +
On Wed, Jan 20, 2016 at 1:39 PM, Timothy Arceri
wrote:
> On Wed, 2016-01-20 at 10:06 -0800, Anuj Phogat wrote:
>> On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
>> wrote:
>> > This is needed now that we pack these type of varyings when they
>> > have
On Wed, Jan 20, 2016 at 4:28 PM, Timothy Arceri
wrote:
> On Wed, 2016-01-20 at 15:38 -0800, Anuj Phogat wrote:
>> On Wed, Jan 20, 2016 at 1:39 PM, Timothy Arceri
>> wrote:
>> > On Wed, 2016-01-20 at 10:06 -0800, Anuj Phogat wrote:
>> > > On Mon, Dec
On Thu, Jan 21, 2016 at 1:47 PM, Timothy Arceri
wrote:
> On Thu, 2016-01-21 at 09:23 -0800, Anuj Phogat wrote:
>> On Wed, Jan 20, 2016 at 4:28 PM, Timothy Arceri
>> wrote:
>> > On Wed, 2016-01-20 at 15:38 -0800, Anuj Phogat wrote:
>> > > On Wed, Jan
On Thu, Jan 21, 2016 at 3:49 PM, Timothy Arceri
wrote:
> On Thu, 2016-01-21 at 15:28 -0800, Anuj Phogat wrote:
>> On Thu, Jan 21, 2016 at 1:47 PM, Timothy Arceri
>> wrote:
>> > On Thu, 2016-01-21 at 09:23 -0800, Anuj Phogat wrote:
>> > > On Wed, Jan
On Tue, Feb 2, 2016 at 2:51 PM, Ben Widawsky
wrote:
> They were already declared as such. It was changed here:
> commit 31f0967fb50101437d2568e9ab9640ffbcbf7ef9
> Author: Ian Romanick
> Date: Wed Sep 2 14:43:18 2015 -0700
>
> i965: Make intel_miptree_map_raw static
>
> Cc: Ian Romanick
> S
On Thu, Feb 4, 2016 at 3:21 AM, Emil Velikov wrote:
> Hi Anuj,
>
> On 24 December 2015 at 21:04, Anuj Phogat wrote:
>> OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both
>> ES 1.0 and 2.0 don't support GL_STREAM_READ in glBufferData().
>> S
it locations.
>
> V3: Don't remove rules from the varying linking code as we need to
> disable packing in the producer if the consumer is a TCS.
>
> V2: move the tessellation packing rules, allow TES output to be packed.
>
> Cc: Anuj Phogat
> ---
> src/
On Fri, Feb 5, 2016 at 11:30 AM, Ian Romanick wrote:
>
> On 12/24/2015 01:04 PM, Anuj Phogat wrote:
> > OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both
> > ES 1.0 and 2.0 don't support GL_STREAM_READ in glBufferData().
> > So, handle it correct
ramebuffer_renderbuffer(struct gl_context *ctx,
> struct gl_framebuffer *fb,
> GLenum attachment,
> - struct gl_renderbuffer *rb,
> - const char *func);
> +
On Fri, Feb 5, 2016 at 3:04 PM, Anuj Phogat wrote:
> On Fri, Feb 5, 2016 at 1:04 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> This function previously was only used in fbobject.c and contained a
>> bunch of API validation. Split the function into
>>
manick
Cc: "11.1"
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_tex_subimage.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/common/meta_tex_subimage.c
b/src/mesa/drivers/common/meta_tex_subimage.c
index 4adaad7..
\
> @@ -1722,7 +1720,7 @@ vec4_visitor::run()
> if (unlikely(INTEL_DEBUG & DEBUG_OPTIMIZER)) {
>char filename[64];
>snprintf(filename, 64, "%s-%04d-00-start",
> - stage_name, shader_prog ? shade
ture_renderbuffer(struct gl_context *ctx,
> --
> 2.1.0
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
With Fredrik's comment fixed:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ot raise a GL_ERROR.
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Series is:
Reviewed-by: Anuj Phogat
__
urface_state(brw, &brw->wm.base.surf_offset[surf_index]);
> + uint32_t *surf = allocate_surface_state(brw, &offset);
>
> surf[0] = (surf_type << BRW_SURFACE_TYPE_SHIFT) |
> (is_array ? GEN7_SURFACE_IS_ARRAY : 0) |
> @@ -423,7 +421,7 @@ gen8_update_ren
On Wed, Apr 29, 2015 at 12:17 PM, Matt Turner wrote:
> On Wed, Apr 29, 2015 at 11:05 AM, Anuj Phogat wrote:
>> With Matt's comments fixed:
>> Reviewed-by: Anuj Phogat
>
> So you know, Ken and I have both reviewed this series now. Unless you
> just want to review
0, 16), 4);
> + dw3 |= SET_FIELD(sampler_count, GEN7_PS_SAMPLER_COUNT);
>
> /* BRW_NEW_FS_PROG_DATA */
> dw3 |=
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ow_major) {
>assert(type->is_record());
>if (this->ubo_block_index == -1)
> @@ -564,7 +564,7 @@ private:
>
> virtual void visit_field(const glsl_type *type, const char *name,
> bool row_major, const glsl_ty
In patch heading: s/interger/integer
On Wed, Apr 29, 2015 at 4:26 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> ---
> src/glsl/builtin_functions.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/glsl/builtin_functions.cpp b/src/
On Wed, Apr 29, 2015 at 5:38 PM, Anuj Phogat wrote:
> In patch heading: s/interger/integer
>
> On Wed, Apr 29, 2015 at 4:26 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Signed-off-by: Ian Romanick
>> ---
>> src/glsl/builtin_functions.cpp | 3 ++-
tions(+), 32 deletions(-)
>
> --
> 1.8.5.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Series is:
Reviewed-by: Anuj Phogat
__
| 16 +++---
> 13 files changed, 132 insertions(+), 41 deletions(-)
>
> --
> 1.8.5.1
>
> ___________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Patches 1-12 are:
Reviewed-by: A
On Wed, May 6, 2015 at 2:19 PM, Matt Turner wrote:
> On Wed, Apr 15, 2015 at 11:46 AM, Anuj Phogat wrote:
>> Reduces the number of conditions tested in if to one in case of
>> non-integer formats. Makes no functional changes.
>>
>> Signed-off-by: Anuj Phogat
>>
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_cs.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp
b/src/mesa/drivers/dri/i965/brw_cs.cpp
index e2f3d63..70731e4 100644
--- a/src/mesa/drivers/dri/i965/brw_cs.cpp
+++ b/src/mesa/drivers
>insert_before(cfg->blocks[cfg->num_blocks - 1],
> new_load_payload);
> tex_inst->src[0] = send_header;
> - tex_inst->dst = reg_null_ud;
>
> return true;
> }
> --
> 1.9.3
>
> ___
> mesa-dev ma
ad);
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
intelReadPixels() for a more detailed
> + * explanation.
> + */
> + intel_batchbuffer_emit_mi_flush(brw);
> return;
> + }
>
>perf_debug("%s: fallback to CPU mapping in PBO case\n", __func__);
> }
> --
> 2.3.5
&
On Tue, Apr 21, 2015 at 3:20 PM, Neil Roberts wrote:
>
> Anuj Phogat writes:
>
> > This will allow Skylake to use _mesa_meta_pbo_GetTexSubImage() for reading
> > YF/YS
> > tiled surfaces.
> >
> > V2: Make changes suggested by Neil.
> >
> &g
On Thu, May 21, 2015 at 12:26 PM, Ben Widawsky wrote:
> A lot of opinion stuff is below, feel free to ignore them if you don't think
> there are improvements.
>
> On Fri, Apr 17, 2015 at 04:51:38PM -0700, Anuj Phogat wrote:
>> This patch enables using XY_FAST_COPY_BLT only
On Thu, May 21, 2015 at 1:51 PM, Matt Turner wrote:
> On Thu, May 21, 2015 at 12:26 PM, Ben Widawsky wrote:
>> A lot of opinion stuff is below, feel free to ignore them if you don't think
>> there are improvements.
>>
>> On Fri, Apr 17, 2015 at 04:51:38PM -0700, A
On Thu, May 21, 2015 at 4:33 PM, Ben Widawsky wrote:
> On Fri, Apr 17, 2015 at 04:51:42PM -0700, Anuj Phogat wrote:
>> Note: Yf/Ys tiling stays disabled to avoid any piglit regressions. I'm
>> working on fixing the remaining piglit failures.
>>
>> We need to do s
On Thu, May 21, 2015 at 4:55 PM, Ben Widawsky wrote:
> On Fri, Apr 17, 2015 at 04:51:43PM -0700, Anuj Phogat wrote:
>> This fixed the buffer corruption happening in a FBO which use YF/YS
>> tiled renderbuffer or texture as color attachment.
>>
>> Spec recommends disa
On Thu, May 21, 2015 at 5:46 PM, Anuj Phogat wrote:
> On Thu, May 21, 2015 at 12:26 PM, Ben Widawsky wrote:
>> A lot of opinion stuff is below, feel free to ignore them if you don't think
>> there are improvements.
>>
>> On Fri, Apr 17, 2015 at 04:51:38PM -0700, A
On Wed, May 27, 2015 at 10:42 AM, Ben Widawsky wrote:
> On Thu, May 21, 2015 at 05:46:48PM -0700, Anuj Phogat wrote:
>> On Thu, May 21, 2015 at 12:26 PM, Ben Widawsky wrote:
>
> SNIP
>
>> > As I mentioned above wrt the CL alignment, I think it's safe to do for
On Wed, May 27, 2015 at 11:56 AM, Ben Widawsky wrote:
> On Fri, Apr 17, 2015 at 04:51:28PM -0700, Anuj Phogat wrote:
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/drivers/dri/i965/brw_tex_layout.c | 80
>> ++
>> 1 file changed, 80
On Wed, May 27, 2015 at 12:04 PM, Ben Widawsky wrote:
> On Fri, Apr 17, 2015 at 04:51:30PM -0700, Anuj Phogat wrote:
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/drivers/dri/i965/brw_tex_layout.c | 74
>> ++
>> 1 file changed, 74
layout_flags);
> if (intel_image->mt == NULL)
> return;
> intel_image->mt->target = target;
> @@ -255,8 +254,7 @@ intelSetTexBuffer2(__DRIcontext *pDRICtx, GLint target,
>rb->Base.Base.Width,
>rb-&
801 - 900 of 1807 matches
Mail list logo
