Re: [Mesa-dev] [PATCH 02/17] ac/surface: don't set the display flag for obviously unsupported cases

On 2018-04-04 07:35 PM, Marek Olšák wrote: > On Wed, Apr 4, 2018 at 9:01 AM, Michel Dänzer wrote: >> On 2018-04-04 02:57 PM, Marek Olšák wrote: >>> On Wed, Apr 4, 2018, 6:18 AM Michel Dänzer >> > wrote: >>> >>> On 2018-04-04 03:59 AM, Marek Olšák wrote: >>> > Fro

[Mesa-dev] [Bug 105901] Warn about mipmap-incomplete texture being used

https://bugs.freedesktop.org/show_bug.cgi?id=105901 Bug ID: 105901 Summary: Warn about mipmap-incomplete texture being used Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: enhance

[Mesa-dev] [Bug 105901] Warn about mipmap-incomplete texture being used

https://bugs.freedesktop.org/show_bug.cgi?id=105901 --- Comment #1 from Ruslan Kabatsayev --- Created attachment 138612 --> https://bugs.freedesktop.org/attachment.cgi?id=138612&action=edit Test program -- You are receiving this mail because: You are the assignee for the bug. You are the QA C

[Mesa-dev] [PATCH] nir: Check if u_vector_init() succeeds

However, it only fails when running out of memory. Now, if we are about to check that, we should be consistent and check the allocation of the worklist as well. On the other hand there are other places where we don't check for allocation failures. Therefore I'm not sure if we bother here either. C

[Mesa-dev] [PATCH 1/2] st/mesa: exit st_translate_fragment_program() earlier for NIR path

This avoids a bunch of scanning that is only used by the TGSI path. --- src/mesa/state_tracker/st_program.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 5bf76e1b888..a740c874c9e 100

[Mesa-dev] [Bug 105871] Discolored KDE panels after updating to Mesa 18.0 on Intel broadwell

https://bugs.freedesktop.org/show_bug.cgi?id=105871 --- Comment #12 from sergio.calleg...@gmail.com --- Tapani Pälli's suggestion that the bug was the same as in the other case was 100% correct! Having been notified about this thread, Paulo Dias has very quickly put up on his padoka stable ppa an

[Mesa-dev] [PATCH 2/2] st/mesa: finalise tcs/tes/geom NIR before storing it to the cache

We don't create variants of the NIR so here we finalise it before caching to avoid unnecessary processing when restoring it. --- src/mesa/state_tracker/st_program.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state

[Mesa-dev] [PATCH] intel/dev: Assert the number of slices is not zero

Fixes: c1900f5b intel: devinfo: add helper functions to fill... CID: 1433511 CC: Lionel Landwerlin Signed-off-by: Topi Pohjolainen --- src/intel/dev/gen_device_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/dev/gen_device_info.c b/src/intel/dev/gen_device_in

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On Wed, 2018-04-04 at 11:27 -0700, Mark Janes wrote: > "Juan A. Suarez Romero" writes: > > > On Wed, 2018-04-04 at 10:07 -0700, Mark Janes wrote: > > > Emil Velikov writes: > > > > In detail: > > > > * make the patch queue, release date and blockers accessible at any > > > >point in time: >

[Mesa-dev] [Bug 105871] Discolored KDE panels after updating to Mesa 18.0 on Intel broadwell

https://bugs.freedesktop.org/show_bug.cgi?id=105871 --- Comment #13 from sergio.calleg...@gmail.com --- As an alternate/complement solution to the patched xserver-xorg-core on the Padoka ppa, for those using kde plasma, there is now also a patch to kwin to fix the visuals selection. https://phabr

[Mesa-dev] [Bug 105871] Discolored KDE panels after updating to Mesa 18.0 on Intel broadwell

https://bugs.freedesktop.org/show_bug.cgi?id=105871 --- Comment #14 from Tapani Pälli --- (In reply to sergio.callegari from comment #13) > As an alternate/complement solution to the patched xserver-xorg-core on the > Padoka ppa, for those using kde plasma, there is now also a patch to kwin to >

Re: [Mesa-dev] [PATCH] intel/dev: Assert the number of slices is not zero

Rb On 05/04/18 08:43, Topi Pohjolainen wrote: Fixes: c1900f5b intel: devinfo: add helper functions to fill... CID: 1433511 CC: Lionel Landwerlin Signed-off-by: Topi Pohjolainen --- src/intel/dev/gen_device_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/

Re: [Mesa-dev] [PATCH 10/17] radeonsi: force 2D tiling on VI only when TC-compat HTILE is really enabled

Patches 4-10 are: Reviewed-by: Samuel Pitoiset On 04/04/2018 03:59 AM, Marek Olšák wrote: From: Marek Olšák just pass the flag that indicates it. --- src/gallium/drivers/radeon/r600_texture.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/gallium/dr

Re: [Mesa-dev] [PATCH 12/17] radeonsi/gfx9: don't use the workaround for gather4 + stencil

Patches 11-12 are: Acked-by: Samuel Pitoiset On 04/04/2018 03:59 AM, Marek Olšák wrote: From: Marek Olšák it doesn't seem to be needed. --- src/gallium/drivers/radeonsi/si_state.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH 14/17] radeonsi: emit shader pointers before cache flushes & waits

Patches 13-14 are: Reviewed-by: Samuel Pitoiset On 04/04/2018 03:59 AM, Marek Olšák wrote: From: Marek Olšák This code was written with the constant engine in mind. We can simplify it now. --- src/gallium/drivers/radeonsi/si_state_draw.c | 20 +++- 1 file changed, 7 insert

Re: [Mesa-dev] [PATCH 15/17] radeonsi: always prefetch later shaders after the draw packet

Reviewed-by: Samuel Pitoiset On 04/05/2018 02:33 AM, Marek Olšák wrote: From: Marek Olšák so that the draw is started as soon as possible. v2: only prefetch the API VS and VBO descriptors --- src/gallium/drivers/radeonsi/si_cp_dma.c | 89 +--- src/gallium/drive

Re: [Mesa-dev] [PATCH 17/17] winsys/amdgpu: always set AMDGPU_IB_FLAG_TC_WB_NOT_INVALIDATE

Patches 16-17 are: Reviewed-by: Samuel Pitoiset Those two are quite interesting. I will probably update my kernel and experiment something. On 04/04/2018 03:59 AM, Marek Olšák wrote: From: Marek Olšák There is a kernel patch that adds the new flag. --- src/gallium/winsys/amdgpu/drm/amdg

[Mesa-dev] [PATCH] radv: enable the Polaris small primitive filter control

Enable it directly in the preamble, but do not enable line on Polaris10/11/12 because there is a hw bug. There is possibly an issue when MSAA is off, but this doesn't regress any CTS and AMDVLK doesn't have a workaround as well. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c

[Mesa-dev] [PATCH] radv: only enable PERFECT_ZPASS_COUNTS for precision occlusion queries

This unnecessary when the precision bit flag is not set, and this might hurt performance. The Vulkan explains that not setting VK_QUERY_CONTROL_PRECISE_BIT might be more efficient on some implementations. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 +++- src/amd/vulk

[Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland

Ported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index dd3189c67d..44caf0eeae 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH] nir: Check if u_vector_init() succeeds

Sorry about that. It doesn't hurt to check. Reviewed-by: Thomas Helland 2018-04-05 9:35 GMT+02:00 Topi Pohjolainen : > However, it only fails when running out of memory. Now, if we > are about to check that, we should be consistent and check > the allocation of the worklist as well. > > On the o

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On 5 April 2018 at 03:33, Ilia Mirkin wrote: > On Wed, Apr 4, 2018 at 12:12 PM, Emil Velikov > wrote: >> On 22 March 2018 at 00:39, Ilia Mirkin wrote: >>> Just one bit of feedback, for the rest I either agree or have no opinion: >>> >>> On Wed, Mar 21, 2018 at 8:28 PM, Emil Velikov >>> wrote:

[Mesa-dev] [PATCH 2/4] radv: do not try to skip draw calls when VBOs upload failed

This is unnecessary because we record an error which should be returned by vkEndCommandBuffer(), and the app shouldn't submit a command buffer when this happens. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 20 ++-- 1 file changed, 6 insertions(+), 14 del

[Mesa-dev] [PATCH 1/4] radv: fix prefetching compute shaders on CIK and older chips

Because the check was moved to radv_emit_prefetch_L2(). Fixes: 4ad7595f35 ("radv: rename radv_emit_prefetch() to radv_emit_prefetch_L2()") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 3/4] radv: rename radv_cmd_buffer_update_vertex_descriptors()

... to radv_flush_vertex_buffers(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 3ae3e33c3b..05610adee8 100644 --- a/src/amd/v

[Mesa-dev] [PATCH 4/4] radv: don't pass the pipeline to radv_flush_constants()

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 05610adee8..2e12c8f403 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/s

Re: [Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland

On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset wrote: > Ported from RadeonSI. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c > index dd3189c67d..44caf

[Mesa-dev] [Bug 105847] Profile GL3bc is not available on X11GraphicsDevice

https://bugs.freedesktop.org/show_bug.cgi?id=105847 --- Comment #2 from Aidan --- Thanks for drawing my attention to these discussions. However as much as I would like to be able to act on this without further assistance I have just spent several hours trying to find my way around the suggested .

Re: [Mesa-dev] [PATCH] radv: only enable PERFECT_ZPASS_COUNTS for precision occlusion queries

Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 5, 2018 at 10:27 AM, Samuel Pitoiset wrote: > This unnecessary when the precision bit flag is not set, and this > might hurt performance. The Vulkan explains that not setting > VK_QUERY_CONTROL_PRECISE_BIT might be more efficient on some > implementatio

Re: [Mesa-dev] [PATCH] radv: enable the Polaris small primitive filter control

Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 5, 2018 at 10:27 AM, Samuel Pitoiset wrote: > Enable it directly in the preamble, but do not enable line > on Polaris10/11/12 because there is a hw bug. > > There is possibly an issue when MSAA is off, but this doesn't > regress any CTS and AMDVLK doesn

Re: [Mesa-dev] [PATCH 2/2] i965: return the fourcc saved in __DRIimage

On 04/05/2018 02:51 AM, James Xiong wrote: From: "Xiong, James" The planar_format in __DRIimage contains the original fourcc used to create the image, if it's set, return the saved fourcc directly; Otherwise fall back to the old way. Also we should validate the input parameter "value" first a

[Mesa-dev] [Bug 105904] Needed to delete mesa shader cache after driver upgrade for 32 bit wine vulkan programs to work.

https://bugs.freedesktop.org/show_bug.cgi?id=105904 Bug ID: 105904 Summary: Needed to delete mesa shader cache after driver upgrade for 32 bit wine vulkan programs to work. Product: Mesa Version: git Hardware: x86-64 (AMD64

Re: [Mesa-dev] [PATCH 0/2] wrong fourcc was returned for imported images

Hi; On 04/05/2018 02:51 AM, James Xiong wrote: From: "Xiong, James" The importer creates an image out of the imported FOURCC_NV12 texture, the image's dri_format is set to R8(same as the first plane's format), when it queries the image's fourcc, mesa goes through intel_image_format table and r

Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

On Wednesday, 2018-04-04 10:45:26 -0700, Dylan Baker wrote: > Which should be relative instead of absolute. > > Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795 >("meson: extend install_megadrivers script to handle symmlinking") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10556

Re: [Mesa-dev] [PATCH] meson: Set .so version for xa like autotools does

On Wednesday, 2018-04-04 10:58:29 -0700, Dylan Baker wrote: > Fixes: 0ba909f0f111824223bc38563d1a6bc73e69c2cc >("meson: build gallium xa state tracker") > Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom > --- > src/gallium/targets/xa/meson.build | 4 +++- > 1 file changed, 3 ins

[Mesa-dev] [Bug 105901] Warn about mipmap-incomplete texture being used

https://bugs.freedesktop.org/show_bug.cgi?id=105901 --- Comment #2 from Brian Paul --- With a debug build of Mesa if you set the MESA_DEBUG env var to "incomplete_tex" you'll get a warning. This predates the GL_ARB_debug_output extension. It shouldn't be hard to go into the incomplete() functio

[Mesa-dev] [PATCH kmscube 1/4] drm-atomic: Fix indentation

From: Thierry Reding One of the error returns ended up being indented twice. Fix it. Signed-off-by: Thierry Reding --- drm-atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm-atomic.c b/drm-atomic.c index 82531d346d73..99ac33d6a686 100644 --- a/drm-atomic.c +++ b/d

[Mesa-dev] [PATCH kmscube 2/4] Pass struct drm to init_gbm()

From: Thierry Reding This helps cut down on the number of parameters that we need to pass around. Subsequent patches will also add more data to struct drm that init_gbm() needs to access, so passing in the struct make sure these will be available. Based on work by Lucas Stach . Signed-off-by: T

[Mesa-dev] [PATCH kmscube 4/4] drm-atomic: Implement user interruption

From: Thierry Reding In legacy mode, the user can interrupt kmscube by pressing the return key. Implement the same behaviour for atomic mode. Signed-off-by: Thierry Reding --- drm-atomic.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drm-atomic.c b/drm-atomic.

[Mesa-dev] [PATCH kmscube 3/4] Automatically select modifiers

From: Thierry Reding If available, use the formats/modifiers blob from a DRM/KMS device to automatically detect which modifiers to use. In the absence of the blob, leave it up to the implementation to choose an appropriate format. Based on work by Lucas Stach . Signed-off-by: Thierry Reding --

Re: [Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

Shouldn't this just be handled as in, e.g., https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/nouveau/drm/nouveau_drm_winsys.c#n97 i.e. return an error in the driver-specific loader? This create function should fail: https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/vir

Re: [Mesa-dev] [PATCH kmscube 3/4] Automatically select modifiers

On 5 April 2018 at 14:44, Thierry Reding wrote: > From: Thierry Reding > > If available, use the formats/modifiers blob from a DRM/KMS device to > automatically detect which modifiers to use. In the absence of the blob, > leave it up to the implementation to choose an appropriate format. > > Base

Re: [Mesa-dev] [PATCH kmscube 1/4] drm-atomic: Fix indentation

2018-04-05 15:44 GMT+02:00 Thierry Reding : > From: Thierry Reding > > One of the error returns ended up being indented twice. Fix it. > > Signed-off-by: Thierry Reding Reviewed-by: Christian Gmeiner > --- > drm-atomic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [Mesa-dev] [RFC PATCH] nir: extend nir_shader_compiler_options with is_scalar

I'm not sure if this should be a NIR compiler option or a PIPE_CAP. On Intel hardware, we have both and we handle it ourselves. On April 4, 2018 23:04:36 Christian Gmeiner wrote: As not every (upcoming) backend compiler is happy with nir_lower_xxx_to_scalar lowerings do them only if the ba

Re: [Mesa-dev] [PATCH kmscube 2/4] Pass struct drm to init_gbm()

2018-04-05 15:44 GMT+02:00 Thierry Reding : > From: Thierry Reding > > This helps cut down on the number of parameters that we need to pass > around. Subsequent patches will also add more data to struct drm that > init_gbm() needs to access, so passing in the struct make sure these > will be avail

Re: [Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

On 5 April 2018 at 14:45, Ilia Mirkin wrote: > Shouldn't this just be handled as in, e.g., > > https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/nouveau/drm/nouveau_drm_winsys.c#n97 > > i.e. return an error in the driver-specific loader? This create > function should fail: > > https:/

Re: [Mesa-dev] [RFC PATCH] nir: extend nir_shader_compiler_options with is_scalar

I'd vote for PIPE_CAP until there is any place inside nir passes were we'd want to do something differently. Since this is just a decision in mesa/st I think a cap makes sense.. On Thu, Apr 5, 2018 at 10:25 AM, Jason Ekstrand wrote: > I'm not sure if this should be a NIR compiler option or a PIP

Re: [Mesa-dev] [PATCH] meson: Set .so version for xa like autotools does

On 4 April 2018 at 18:58, Dylan Baker wrote: > Fixes: 0ba909f0f111824223bc38563d1a6bc73e69c2cc >("meson: build gallium xa state tracker") > Signed-off-by: Dylan Baker Reviewed-by: Emil Velikov Please land this as-is, and take a look at the other bits mentioned below. Thanks Emil Skim

Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

On 4 April 2018 at 18:45, Dylan Baker wrote: > Which should be relative instead of absolute. > > Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795 >("meson: extend install_megadrivers script to handle symmlinking") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105567 > Signed-off-

Re: [Mesa-dev] [RFC PATCH] nir: extend nir_shader_compiler_options with is_scalar

2018-04-05 16:35 GMT+02:00 Rob Clark : > I'd vote for PIPE_CAP until there is any place inside nir passes were > we'd want to do something differently. Since this is just a decision > in mesa/st I think a cap makes sense.. > Makes sense.. will go that route - thanks for your comments! -- greets

Re: [Mesa-dev] [PATCH 1/2] i965: init image's planar_format in intel_create_image_from_texture

Does this fix a bug? If so, what? On April 4, 2018 16:57:21 James Xiong wrote: From: "Xiong, James" When creating a image from a texture, initialize the image's planar_format with the texture's. Signed-off-by: Xiong, James --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed,

Re: [Mesa-dev] [PATCH 3/4] radv: rename radv_cmd_buffer_update_vertex_descriptors()

On Thu, Apr 5, 2018 at 11:42 AM, Samuel Pitoiset wrote: > ... to radv_flush_vertex_buffers(). > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vu

Re: [Mesa-dev] [PATCH 0/2] wrong fourcc was returned for imported images

On Thu, 5 Apr 2018 15:05:26 +0300 Tapani Pälli wrote: > Hi; > > On 04/05/2018 02:51 AM, James Xiong wrote: > > From: "Xiong, James" > > > > The importer creates an image out of the imported FOURCC_NV12 > > texture, the image's dri_format is set to R8(same as the first > > plane's format), when

Re: [Mesa-dev] [PATCH 2/2] i965: return the fourcc saved in __DRIimage

On Thu, 5 Apr 2018 14:30:02 +0300 Tapani Pälli wrote: > On 04/05/2018 02:51 AM, James Xiong wrote: > > From: "Xiong, James" > > > > The planar_format in __DRIimage contains the original fourcc > > used to create the image, if it's set, return the saved fourcc > > directly; Otherwise fall back t

Re: [Mesa-dev] [PATCH 1/2] i965: init image's planar_format in intel_create_image_from_texture

On Thu, 5 Apr 2018 08:24:27 -0700 Jason Ekstrand wrote: > Does this fix a bug? If so, what? Jason, yes. I am sorry for the confusion, please see my earlier reply to Tapani. > > On April 4, 2018 16:57:21 James Xiong wrote: > > > From: "Xiong, James" > > > > When creating a image from a textur

Re: [Mesa-dev] [PATCH 1/2] i965: init image's planar_format in intel_create_image_from_texture

On Thu, Apr 5, 2018 at 8:45 AM, James Xiong wrote: > On Thu, 5 Apr 2018 08:24:27 -0700 > Jason Ekstrand wrote: > > > Does this fix a bug? If so, what? > Jason, yes. I am sorry for the confusion, please see my earlier reply > to Tapani. > If it fixes a bug then the commit message should include

[Mesa-dev] [Bug 105906] [DRI3] Compiz segfaults in intel_destroy_image()

https://bugs.freedesktop.org/show_bug.cgi?id=105906 Lionel Landwerlin changed: What|Removed |Added Component|Drivers/DRI/i965|Drivers/X11 Assignee|inte

[Mesa-dev] [Bug 105906] [DRI3] Compiz segfaults in intel_destroy_image()

https://bugs.freedesktop.org/show_bug.cgi?id=105906 Lionel Landwerlin changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |intel-3d-bugs@lists.freedes

Re: [Mesa-dev] [PATCH 1/2] i965: init image's planar_format in intel_create_image_from_texture

On Thu, 5 Apr 2018 08:56:54 -0700 Jason Ekstrand wrote: > On Thu, Apr 5, 2018 at 8:45 AM, James Xiong > wrote: > > > On Thu, 5 Apr 2018 08:24:27 -0700 > > Jason Ekstrand wrote: > > > > > Does this fix a bug? If so, what? > > Jason, yes. I am sorry for the confusion, please see my earlier

Re: [Mesa-dev] [PATCH 2/2] i965: Add ARB_fragment_shader_interlock support.

Plamena Manolova writes: > Adds suppport for ARB_fragment_shader_interlock. We achieve > the interlock and fragment ordering by issuing a memory fence > via sendc. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt| 2 +- > docs/relnotes/18.1.0.html

Re: [Mesa-dev] [PATCH v3 018/104] nir: Add a deref path helper struct

Hello, > + if (count <= max_short_path_len) { > + /* If we're under max_short_path_len, just use the short path. */ > + path->path = head; > + goto done; > + } > + > + path->path = ralloc_array(mem_ctx, nir_deref_instr *, count + 1); > + head = tail = path->path + count; > +

Re: [Mesa-dev] [PATCH v3 018/104] nir: Add a deref path helper struct

On Thu, Apr 5, 2018 at 10:06 AM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hello, > > > + if (count <= max_short_path_len) { > > + /* If we're under max_short_path_len, just use the short path. */ > > + path->path = head; > > + goto done; > > + } > > + >

Re: [Mesa-dev] [PATCH 1/2] mesa: Add GL/GLSL plumbing for ARB_fragment_shader_interlock.

Plamena Manolova writes: > This extension provides new GLSL built-in functions > beginInvocationInterlockARB() and endInvocationInterlockARB() > that delimit a critical section of fragment shader code. For > pairs of shader invocations with "overlapping" coverage in a > given pixel, the OpenGL im

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675 when playing Natural Selection 2

https://bugs.freedesktop.org/show_bug.cgi?id=105846 --- Comment #8 from l...@protonmail.ch --- So I've tested it for a few hours now, and it does not seem to be happening anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

On 4 April 2018 at 22:50, Mark Janes wrote: > Leo Liu writes: > >> On 04/04/2018 12:40 PM, Mark Janes wrote: >>> Leo Liu writes: >>> On the CI family, firmware requires the destory command have to be the last command in the IB, moving feedback command after destroy is causing issu

Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

Quoting Emil Velikov (2018-04-05 07:58:22) > On 4 April 2018 at 18:45, Dylan Baker wrote: > > Which should be relative instead of absolute. > > > > Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795 > >("meson: extend install_megadrivers script to handle symmlinking") > > Bugzilla: https://bu

[Mesa-dev] [PATCH] intel/blorp: Assert that we don't re-layout a compressed surface

--- src/intel/blorp/blorp_blit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 0757db0..0f9ecb3 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -1395,6 +1395,9 @@ blorp_surf_convert_to_single

Re: [Mesa-dev] [PATCH] anv: Add WSI support for the I915_FORMAT_MOD_Y_TILED_CCS

ping? On Wed, Feb 21, 2018 at 11:17 AM, Jason Ekstrand wrote: > v2 (Jason Ekstrand): > - Return the correct enum values from anv_layout_to_fast_clear_type > > v3 (Jason Ekstrand): > - Always return ANV_FAST_CLEAR_NONE and leave doing the right thing for >the patch which adds a modifier whi

Re: [Mesa-dev] [PATCH 2/2] i965: return the fourcc saved in __DRIimage

On 05.04.2018 18:43, James Xiong wrote: On Thu, 5 Apr 2018 14:30:02 +0300 Tapani Pälli wrote: On 04/05/2018 02:51 AM, James Xiong wrote: From: "Xiong, James" The planar_format in __DRIimage contains the original fourcc used to create the image, if it's set, return the saved fourcc directl

Re: [Mesa-dev] [PATCH 2/2] i965: expose MESA_FORMAT_R8G8B8A8_SRGB visual

ping .. CC my favourite sRGB reviewer On 19.03.2018 13:41, Tapani Pälli wrote: Exposing the visual makes following dEQP tests pass on Android: dEQP-EGL.functional.wide_color.window__colorspace_srgb dEQP-EGL.functional.wide_color.pbuffer__colorspace_srgb Visual is exposed only w

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

Hi everyone, On 5 April 2018 at 01:58, Laura Ekstrand wrote: > I forgot to note that you have to choose space->ignore in the diff options > on cgit in order to see the easy-to-read git diff. > I really should have made this more obvious. The key blocker isn't about reviewing the patches, but havi

Re: [Mesa-dev] [PATCH 2/2] i965: return the fourcc saved in __DRIimage

On Thu, 5 Apr 2018 20:57:46 +0300 Tapani Pälli wrote: > On 05.04.2018 18:43, James Xiong wrote: > > On Thu, 5 Apr 2018 14:30:02 +0300 > > Tapani Pälli wrote: > > > >> On 04/05/2018 02:51 AM, James Xiong wrote: > >>> From: "Xiong, James" > >>> > >>> The planar_format in __DRIimage contains

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

Emil, Specifically, what infrastructure do you need? Gallium is already carrying Sphinx around as a dependency. Laura On Thu, Apr 5, 2018 at 11:07 AM, Emil Velikov wrote: > Hi everyone, > > On 5 April 2018 at 01:58, Laura Ekstrand wrote: > > I forgot to note that you have to choose space->ig

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

On 5 April 2018 at 19:10, Laura Ekstrand wrote: > Emil, > > Specifically, what infrastructure do you need? Gallium is already carrying > Sphinx around as a dependency. > The gallium docs are hosted on readthedocs.org. And I doubt we want to move the main mesa3d.org website there ;-) Currently mes

[Mesa-dev] [Bug 105567] meson/ninja: 1. mesa/vdpau incorrect symlinks in DESTDIR and 2. Ddri-drivers-path Dvdpau-libs-path overrides DESTDIR

https://bugs.freedesktop.org/show_bug.cgi?id=105567 --- Comment #7 from Dylan Baker --- 1) What is the argument you're providing to -Ddri-drivers-path? 2) It's only supposed to install vdpau symlinks for drivers you've built. When I run `meson build -Dgallium-drivers=nouveau -Ddri-drivers= -Dvul

[Mesa-dev] [PATCH 1/1] i965: return the fourcc saved in __DRIimage when possible

From: "Xiong, James" When creating a image from a texture, the image's dri_format is set to the first plane's format, and used to look up for the fourcc. e.g. for FOURCC_NV12 texture, the dri_format is set to __DRI_IMAGE_FORMAT_R8, we end up with a wrong entry in function intel_lookup_fourcc():

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

Emil Velikov writes: > On 4 April 2018 at 22:50, Mark Janes wrote: >> Leo Liu writes: >> >>> On 04/04/2018 12:40 PM, Mark Janes wrote: Leo Liu writes: > On the CI family, firmware requires the destory command have to be the > last command in the IB, moving feedback command af

[Mesa-dev] [PATCH v2] virgl: disable virgl when no 3D for virtio gpu.

If users are running mesa under old version of qemu or have turned off GL at runtime, virtio gpu driver actually doesn't work. Adds a detection here so mesa can fall back to software rendering. v2: - move detection from loader to virgl (Ilia, Emil) Signed-off-by: Lepton Wu --- src/gallium/wins

Re: [Mesa-dev] [PATCH 1/5] i965/tiled_memcpy: ytiled_to_linear a cache line at a time

Quoting Scott D Phillips (2018-04-03 21:05:41) > Similar to the transformation applied to linear_to_ytiled, also align > each readback from the ytiled source to a cacheline (i.e. transfer a > whole cacheline from the source before moving on to the next column). > This will allow us to utilize movnt

Re: [Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland

On 04/05/2018 01:18 PM, Bas Nieuwenhuizen wrote: On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset wrote: Ported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vul

Re: [Mesa-dev] [PATCH 3/4] radv: rename radv_cmd_buffer_update_vertex_descriptors()

On 04/05/2018 05:42 PM, Bas Nieuwenhuizen wrote: On Thu, Apr 5, 2018 at 11:42 AM, Samuel Pitoiset wrote: ... to radv_flush_vertex_buffers(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/am

Re: [Mesa-dev] [PATCH] anv: Add WSI support for the I915_FORMAT_MOD_Y_TILED_CCS

On 21 February 2018 at 19:17, Jason Ekstrand wrote: > v2 (Jason Ekstrand): > - Return the correct enum values from anv_layout_to_fast_clear_type > > v3 (Jason Ekstrand): > - Always return ANV_FAST_CLEAR_NONE and leave doing the right thing for >the patch which adds a modifier which supports

[Mesa-dev] [AppVeyor] mesa master #7383 failed

Build mesa 7383 failed Commit be4250aa88 by Marek Olšák on 4/2/2018 2:49 AM: radeonsi: remove more R600 references\n\nAcked-by: Timothy Arceri Configure your notification preferences ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH v3 019/104] nir: Support deref instructions in lower_var_copies

Hello, > +static nir_deref_instr * > +build_deref_to_next_wildcard(nir_builder *b, > + nir_deref_instr *parent, > + nir_deref_instr ***deref_arr) > +{ > + for (; **deref_arr; (*deref_arr)++) { > + if ((**deref_arr)->deref_type == nir_d

Re: [Mesa-dev] [PATCH 2/5] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

Quoting Scott D Phillips (2018-04-03 21:05:42) > The reference for MOVNTDQA says: > > For WC memory type, the nontemporal hint may be implemented by > loading a temporary internal buffer with the equivalent of an > aligned cache line without filling this data to the cache. > [...]

Re: [Mesa-dev] [PATCH 2/5] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

Quoting Chris Wilson (2018-04-05 20:54:54) > Quoting Scott D Phillips (2018-04-03 21:05:42) > > The reference for MOVNTDQA says: > > > > For WC memory type, the nontemporal hint may be implemented by > > loading a temporary internal buffer with the equivalent of an > > aligned cache li

[Mesa-dev] [AppVeyor] mesa master #7384 completed

Build mesa 7384 completed Commit c7dd59b06d by Marek Olšák on 4/5/2018 7:53 PM: radeonsi: fix a crash if ps_shader.cso is NULL in si_get_total_colormask Configure your notification preferences ___ mesa-dev

Re: [Mesa-dev] [PATCH v4 3/5] i965/miptree: Use cpu tiling/detiling when mapping

Quoting Scott D Phillips (2018-04-03 21:05:43) > Rename the (un)map_gtt functions to (un)map_map (map by > returning a map) and add new functions (un)map_tiled_memcpy that > return a shadow buffer populated with the intel_tiled_memcpy > functions. > > Tiling/detiling with the cpu will be the only

Re: [Mesa-dev] [PATCH 4/5] i965/miptree: Map with movntdqa for linear buffers only

Quoting Scott D Phillips (2018-04-03 21:05:44) > Removes a place where gtt mapping is used. > > Reviewed-by: Nanley Chery > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree

Re: [Mesa-dev] [PATCH v2 5/5] i965/miptree: Don't gtt map from map_depthstencil

Quoting Scott D Phillips (2018-04-03 21:05:45) > Instead of gtt mapping, call out to other map functions (map_map > or map_tiled_memcpy) for the depth surface. Removes a place where > gtt mapping is used. > > v2: add level, slice to debug print (Nanley) > --- > @@ -3549,16 +3555,21 @@ intel_miptre

Re: [Mesa-dev] [PATCH v3] intel/tools: new intel_sanitize_gpu tool

Quoting Scott D Phillips (2018-02-08 17:11:25) > diff --git a/src/intel/tools/intel_sanitize_gpu.in > b/src/intel/tools/intel_sanitize_gpu.in > new file mode 100755 > index 000..3dac954c408 > --- /dev/null > +++ b/src/intel/tools/intel_sanitize_gpu.in > @@ -0,0 +1,4 @@ > +#!/bin/bash > +#

Re: [Mesa-dev] [PATCH v3 020/104] nir: Support deref instructions in split_var_copies

> @@ -268,8 +288,30 @@ split_var_copies_impl(nir_function_impl *impl) > state.dead_ctx = ralloc_context(NULL); > state.progress = false; > > + nir_builder b; > + nir_builder_init(&b, impl); > + > nir_foreach_block(block, impl) { >split_var_copies_block(block, &state); > +

Re: [Mesa-dev] [PATCH 02/17] ac/surface: don't set the display flag for obviously unsupported cases

On Thu, Apr 5, 2018 at 3:09 AM, Michel Dänzer wrote: > On 2018-04-04 07:35 PM, Marek Olšák wrote: > > On Wed, Apr 4, 2018 at 9:01 AM, Michel Dänzer > wrote: > >> On 2018-04-04 02:57 PM, Marek Olšák wrote: > >>> On Wed, Apr 4, 2018, 6:18 AM Michel Dänzer >>> > wrote: >

[Mesa-dev] [PATCH 1/1] radeonsi: Reorder checks in si_check_render_feedback

si_get_total_colormask accesses NULL pointer on compute shaders Fixes crashes on clover Fixes: 0669dca9c00261849cee14d69fdea0a5e323c7f7 ("radeonsi: skip DCC render feedback checking if color writes are disabled") CC: Marek Olšák Signed-off-by: Jan Vesely --- src/gallium/drivers/radeonsi/si_blit

Re: [Mesa-dev] [PATCH v3 019/104] nir: Support deref instructions in lower_var_copies

On Thu, Apr 5, 2018 at 12:55 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hello, > > > +static nir_deref_instr * > > +build_deref_to_next_wildcard(nir_builder *b, > > + nir_deref_instr *parent, > > + nir_deref_instr

Re: [Mesa-dev] [PATCH 17/17] winsys/amdgpu: always set AMDGPU_IB_FLAG_TC_WB_NOT_INVALIDATE

On Thu, Apr 5, 2018 at 4:22 AM, Samuel Pitoiset wrote: > Patches 16-17 are: > > Reviewed-by: Samuel Pitoiset > > Those two are quite interesting. I will probably update my kernel and > experiment something. Patch 16 breaks things and needs more changes. Marek _

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Reorder checks in si_check_render_feedback

Even though I've already fixed the crash in master, I'd like to have this patch in master too. Reviewed-by: Marek Olšák Marek On Thu, Apr 5, 2018 at 4:49 PM, Jan Vesely wrote: > si_get_total_colormask accesses NULL pointer on compute shaders > Fixes crashes on clover > Fixes: 0669dca9c0026184

[Mesa-dev] [Bug 105567] meson/ninja: 1. mesa/vdpau incorrect symlinks in DESTDIR and 2. Ddri-drivers-path Dvdpau-libs-path overrides DESTDIR

https://bugs.freedesktop.org/show_bug.cgi?id=105567 --- Comment #8 from charlie --- 1) "build.environment" (file) export LIBDIRSUFFIX='64' export XBUILD="/usr" EOF -Ddri-drivers-path=${XBUILD}/lib${LIBDIRSUFFIX}/xorg/modules/dri 2) I don't believe there is a typo in my "mesa.cfg2

Re: [Mesa-dev] [PATCH 02/17] ac/surface: don't set the display flag for obviously unsupported cases

On Thu, Apr 5, 2018 at 4:47 PM, Marek Olšák wrote: > On Thu, Apr 5, 2018 at 3:09 AM, Michel Dänzer wrote: > >> On 2018-04-04 07:35 PM, Marek Olšák wrote: >> > On Wed, Apr 4, 2018 at 9:01 AM, Michel Dänzer >> wrote: >> >> On 2018-04-04 02:57 PM, Marek Olšák wrote: >> >>> On Wed, Apr 4, 2018, 6:1

Re: [Mesa-dev] [PATCH v3 020/104] nir: Support deref instructions in split_var_copies

On Thu, Apr 5, 2018 at 1:31 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > > @@ -268,8 +288,30 @@ split_var_copies_impl(nir_function_impl *impl) > > state.dead_ctx = ralloc_context(NULL); > > state.progress = false; > > > > + nir_builder b; > > + nir_builder_ini

  1   2   >