[Mesa-dev] [PATCH 2/4] radv: do not try to skip draw calls when VBOs upload failed

[Samuel Pitoiset]

This is unnecessary because we record an error which should
be returned by vkEndCommandBuffer(), and the app shouldn't
submit a command buffer when this happens.

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index a6d85e1b35..3ae3e33c3b 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1475,7 +1475,7 @@ radv_flush_constants(struct radv_cmd_buffer *cmd_buffer,
        assert(cmd_buffer->cs->cdw <= cdw_max);
 }
 
-static bool
+static void
 radv_cmd_buffer_update_vertex_descriptors(struct radv_cmd_buffer *cmd_buffer, 
bool pipeline_is_dirty)
 {
        if ((pipeline_is_dirty ||
@@ -1492,7 +1492,7 @@ radv_cmd_buffer_update_vertex_descriptors(struct 
radv_cmd_buffer *cmd_buffer, bo
                /* allocate some descriptor state for vertex buffers */
                if (!radv_cmd_buffer_upload_alloc(cmd_buffer, count * 16, 256,
                                                  &vb_offset, &vb_ptr))
-                       return false;
+                       return;
 
                for (i = 0; i < count; i++) {
                        uint32_t *desc = &((uint32_t *)vb_ptr)[i * 4];
@@ -1525,21 +1525,15 @@ radv_cmd_buffer_update_vertex_descriptors(struct 
radv_cmd_buffer *cmd_buffer, bo
                cmd_buffer->state.prefetch_L2_mask |= 
RADV_PREFETCH_VBO_DESCRIPTORS;
        }
        cmd_buffer->state.dirty &= ~RADV_CMD_DIRTY_VERTEX_BUFFER;
-
-       return true;
 }
 
-static bool
+static void
 radv_upload_graphics_shader_descriptors(struct radv_cmd_buffer *cmd_buffer, 
bool pipeline_is_dirty)
 {
-       if (!radv_cmd_buffer_update_vertex_descriptors(cmd_buffer, 
pipeline_is_dirty))
-               return false;
-
+       radv_cmd_buffer_update_vertex_descriptors(cmd_buffer, 
pipeline_is_dirty);
        radv_flush_descriptors(cmd_buffer, VK_SHADER_STAGE_ALL_GRAPHICS);
        radv_flush_constants(cmd_buffer, cmd_buffer->state.pipeline,
                             VK_SHADER_STAGE_ALL_GRAPHICS);
-
-       return true;
 }
 
 static void
@@ -3066,8 +3060,7 @@ radv_draw(struct radv_cmd_buffer *cmd_buffer,
                si_emit_cache_flush(cmd_buffer);
                /* <-- CUs are idle here --> */
 
-               if (!radv_upload_graphics_shader_descriptors(cmd_buffer, 
pipeline_is_dirty))
-                       return;
+               radv_upload_graphics_shader_descriptors(cmd_buffer, 
pipeline_is_dirty);
 
                radv_emit_draw_packets(cmd_buffer, info);
                /* <-- CUs are busy here --> */
@@ -3094,8 +3087,7 @@ radv_draw(struct radv_cmd_buffer *cmd_buffer,
                                              cmd_buffer->state.pipeline, true);
                }
 
-               if (!radv_upload_graphics_shader_descriptors(cmd_buffer, 
pipeline_is_dirty))
-                       return;
+               radv_upload_graphics_shader_descriptors(cmd_buffer, 
pipeline_is_dirty);
 
                radv_emit_all_graphics_states(cmd_buffer, info);
                radv_emit_draw_packets(cmd_buffer, info);
-- 
2.16.3

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev