On Thu, Apr 5, 2018 at 8:45 AM, James Xiong <james.xi...@intel.com> wrote:
> On Thu, 5 Apr 2018 08:24:27 -0700
> Jason Ekstrand <ja...@jlekstrand.net> wrote:
>
> > Does this fix a bug? If so, what?
> Jason, yes. I am sorry for the confusion, please see my earlier reply
> to Tapani.
>
If it fixes a bug then the commit message should include a description of
the bug fixed. If the bug is a regression, it should have a "Fixes: SHA1"
tag indicating where the regression originated and if it is a bug that has
been around for a very long time, it should have a "Cc:
mesa-sta...@lists.freedesktop.org" tag. If the bug is filed in bugzilla,
it should have a "Bugzilla: <link>" tag.
--Jason
> >
> > On April 4, 2018 16:57:21 James Xiong <james.xi...@intel.com> wrote:
> >
> > > From: "Xiong, James" <james.xi...@intel.com>
> > >
> > > When creating a image from a texture, initialize the image's
> > > planar_format with the texture's.
> > >
> > > Signed-off-by: Xiong, James <james.xi...@intel.com>
> > > ---
> > > src/mesa/drivers/dri/i965/intel_screen.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
> > > b/src/mesa/drivers/dri/i965/intel_screen.c
> > > index dcb98da..7df8bc4 100644
> > > --- a/src/mesa/drivers/dri/i965/intel_screen.c
> > > +++ b/src/mesa/drivers/dri/i965/intel_screen.c
> > > @@ -578,6 +578,7 @@ intel_create_image_from_texture(__DRIcontext
> > > *context, int target,
> > > intel_setup_image_from_mipmap_tree(brw, image, iobj->mt, level,
> > > zoffset); image->dri_format =
> > > driGLFormatToImageFormat(image->format); image->has_depthstencil =
> > > iobj->mt->stencil_mt? true : false;
> > > + image->planar_format = iobj->planar_format;
> > > if (image->dri_format == MESA_FORMAT_NONE) {
> > > *error = __DRI_IMAGE_ERROR_BAD_PARAMETER;
> > > free(image);
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> >
> >
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
