[Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

2017-01-11 Thread Randy Xu
On Android platform, the EGL configuration query (eglGetConfigs) will check the DRI backend. Add R8G8B8A8 and R8G8B8X8 to meet the native app test requirement (like gl2_basic etc.). Reorder the list and move the B5G6R5 to the tail, it can solve two dEQP failures on Android platform, they are dEQP-

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: > On 10/01/17 06:53 PM, Nayan Deshmukh wrote: >> On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: >>> On 06/01/17 05:50 AM, Andy Furniss wrote: Christian König wrote: > Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >> dri3

Re: [Mesa-dev] [PATCH 06/22] i965/fs: double-precision execution does not use 2 channels per DF in IVB/VLV

2017-01-11 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-10 at 14:01 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > On Mon, 2017-01-09 at 16:18 -0800, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > From: Iago Toral Quiroga > > > > > > > > It seems to use 1 channel por DF, just l

Re: [Mesa-dev] i965: No relocation support for GL

2017-01-11 Thread Martin Peres
On 10/01/17 23:23, Chris Wilson wrote: Not much has changed in the couple of years since last posting, just a lot of rebasing. Still the major open question is how much locking do individual contexts require amongst a shared set - can we rely of the upper layer providing sufficient serialisation

Re: [Mesa-dev] [PATCH 04/22] i965/fs: add lowering step to duplicate sources with stride 0.

2017-01-11 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-10 at 22:07 -0800, Francisco Jerez wrote: > Hi Matt, > > Matt Turner writes: > > > On Sun, Jan 8, 2017 at 10:53 PM, Matt Turner > > wrote: > > > On 01/05, Samuel Iglesias Gonsálvez wrote: > > > > > > > > From: "Juan A. Suarez Romero" > > > > > > > > When dealing with DF unifo

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Michel Dänzer
On 11/01/17 05:13 PM, Nayan Deshmukh wrote: > On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: >> On 10/01/17 06:53 PM, Nayan Deshmukh wrote: >>> On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: On 06/01/17 05:50 AM, Andy Furniss wrote: > Christian König wrote: >> Am 04.01

Re: [Mesa-dev] [PATCH 05/22] i965/fs: consider execsize can be duplicated in lower_simd_with

2017-01-11 Thread Juan A. Suarez Romero
On Tue, 2017-01-10 at 14:31 -0800, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > On Mon, 2017-01-09 at 15:41 -0800, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > From: "Juan A. Suarez Romero" > > > > > > > > In IVB/VLV, for instructions dealing

Re: [Mesa-dev] [PATCH v2 1/3] gallium: add renderonly library

2017-01-11 Thread Alexandre Courbot
On 12/24/2016 07:04 AM, Christian Gmeiner wrote: > This a very lightweight library to add basic support for renderonly > GPUs. A kms gallium driver must specify how a renderonly_scanout > objects gets created. Also it must provide file handles to the used > kms device and the used gpu device. > >

Re: [Mesa-dev] [PATCH 01/10] radeonsi: fix the offset in cube map coordinate conversion

2017-01-11 Thread Nicolai Hähnle
On 10.01.2017 16:12, Nicolai Hähnle wrote: From: Nicolai Hähnle The correct offset is really 0.5, both intuitively and according to the formulas in Section 8.13 (Cube Map Texture Selection) of the OpenGL spec. This mistake probably never hurt because wrap-around is constrained to individual cub

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 Karol Herbst changed: What|Removed |Added CC||karolher...@gmail.com -- You are receivi

Re: [Mesa-dev] i965: No relocation support for GL

2017-01-11 Thread Chris Wilson
On Wed, Jan 11, 2017 at 10:16:06AM +0200, Martin Peres wrote: > On 10/01/17 23:23, Chris Wilson wrote: > >Not much has changed in the couple of years since last posting, just a > >lot of rebasing. > > > >Still the major open question is how much locking do individual contexts > >require amongst a s

Re: [Mesa-dev] [PATCH 04/11] i965/vec4/nir: vec4 also need to remap vs attributes

2017-01-11 Thread Juan A. Suarez Romero
On Tue, 2017-01-10 at 20:52 -0800, Matt Turner wrote: > On 01/09, Juan A. Suarez Romero wrote: > > From: Alejandro Piñeiro > > > > Doubles need extra space, so we would need to do a remapping for vec4 > > too in order to take that into account. We reuse the already > > existing remap_vs_attrs, bu

Re: [Mesa-dev] [PATCH 03/11] i965/vec4: use attribute slots for first non payload GRF

2017-01-11 Thread Alejandro Piñeiro
On 10/01/17 15:52, Jordan Justen wrote: > On 2017-01-09 09:10:01, Juan A. Suarez Romero wrote: >> From: Alejandro Piñeiro >> >> --- >> src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp >> b/sr

Re: [Mesa-dev] [PATCH 1/3] i965: Fix comment to include 3d textures

2017-01-11 Thread Alejandro Piñeiro
The three patches: Reviewed-by: Alejandro Piñeiro On 10/01/17 21:56, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c > b/src/

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Grazvydas Ignotas
On Tue, Jan 10, 2017 at 7:33 PM, Samuel Pitoiset wrote: > diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > b/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > index 3e0f7c4f76..3cd87f2f66 100644 > --- a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > +++ b/src/gallium/

Re: [Mesa-dev] [PATCH 3/3] anv: Support loader interface version 2

2017-01-11 Thread Emil Velikov
On 11 January 2017 at 03:59, Jason Ekstrand wrote: > On Tue, Jan 10, 2017 at 7:17 PM, Chad Versace > wrote: >> >> Loader interface v2 differs from v1 in that the first ICD entrypoint >> called by the loader is vk_icdNegotiateLoaderICDInterfaceVersion(), not >> vk_icdGetInstanceProcAddr(). The ICD

Re: [Mesa-dev] [PATCH 02/12] st/dri: remove trailing whitespace

2017-01-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 10, 2017 at 1:52 AM, Mauro Rossi wrote: > --- > src/gallium/state_trackers/dri/dri_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/dri/dri_screen.c > b/src/gallium/state_trackers/dri/dri_sc

Re: [Mesa-dev] [PATCH v4 03/11] gallium: add common pipe_screen reference counting functions

2017-01-11 Thread Marek Olšák
On Mon, Jan 9, 2017 at 7:38 PM, Emil Velikov wrote: > On 28 July 2016 at 13:45, Marek Olšák wrote: >> On Fri, Jul 22, 2016 at 6:22 PM, Rob Herring wrote: >>> In order to prevent multiple pipe_screens being created in the same >>> process, lookup of the DRM FD and reference counting of the pipe_s

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Andy Furniss
Michel Dänzer wrote: On 11/01/17 05:13 PM, Nayan Deshmukh wrote: On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: On 10/01/17 06:53 PM, Nayan Deshmukh wrote: On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: On 06/01/17 05:50 AM, Andy Furniss wrote: Christian König wrote: Am 04.

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Marek Olšák
We don't have to use lp_build_tgsi_soa_context::immediates at all just as we don't use lp_build_tgsi_soa_context::temps. Marek On Wed, Jan 11, 2017 at 11:51 AM, Grazvydas Ignotas wrote: > On Tue, Jan 10, 2017 at 7:33 PM, Samuel Pitoiset > wrote: >> diff --git a/src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH] radeonsi: num_records is in units of stride for swizzled buffers even on VI

2017-01-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 10, 2017 at 3:58 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The old setting didn't hurt, but this is cleaner. > --- > src/gallium/drivers/radeonsi/si_shader.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: > I'll be honest, I'm not a fan... Given that D3D10 has one defined behavior, > D3D9 has another, and GL doesn't specify, I don't really think we should be > making a global change to all drivers to do the D3D9 behavior just to fix > one app.

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 12:47 PM, Marek Olšák wrote: We don't have to use lp_build_tgsi_soa_context::immediates at all just as we don't use lp_build_tgsi_soa_context::temps. You want to always allocate the array of immediates dynamically? And use ctx->imms/ctx->imms_count like what we currently do for

Re: [Mesa-dev] [PATCH] spirv: fix typo in warning message

2017-01-11 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Mon, 2017-01-09 at 16:09 +0100, Iago Toral Quiroga wrote: > --- >  src/compiler/spirv/spirv_to_nir.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c > index

Re: [Mesa-dev] [PATCH 24/25] mesa/glsl: set and get cs layouts to and from shader_info

2017-01-11 Thread Lionel Landwerlin
On 09/01/17 05:13, Timothy Arceri wrote: --- src/compiler/glsl/linker.cpp | 35 +++ src/mesa/main/mtypes.h | 10 -- src/mesa/main/shaderapi.c| 6 ++ src/mesa/main/shaderobj.c| 2 -- 4 files changed, 17 insertions(+), 36 deletions(-

Re: [Mesa-dev] [ANNOUNCE] mesa 12.0.5

2017-01-11 Thread Emil Velikov
On 6 December 2016 at 14:55, Marek Olšák wrote: > Hi, > > I'd like to announce that this release doesn't fix the worst GPU > hangs/freezes it has. I'm talking about all Gallium drivers here. > There was a bug recently discovered in shared code that leads to > random GPU hangs with radeonsi, but al

Re: [Mesa-dev] [PATCH 01/25] mesa/glsl: move ProgramResourceList to gl_shader_program_data

2017-01-11 Thread Lionel Landwerlin
Looks fine : Reviewed-by: Lionel Landwerlin On 09/01/17 05:13, Timothy Arceri wrote: We also move NumProgramResourceList at the same time. GLES does interface validation on SSO at runtime so we need to move this to be able to switch to storing gl_program pointers in CurrentProgram. --- src/

Re: [Mesa-dev] Mesa 13.1.0 release plan

2017-01-11 Thread Emil Velikov
On 30 November 2016 at 20:23, Emil Velikov wrote: > Hi all, > > With holidays not far off, it might be a nice idea to consider the > branchpoint/release schedule for the next release. > > I will be having limited internet access during 20 Dec - 7 Jan, thus > the I'm leaning towards following: > J

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
Hi Andy, Can you try this patch? This should help with the tearing. diff --git a/src/gallium/state_trackers/vdpau/output.c b/src/gallium/state_trackers/vdpau/output.c index 48e3133..98a8011 100644 --- a/src/gallium/state_trackers/vdpau/output.c +++ b/src/gallium/state_trackers/vdpau/output.c @@ -

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 1:45 PM, Samuel Pitoiset wrote: > > > On 01/11/2017 12:47 PM, Marek Olšák wrote: >> >> We don't have to use lp_build_tgsi_soa_context::immediates at all just >> as we don't use lp_build_tgsi_soa_context::temps. > > > You want to always allocate the array of immediates dynam

Re: [Mesa-dev] Clean ups (hopefully last time)

2017-01-11 Thread Edward O'Callaghan
I think if there is other serious objections, this series is Acked-by: Edward O'Callaghan On 01/09/2017 04:13 PM, Timothy Arceri wrote: > Sorry to keep spamming the list with these but a bunch have now landed > and theire was a bug fix and a bunch of rebasing required in the remaining > patches.

Re: [Mesa-dev] [PATCH v3] gallium/tgsi: fix overflow in parse property

2017-01-11 Thread Marek Olšák
Pushed, thanks. Marek On Tue, Jan 10, 2017 at 9:56 AM, Li Qiang wrote: > In parse_identifier, it doesn't stop copying '*pcur' > untill encounter the NULL. As the 'ret' has a > fixed-size buffer, if the '*pcur' has a long string, > there will be a buffer overflow. This patch avoid this. > > Signe

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 03:16 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 1:45 PM, Samuel Pitoiset wrote: On 01/11/2017 12:47 PM, Marek Olšák wrote: We don't have to use lp_build_tgsi_soa_context::immediates at all just as we don't use lp_build_tgsi_soa_context::temps. You want to always allo

Re: [Mesa-dev] [PATCH 03/25] mesa: change init subroutine defaults helper to work per gl_program

2017-01-11 Thread Lionel Landwerlin
Thanks, Reviewed-by: Lionel Landwerlin On 09/01/17 05:13, Timothy Arceri wrote: A later patch will result in SSO programs calling this helper per gl_program rather than per gl_shader_program. --- src/mesa/main/pipelineobj.c | 10 -- src/mesa/main/shaderapi.c | 30 ++---

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 3:47 PM, Samuel Pitoiset wrote: > > > On 01/11/2017 03:16 PM, Marek Olšák wrote: >> >> On Wed, Jan 11, 2017 at 1:45 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 01/11/2017 12:47 PM, Marek Olšák wrote: We don't have to use lp_build_tgsi_soa_context::immed

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Nicolai Hähnle
On 11.01.2017 13:17, Marek Olšák wrote: On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: I'll be honest, I'm not a fan... Given that D3D10 has one defined behavior, D3D9 has another, and GL doesn't specify, I don't really think we should be making a global change to all drivers to do the

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Cheng, Tony
Vblank interrupt fires as soon as the last line of active region is scanned out. VSync interrupt fires at the vsync. VUpdate interrupt fires HW is ready to scan out a new frame, this include latch on double buffer registers, starting memory request etc. We use VUpdate to accommodate free sync, as

Re: [Mesa-dev] [PATCH 05/25] mesa/meta: rewrite _mesa_shader_program_use() and _mesa_program_use()

2017-01-11 Thread Lionel Landwerlin
Looks fine, with a small suggestion for meta.c : Reviewed-by: Lionel Landwerlin On 09/01/17 05:13, Timothy Arceri wrote: These are rewritten to do what the function name suggests, that is _mesa_shader_program_use() sets the use of all stage and _mesa_program_use() sets the use of a single stag

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: > On 11.01.2017 13:17, Marek Olšák wrote: >> >> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >> wrote: >>> >>> I'll be honest, I'm not a fan... Given that D3D10 has one defined >>> behavior, >>> D3D9 has another, and GL doesn't specify, I

Re: [Mesa-dev] [PATCH v2] dri: allow 16bit R/GR images to be exported via drm buffers

2017-01-11 Thread Ben Widawsky
On 17-01-05 16:58:56, Rainer Hochecker wrote: From: Rainer Hochecker This allows eglCreateImageKHR to access P010 surfaces created by vaapi Signed-off-by: Rainer Hochecker Acked-by: Ben Widawky --- include/GL/internal/dri_interface.h | 4 src/egl/drivers/dri2/egl_dri2.c

Re: [Mesa-dev] [PATCH] nouveau: take extra push space into account for pushbuf_space calls

2017-01-11 Thread Emil Velikov
On 11 January 2017 at 03:10, Ilia Mirkin wrote: > Ever since a long time ago when I messed around with fences, I ensure > that after a PUSH_SPACE call there is enough space to write a fence out > into the pushbuf. > > However the PUSH_SPACE macro is not all-knowing, and so sometimes we > have to i

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Jan 11, 2017 7:34 AM, "Erik Faye-Lund" wrote: On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: > On 11.01.2017 13:17, Marek Olšák wrote: >> >> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >> wrote: >>> >>> I'll be honest, I'm not a fan... Given that D3D10 has one defined >>> behavio

Re: [Mesa-dev] [PATCH] nouveau: take extra push space into account for pushbuf_space calls

2017-01-11 Thread Ilia Mirkin
On Wed, Jan 11, 2017 at 10:47 AM, Emil Velikov wrote: > On 11 January 2017 at 03:10, Ilia Mirkin wrote: >> Ever since a long time ago when I messed around with fences, I ensure >> that after a PUSH_SPACE call there is enough space to write a fence out >> into the pushbuf. >> >> However the PUSH_S

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Andy Furniss
Nayan Deshmukh wrote: Hi Andy, Can you try this patch? This should help with the tearing. Patch seems to be good - I get page flipping again so DC, modesetting and "normal" setup all work OK. diff --git a/src/gallium/state_trackers/vdpau/output.c b/src/gallium/state_trackers/vdpau/output.c

Re: [Mesa-dev] [PATCH] egl/dri2: add image_loader_extension back into loader extensions for wayland

2017-01-11 Thread Emil Velikov
On 10 January 2017 at 21:21, Derek Foreman wrote: > before commit f871946594129500a67c05a6d9fe99db54b4bb64 > image_loader_extension was always present in dri2_dpy->extensions, > after that commit it is only present for render nodes. > > Its removal broke partial render based on buffer age on (at l

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2017-01-11 Thread Emil Velikov
On 24 November 2016 at 15:47, Derek Foreman wrote: > On 24/11/16 08:53 AM, Emil Velikov wrote: >> >> On 24 November 2016 at 06:22, Boyan Ding wrote: >>> >>> 2016-11-24 13:29 GMT+08:00 Derek Foreman : On 23/11/16 07:18 PM, Boyan Ding wrote: > > > 2016-11-24 7:01 GMT+08:00 Der

Re: [Mesa-dev] [PATCH v2] gbm/drm: Pick the oldest available buffer in get_back_bo

2017-01-11 Thread Emil Velikov
On 25 November 2016 at 16:57, Emil Velikov wrote: > On 23 November 2016 at 22:40, Derek Foreman wrote: >> Applications may query the back buffer age to efficiently perform >> partial updates. Generally the application will keep a fixed length >> damage history, and use this to calculate what need

Re: [Mesa-dev] [PATCH v2] gbm/drm: Pick the oldest available buffer in get_back_bo

2017-01-11 Thread Daniel Stone
Hey Emil, On 11 January 2017 at 16:24, Emil Velikov wrote: > On 25 November 2016 at 16:57, Emil Velikov wrote: >> Don't we want to apply this in the platform_wayland as well ? >> One thing that comes to mind is that wayland does purge the >> old/unlocked buffers via update_buffers() thus the sce

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: >> On 11.01.2017 13:17, Marek Olšák wrote: >>> >>> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >>> wrote: I'll be honest, I'm not a fan... Given that D3D10 has one define

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 5:32 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: >>> On 11.01.2017 13:17, Marek Olšák wrote: On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: > > I'

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 9:25 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, >> >> Can you try this patch? This should help with the tearing. > > > Patch seems to be good - I get page flipping again so DC, modesetting > and "normal" setup all work OK. > Great. Thanks for the help M

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a portion of the surface v3: remove redundant variables, fix wrapping, rename vari

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2017-01-11 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c| 50 - src/gallium/state_trackers/

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-11 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize v2: add PIPE_BIND_SCANOUT to output buffers as they will be send to X server directly (Michel) Suggested-by: Christian König Tested-by: Andy Furniss Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [PATCH 11/11] anv: Enable tessellation shaders.

2017-01-11 Thread Eero Tamminen
Hi, On 09.01.2017 07:26, Kenneth Graunke wrote: Signed-off-by: Kenneth Graunke --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I'm not clear whether we want to do this yet. On Skylake, the status is: 99.3% of the CTS passing, Sascha demos work. Teste

Re: [Mesa-dev] Clean ups (hopefully last time)

2017-01-11 Thread Lionel Landwerlin
Patches 10->21 are : Reviewed-by: Lionel Landwerlin On 09/01/17 05:13, Timothy Arceri wrote: Sorry to keep spamming the list with these but a bunch have now landed and theire was a bug fix and a bunch of rebasing required in the remaining patches. Thanks to all that have help review the serie

[Mesa-dev] [PATCH v2] radeonsi: allocate the array of immediates dynamically

2017-01-11 Thread Samuel Pitoiset
Currently, we can store up to 256 immediates in a static array, but this is not always enough. Instead, allocate a dynamic array like what we currently do for temps. This fixes a segfault with dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 No regressions found with full piglit run

Re: [Mesa-dev] [PATCH 3/3] anv: Support loader interface version 2

2017-01-11 Thread Chad Versace
On Tue 10 Jan 2017, Jason Ekstrand wrote: > On Tue, Jan 10, 2017 at 7:17 PM, Chad Versace > wrote: > > Loader interface v2 differs from v1 in that the first ICD entrypoint > called by the loader is vk_icdNegotiateLoaderICDInterfaceVersion(), not > vk_icdGetInstanceProcAddr(). The ICD

[Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Samuel Pitoiset
Only VI can do 32-bit denormals at full rate while previous generations can do it only for 64-bit and 16-bit. This fixes some dEQP tests with the highp type qualifier. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99343 Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH 3/3] anv: Support loader interface version 2

2017-01-11 Thread Chad Versace
On Wed 11 Jan 2017, Emil Velikov wrote: > On 11 January 2017 at 03:59, Jason Ekstrand wrote: > > On Tue, Jan 10, 2017 at 7:17 PM, Chad Versace > > wrote: > >> > >> Loader interface v2 differs from v1 in that the first ICD entrypoint > >> called by the loader is vk_icdNegotiateLoaderICDInterfaceVe

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 05:32 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: On 11.01.2017 13:17, Marek Olšák wrote: On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: I'll be honest, I'm not a fan... Given

Re: [Mesa-dev] [PATCH 3/3] anv: Support loader interface version 2

2017-01-11 Thread Jason Ekstrand
On Jan 11, 2017 9:30 AM, "Chad Versace" wrote: On Wed 11 Jan 2017, Emil Velikov wrote: > On 11 January 2017 at 03:59, Jason Ekstrand wrote: > > On Tue, Jan 10, 2017 at 7:17 PM, Chad Versace > > wrote: > >> > >> Loader interface v2 differs from v1 in that the first ICD entrypoint > >> called by

Re: [Mesa-dev] [PATCH 3/7] gallium: add FBFETCH opcode to retrieve the current sample value

2017-01-11 Thread Ilia Mirkin
On Fri, Jan 6, 2017 at 6:05 AM, Nicolai Hähnle wrote: > On 05.01.2017 17:59, Ilia Mirkin wrote: >> >> On Thu, Jan 5, 2017 at 11:30 AM, Nicolai Hähnle >> wrote: >>> >>> On 05.01.2017 17:02, Ilia Mirkin wrote: On Thu, Jan 5, 2017 at 10:48 AM, Nicolai Hähnle wrote: > > >

[Mesa-dev] [PATCH] docs: document INTEL_PRECISE_TRIG envvar

2017-01-11 Thread Juan A. Suarez Romero
--- docs/envvars.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/envvars.html b/docs/envvars.html index 9eee8db..4f05d7f 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -187,6 +187,7 @@ See the Xlib software driver page for details. do32 - generate compute shader SIMD3

[Mesa-dev] [PATCH 3/3] anv: Support loader interface version 3 (patch v2)

2017-01-11 Thread Chad Versace
This patch implements vk_icdNegotiateLoaderICDInterfaceVersion(), which brings us to loader interface v3. v2: - Drop the pragmas. [emil] - Advertise v3 instead of v2. Anvil supported more than I thought. [jason] - s/Surface/SurfaceKHR/ in comments. [emil] Cc: Emil Velikov Cc: Jason Ek

Re: [Mesa-dev] [PATCH 11/11] anv: Enable tessellation shaders.

2017-01-11 Thread Lionel Landwerlin
On 11/01/17 17:02, Eero Tamminen wrote: Hi, On 09.01.2017 07:26, Kenneth Graunke wrote: Signed-off-by: Kenneth Graunke --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I'm not clear whether we want to do this yet. On Skylake, the status is: 99.3% of th

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset wrote: > > > On 01/11/2017 05:32 PM, Marek Olšák wrote: > >> On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund >> wrote: >> >>> On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle >>> wrote: >>> On 11.01.2017 13:17, Marek Olšák wrote: > >

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Would you please run a GPU-bound benchmark of your choice to make sure it doesn't affect performance? Thanks, Marek On Wed, Jan 11, 2017 at 6:29 PM, Samuel Pitoiset wrote: > Only VI can do 32-bit denormals at full rate while previous > generations can do it only for 64

Re: [Mesa-dev] [PATCH 1/6] configure.ac: Rename MESA_LLVM to FOUND_LLVM

2017-01-11 Thread Emil Velikov
On 8 December 2016 at 22:12, Tobias Droste wrote: > Am Donnerstag, 8. Dezember 2016, 16:59:27 CET schrieb Emil Velikov: >> On 8 December 2016 at 02:03, Tobias Droste wrote: >> > this renames MESA_LLVM to FOUND_LLVM and updates the config.log report >> > to say if LLVM is found or not, to make cle

Re: [Mesa-dev] [PATCH 3/3] anv: Support loader interface version 3 (patch v2)

2017-01-11 Thread Emil Velikov
On 11 January 2017 at 17:58, Chad Versace wrote: > This patch implements vk_icdNegotiateLoaderICDInterfaceVersion(), which > brings us to loader interface v3. > > v2: > - Drop the pragmas. [emil] > - Advertise v3 instead of v2. Anvil supported more than I > thought. [jason] > - s/Surfac

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Roland Scheidegger
I don't think there's any glsl, es or otherwise, specification which would require denorms (since obviously lots of hw can't do it, d3d10 forbids them), with any precision qualifier. Hence these look like bugs of the test suite to me? (Irrespective if it's a good idea or not to enable denormals, wh

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Ilia Mirkin
So, I don't know whether this affects more than compute shaders without reading the code, but I explicitly had to enable denorm flushing on nvc0 in order to fix some sad artifacts in Unigine Heaven. Right now nouveau only does denorm flushes on graphics shaders, but the reason I did that originall

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: > On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset > wrote: >> >> >> >> On 01/11/2017 05:32 PM, Marek Olšák wrote: >>> >>> On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund >>> wrote: On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle

Re: [Mesa-dev] [PATCH 03/11] i965/vec4: use attribute slots for first non payload GRF

2017-01-11 Thread Jordan Justen
On 2017-01-11 02:33:59, Alejandro Piñeiro wrote: > On 10/01/17 15:52, Jordan Justen wrote: > > The explanation could be something that you can then add to the commit > > message... > > Ok, so how about a commit message like this?: > > "i965/vec4: use attribute slots for first non payload GRF > >

[Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

2017-01-11 Thread Matt Turner
Coverity thinks there are some bad shifts introduced by commit c2acf97. I think it thinks that first can be 64 because 64 is the greatest value that can be returned by ffsll(), but that's not actually possible? If that's correct, maybe an assert is in order. ** CID 1398563:(BAD_SHIFT) /src/me

Re: [Mesa-dev] [PATCH 3/7] gallium: add FBFETCH opcode to retrieve the current sample value

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 6:45 PM, Ilia Mirkin wrote: > On Fri, Jan 6, 2017 at 6:05 AM, Nicolai Hähnle wrote: >> On 05.01.2017 17:59, Ilia Mirkin wrote: >>> >>> On Thu, Jan 5, 2017 at 11:30 AM, Nicolai Hähnle >>> wrote: On 05.01.2017 17:02, Ilia Mirkin wrote: > > > On Thu, Ja

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 01/11/2017 05:32 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wr

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
One trivial request: If we do land this patch, please include a link the the mailing list archives in the commit message so that we can easily track down this discussion if we ever need to in the future. On Fri, Jan 6, 2017 at 1:42 AM, Samuel Pitoiset wrote: > D3D always computes the absolute v

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: > > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand > wrote: > >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset < > samuel.pitoi...@gmail.com> > >> wrote: > >>> > >>> > >>> > >>> On

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: > On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund > wrote: >> >> On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >> > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand >> > wrote: >> >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset >>

Re: [Mesa-dev] [PATCH] docs: document INTEL_PRECISE_TRIG envvar

2017-01-11 Thread Jordan Justen
On 2017-01-11 09:53:15, Juan A. Suarez Romero wrote: > --- > docs/envvars.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/envvars.html b/docs/envvars.html > index 9eee8db..4f05d7f 100644 > --- a/docs/envvars.html > +++ b/docs/envvars.html > @@ -187,6 +187,7 @@ See the Xlib soft

Re: [Mesa-dev] [PATCH] docs: document INTEL_PRECISE_TRIG envvar

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 10:34 AM, Jordan Justen wrote: > On 2017-01-11 09:53:15, Juan A. Suarez Romero wrote: > > --- > > docs/envvars.html | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/docs/envvars.html b/docs/envvars.html > > index 9eee8db..4f05d7f 100644 > > --- a/docs/envvar

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Marek Olšák
I've realized there is a small problem with this. MAD never supports denorms, but MUL+ADD do. That can cause issues, because the compiler assumes that MAD = MUL+ADD. We need to use MAD for good performance, which means we should probably never enable FP32 denorms. Marek On Wed, Jan 11, 2017 at 6

[Mesa-dev] [PATCH 1/2] nir/search: Rework conditions to be a bit simpler and more generic

2017-01-11 Thread Jason Ekstrand
Instead of passing all of the ALU op information, we just pass what you need: The SSA def, the type it's being read as, and a component mask. --- src/compiler/nir/nir_search.c | 12 +-- src/compiler/nir/nir_search.h | 3 +- src/compiler/nir/nir_search_helpers.h | 62 ++

[Mesa-dev] [PATCH 2/2] nir/search: Allow conditions on expressions as well as variables

2017-01-11 Thread Jason Ekstrand
--- src/compiler/nir/nir_algebraic.py | 10 +++--- src/compiler/nir/nir_search.c | 28 +--- src/compiler/nir/nir_search.h | 18 +- 3 files changed, 33 insertions(+), 23 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Harry Wentland
On 2017-01-11 12:50 AM, Michel Dänzer wrote: On 10/01/17 09:07 PM, Andy Furniss wrote: Andy Furniss wrote: Though recent testing shows this is not true with DAL/DC on 3.7 - todo test DC on new drm-next branch. todo done, DC for some reason on both amd-staging-4.7 and amd-staging-drm-next is

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 7:34 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: >> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund >> wrote: >>> >>> On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >>> > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand >>> >

Re: [Mesa-dev] [PATCH 4/8] android: fix llvmpipe build

2017-01-11 Thread Jose Fonseca
On 10/01/17 15:54, Emil Velikov wrote: On 6 January 2017 at 17:35, Wu Zhen wrote: From: WuZhen since (cf410574 gallivm: Make MCJIT a runtime optioni.), llvmpipe assume MCJIT is available on x86(_64). this is not the case for android prior to M. Wu Zhen, what exactly is the issue you're gett

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Ilia Mirkin
On Wed, Jan 11, 2017 at 2:33 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 7:34 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: >>> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund >>> wrote: On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >

Re: [Mesa-dev] [PATCH] util: fix list_is_singular()

2017-01-11 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Please CC stable. On Tue, Jan 10, 2017 at 8:13 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > Currently its dependant on the user calling and checking the result > of list_empty() before using the result of list_is_singular(). > --- > src/util/list.h |

Re: [Mesa-dev] [PATCH 3/9] nir/algebraic: add support for conditional helper functions to expressions

2017-01-11 Thread Jason Ekstrand
This patch and 5-9 are Reviewed-by: Jason Ekstrand If others think the "unified" approach is nicer, I'll rebase on top and we shouldn't need any nir_opt_algebraic.py changes since the syntax won't change. On Tue, Jan 10, 2017 at 1:41 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: >

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:09 PM, Marek Olšák wrote: Reviewed-by: Marek Olšák Would you please run a GPU-bound benchmark of your choice to make sure it doesn't affect performance? I tried Furmark and Pixmark Piano on my rx 480. With 3 runs before and after that change, the number of FPS as well as t

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:18 PM, Ilia Mirkin wrote: So, I don't know whether this affects more than compute shaders without reading the code, but I explicitly had to enable denorm flushing on nvc0 in order to fix some sad artifacts in Unigine Heaven. Right now nouveau only does denorm flushes on graphi

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:49 PM, Marek Olšák wrote: I've realized there is a small problem with this. MAD never supports denorms, but MUL+ADD do. That can cause issues, because the compiler assumes that MAD = MUL+ADD. We need to use MAD for good performance, which means we should probably never enable

Re: [Mesa-dev] [PATCH] radeonsi: enable 32-bit denormals on VI+

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:00 PM, Roland Scheidegger wrote: I don't think there's any glsl, es or otherwise, specification which would require denorms (since obviously lots of hw can't do it, d3d10 forbids them), with any precision qualifier. Hence these look like bugs of the test suite to me? (Irrespect

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:33 PM, Jason Ekstrand wrote: One trivial request: If we do land this patch, please include a link the the mailing list archives in the commit message so that we can easily track down this discussion if we ever need to in the future. Sure, I was planning to do it. :-) But it

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: On Wed, Jan 11, 2017 a

Re: [Mesa-dev] [PATCH 1/9] nir: tidy up swizzle handling in nir_search

2017-01-11 Thread Jason Ekstrand
This patch appears to cause regressions on Haswell. I'm not sure why. The fact that it's only haswell strikes me as a bit odd so it's possible it's not your patch's fault. I'm looking into it. On Tue, Jan 10, 2017 at 1:41 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > If we just c

Re: [Mesa-dev] [PATCH 1/2] nir/search: Rework conditions to be a bit simpler and more generic

2017-01-11 Thread Jason Ekstrand
These two patches provide a slightly different approach to what Tim did. I think Tim's is fine but I also like the idea of conditions working based on SSA def, type, and read mask so I consider this a unification/cleanup rather than a counter-proposal. Thoughts? On Wed, Jan 11, 2017 at 11:13 AM,

Re: [Mesa-dev] [PATCH 06/10] amd/common: unify cube map coordinate handling between radeonsi and radv

2017-01-11 Thread Bas Nieuwenhuizen
On Wed, Jan 11, 2017 at 1:45 AM, Grazvydas Ignotas wrote: > Unfortunately this one breaks at least (surprise!) texturecubemap > SaschaWillemsVulkan demo. > I recommend you try it yourself, there are even precompiled binaries > available (see README.md): > https://github.com/SaschaWillems/Vulkan A

  1   2   >