Re: [Mesa-dev] [PATCH 04/22] spirv: add DF support to vtn_const_ssa_value()

2016-12-02 Thread Samuel Iglesias Gonsálvez
On Thu, 2016-12-01 at 18:55 -0800, Jason Ekstrand wrote: > If you don't mind rebasing on it, my "get rid of nir_constant_data" > patch should let you drop most of this and patch 5. > > OK, thanks! Sam On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero wrote: From: Samuel Iglesias Gonsál

Re: [Mesa-dev] [PATCH 12/22] spirv/nir: implement DF conversions

2016-12-02 Thread Samuel Iglesias Gonsálvez
On Thu, 2016-12-01 at 18:50 -0800, Jason Ekstrand wrote: > On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero lia.com> wrote: > > From: Samuel Iglesias Gonsálvez > > > > SPIR-V does not have special opcodes for DF conversions. We need to > > identify > > them by checking the bit size of the

Re: [Mesa-dev] [PATCH 16/22] isl: fix VA64 support for double and dvecN vertex attributes

2016-12-02 Thread Samuel Iglesias Gonsálvez
On Thu, 2016-12-01 at 18:58 -0800, Jason Ekstrand wrote: > On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero lia.com> wrote: > > From: Samuel Iglesias Gonsálvez > > > > > > > > We use *64*_PASSTHRU formats to upload vertex attributes of 64 bits > > > > to avoid conversions. From the BDW

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-02 Thread Juan A. Suarez Romero
On Thu, 2016-12-01 at 21:29 +0100, Marek Olšák wrote: > On Wed, Nov 30, 2016 at 9:23 PM, Emil Velikov om> wrote: > > Hi all, > > > > With holidays not far off, it might be a nice idea to consider the > > branchpoint/release schedule for the next release. > > > > I will be having limited internet

Re: [Mesa-dev] [PATCH 1/2] st/va: force to submit two consecutive single jobs

2016-12-02 Thread Christian König
Am 29.11.2016 um 20:43 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang The gop_size in rate control is the budget window for internal rate control calculation, and shouldn't always equal to idr period. Define a coefficient to let budget window contains a number of idr period for proper rate co

Re: [Mesa-dev] [PATCH 00/27] Renderbuffer Decompression (and GBM modifiers)

2016-12-02 Thread Daniel Stone
Hey Ben, Sorry I didn't get to testing this before now; have been tied up with all manner of stuff. On 1 December 2016 at 22:09, Ben Widawsky wrote: > The overall strategy is that the buffer/surface is created with a list of > modifiers. The list of modifiers the hardware is capable of using will

Re: [Mesa-dev] [PATCH 09/27] gbm: Introduce modifiers into surface/bo creation

2016-12-02 Thread Daniel Stone
Hi Ben, On 1 December 2016 at 22:09, Ben Widawsky wrote: > @@ -996,13 +997,22 @@ gbm_dri_bo_create(struct gbm_device *gbm, > dri_use |= __DRI_IMAGE_USE_SHARE; > > bo->image = > - dri->image->createImage(dri->screen, > - width, height, > -

Re: [Mesa-dev] [PATCH 11/27] gbm: Get modifiers from DRI

2016-12-02 Thread Daniel Stone
Hi Ben, On 1 December 2016 at 22:09, Ben Widawsky wrote: > @@ -678,6 +679,28 @@ gbm_dri_bo_get_offset(struct gbm_bo *_bo, int plane) > return (uint32_t)offset; > } > > +static uint64_t > +gbm_dri_bo_get_modifier(struct gbm_bo *_bo) > +{ > + struct gbm_dri_device *dri = gbm_dri_device(_bo->

Re: [Mesa-dev] [PATCH 00/27] Renderbuffer Decompression (and GBM modifiers)

2016-12-02 Thread Rob Clark
On Thu, Dec 1, 2016 at 5:09 PM, Ben Widawsky wrote: > When Kristian's interface is ready, kmscube can be modified to make use of it. > > Rob: are you interested in a PR for kmscube? sure, from a quick look seems like it should be backwards compatible.. probably we should set up a git tree on fd.o

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-02 Thread Emil Velikov
On 1 December 2016 at 09:35, Nicolai Hähnle wrote: > On 30.11.2016 21:23, Emil Velikov wrote: >> >> Hi all, >> >> With holidays not far off, it might be a nice idea to consider the >> branchpoint/release schedule for the next release. > > > +1 on the 17.0 question. > I'd prefer to keep different t

[Mesa-dev] [PATCH] spirv: Builtin Layer is an input for fragment shaders

2016-12-02 Thread Iago Toral Quiroga
This change makes it so we emit a load_input intrinsic when Layer is read in a fragment shader. --- Even with this, layered rendering does not seem to work in the Vulkan driver, so there is something else that is broken. We are probably not mapping the Layer input correctly somewhere. src/compil

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-02 Thread Emil Velikov
On 1 December 2016 at 10:00, Christian Gmeiner wrote: > 2016-11-30 21:23 GMT+01:00 Emil Velikov : >> Hi all, >> >> With holidays not far off, it might be a nice idea to consider the >> branchpoint/release schedule for the next release. >> >> I will be having limited internet access during 20 Dec -

[Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

2016-12-02 Thread Lionel Landwerlin
This is the size selected by the i965 driver. Signed-off-by: Lionel Landwerlin Cc: Kenneth Graunke --- src/intel/vulkan/anv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 1f03b68..ce4eb4d 100644

[Mesa-dev] [PATCH 2/4] st/dri: ask the driver to update its internal copies on reimport

2016-12-02 Thread Philipp Zabel
For imported buffers that can't be used directly as a source to the texture samplers, the pipe driver might need to create an internal copy, for example in a different tiling layout. When buffers are reimported they may contain new image data, so the driver internal copies need to be recreated. Si

[Mesa-dev] [PATCH 3/4] etnaviv: initialize seqno of imported resources

2016-12-02 Thread Philipp Zabel
Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if they had already been rendered to. Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 ++ 1 file ch

[Mesa-dev] [PATCH 0/4] etnaviv: update derived texture resources of (re)imported buffers

2016-12-02 Thread Philipp Zabel
Hi, to get weston / wayland_egl working on etnaviv, we need to update the texture resources derived from imported buffers every time they are re-imported. This patchset is based on the github-etnaviv/for_mainline_v1 branch and adds a new pipe_screen::resource_changed callback that is called insid

[Mesa-dev] [PATCH 1/4] gallium: add pipe_screen::resource_changed

2016-12-02 Thread Philipp Zabel
Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel --- src/gallium/include/pipe/p_screen.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/sr

[Mesa-dev] [PATCH 4/4] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

2016-12-02 Thread Philipp Zabel
Implement the new resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables that may contain new contents. Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 ++

[Mesa-dev] [PATCH 1/3] st/va: automake: cleanup C{PP,}FLAGS

2016-12-02 Thread Emil Velikov
From: Emil Velikov Remove some transitional left overs from the gallium pipe-loader rework and kill off unneeded AM_CPPFLAGS. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/va/Makefile.am | 12 1 file changed, 12 deletions(-) diff --git a/src/gallium/state_trackers/va

[Mesa-dev] [PATCH 2/3] st/va: remove unused variable pbuff

2016-12-02 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/gallium/state_trackers/va/surface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c index f8513d9..357e85e 100644 --- a/src/gallium/state_trackers/va/surf

[Mesa-dev] [PATCH 3/3] st/va: move vlVaBuffer declaration further up

2016-12-02 Thread Emil Velikov
From: Emil Velikov This allows us to remove the struct vlVaBuffer reference, which lead the compiler to emit a "assignment from incompatible pointer type" warnings. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/va/va_private.h | 30 +++--- 1 file changed, 1

[Mesa-dev] [PATCH 1/6] autoconf/scons: bump libdrm to 2.4.75

2016-12-02 Thread Emil Velikov
From: Emil Velikov We'll be using the drmGetDevice[s]2 API with next patch. Cc: Michel Dänzer Signed-off-by: Emil Velikov --- The libdrm patches have not landed ! Version number is preliminary ! --- configure.ac | 2 +- scons/gallium.py | 2 +- 2 files changed, 2 insertions(+), 2 deletion

[Mesa-dev] [PATCH 4/6] radv/winsys: use drmGetDevice[s]2 API

2016-12-02 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit Cc: Michel Dänzer Cc: Dave Airlie Signed-off-by: Emil Velikov --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c b/src

[Mesa-dev] [PATCH 2/6] loader: use drmGetDevice[s]2 API

2016-12-02 Thread Emil Velikov
From: Emil Velikov By default this allows us to fetch the device list/info _without_ the revision field. At the moment retrieving that wakes up the device. Note: kernel patch to resolve that should be in 4.10. Cc: Michel Dänzer Signed-off-by: Emil Velikov --- src/loader/loader.c | 6 +++---

[Mesa-dev] [PATCH 5/6] radv: do not open random render node(s)

2016-12-02 Thread Emil Velikov
From: Emil Velikov drmGetDevices2() provides us with enough flexibility to build heuristics upon. Opening a random node on the other hand will wake up the device, regardless if it's the one we're intereseted or not. Cc: Michel Dänzer Cc: Dave Airlie Signed-off-by: Emil Velikov --- Afacit ther

[Mesa-dev] [PATCH 6/6] anv: do not open random render node(s)

2016-12-02 Thread Emil Velikov
From: Emil Velikov drmGetDevices2() provides us with enough flexibility to build heuristics upon. Opening a random node on the other hand will wake up the device, regardless if it's the one we're intereseted or not. Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.

[Mesa-dev] [PATCH 3/6] winsys/amdgpu: use drmGetDevice[s]2 API

2016-12-02 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit Cc: Michel Dänzer Signed-off-by: Emil Velikov --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c b/src/gallium/winsys/amdgpu/dr

[Mesa-dev] [PATCH] swr: [rasterizer jitter] include stdarg.h in builder_misc.cpp

2016-12-02 Thread Tim Rowley
Fixes build problem with llvm-svn. --- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp b/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp index d75

Re: [Mesa-dev] [PATCH] swr: [rasterizer jitter] include stdarg.h in builder_misc.cpp

2016-12-02 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Dec 2, 2016, at 10:53 AM, Rowley, Timothy O > wrote: > > Fixes build problem with llvm-svn. > --- > src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/swr/ra

Re: [Mesa-dev] [PATCH 02/23] tgsi: add Stream{X, Y, Z, W} fields to tgsi_declaration_semantic

2016-12-02 Thread Nicolai Hähnle
On 30.11.2016 21:37, Roland Scheidegger wrote: Am 30.11.2016 um 20:19 schrieb Nicolai Hähnle: On 30.11.2016 19:06, Roland Scheidegger wrote: Am 30.11.2016 um 14:35 schrieb Nicolai Hähnle: From: Nicolai Hähnle This is for geometry shader outputs. Without it, drivers have no way of knowing whi

Re: [Mesa-dev] [PATCH 6/6] anv: do not open random render node(s)

2016-12-02 Thread Eric Engestrom
On Friday, 2016-12-02 16:31:49 +, Emil Velikov wrote: > From: Emil Velikov > > drmGetDevices2() provides us with enough flexibility to build heuristics > upon. Opening a random node on the other hand will wake up the device, > regardless if it's the one we're intereseted or not. "interested"

Re: [Mesa-dev] [PATCH] swr: [rasterizer jitter] include stdarg.h in builder_misc.cpp

2016-12-02 Thread Jan Vesely
On Fri, 2016-12-02 at 10:53 -0600, Tim Rowley wrote: > Fixes build problem with llvm-svn. > --- > src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp > b/s

Re: [Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

2016-12-02 Thread Eric Engestrom
On Thursday, 2016-12-01 14:09:43 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/gbm/main/gbm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h > index 59daaa1..efb329e 100644 > ---

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2016-12-02 Thread Eric Engestrom
On Thursday, 2016-12-01 14:09:44 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used by clients that need to know the number of planes > allocated for them on behalf of the GL or other API. The best current > example of this is when an extra "plane" is allocated to store > compr

Re: [Mesa-dev] [PATCH 04/27] gbm: Create a gbm_device getter for stride

2016-12-02 Thread Eric Engestrom
On Thursday, 2016-12-01 14:09:45 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used so we can query information per plane. > > Signed-off-by: Ben Widawsky > --- > src/gbm/backends/dri/gbm_dri.c | 7 +++ > src/gbm/main/gbm.c | 2 +- > src/gbm/main/gbmint.h

Re: [Mesa-dev] [PATCH 07/27] i965/dri: Store the screen associated with the image

2016-12-02 Thread Eric Engestrom
On Thursday, 2016-12-01 14:09:48 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > I intend to need to get to the devinfo structure, and storing the screen > is an easy way to do that. > > It seems to be the consensus that you cannot share an image between > multiple screens. > > Scape-goat:

Re: [Mesa-dev] [PATCH 08/27] dri: Add an image creation with modifiers

2016-12-02 Thread Eric Engestrom
On Thursday, 2016-12-01 14:09:49 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Modifiers will be obtains or guessed by the client and passed in during > image creation/import. > > This requires bumping the DRIimage version. > > Signed-off-by: Ben Widawsky > --- > include/GL/internal/dri

Re: [Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

2016-12-02 Thread Daniel Stone
Hi, On 2 December 2016 at 17:56, Eric Engestrom wrote: > On Thursday, 2016-12-01 14:09:43 -0800, Ben Widawsky wrote: >> --- a/src/gbm/main/gbm.h >> +++ b/src/gbm/main/gbm.h >> @@ -294,10 +294,10 @@ gbm_bo_map(struct gbm_bo *bo, >> void >> gbm_bo_unmap(struct gbm_bo *bo, void *map_data); >> >> -

Re: [Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

2016-12-02 Thread Ben Widawsky
On 16-12-02 18:07:22, Daniel Stone wrote: Hi, On 2 December 2016 at 17:56, Eric Engestrom wrote: On Thursday, 2016-12-01 14:09:43 -0800, Ben Widawsky wrote: --- a/src/gbm/main/gbm.h +++ b/src/gbm/main/gbm.h @@ -294,10 +294,10 @@ gbm_bo_map(struct gbm_bo *bo, void gbm_bo_unmap(struct gbm_bo

Re: [Mesa-dev] [PATCH 1/3] st/va: automake: cleanup C{PP,}FLAGS

2016-12-02 Thread Christian König
Am 02.12.2016 um 17:26 schrieb Emil Velikov: From: Emil Velikov Remove some transitional left overs from the gallium pipe-loader rework and kill off unneeded AM_CPPFLAGS. Signed-off-by: Emil Velikov Reviewed-by: Christian König . --- src/gallium/state_trackers/va/Makefile.am | 12 --

Re: [Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

2016-12-02 Thread Daniel Stone
Hi Ben, On 2 December 2016 at 18:17, Ben Widawsky wrote: > On 16-12-02 18:07:22, Daniel Stone wrote: >> On 2 December 2016 at 17:56, Eric Engestrom >> wrote: >> I have to admit I didn't catch this one. It doesn't help on 64-bit >> since unsigned int is still 32-bit there, and in any case it's l

Re: [Mesa-dev] [PATCH 6/6] anv: do not open random render node(s)

2016-12-02 Thread Emil Velikov
On 2 December 2016 at 17:33, Eric Engestrom wrote: > On Friday, 2016-12-02 16:31:49 +, Emil Velikov wrote: >> From: Emil Velikov >> >> drmGetDevices2() provides us with enough flexibility to build heuristics >> upon. Opening a random node on the other hand will wake up the device, >> regardle

Re: [Mesa-dev] [PATCH 2/3] st/va: remove unused variable pbuff

2016-12-02 Thread tournier.elie
Reviewed-by: Elie Tournier 2016-12-02 17:26 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/gallium/state_trackers/va/surface.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/state_trackers/va/surface.c > b/src/gallium/state_trac

Re: [Mesa-dev] [PATCH 02/23] tgsi: add Stream{X, Y, Z, W} fields to tgsi_declaration_semantic

2016-12-02 Thread Roland Scheidegger
Am 02.12.2016 um 18:23 schrieb Nicolai Hähnle: > On 30.11.2016 21:37, Roland Scheidegger wrote: >> Am 30.11.2016 um 20:19 schrieb Nicolai Hähnle: >>> On 30.11.2016 19:06, Roland Scheidegger wrote: Am 30.11.2016 um 14:35 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > This is fo

[Mesa-dev] [PATCH v2] swr: Fix type to match parameters of std::max()

2016-12-02 Thread George Kyriazis
Include propagation of comparisons further down. --- src/gallium/drivers/swr/swr_clear.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/swr/swr_clear.cpp b/src/gallium/drivers/swr/swr_clear.cpp index f59179f..08eead8 100644 --- a/src/galli

Re: [Mesa-dev] [PATCH 3/3] i965: Delete the meta-base CopyImageSubData implementation

2016-12-02 Thread Anuj Phogat
On Thu, Dec 1, 2016 at 10:35 AM, Jason Ekstrand wrote: > > When I originally implemented the ARB_copy_image extension, the fast-path > was written in meta using texture views. This path only worked if both > images were uncompressed color images. All of the other cases fell back to > the blitter

Re: [Mesa-dev] [PATCH v2] swr: Fix type to match parameters of std::max()

2016-12-02 Thread Rowley, Timothy O
Should have parens on the zsbuf test line to match your corresponding change for cbuf attachments. With that change, Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Dec 2, 2016, at 1:18 PM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: Include propagation of compari

Re: [Mesa-dev] [PATCH 3/3] i965: Delete the meta-base CopyImageSubData implementation

2016-12-02 Thread Jason Ekstrand
On Fri, Dec 2, 2016 at 11:19 AM, Anuj Phogat wrote: > On Thu, Dec 1, 2016 at 10:35 AM, Jason Ekstrand > wrote: > > > > When I originally implemented the ARB_copy_image extension, the fast-path > > was written in meta using texture views. This path only worked if both > > images were uncompresse

[Mesa-dev] [PATCH v2] swr: [rasterizer jitter] include cstdarg in builder_misc.cpp

2016-12-02 Thread Tim Rowley
Fixes build problem with llvm-svn. v2: use cstdarg instead of stdarg.h --- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp b/src/gallium/drivers/swr/rasteri

[Mesa-dev] [PATCH] i915: Stop claiming GL 2.1 support.

2016-12-02 Thread Matt Turner
A user reporting an unrelated bug (98964) said that he has to set MESA_GL_VERSION_OVERRIDE=1.4 when running Chromium otherwise it's too slow. I presume that it's attempting to use GL 2.0/2.1 features that aren't hardware-supported on i915. --- src/mesa/drivers/dri/i915/intel_screen.c | 2 +- 1 fil

Re: [Mesa-dev] [PATCH 19/22] anv/nir: add support for dvec3/4 consuming two locations

2016-12-02 Thread Jason Ekstrand
On Thu, Dec 1, 2016 at 10:22 PM, Jason Ekstrand wrote: > +Ken > > On Thu, Dec 1, 2016 at 10:17 PM, Jason Ekstrand > wrote: > >> I'm not sure how I feel about this one. It seems like it would almost be >> easier to just pick one convention or the other for NIR and adjust one of >> the drivers ac

Re: [Mesa-dev] [PATCH 6/6] anv: do not open random render node(s)

2016-12-02 Thread Jason Ekstrand
I haven't reviewed in any sort of detail, but I'm fine with this change FWIW. I glanced at the drm entrypoints you're calling, and that's not code we want to duplicate in anv. On Fri, Dec 2, 2016 at 10:31 AM, Emil Velikov wrote: > On 2 December 2016 at 17:33, Eric Engestrom > wrote: > > On Fri

Re: [Mesa-dev] [PATCH v2] swr: [rasterizer jitter] include cstdarg in builder_misc.cpp

2016-12-02 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Dec 2, 2016, at 1:28 PM, Rowley, Timothy O > wrote: > > Fixes build problem with llvm-svn. > > v2: use cstdarg instead of stdarg.h > --- > src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[Mesa-dev] Mesa 12.0.5 release candidate

2016-12-02 Thread Emil Velikov
Hello list, The candidate for the Mesa 12.0.5 is now available. Currently we have: - 25 queued - 0 nominated (outstanding) - and 1 rejected patches Take a look at section "Mesa stable queue" for more information. Note: This is the final planned release for the 12.0 stable branch. Testing re

Re: [Mesa-dev] [PATCH 02/23] tgsi: add Stream{X, Y, Z, W} fields to tgsi_declaration_semantic

2016-12-02 Thread Nicolai Hähnle
On 02.12.2016 19:46, Roland Scheidegger wrote: Am 02.12.2016 um 18:23 schrieb Nicolai Hähnle: On 30.11.2016 21:37, Roland Scheidegger wrote: Am 30.11.2016 um 20:19 schrieb Nicolai Hähnle: On 30.11.2016 19:06, Roland Scheidegger wrote: Am 30.11.2016 um 14:35 schrieb Nicolai Hähnle: From: Nico

Re: [Mesa-dev] [PATCH] i915: Stop claiming GL 2.1 support.

2016-12-02 Thread Emil Velikov
On 2 December 2016 at 19:49, Matt Turner wrote: > A user reporting an unrelated bug (98964) said that he has to set > MESA_GL_VERSION_OVERRIDE=1.4 when running Chromium otherwise it's too > slow. I presume that it's attempting to use GL 2.0/2.1 features that > aren't hardware-supported on i915. Ub

Re: [Mesa-dev] [PATCH] swr: Fix active_queries count

2016-12-02 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Dec 1, 2016, at 7:08 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: The active_query count was incorrect for query types that don't require a begin_query. Removed the unnecessary assert. --- src/gallium/drivers/swr/swr

[Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-02 Thread Marek Olšák
From: Marek Olšák This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and probably many other games too. cso_cache deletes sampler states when the cache size is too big and doesn't check which sampler states are bound, causing use-after-free in drivers. Because of that, radeons

[Mesa-dev] [PATCH 3/3] st/mesa: round lod_bias to a multiple of 1/256

2016-12-02 Thread Marek Olšák
From: Marek Olšák This reduces the number of sampler states 3.6x in Batman Arkham: Origins. (from ~7200 to ~2000) --- src/mesa/state_tracker/st_atom_sampler.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_atom_sampler.c b/src/mesa/state_tracker/st_atom_samp

[Mesa-dev] [PATCH 01/10] radeonsi: take LDS into account for compute shader occupancy stats

2016-12-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 44a4dd2..145de9f 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 2/3] gallium: decrease the size of pipe_sampler_state fields

2016-12-02 Thread Marek Olšák
From: Marek Olšák We've had unused bits. --- src/gallium/include/pipe/p_state.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index 46df196..d501a93 100644 --- a/src/gallium/include/pipe/p_state.

[Mesa-dev] [PATCH 06/10] radeonsi: write shader descriptors into hang reports

2016-12-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 114 ++ src/gallium/drivers/radeonsi/si_descriptors.c | 1 + src/gallium/drivers/radeonsi/si_state.h | 2 + 3 files changed, 117 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_deb

[Mesa-dev] [PATCH 04/10] radeonsi: properly declare context sampler states

2016-12-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 2 +- src/gallium/drivers/radeonsi/si_descriptors.c | 4 ++-- src/gallium/drivers/radeonsi/si_state.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/g

[Mesa-dev] [PATCH 03/10] radeonsi: fix incorrect FMASK checking in bind_sampler_states

2016-12-02 Thread Marek Olšák
From: Marek Olšák Cc: 13.0 12.0 --- src/gallium/drivers/radeonsi/si_descriptors.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 8777f36..cf66102 100644 --- a/src/ga

[Mesa-dev] [PATCH 05/10] radeonsi: check for sampler state CSO corruption

2016-12-02 Thread Marek Olšák
From: Marek Olšák It really happens. --- src/gallium/drivers/radeonsi/si_descriptors.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h| 3 +++ src/gallium/drivers/radeonsi/si_state.c | 5 + 3 files changed, 9 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_descriptors

[Mesa-dev] [PATCH 02/10] radeonsi: always restore sampler states when unbinding sampler views

2016-12-02 Thread Marek Olšák
From: Marek Olšák Cc: 13.0 12.0 --- src/gallium/drivers/radeonsi/si_descriptors.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 097ffcd..8777f36 100644 --- a/sr

[Mesa-dev] [PATCH 09/10] tgsi: fix the src type of TGSI_OPCODE_MEMBAR

2016-12-02 Thread Marek Olšák
From: Marek Olšák It's a literal integer. The next commit will need this. Cc: 13.0 12.0 --- src/gallium/auxiliary/tgsi/tgsi_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tgsi_info.c index 18e1bc8..37549aa 100644

[Mesa-dev] [PATCH 10/10] radeonsi: wait for outstanding LDS instructions in memory barriers if needed

2016-12-02 Thread Marek Olšák
From: Marek Olšák Cc: 13.0 12.0 --- src/gallium/drivers/radeonsi/si_shader.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 45896bd..dc5c67a 100644 --- a/src/galliu

[Mesa-dev] [PATCH 07/10] radeonsi: allow specifying simm16 of emit_waitcnt at call sites

2016-12-02 Thread Marek Olšák
From: Marek Olšák The next commit will use this. Cc: 13.0 12.0 --- src/gallium/drivers/radeonsi/si_shader.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 145de9f..b914e

[Mesa-dev] [PATCH 08/10] radeonsi: wait for outstanding memory instructions in TCS barriers

2016-12-02 Thread Marek Olšák
From: Marek Olšák Cc: 13.0 12.0 --- src/gallium/drivers/radeonsi/si_shader.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index b914efb..45896bd 100644 --- a/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 05/10] radeonsi: check for sampler state CSO corruption

2016-12-02 Thread Gustaw Smolarczyk
2016-12-02 21:39 GMT+01:00 Marek Olšák : > From: Marek Olšák > > It really happens. > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 1 + > src/gallium/drivers/radeonsi/si_pipe.h| 3 +++ > src/gallium/drivers/radeonsi/si_state.c | 5 + > 3 files changed, 9 insertions(+)

Re: [Mesa-dev] Mesa 12.0.5 release candidate

2016-12-02 Thread Nanley Chery
On Fri, Dec 02, 2016 at 08:15:16PM +, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 12.0.5 is now available. Currently we have: > - 25 queued > - 0 nominated (outstanding) > - and 1 rejected patches > > Take a look at section "Mesa stable queue" for more information. >

Re: [Mesa-dev] Mesa 12.0.5 release candidate

2016-12-02 Thread Emil Velikov
On 2 December 2016 at 20:53, Nanley Chery wrote: > On Fri, Dec 02, 2016 at 08:15:16PM +, Emil Velikov wrote: >> Hello list, >> >> The candidate for the Mesa 12.0.5 is now available. Currently we have: >> - 25 queued >> - 0 nominated (outstanding) >> - and 1 rejected patches >> >> Take a loo

Re: [Mesa-dev] [PATCH 3/3] st/mesa: round lod_bias to a multiple of 1/256

2016-12-02 Thread Roland Scheidegger
Ideally this wouldn't be tied to specific hardware... That said, I believe the clamping limits are sane (d3d10 will use these too). If GL has some requirements for lod accuracy or if it's queryable, it should probably honor this (d3d10 only would require 6 fractional bits), although I'd guess that

Re: [Mesa-dev] [PATCH] spirv: Builtin Layer is an input for fragment shaders

2016-12-02 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Dec 2, 2016 at 5:16 AM, Iago Toral Quiroga wrote: > This change makes it so we emit a load_input intrinsic when Layer > is read in a fragment shader. > --- > > Even with this, layered rendering does not seem to work in the Vulkan > driver, so there is somethi

Re: [Mesa-dev] Mesa 12.0.5 release candidate

2016-12-02 Thread Emil Velikov
On 2 December 2016 at 21:16, Emil Velikov wrote: > On 2 December 2016 at 20:53, Nanley Chery wrote: >> On Fri, Dec 02, 2016 at 08:15:16PM +, Emil Velikov wrote: >>> Hello list, >>> >>> The candidate for the Mesa 12.0.5 is now available. Currently we have: >>> - 25 queued >>> - 0 nominated (

Re: [Mesa-dev] [PATCH 2/3] gallium: decrease the size of pipe_sampler_state fields

2016-12-02 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Not that it really makes a difference... Am 02.12.2016 um 21:38 schrieb Marek Olšák: > From: Marek Olšák > > We've had unused bits. > --- > src/gallium/include/pipe/p_state.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH 02/23] tgsi: add Stream{X, Y, Z, W} fields to tgsi_declaration_semantic

2016-12-02 Thread Roland Scheidegger
Am 02.12.2016 um 20:44 schrieb Nicolai Hähnle: > On 02.12.2016 19:46, Roland Scheidegger wrote: >> Am 02.12.2016 um 18:23 schrieb Nicolai Hähnle: >>> On 30.11.2016 21:37, Roland Scheidegger wrote: Am 30.11.2016 um 20:19 schrieb Nicolai Hähnle: > On 30.11.2016 19:06, Roland Scheidegger wrot

Re: [Mesa-dev] [PATCH 3/3] st/mesa: round lod_bias to a multiple of 1/256

2016-12-02 Thread Marek Olšák
On Fri, Dec 2, 2016 at 10:18 PM, Roland Scheidegger wrote: > Ideally this wouldn't be tied to specific hardware... That said, I > believe the clamping limits are sane (d3d10 will use these too). If GL > has some requirements for lod accuracy or if it's queryable, it should > probably honor this (d

Re: [Mesa-dev] [PATCH 3/6] winsys/amdgpu: use drmGetDevice[s]2 API

2016-12-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Dec 2, 2016 at 5:31 PM, Emil Velikov wrote: > From: Emil Velikov > > Analogous to previous commit > > Cc: Michel Dänzer > Signed-off-by: Emil Velikov > --- > src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_screen::resource_changed

2016-12-02 Thread Marek Olšák
Shouldn't this be in pipe_context if it does a copy? It's basically the opposite of flush_resource, right? Marek On Fri, Dec 2, 2016 at 4:27 PM, Philipp Zabel wrote: > Add a hook to tell drivers that an imported resource may have changed > and they need to update their internal derived resources

Re: [Mesa-dev] [PATCH 3/6] winsys/amdgpu: use drmGetDevice[s]2 API

2016-12-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Dec 2, 2016 at 5:31 PM, Emil Velikov wrote: > From: Emil Velikov > > Analogous to previous commit > > Cc: Michel Dänzer > Signed-off-by: Emil Velikov > --- > src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [Mesa-dev] Mesa 12.0.5 release candidate

2016-12-02 Thread Nanley Chery
On Fri, Dec 02, 2016 at 09:27:42PM +, Emil Velikov wrote: > On 2 December 2016 at 21:16, Emil Velikov wrote: > > On 2 December 2016 at 20:53, Nanley Chery wrote: > >> On Fri, Dec 02, 2016 at 08:15:16PM +, Emil Velikov wrote: > >>> Hello list, > >>> > >>> The candidate for the Mesa 12.0.5

[Mesa-dev] [PATCH] anv: Reject VkMemoryAllocateInfo::allocationSize == 0

2016-12-02 Thread Chad Versace
--- src/intel/vulkan/anv_device.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index d594df7d3b..e3d278df73 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -1246,11 +1246,8

Re: [Mesa-dev] [PATCH 16/22] anv/hiz: Perform HiZ resolves for all partial renders

2016-12-02 Thread Nanley Chery
On Fri, Oct 14, 2016 at 12:46:31PM -0700, Jason Ekstrand wrote: > On Wed, Oct 12, 2016 at 9:01 AM, Nanley Chery wrote: > > > On Tue, Oct 11, 2016 at 06:55:53PM -0700, Jason Ekstrand wrote: > > > On Tue, Oct 11, 2016 at 6:16 PM, Nanley Chery > > wrote: > > > > > > > On Mon, Oct 10, 2016 at 06:00:

Re: [Mesa-dev] [PATCH] anv: Reject VkMemoryAllocateInfo::allocationSize == 0

2016-12-02 Thread Nanley Chery
On Fri, Dec 02, 2016 at 02:37:32PM -0800, Chad Versace wrote: > --- > src/intel/vulkan/anv_device.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) This patch is, Reviewed-by: Nanley Chery > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index d59

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-02 Thread Edward O'Callaghan
patches 1 & 2 are, Reviewed-by: Edward O'Callaghan On 12/03/2016 07:38 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and > probably many other games too. > > cso_cache deletes sampler states when the cache size is too big a

Re: [Mesa-dev] [PATCH 06/23] radeonsi: update all GSVS ring descriptors for new buffer allocations

2016-12-02 Thread Edward O'Callaghan
On 12/01/2016 12:35 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes > GL45-CTS.gtf40.GL3Tests.transform_feedback3.transform_feedback3_geometry_instanced. Reviewed-by: Edward O'Callaghan > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/drivers/radeonsi/si_state_shade

[Mesa-dev] [Bug 98974] Can't see borders/empires in Stellaris

2016-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98974 Dylan Baker changed: What|Removed |Added CC||baker.dyla...@gmail.com -- You are receiv

[Mesa-dev] [Bug 98974] Can't see borders/empires in Stellaris

2016-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98974 Dylan Baker changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH v2 3/7] intel/blorp_blit: Adjust blorp surface parameters for split blits

2016-12-02 Thread Jordan Justen
On 2016-12-01 16:19:49, Jason Ekstrand wrote: > On Wed, Nov 30, 2016 at 8:12 PM, Jordan Justen > wrote: > > > + > > + x_offset_sa = (uint32_t)*x0 * px_size_sa.w + info->tile_x_sa; > > + y_offset_sa = (uint32_t)*y0 * px_size_sa.h + info->tile_y_sa; > > + isl_tiling_get_intratile_offset_sa(de

Re: [Mesa-dev] [PATCH] i915: Stop claiming GL 2.1 support.

2016-12-02 Thread Matt Turner
On Fri, Dec 2, 2016 at 12:22 PM, Emil Velikov wrote: > On 2 December 2016 at 19:49, Matt Turner wrote: >> A user reporting an unrelated bug (98964) said that he has to set >> MESA_GL_VERSION_OVERRIDE=1.4 when running Chromium otherwise it's too >> slow. I presume that it's attempting to use GL 2.

[Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-02 Thread Vinson Lee
HAVE_LLVM variable included the patch version if the LLVM version had a patch version. For LLVM version '4.0.0', HAVE_LLVM would be '0x0400.0'. Fixes: 45574ab2e92f ("configure.ac: better detection of LLVM version") Signed-off-by: Vinson Lee --- configure.ac | 2 +- 1 file changed, 1 insertion(+

[Mesa-dev] [PATCH] llvmpipe: Link tests with CLOCK_LIB.

2016-12-02 Thread Vinson Lee
Fix linking error with 'make check'. CXXLD lp_test_format ../../../../src/gallium/auxiliary/.libs/libgallium.a(os_time.o): In function `os_time_get_nano': /home/jenkins/workspace/mesa/src/gallium/auxiliary/os/os_time.c:59: undefined reference to `clock_gettime' Signed-off-by: Vinson Lee ---