Re: [Mesa-dev] [PATCH] glsl: don't flatten if-blocks with dynamic array indices

2016-11-18 Thread Nicolai Hähnle
On 18.11.2016 02:35, Dylan Baker wrote: Are you sure this is correct? Marek mentions in the referenced commit message that these pass on softpipe, and they work on i965 and i915 just fine. GLSL states very clearly that out-of-bounds array accesses lead to undefined behavior. Without this patch

Re: [Mesa-dev] [PATCH 1/2] gbm: automake: remove unused defines

2016-11-18 Thread Eduardo Lima Mitev
Series is: Reviewed-by: Eduardo Lima Mitev Thanks! On 11/17/2016 04:45 PM, Emil Velikov wrote: From: Emil Velikov Signed-off-by: Emil Velikov --- src/gbm/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gbm/Makefile.am b/src/gbm/Makefile.am index aba8d1e..e34c1d4 10064

Re: [Mesa-dev] Determinism in the results of llvmpipe?

2016-11-18 Thread Jose Fonseca
On 17/11/16 07:37, Andrew A. wrote: Hello, I'm using Mesa's software renderer for the purposes of regression testing in our graphics software. We render various scenes, save a screencap of the framebuffer for each scene, then compare those framebuffer captures to previously known-good captures.

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

2016-11-18 Thread Emil Velikov
On 17 November 2016 at 20:51, Kyriazis, George wrote: > > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On >> Behalf Of Emil Velikov >> Sent: Thursday, November 17, 2016 11:12 AM >> To: Kyriazis, George >> Cc: ML mesa-dev >> Subject: Re: [Mesa-de

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-18 Thread Emil Velikov
On 18 November 2016 at 04:27, George Kyriazis wrote: > Also, modify gen_knobs.py so that each invocation creates a single generated > file. This is more similar to how the other generators behave. > --- > src/gallium/SConscript | 1 + > src/gallium/drivers/swr/Makef

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Emil Velikov
On 17 November 2016 at 23:42, Marek Olšák wrote: > On Thu, Nov 17, 2016 at 4:06 PM, Emil Velikov > wrote: >> On 15 November 2016 at 16:57, Marek Olšák wrote: >>> On Tue, Nov 15, 2016 at 5:30 PM, Emil Velikov >>> wrote: On 15 November 2016 at 16:13, Marek Olšák wrote: > I think that

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Marek Olšák
On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov wrote: > On 17 November 2016 at 23:42, Marek Olšák wrote: >> On Thu, Nov 17, 2016 at 4:06 PM, Emil Velikov >> wrote: >>> On 15 November 2016 at 16:57, Marek Olšák wrote: On Tue, Nov 15, 2016 at 5:30 PM, Emil Velikov wrote: > On 15

[Mesa-dev] [Bug 98767] [swrast] ralloc.c:84: get_header: Assertion `info->canary == CANARY' failed.

2016-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98767 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] glsl: don't flatten if-blocks with dynamic array indices

2016-11-18 Thread Marek Olšák
Thanks! Reviewed-by: Marek Olšák Marek On Thu, Nov 17, 2016 at 10:59 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes the regression of radeonsi in > glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr > caused by commit 74e39de9324d2d2333cda6adca50ae2a3fc36de2.

[Mesa-dev] [PATCH] anv/state: enable coordinate address rounding for Min/Mag filters

2016-11-18 Thread Iago Toral Quiroga
This patch improves pass rate of dEQP-VK.texture.explicit_lod.2d.sizes.* from 68.0% (98/144) to 83.3% (120/144) by enabling sampler address rounding mode when the selected filter is not nearest, which is the same thing we do for OpenGL. These tests check texture filtering for various texture sizes

[Mesa-dev] [PATCH 00/10] mesa: support for EGL_ANDROID_native_fence_sync (vN+1)

2016-11-18 Thread Rob Clark
This patchset implements support for EGL_ANDROID_native_fence_sync[1] for egl and gallium. This extension provides support for native fence fd's (file descriptors) for the GPU. In a similar way to dma-buf fd's, which provide a reference-counted userspace handle to buffers which can be shared acro

[Mesa-dev] [PATCH 01/10] egl: initialize SyncCondition after attr parsing

2016-11-18 Thread Rob Clark
From: Rob Clark Reduce the noise in the next patch. For EGL_SYNC_NATIVE_FENCE_ANDROID the sync condition is conditional on EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute. Signed-off-by: Rob Clark --- src/egl/main/eglsync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/

[Mesa-dev] [PATCH 03/10] dri: extend fence extension to support native fd fences

2016-11-18 Thread Rob Clark
From: Rob Clark Required to implement EGL_ANDROID_native_fence_sync. Signed-off-by: Rob Clark --- include/GL/internal/dri_interface.h | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/inte

[Mesa-dev] [PATCH 02/10] egl: un-fallthrough sync attr parsing

2016-11-18 Thread Rob Clark
Doesn't work so well when you start having more than one possible attrib. Prep-work for next patch. Signed-off-by: Rob Clark --- src/egl/main/eglsync.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c index 005cb31..7b2c88

[Mesa-dev] [PATCH 04/10] egl: add EGL_ANDROID_native_fence_sync

2016-11-18 Thread Rob Clark
From: Rob Clark With fixes from Chad squashed in, plus fixes for issues that Rafael found while writing piglit tests. Cc: Chad Versace Cc: Rafael Antognolli Signed-off-by: Rob Clark --- src/egl/drivers/dri2/egl_dri2.c | 58 - src/egl/main/eglapi.c

[Mesa-dev] [PATCH 05/10] gallium: wire up server_wait_sync

2016-11-18 Thread Rob Clark
From: Rob Clark This will be needed for explicit synchronization with devices outside the gpu, ie. EGL_ANDROID_native_fence_sync. Signed-off-by: Rob Clark Reviewed-by: Marek Olšák --- src/gallium/include/pipe/p_context.h | 6 ++ src/gallium/state_trackers/dri/dri2.c | 6 +- 2 files c

[Mesa-dev] [PATCH 07/10] freedreno: some fence cleanup

2016-11-18 Thread Rob Clark
Prep-work for next patch, mostly move to tracking last_fence as a pipe_fence_handle (created now only in fd_gmem_render_tiles()), and a bit of superficial renaming. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_batch.c | 2 -- src/gallium/drivers/freedreno/freedreno

[Mesa-dev] [PATCH 06/10] gallium: support for native fence fd's

2016-11-18 Thread Rob Clark
From: Rob Clark This enables gallium support for EGL_ANDROID_native_fence_sync, for drivers which support PIPE_CAP_NATIVE_FENCE_FD. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_screen.c | 2 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers

[Mesa-dev] [PATCH 09/10] freedreno: no-op render when we need a fence

2016-11-18 Thread Rob Clark
If app tries to create a fence but there is no rendering to submit, we need a dummy/no-op submit. Use a string-marker for the purpose.. mostly since it avoids needing to realize that the packet format changes in later gen's (so one less place to fixup for a5xx). Signed-off-by: Rob Clark --- src

[Mesa-dev] [RFC 10/10] virgl: native fence fd support

2016-11-18 Thread Rob Clark
From: Gustavo Padovan --- src/gallium/drivers/virgl/virgl_context.c | 47 +++-- src/gallium/drivers/virgl/virgl_screen.c | 12 +++- src/gallium/drivers/virgl/virgl_winsys.h | 16 - src/gallium/winsys/virgl/drm/virgl_drm_winsys.c| 78 ++

[Mesa-dev] [PATCH 08/10] freedreno: native fence fd support

2016-11-18 Thread Rob Clark
Requires newer libdrm, and the support only is advertised with a sufficiently new kernel (v4.9 and later) as it depends on fence fd support in the submit ioctl. Signed-off-by: Rob Clark --- configure.ac | 2 +- src/gallium/drivers/freedreno/freedreno_batch.c

Re: [Mesa-dev] UDL & Modeset with Mesa 13.0.1 - Segmentation fault

2016-11-18 Thread Emil Velikov
On 17 November 2016 at 20:15, poma wrote: > > Airlie solved everything concerning the kernel, > so it seems, now it's user space turn. > > = mesa-libgbm-12.0.3 - works OK > ... > [ 714.429] (II) Loading sub module "glamoregl" > [ 714.429] (II) LoadModule: "glamoregl" > [ 714.430] (II) Loadin

Re: [Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

2016-11-18 Thread Iago Toral
On Thu, 2016-11-17 at 08:56 -0800, Jason Ekstrand wrote: > On Thu, Nov 17, 2016 at 4:43 AM, Iago Toral > wrote: > > Ah, I had missed this, ignore my comment then  :) > > > I just sent out a v2 of patch 7 and force-pushed my review branch if > you want to test things out. Yep, that fixes the prob

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

2016-11-18 Thread Emil Velikov
[Pardon for dropping in uninvited] On 15 November 2016 at 18:04, Marek Olšák wrote: > Immutable metadata (modifiers) stored in the kernel is the only > scalable (and thus usable) solution here. There was an argument > against _mutable_ metadata attached to BOs and the synchronization > hell it c

Re: [Mesa-dev] [PATCH 03/13] egl: update eglext.h

2016-11-18 Thread Emil Velikov
On 15 November 2016 at 14:24, Varad Gautam wrote: > +#ifndef EGL_MESA_platform_surfaceless > +#define EGL_MESA_platform_surfaceless 1 > +#define EGL_PLATFORM_SURFACELESS_MESA 0x31DD > +#endif /* EGL_MESA_platform_surfaceless */ > + Thinking out loud: is dropping the similar hunk from include/

Re: [Mesa-dev] [PATCH 04/13] egl/main: add support for fourth plane tokens

2016-11-18 Thread Emil Velikov
On 15 November 2016 at 14:24, Varad Gautam wrote: > From: Pekka Paalanen > > The EGL_EXT_dma_buf_import_modifiers extension adds support for a > fourth plane, just like DRM KMS API does. > > Bump maximum dma_buf plane count to four. > > Signed-off-by: Pekka Paalanen > Signed-off-by: Varad Gautam

Re: [Mesa-dev] [PATCH 08/10] freedreno: native fence fd support

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 08:39:37AM -0500, Rob Clark wrote: > +void fd_fence_server_sync(struct pipe_context *pctx, > + struct pipe_fence_handle *fence) > +{ > + struct fd_context *ctx = fd_context(pctx); > + struct fd_batch *batch = ctx->batch; > + > + if (sync_accumulate("f

Re: [Mesa-dev] [PATCH 06/13] st/dri: implement DRIimage creation from dmabufs with modifiers

2016-11-18 Thread Emil Velikov
On 15 November 2016 at 14:24, Varad Gautam wrote: > From: Varad Gautam > > support importing dmabufs into DRIimage taking format modifiers in > account, as per DRIimage extension version 14. > With the following discussion in mind [1] I'm wondering if we don't want to rework things to pass/store

Re: [Mesa-dev] [PATCH 08/10] freedreno: native fence fd support

2016-11-18 Thread Rob Clark
On Fri, Nov 18, 2016 at 9:20 AM, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 08:39:37AM -0500, Rob Clark wrote: >> +void fd_fence_server_sync(struct pipe_context *pctx, >> + struct pipe_fence_handle *fence) >> +{ >> + struct fd_context *ctx = fd_context(pctx); >> + struct fd_

Re: [Mesa-dev] [PATCH v2] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

2016-11-18 Thread Emil Velikov
On 16 November 2016 at 09:28, Varad Gautam wrote: > From: Pekka Paalanen > > allow creating EGLImages with dmabuf format modifiers when target is > EGL_LINUX_DMA_BUF_EXT for EGL_EXT_image_dma_buf_import_modifiers. > > v2: clear modifier assembling and error label name (Eric Engestrom) > > Signed-

Re: [Mesa-dev] [PATCH 08/13] egl: implement eglQueryDmaBufFormatsEXT

2016-11-18 Thread Emil Velikov
On 15 November 2016 at 14:24, Varad Gautam wrote: > From: Varad Gautam > > allow egl clients to query the dmabuf formats supported on this platform. > > Signed-off-by: Louis-Francis Ratté-Boulianne > Signed-off-by: Varad Gautam > --- > src/egl/drivers/dri2/egl_dri2.c | 87 > ++

Re: [Mesa-dev] [PATCH v2] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

2016-11-18 Thread Daniel Stone
Hi, On 18 November 2016 at 14:50, Emil Velikov wrote: > On 16 November 2016 at 09:28, Varad Gautam wrote: >> + if (nonzero_modifier_found && dri2_dpy->image->createImageFromDmaBufs2) { >> + dri_image = >> + dri2_dpy->image->createImageFromDmaBufs2(dri2_dpy->dri_screen, >> +

Re: [Mesa-dev] [PATCH] configure.ac: invert order for wayland-scanner check

2016-11-18 Thread Emil Velikov
Hi Gustavo, On 17 November 2016 at 18:57, Gustavo Zacarias wrote: > When cross-compiling the .pc file might point to the wrong > wayland-scanner binary (target rather than host) resulting in a > non-executable and wrong scanner. > Try searching the PATH first, and if that fails fall back into > p

Re: [Mesa-dev] [PATCH v2] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

2016-11-18 Thread Emil Velikov
On 18 November 2016 at 15:17, Daniel Stone wrote: > Hi, > > On 18 November 2016 at 14:50, Emil Velikov wrote: >> On 16 November 2016 at 09:28, Varad Gautam wrote: >>> + if (nonzero_modifier_found && dri2_dpy->image->createImageFromDmaBufs2) >>> { >>> + dri_image = >>> + dri2_dpy-

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

2016-11-18 Thread Marek Olšák
On Nov 18, 2016 2:55 PM, "Emil Velikov" wrote: > > [Pardon for dropping in uninvited] > > On 15 November 2016 at 18:04, Marek Olšák wrote: > > > Immutable metadata (modifiers) stored in the kernel is the only > > scalable (and thus usable) solution here. There was an argument > > against _mutable

Re: [Mesa-dev] [PATCH v2] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

2016-11-18 Thread Daniel Stone
Hi Emil, On 18 November 2016 at 15:24, Emil Velikov wrote: > On 18 November 2016 at 15:17, Daniel Stone wrote: >> Actually, present-and-zero modifier has a very well-defined meaning: >> it _forces_ linear interpretation of the buffer, whereas a non-present >> modifier may cause a kernel query (e

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

2016-11-18 Thread Emil Velikov
On 18 November 2016 at 15:26, Marek Olšák wrote: > On Nov 18, 2016 2:55 PM, "Emil Velikov" wrote: >> >> [Pardon for dropping in uninvited] >> >> On 15 November 2016 at 18:04, Marek Olšák wrote: >> >> > Immutable metadata (modifiers) stored in the kernel is the only >> > scalable (and thus usable

Re: [Mesa-dev] [RFC 10/10] virgl: native fence fd support

2016-11-18 Thread Robert Foss
Thanks for upstreaming this, this patch has been tested and confirmed working on a qemu setup. Tested-by: Robert Foss On Fri, 2016-11-18 at 08:39 -0500, Rob Clark wrote: > From: Gustavo Padovan > > --- >  src/gallium/drivers/virgl/virgl_context.c  | 47 +++- > - >  src/gallium/d

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Emil Velikov
On 18 November 2016 at 12:34, Marek Olšák wrote: > On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov > wrote: >> On 17 November 2016 at 23:42, Marek Olšák wrote: >>> On Thu, Nov 17, 2016 at 4:06 PM, Emil Velikov >>> wrote: On 15 November 2016 at 16:57, Marek Olšák wrote: > On Tue, Nov

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Nicolai Hähnle
On 18.11.2016 16:56, Emil Velikov wrote: On 18 November 2016 at 12:34, Marek Olšák wrote: On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov wrote: On 17 November 2016 at 23:42, Marek Olšák wrote: On Thu, Nov 17, 2016 at 4:06 PM, Emil Velikov wrote: On 15 November 2016 at 16:57, Marek Olšák

Re: [Mesa-dev] [PATCH 04/10] egl: add EGL_ANDROID_native_fence_sync

2016-11-18 Thread Rafael Antognolli
The first 4 patches of this series at least (including this one) work well on i915 when combined with the pending i915 patches for mesa, libdrm and kernel. Tested-by: Rafael Antognolli On Fri, Nov 18, 2016 at 08:39:33AM -0500, Rob Clark wrote: > From: Rob Clark > > With fixes from Chad squashe

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Kai Wasserbäch
Hi everybody, Nicolai Hähnle wrote on 18.11.2016 17:48: > On 18.11.2016 16:56, Emil Velikov wrote: >> On 18 November 2016 at 12:34, Marek Olšák wrote: >>> On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov >>> wrote: >>> [...] Speaking of patchwork, mostly I'm fine with it. There are some

Re: [Mesa-dev] [PATCH] anv/state: enable coordinate address rounding for Min/Mag filters

2016-11-18 Thread Jason Ekstrand
Thanks! Reviewed-by: Jason Ekstrand On Fri, Nov 18, 2016 at 4:44 AM, Iago Toral Quiroga wrote: > This patch improves pass rate of dEQP-VK.texture.explicit_lod.2d.sizes.* > from 68.0% (98/144) to 83.3% (120/144) by enabling sampler address > rounding mode when the selected filter is not nearest

[Mesa-dev] [PATCH v3] clover: restore support for LLVM <= 3.9

2016-11-18 Thread Vedran Miletić
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 ++ src

[Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

2016-11-18 Thread Vedran Miletić
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 ++ src

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Marek Olšák
On Fri, Nov 18, 2016 at 4:56 PM, Emil Velikov wrote: > On 18 November 2016 at 12:34, Marek Olšák wrote: >> On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov >> wrote: >>> On 17 November 2016 at 23:42, Marek Olšák wrote: On Thu, Nov 17, 2016 at 4:06 PM, Emil Velikov wrote: > On 15

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Marek Olšák
On Fri, Nov 18, 2016 at 7:45 PM, Kai Wasserbäch wrote: > Hi everybody, > Nicolai Hähnle wrote on 18.11.2016 17:48: >> On 18.11.2016 16:56, Emil Velikov wrote: >>> On 18 November 2016 at 12:34, Marek Olšák wrote: On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov wrote: [...] > Sp

[Mesa-dev] [PATCH] radeonsi: store group_size_variable in struct si_compute

2016-11-18 Thread Nicolai Hähnle
From: Nicolai Hähnle For compute shaders, we free the selector after the shader has been compiled, so we need to save this bit somewhere else. Also, make sure that this type of bug cannot re-appear, by NULL-ing the selector pointer after we're done with it. This bug has been there since the fea

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-18 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Friday, November 18, 2016 5:24 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for > windows >

Re: [Mesa-dev] [PATCH 11/70] glsl: create gl_program at the start of linking rather than the end

2016-11-18 Thread Emil Velikov
On 16 November 2016 at 21:47, Timothy Arceri wrote: > On Wed, 2016-11-16 at 21:17 +, Emil Velikov wrote: >> On 11 November 2016 at 00:45, Timothy Arceri >> wrote: >> > >> > This will allow us to directly store metadata we want to retain in >> > gl_program this metadata is currently stored in

[Mesa-dev] [PATCH 3/4] intel/aubinator: Fix the kernel start pointer for 3DSTATE_HS

2016-11-18 Thread Jason Ekstrand
--- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 0da01f4..f5e5167 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -442,9 +442,9 @@ handle_3dstate_hs(

[Mesa-dev] [PATCH 1/4] intel/aubinator: Properly handle batch buffer chaining

2016-11-18 Thread Jason Ekstrand
From: Jason Ekstrand The original aubinator that Kristian wrote had a bug in the handling of MI_BATCH_BUFFER_START that propagated into the version in upstream mesa. In particular, it ignored the "2nd level" bit which tells you whether this MI_BATCH_BUFFER_START is a subroutine call (2nd level) o

[Mesa-dev] [PATCH 2/4] intel/aubinator: Add a get_address helper

2016-11-18 Thread Jason Ekstrand
This new helper is automatically handles 32 vs. 48-bit GTT issues. It also handles 48-bit canonical addresses on Broadwell and above. --- src/intel/tools/aubinator.c | 47 ++--- 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/src/intel/tools

[Mesa-dev] [PATCH 4/4] intel/aubinator: Add a get_offset helper

2016-11-18 Thread Jason Ekstrand
The helper automatically handles masking for us so we don't have to worry about whether or not something is in the bottom bits. --- src/intel/tools/aubinator.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/inte

[Mesa-dev] [Bug 77662] Fail to render to different faces of depth-stencil cube map

2016-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77662 Nanley Chery changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 3/3] anv/cmd_buffer: Enable stencil-only HZ clears

2016-11-18 Thread Nanley Chery
On Thu, Nov 17, 2016 at 10:06:12PM -0800, Jason Ekstrand wrote: > On Wed, Oct 19, 2016 at 10:47 AM, Nanley Chery > wrote: > > > The HZ sequence modifies less state than the blorp path and requires > > less CPU time to generate the necessary packets. > > > > Signed-off-by: Nanley Chery > > --- >

Re: [Mesa-dev] [PATCH 14/70] mesa: create new gl_shader_program_data struct

2016-11-18 Thread Emil Velikov
On 11 November 2016 at 00:45, Timothy Arceri wrote: > This will be used to share data between gl_program and gl_shader_program > allowing for greater code simplification as we can remove a number of > awkward uses of gl_shader_program. > --- > src/mesa/main/mtypes.h| 25 ++

[Mesa-dev] [PATCH v5 04/11] gallium: Added SWR support for gdi

2016-11-18 Thread George Kyriazis
Added hooks for screen creation and swap. Still keep llvmpipe the default software renderer. v2: split from bigger patch v3: reword commit message Reviewed-by: Emil Velikov --- src/gallium/targets/libgl-gdi/libgl_gdi.c | 28 +++- 1 file changed, 23 insertions(+), 5 dele

[Mesa-dev] [PATCH v5 05/11] swr: Handle windows.h and NOMINMAX

2016-11-18 Thread George Kyriazis
Reorder header files so that we have a chance to defined NOMINMAX before mesa include files include windows.h v3: split from bigger patch Reviewed-by: Emil Velikov --- src/gallium/drivers/swr/swr_context.cpp | 16 src/gallium/drivers/swr/swr_context.h | 2 ++ src/gallium/dri

[Mesa-dev] [PATCH v5 06/11] swr: renamed duplicate swr_create_screen()

2016-11-18 Thread George Kyriazis
There are 2 swr_create_screen() functions. One in swr_loader.cpp, which is used during driver init, and the other is hiding in swr_screen.cpp, which ends up in the arch-specific .dll/.so. Rename the second one to swr_create_screen_internal(), to avoid confusion in header files. --- src/gallium/d

[Mesa-dev] [PATCH v5 00/11] Support windows builds for OpenSWR

2016-11-18 Thread George Kyriazis
Changes to support Windows scons builds for OpenSWR driver, since scons is the only supported build system for windows. Scons swr build will not work at this point. Also, windows scons swr build requires llvm version 3.9 (and above). Build on windows using the following command line: scons swr=

[Mesa-dev] [PATCH v5 10/11] gallium: swr: Added swr build for windows

2016-11-18 Thread George Kyriazis
v4: Add windows-specific gen_knobs.{cpp|h} changes v5: remove aggresive squashing of gen_knobs.py to this commit Reviewed-by: Emil Velikov --- src/gallium/SConscript | 1 + src/gallium/drivers/swr/SConscript | 216 + 2 files changed, 217 insertio

[Mesa-dev] [PATCH v5 08/11] scons: Add swr compile option

2016-11-18 Thread George Kyriazis
To buils The SWR driver (currently optional, not compiled by default) v3: add option as opposed to target Reviewed-by: Emil Velikov --- common.py | 1 + 1 file changed, 1 insertion(+) diff --git a/common.py b/common.py index fb0884e..704ad2e 100644 --- a/common.py +++ b/common.py @@ -110,5 +11

[Mesa-dev] [PATCH v5 02/11] scons: ignore .hpp files in parse_source_list()

2016-11-18 Thread George Kyriazis
Drivers that contain C++ .hpp files need to ignore them too, along with .h files, when building source file lists. Reviewed-by: Emil Velikov --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index bdb4039..544b15d 100644 ---

[Mesa-dev] [PATCH v5 03/11] scons: add llvm 3.9 support.

2016-11-18 Thread George Kyriazis
v2: reworded commit message Reviewed-by: Emil Velikov --- scons/llvm.py | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/scons/llvm.py b/scons/llvm.py index 1fc8a3f..977e47a 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -106,7 +106,24 @@ def generate

[Mesa-dev] [PATCH v5 07/11] swr: Windows-related changes

2016-11-18 Thread George Kyriazis
- Handle dynamic library loading for windows - Implement swap for gdi - fix prototypes - update include paths on configure-based build for swr_loader.cpp v2: split to multiple patches v3: split and reshuffle some more; renamed title v4: move Makefile.am changes to other commit. Modify header files

[Mesa-dev] [PATCH v5 09/11] swr: Modify gen_knobs.{cpp|h} creation script

2016-11-18 Thread George Kyriazis
Modify gen_knobs.py so that each invocation creates a single generated file. This is more similar to how the other generators behave. v5: remove Scoscript edits from this commit; moved to commit that first adds SConscript Acked-by: Emil Velikov --- src/gallium/drivers/swr/Makefile.am

[Mesa-dev] [PATCH v5 01/11] mesa: removed redundant #else

2016-11-18 Thread George Kyriazis
Reviewed-by: Emil Velikov --- src/util/macros.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/macros.h b/src/util/macros.h index 733bf42..6f55ac6 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -178,7 +178,6 @@ do { \ # elif defined(_MSC_VER) && !d

[Mesa-dev] [PATCH v5 11/11] gallium: Add support for SWR compilation

2016-11-18 Thread George Kyriazis
Include swr library and include -DHAVE_SWR in the compile line. v3: split to a separate commit Reviewed-by: Emil Velikov --- src/gallium/targets/libgl-gdi/SConscript | 4 src/gallium/targets/libgl-xlib/SConscript | 4 src/gallium/targets/osmesa/SConscript | 4 3 files change

Re: [Mesa-dev] [PATCH 15/70] st/mesa/glsl/nir/i965: make use of new gl_shader_program_data in gl_shader_program

2016-11-18 Thread Emil Velikov
Hi Tim, In general we could use the odd local variable to make things shorter (and cut down the number of derefs). That can (should?) be done once we're finished with the big churn. On 11 November 2016 at 00:45, Timothy Arceri wrote: > @@ -296,6 +296,8 @@ init_shader_program(struct gl_shader_pr

[Mesa-dev] [PATCH 2/2] st/va: fix gop size for rate control

2016-11-18 Thread boyuan.zhang
From: Boyuan Zhang The gop_size in rate control is the budget window for internal rate control calculation, and shouldn't always equal to idr period. Define a coefficient to let budget window contains a number of idr period for proper rate control calculation. Adjust the number of i/p frame rema

Re: [Mesa-dev] [PATCH 1/4] intel/aubinator: Properly handle batch buffer chaining

2016-11-18 Thread Kristian Høgsberg
On Fri, Nov 18, 2016 at 11:54 AM Jason Ekstrand wrote: > From: Jason Ekstrand > > The original aubinator that Kristian wrote had a bug in the handling of > MI_BATCH_BUFFER_START that propagated into the version in upstream mesa. > In particular, it ignored the "2nd level" bit which tells you whe

[Mesa-dev] [PATCH 1/2] st/va: force to submit two consecutive single jobs

2016-11-18 Thread boyuan.zhang
From: Boyuan Zhang When using dual instance and rate control, driver needs to submit jobs either in dual submissions or 2 consecutive single submissions to keep the pattern constant for rate control Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98005 Signed-off-by: Boyuan Zhang --- src/

Re: [Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

2016-11-18 Thread Vinson Lee
On Fri, Nov 18, 2016 at 10:57 AM, Vedran Miletić wrote: > The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM > 3.9 and older versionsin Clover. This patch restores it and refactors > the support using Clover compatibility layer for LLVM. > > Signed-off-by: Vedran Miletić > ---

Re: [Mesa-dev] [PATCH 14/70] mesa: create new gl_shader_program_data struct

2016-11-18 Thread Timothy Arceri
On Fri, 2016-11-18 at 20:35 +, Emil Velikov wrote: > On 11 November 2016 at 00:45, Timothy Arceri > wrote: > > > > This will be used to share data between gl_program and > > gl_shader_program > > allowing for greater code simplification as we can remove a number > > of > > awkward uses of gl_

Re: [Mesa-dev] [PATCH 05/10] gallium: wire up server_wait_sync

2016-11-18 Thread Marek Olšák
On Fri, Nov 18, 2016 at 2:39 PM, Rob Clark wrote: > From: Rob Clark > > This will be needed for explicit synchronization with devices outside > the gpu, ie. EGL_ANDROID_native_fence_sync. > > Signed-off-by: Rob Clark > Reviewed-by: Marek Olšák > --- > src/gallium/include/pipe/p_context.h | 6

[Mesa-dev] [Bug 98774] glsl/tests/warnings-test regression

2016-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98774 Bug ID: 98774 Summary: glsl/tests/warnings-test regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: bisected, hav

Re: [Mesa-dev] [PATCH 05/10] gallium: wire up server_wait_sync

2016-11-18 Thread Rob Clark
On Fri, Nov 18, 2016 at 5:07 PM, Marek Olšák wrote: > On Fri, Nov 18, 2016 at 2:39 PM, Rob Clark wrote: >> From: Rob Clark >> >> This will be needed for explicit synchronization with devices outside >> the gpu, ie. EGL_ANDROID_native_fence_sync. >> >> Signed-off-by: Rob Clark >> Reviewed-by: Ma

Re: [Mesa-dev] [PATCH 05/10] gallium: wire up server_wait_sync

2016-11-18 Thread Marek Olšák
On Fri, Nov 18, 2016 at 11:17 PM, Rob Clark wrote: > On Fri, Nov 18, 2016 at 5:07 PM, Marek Olšák wrote: >> On Fri, Nov 18, 2016 at 2:39 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> This will be needed for explicit synchronization with devices outside >>> the gpu, ie. EGL_ANDROID_native_fen

Re: [Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

2016-11-18 Thread Pierre Moreau
Mesa master builds again against LLVM 3.6. Tested-by: Pierre Moreau On 07:57 pm - Nov 18 2016, Vedran Miletić wrote: > The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM > 3.9 and older versionsin Clover. This patch restores it and refactors > the support using Clover compatib

Re: [Mesa-dev] [PATCH 07/12] docs/submittingpatches: flesh out "how to nominate" methods

2016-11-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Nov 16, 2016 at 7:46 PM, Emil Velikov wrote: > From: Emil Velikov > > Currently things are a bit buried within the text, making it harder to > find out. Move at the top and be clear what is _not_ a good idea. > > We had some people consistently using the

Re: [Mesa-dev] [PATCH] radeonsi: store group_size_variable in struct si_compute

2016-11-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 18, 2016 at 8:22 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > For compute shaders, we free the selector after the shader has been > compiled, so we need to save this bit somewhere else. Also, make sure that > this type of bug cannot re-appear

Re: [Mesa-dev] [PATCH] st/mesa: silence warnings in optimized builds

2016-11-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Nov 17, 2016 at 11:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Mark variables and static functions that only occur in assert()s as > MAYBE_UNUSED. > --- > src/mesa/state_tracker/st_sampler_view.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH] mesa: Add missing call to _mesa_unlock_debug_state(ctx);

2016-11-18 Thread Marek Olšák
On Wed, Nov 16, 2016 at 10:23 PM, Tom Stellard wrote: > cd724208d3e1e3307f84a794f2c1fc83b69ccf8a added a call to > _mesa_lock_debug_state(ctx) but wasn't unlocking the debug state. > > This fixes a hang in glsl-fs-loop piglit test with MESA_DEBUG=context. > --- > src/gallium/drivers/radeonsi/si_p

[Mesa-dev] [Bug 98740] bitcode.cpp:102:8: error: ‘Error’ is not a member of ‘llvm’

2016-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98740 Alejandro Vilicic changed: What|Removed |Added CC||alejandro.vilicich@inacapma

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-18 Thread Marek Olšák
On Wed, Nov 16, 2016 at 4:38 PM, Tom Stellard wrote: > On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: >> Have you looked at the shader-db impact? >> > > shader-db is mostly unchanged. There are a few decreases in SGPR usage and > code size, and a 4 byte increase in code size for

[Mesa-dev] [PATCH] glsl: add new program driver function to standalone compiler

2016-11-18 Thread Timothy Arceri
This fixes a regression with the standalone compiler caused by 9d96d3803ab5dc Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98774 --- src/compiler/glsl/standalone.cpp | 61 1 file changed, 43 insertions(+), 18 deletions(-) diff --git a/src/compil

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-18 Thread Tom Stellard
On Sat, Nov 19, 2016 at 01:09:00AM +0100, Marek Olšák wrote: > On Wed, Nov 16, 2016 at 4:38 PM, Tom Stellard wrote: > > On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: > >> Have you looked at the shader-db impact? > >> > > > > shader-db is mostly unchanged. There are a few decreas

[Mesa-dev] [Bug 98774] glsl/tests/warnings-test regression

2016-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98774 --- Comment #1 from Timothy Arceri --- Thanks, fix sent for review: https://lists.freedesktop.org/archives/mesa-dev/2016-November/135829.html -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

Re: [Mesa-dev] [PATCH] glsl: add new program driver function to standalone compiler

2016-11-18 Thread Timothy Arceri
On Sat, 2016-11-19 at 11:14 +1100, Timothy Arceri wrote: > This fixes a regression with the standalone compiler caused by > 9d96d3803ab5dc I forgot to add this: Note that we change standalone_compiler_cleanup() to no longer explicitly free the linked shaders as the will be freed when we free the

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-18 Thread Marek Olšák
On Sat, Nov 19, 2016 at 1:13 AM, Tom Stellard wrote: > On Sat, Nov 19, 2016 at 01:09:00AM +0100, Marek Olšák wrote: >> On Wed, Nov 16, 2016 at 4:38 PM, Tom Stellard wrote: >> > On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: >> >> Have you looked at the shader-db impact? >> >> >>

[Mesa-dev] [PATCH v5 03/20] configure.ac: Use new llvm_add_default_components

2016-11-18 Thread Tobias Droste
Signed-off-by: Tobias Droste Reviewed-by: Emil Velikov --- configure.ac | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 0c955bf..4f98c19 100644 --- a/configure.ac +++ b/configure.ac @@ -2242,11 +2242,7 @@ if test "x$enable_gallium_llvm"

[Mesa-dev] [PATCH v5 04/20] configure.ac: Use new helper function for LLVM

2016-11-18 Thread Tobias Droste
Use the new helper function to add LLVM targets and components. The components are added one by one to later find out which component is missing in case there is one. Signed-off-by: Tobias Droste Reviewed-by: Emil Velikov --- configure.ac | 25 ++--- 1 file changed, 18 inser

[Mesa-dev] [PATCH v5 06/20] configure.ac: Move LLVM functions to the top

2016-11-18 Thread Tobias Droste
This just moves code around so that all LLVM related stuff is at the top of the file in the correct order. No functional change. Signed-off-by: Tobias Droste Reviewed-by: Emil Velikov --- configure.ac | 151 +-- 1 file changed, 74 insertio

[Mesa-dev] [PATCH v5 18/20] configure.ac: Add required LLVM versions to the top

2016-11-18 Thread Tobias Droste
Consolidate the required LLVM versions at the top where the other versions for dependencies are listed. v5: Splitted out separate changes (see patch 19 and 20) Signed-off-by: Tobias Droste --- configure.ac | 68 +++- 1 file changed, 54 ins

[Mesa-dev] [PATCH v5 09/20] configure.ac: Use short names for r600 und r300

2016-11-18 Thread Tobias Droste
There are no non gallium r300 and r600 drivers anymore. No need to explicilty mention gallium here. Just cosmetics, no functional change. Signed-off-by: Tobias Droste Reviewed-by: Emil Velikov --- configure.ac | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure

[Mesa-dev] [PATCH v5 01/20] configure.ac: Don't search llvm-config if it's known

2016-11-18 Thread Tobias Droste
This way LLVM_CONFIG can bet set from an env variable if it's outside the $llvm_prefix. This is not a must, but it helps testing. Signed-off-by: Tobias Droste Reviewed-by: Emil Velikov --- configure.ac | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/configure.ac

[Mesa-dev] [PATCH v5 10/20] configure.ac: Check gallium LLVM version in gallium_require_llvm

2016-11-18 Thread Tobias Droste
This moves the LLVM version check to the helper function gallium_require_llvm() and uses the llvm_check_version_for() helper instead of open conding the LLVM version check. gallium_require_llvm is functionally the same as before, because "enable_gallium_llvm" is only set to "yes" if the host cpu i

[Mesa-dev] [PATCH v5 20/20] configure.ac: Create correct LLVM_VERSION_INT with minor >= 10

2016-11-18 Thread Tobias Droste
This makes sure that we handle LLVM minor version >= 10 correctly. Signed-off-by: Tobias Droste --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 5fc2c87..4cdd0cc 100644 --- a/configure.ac +++ b/configure.ac @@ -990,7 +990

[Mesa-dev] [PATCH v5 19/20] configure.ac: Get complete LLVM version from header

2016-11-18 Thread Tobias Droste
Major and minor version are included in the header file since LLVM version 3.1.0. Since the minimal required version is 3.3.0 we can remove the workaround if no values for major/minor were found in the header. Since LLVM 3.6.0 the patch version is inside the header file of LLVM. Only radeon driver

  1   2   >