> -----Original Message----- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Friday, November 18, 2016 5:24 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for > windows > > On 18 November 2016 at 04:27, George Kyriazis <george.kyria...@intel.com> > wrote: > > Also, modify gen_knobs.py so that each invocation creates a single > > generated file. This is more similar to how the other generators behave. > > --- > > src/gallium/SConscript | 1 + > > src/gallium/drivers/swr/Makefile.am | 15 +- > > src/gallium/drivers/swr/SConscript | 216 > +++++++++++++++++++++ > > .../drivers/swr/rasterizer/scripts/gen_knobs.py | 51 ++--- > > 4 files changed, 257 insertions(+), 26 deletions(-) create mode > > 100644 src/gallium/drivers/swr/SConscript > > > This is getting tiresome :'-( > > I've mentioned on multiple occasions to keep separate logical changes into > individual patches. > In my previous sounds I've _explicitly_ left only the ones (SConscript > fixes) that should be squashed here. > Please read review comments more carefully ? > I hope we can go past the confusion. Hopefully last set of patches will be posted in a bit.
> When sending version X of patch series, adding r-b/ack-b/t-b/other tags > (where applicable) and brief version history is highly recommended. > If in doubt on the latter - skim through git log + grep v2. > Appreciate the pointer; I am new to mesa check-in practices, and I didn't know. I think it's a good idea to add this info in the Mesa Development notes webpage, to make it more obvious (http://www.mesa3d.org/devinfo.html). Thanks, George > Thanks > Emil > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
