On Fri, Nov 18, 2016 at 7:45 PM, Kai Wasserbäch <k...@dev.carbon-project.org> wrote: > Hi everybody, > Nicolai Hähnle wrote on 18.11.2016 17:48: >> On 18.11.2016 16:56, Emil Velikov wrote: >>> On 18 November 2016 at 12:34, Marek Olšák <mar...@gmail.com> wrote: >>>> On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov <emil.l.veli...@gmail.com> >>>> wrote: >>>> [...] >>>>> Speaking of patchwork, mostly I'm fine with it. There are some >>>>> "drawbacks" though: >>>>> - some duplicated time will be spent tagging "self-rejected" patches. >>>>> I already track these based from the mailing list. >>>>> - it doesn't parse "Pick commit $sha, it addresses $issue" >>>>> nominations, so it cannot substitute/replace the mailing list. >>>>> In case my first point brought some "don't bother with the ML" type of >>>>> thoughts. >>>>> - you don't seem to be using it [1] so I'm not sure of the sudden >>>>> interest. >>>> >>>> Patchwork can't clear any of my patches on git push. That's normal. I >>>> do use Patchwork for reviewing patches though. >>>> >>> Seems to work fairly well here. Admittedly I have way less (and >>> smaller) patches... >> >> Patchwork is pretty dumb about how it compares patches. If you have >> non-standard >> git diff settings (e.g. more lines of context), it will never recognize a >> patch. > > wouldn't a tool like Phabricator be much better for reviewing and reliably > tracking whether a patch has landed or not? Especially if you use it in > combination with Arcanist? While I'm certainly not a core developer, I find > patchwork clunky. Sometimes it doesn't pick up R-bs or doesn't recognise > series, > which makes seeing the actual state of a patch a bit tricky from time to time. > > In addition you would get things like automatically closure of bugs, nice > referencing features and lots of other nice features. And AFAIK > freedesktop.org > already has a Phabricator instance, which could be used.
OK, off topic we go. I have some experience with Phabricator and Arcanist from LLVM and it's not very good. Phabricator (or Arcanist) doesn't support patch series. You can only submit one patch, or a range of commits as one patch (which is pretty bad - why would anyone on Earth want to do that). It also doesn't support downloading patches in the mbox format (only plain diffs). Based on that, I don't recommend it. Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
