Re: [Mesa-dev] [PATCH] i965: "Fix" aux offsets

Reviewed-by: Lionel Landwerlin On 16/11/16 01:35, Ben Widawsky wrote: From: Ben Widawsky When 1 BO is used for aux data, it needs to point to the correct offset, which will not be the BOs offset but instead an offset from the BOs offset. Since today there are always multiple BOs for aux, this

Re: [Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

On 16/11/16 01:35, Jordan Justen wrote: On 2016-11-15 16:21:27, Matt Turner wrote: Jordan, In commit 0041169cacb300a882b4dc38cd341f98bf2a7c38 Author: Jordan Justen Date: Fri Oct 21 12:56:49 2016 +0100 This date is not correct. In my branch it was: Date: Mon Jun 30 00:50:56 2014 + Y

Re: [Mesa-dev] [PATCH 1/7] intel: Convert devinfo->urb.max_*_entries into an array.

On Tue, Nov 15, 2016 at 05:53:56PM -0800, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/intel/common/gen_device_info.c | 144 > +-- > src/intel/common/gen_device_info.h | 10 ++- > src/intel/vulkan/genX_pipeline.c | 12 ++- > src/me

Re: [Mesa-dev] [PATCH 1/7] intel: Convert devinfo->urb.max_*_entries into an array.

On Tue, Nov 15, 2016 at 05:53:56PM -0800, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/intel/common/gen_device_info.c | 144 > +-- > src/intel/common/gen_device_info.h | 10 ++- > src/intel/vulkan/genX_pipeline.c | 12 ++- > src/me

[Mesa-dev] [PATCH 2/3] intel/isl: Add support for saving surface debug info to files

Signed-off-by: Jordan Justen --- src/intel/Makefile.sources | 1 + src/intel/isl/isl.h| 14 +++ src/intel/isl/isl_dump.c | 217 + 3 files changed, 232 insertions(+) create mode 100644 src/intel/isl/isl_dump.c diff --git a/src/intel/Makefi

[Mesa-dev] [PATCH 1/3] intel/blorp: Support map/unmap of blorp_address

Signed-off-by: Jordan Justen --- src/intel/blorp/blorp.h | 8 +++ src/mesa/drivers/dri/i965/brw_blorp.c | 39 +++ 2 files changed, 47 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 4351cb1..d891ba3 100644 ---

[Mesa-dev] [PATCH 3/3] intel/blorp_blit: Add option to dump surfaces on blits

Enabling this option causes the source and destination surfaces to be dumped out to debug files. The destination is dumped both before and after the blit operation. Signed-off-by: Jordan Justen --- src/intel/blorp/blorp_blit.c | 53 1 file changed, 53

Re: [Mesa-dev] [PATCH 5/7] i965: Drop brw->urb.{nr_*_entries, *_start} assignments from gen7_urb.c.

On Tue, Nov 15, 2016 at 05:54:00PM -0800, Kenneth Graunke wrote: > The context fields are for Gen4-5; setting them has always been useless. > There's no point in spending the cost in the hottest path in the driver. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen7_urb.c |

Re: [Mesa-dev] [PATCH 31/59] st/glsl_to_tgsi: add support for 64-bit integers. (v2)

On 15.11.2016 20:15, Ian Romanick wrote: On 11/15/2016 01:40 AM, Nicolai Hähnle wrote: On 10.11.2016 23:59, Ian Romanick wrote: On 10/27/2016 06:32 AM, Nicolai Hähnle wrote: This part is suspicious. It looks like the top two vector elements are written into a temporary register that isn't used

Re: [Mesa-dev] [PATCH 5/7] i965: Drop brw->urb.{nr_*_entries, *_start} assignments from gen7_urb.c.

On Wednesday, November 16, 2016 11:06:44 AM PST Pohjolainen, Topi wrote: > On Tue, Nov 15, 2016 at 05:54:00PM -0800, Kenneth Graunke wrote: > > The context fields are for Gen4-5; setting them has always been useless. > > There's no point in spending the cost in the hottest path in the driver. > >

Re: [Mesa-dev] [PATCH 1/7] intel: Convert devinfo->urb.max_*_entries into an array.

On Wednesday, November 16, 2016 10:56:32 AM PST Pohjolainen, Topi wrote: > On Tue, Nov 15, 2016 at 05:53:56PM -0800, Kenneth Graunke wrote: > > diff --git a/src/intel/common/gen_device_info.h > > b/src/intel/common/gen_device_info.h > > index 10324e6..3125a68 100644 > > --- a/src/intel/common/gen_

Re: [Mesa-dev] [PATCH 5/7] i965: Drop brw->urb.{nr_*_entries, *_start} assignments from gen7_urb.c.

On Wed, Nov 16, 2016 at 01:13:54AM -0800, Kenneth Graunke wrote: > On Wednesday, November 16, 2016 11:06:44 AM PST Pohjolainen, Topi wrote: > > On Tue, Nov 15, 2016 at 05:54:00PM -0800, Kenneth Graunke wrote: > > > The context fields are for Gen4-5; setting them has always been useless. > > > There

[Mesa-dev] [PATCH v2] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

From: Pekka Paalanen allow creating EGLImages with dmabuf format modifiers when target is EGL_LINUX_DMA_BUF_EXT for EGL_EXT_image_dma_buf_import_modifiers. v2: clear modifier assembling and error label name (Eric Engestrom) Signed-off-by: Pekka Paalanen Signed-off-by: Varad Gautam Reviewed-by

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

On Wed, Nov 16, 2016 at 12:25 PM, Michel Dänzer wrote: > On 15/11/16 11:24 PM, Varad Gautam wrote: >> From: Varad Gautam >> >> drivers should implement pipe_screen->get_modifiers_for_format and >> advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to support format >> modifier queries. > > Is ther

[Mesa-dev] [AppVeyor] mesa master #2706 failed

Build mesa 2706 failed Commit 6403a9e074 by Nicolai Hähnle on 11/8/2016 2:24 PM: radeonsi: fix a subtle bounds checking corner case with 3-component attributes\n\nI'm also sending out a piglit test, gl-2.0/vertexattribpointer-size-3,\nwhich exposes this corner

[Mesa-dev] [PATCH 1/4] mesa/main: consider multisampling enabled when number of samples == 1

From: Nicolai Hähnle There are some differences between how non-multisampled framebuffers (i.e. samples == 0) and multisampled framebuffers with a single sample should be treated. For example, alpha to coverage and writing to gl_SampleMask has an effect with single-sample multisample framebuffer

[Mesa-dev] [PATCH 3/4] radeonsi: allow sample mask export for single-sample framebuffers

From: Nicolai Hähnle This fixes GL45-CTS.sample_variables.mask.*.samples_1.*. --- src/gallium/drivers/radeonsi/si_state.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f8dfcf2.

[Mesa-dev] [PATCH 2/4] st/mesa: remove a redundant call to _mesa_is_multisample_enabled

From: Nicolai Hähnle We called it immediately prior, so re-use the previously returned value. --- src/mesa/state_tracker/st_atom_rasterizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c b/src/mesa/state_tracker/st_atom_rasteriz

[Mesa-dev] [PATCH 4/4] radeonsi: emit sample locations also when nr_samples == 1

From: Nicolai Hähnle Since the state tracker now enables MSAA in the hardware for the case nr_samples == 1 as well, we need to set sample locations correctly for this case. The Polaris override is still needed for the non-MSAA case (when nr_samples == 0). --- src/gallium/drivers/radeonsi/si_sta

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

On 16.11.2016 00:05, Brian Paul wrote: A number of drivers report useful debug/perf information accessible through GL_ARB_debug_output and with debug contexts (i.e. setting the GLX_CONTEXT_DEBUG_BIT_ARB flag). But few applications actually use the GL_ARB_debug_output extension. This change lets

Re: [Mesa-dev] [PATCH 3/3] [Bug 38970] [bisected]piglit glx/glx-pixmap-multi failed

On Thu, Oct 20, 2016 at 4:06 PM, Rahul Jain wrote: > > On Wed, Oct 19, 2016 at 1:24 AM, Nicolai Hähnle > wrote: > >> On 18.10.2016 19:23, Ian Romanick wrote: >> >>> On 09/29/2016 01:55 PM, Anutex wrote: >>> I tried to debug this issue with changing the condition to check only bad magic

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Use amdgcn intrinsics for fs interpolation

On 16.11.2016 03:14, Tom Stellard wrote: --- src/gallium/drivers/radeonsi/si_shader.c | 197 ++- 1 file changed, 143 insertions(+), 54 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 0410a32..306e12

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

Have you looked at the shader-db impact? I do think we should eventually do this, but llvm.SI.vs.load.input is ReadNone while llvm.amdgcn.buffer.load.* is only ReadOnly, so as long as we can't teach LLVM properly about no-aliasing and speculability, there may be performance regressions. Chee

Re: [Mesa-dev] [PATCH 1/4] mesa/main: consider multisampling enabled when number of samples == 1

This series is, Reviewed-by: Edward O'Callaghan On 11/16/2016 08:42 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > There are some differences between how non-multisampled framebuffers (i.e. > samples == 0) and multisampled framebuffers with a single sample should be > treated. For exampl

Re: [Mesa-dev] [PATCH 6/7] i965: Use arrays in Gen7+ URB code.

On Tue, Nov 15, 2016 at 05:54:01PM -0800, Kenneth Graunke wrote: > So much of this code was cut and pasted per stage. We can accomplish > much of it by looping over shader stages. I laid out original and new side-by-side and tried to compare things carefully. To me everything looks to match. Than

[Mesa-dev] [PATCH] u_simple_shaders: try to un-break the Windows build

From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_simple_shaders.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_simple_shaders.c b/src/gallium/auxiliary/util/u_simple_shaders.c index b46ec58..8be31be 100644 --- a/src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

On Tuesday, 2016-11-15 12:27:44 -0500, Rob Clark wrote: > see drm_fourcc.h (if the extension txt didn't mention that, perhaps it should) It does :) These attribute values together form an unsigned 64-bit value called a format modifier. Format modifiers are specified by drm_fourcc.

[Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 ++- sr

Re: [Mesa-dev] [PATCH] u_simple_shaders: try to un-break the Windows build

Acked-by: Edward O'Callaghan On 11/16/2016 09:27 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/util/u_simple_shaders.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_simple_shaders.c > b/src/galliu

[Mesa-dev] [AppVeyor] mesa master #2707 completed

Build mesa 2707 completed Commit fb17b7f99d by Nicolai Hähnle on 11/16/2016 10:26 AM: u_simple_shaders: try to un-break the Windows build\n\nAcked-by: Edward O'Callaghan Configure your notification preferences ___

[Mesa-dev] [PATCH] anv: don't try to free VK_NULL_HANDLE objects

Initial Vulkan documentation stated that it was invalid to free VK_NULL_HANDLE objects, however this has been changed. From the Vulkan 1.0.33 specification. 2.6.2. Implicit Valid Usage. Valid Usage for Object Handles: "It is valid to pass VK_NULL_HANDLE to any vkDestroy* or vkFree* command, which

Re: [Mesa-dev] [PATCH] anv: don't try to free VK_NULL_HANDLE objects

Never mind this, I just noticed that Jason has the same patch in his vulkan-cts fixes branch, I am not sure how I missed that. Iago On Wed, 2016-11-16 at 13:34 +0100, Iago Toral Quiroga wrote: > Initial Vulkan documentation stated that it was invalid to free > VK_NULL_HANDLE > objects, however th

Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

On Wednesday, 2016-11-16 08:29:27 +0200, Tapani Pälli wrote: > why not .. > > Reviewed-by: Tapani Pälli > > (note that there are other static functions that don't have '_' in them in > this file, also there is _eglConvertIntsToAttribs which looks like it could > be static (only one caller in sam

Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

On Tuesday, 2016-11-15 22:49:52 -0800, Matt Turner wrote: > On Tue, Nov 15, 2016 at 3:43 PM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > src/egl/main/eglapi.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/egl/main/eglapi.c b/src/

Re: [Mesa-dev] [PATCH 2/3] egl/wayland: remove non-applicable destroyDrawable from error path

On Friday, 2016-11-11 16:45:00 +, Emil Velikov wrote: > From: Emil Velikov > > If we fail to create the drawable there's not much point in attampting > to destroy it. > > Signed-off-by: Emil Velikov The rest of this series needs more work, but this patch is self-contained so it can be push

Re: [Mesa-dev] [PATCH] swr: [rasterizer] fix clear with multiple color attachments

Looks good (and concise), with the exception of a few styling issues (suggestions inlined) Reviewed-by: Bruce Cherniak after minor styling fixes. > On Nov 15, 2016, at 8:26 PM, Tim Rowley wrote: > > Fixes fbo-mrt-alphatest > --- > src/gallium/drivers/swr/rasterizer/core/api.cpp| 10 ++---

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: > Have you looked at the shader-db impact? > shader-db is mostly unchanged. There are a few decreases in SGPR usage and code size, and a 4 byte increase in code size for one shader. > I do think we should eventually do this, but ll

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

On 11/16/2016 02:56 AM, Nicolai Hähnle wrote: On 16.11.2016 00:05, Brian Paul wrote: A number of drivers report useful debug/perf information accessible through GL_ARB_debug_output and with debug contexts (i.e. setting the GLX_CONTEXT_DEBUG_BIT_ARB flag). But few applications actually use the G

Re: [Mesa-dev] [PATCH 4/4] radeonsi: emit sample locations also when nr_samples == 1

For the series: Reviewed-by: Marek Olšák Marek On Wed, Nov 16, 2016 at 10:42 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Since the state tracker now enables MSAA in the hardware for the case > nr_samples == 1 as well, we need to set sample locations correctly for > this case. > > Th

Re: [Mesa-dev] [PATCH] swr: [rasterizer] fix clear with multiple color attachments

Hi Tim, I mentioned this on IRC, but let me give a concise view here. First off - this is a vast improvement over the current state. Assuming the core bits are up to snuff, this is worth landing. Secondly - starting GL 3.2, layered attachments (and clears on them) are a thing. Currently SWR_SURF

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: > The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM > 3.9 and older versionsin Clover. This patch restores it and refactors > the support using Clover compatibility layer for LLVM. > > Signed-off-by: Vedran Miletić LGTM

[Mesa-dev] [Bug 98691] egl.h:55: error: redefinition of typedef ‘EGLDisplay’

https://bugs.freedesktop.org/show_bug.cgi?id=98691 Alejandro Vilicich changed: What|Removed |Added CC||jano.vili...@gmail.com -- You are

[Mesa-dev] [Bug 98691] egl.h:55: error: redefinition of typedef ‘EGLDisplay’

https://bugs.freedesktop.org/show_bug.cgi?id=98691 Alejandro Vilicich changed: What|Removed |Added Severity|normal |critical OS|Linux (

[Mesa-dev] [PATCH 00/20] RadeonSI: Optimized shader variants and other improvements

Hi, Patches 1-10 are random improvements. Patches 11-14 are cleanups. Patches 15-20 add support for optimized shader variants compiled asynchronously (without stalling rendering). The following optimizations are implemented for the shader variants: - If user clipping is disabled, clip distance

[Mesa-dev] [PATCH 01/20] gallium/radeon: add RADEON_SURF_OPTIMIZE_FOR_SPACE

From: Marek Olšák FORCE_TILING should disable it. It has no effect now, but that may change soon. --- src/gallium/drivers/radeon/r600_texture.c | 2 ++ src/gallium/drivers/radeon/radeon_winsys.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 4 +++- 3 files changed, 6 insertion

[Mesa-dev] [PATCH 05/20] radeonsi: decrease the number of texture slots to 24

From: Marek Olšák Company Of Heroes 2 needs only 24. This saves 512 bytes of CE RAM per shader stage. --- src/gallium/drivers/radeonsi/si_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.

[Mesa-dev] [PATCH 03/20] winsys/amdgpu: set addrlib flag opt4Space

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_surface.c b/src/gallium/winsys/amdgpu/drm/amdgpu_surface.c index d8ab28b..08989b5 100644 --- a/src/gallium/winsys/amdgpu/drm/amdgpu_surfa

[Mesa-dev] [PATCH 16/20] radeonsi: don't export ClipVertex and ClipDistance[] if clipping is disabled

From: Marek Olšák This is the first user of optimized monolithic shader variants. Cull distances can't be disabled by states. --- src/gallium/drivers/radeonsi/si_shader.c| 6 ++ src/gallium/drivers/radeonsi/si_shader.h| 5 +++-- src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 19/20] radeonsi: eliminate VS outputs that aren't used by PS at runtime

From: Marek Olšák A past commit added the ability to compile "optimized" shader variants asynchronously (not stalling the app). This commit builds upon that and adds what is basically a runtime shader linker. If a VS output isn't used by the currently-bound PS, a new VS compilation is started wi

[Mesa-dev] [PATCH 04/20] radeonsi: fast exit si_emit_derived_tess_state early

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 25 ++--- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.

[Mesa-dev] [PATCH 18/20] radeonsi: record information about all written and read varyings

From: Marek Olšák It's just tgsi_shader_info with DEFAULT_VAL varyings removed. --- src/gallium/drivers/radeonsi/si_shader.c| 22 src/gallium/drivers/radeonsi/si_shader.h| 10 ++-- src/gallium/drivers/radeonsi/si_state_shaders.c | 69 + 3 files ch

[Mesa-dev] [PATCH 14/20] radeonsi: don't set vs.epilog.export_prim_id if TES is bound

From: Marek Olšák there is no VS epilog in this case --- src/gallium/drivers/radeonsi/si_state_shaders.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 9df8f47..7

[Mesa-dev] [PATCH 02/20] radeonsi: check for !is_linear in do_hardware_msaa_resolve

From: Marek Olšák We don't want opt4Space here. --- src/gallium/drivers/radeonsi/si_blit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 075d76a..f5f49c1 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 20/20] radeonsi: remove all varyings for depth-only rendering or rasterization off

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 2 ++ src/gallium/drivers/radeonsi/si_state_shaders.c | 19 ++- 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 07/20] tgsi/scan: record if a shader writes the position output

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index f0dba0b..84d6456 100644 --- a/src/gallium/auxil

[Mesa-dev] [PATCH 11/20] radeonsi: split the shader key into 3 logical parts

From: Marek Olšák key->part.*: prolog and epilog flags only key->as_{ls,es}: special flags key->mono.*: flags for monolithic compilation only --- src/gallium/drivers/radeonsi/si_pipe.h | 4 +- src/gallium/drivers/radeonsi/si_shader.c| 194 src/gallium/

[Mesa-dev] [PATCH 08/20] radeonsi: assume that a VS without POSITION is LS

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 9e95fea..d0869e3 100644 --- a/src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH 06/20] tgsi/scan: use a big switch for scanning outputs

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 68 ++ 1 file changed, 28 insertions(+), 40 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 40a1340..f0dba0b 100644 --- a/src/gallium/a

[Mesa-dev] [PATCH 12/20] radeonsi: print all flags in si_dump_shader_key

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 4e73d59..c7028de 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/gall

[Mesa-dev] [PATCH 17/20] radeonsi: make si_shader_io_get_unique_index stricter

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 14 -- src/gallium/drivers/radeonsi/si_state_shaders.c | 11 ++- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 13/20] radeonsi: simplify checking for monolithic compilation

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 1 + src/gallium/drivers/radeonsi/si_shader.c| 9 + src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++ 4 files changed, 9 insertions(+), 8 delet

[Mesa-dev] [PATCH 15/20] radeonsi: add infrastr. for compiling optimized shader variants asynchronously

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 7 ++ src/gallium/drivers/radeonsi/si_state_shaders.c | 136 ++-- 2 files changed, 109 insertions(+), 34 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 09/20] radeonsi: clean up si_emit_clip_regs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 24c7b10..683a157 100644 --- a/src/gallium/drivers/radeonsi/si_state.

[Mesa-dev] [PATCH 10/20] radeonsi: fix culling if clip & cull distances are used at the same time

From: Marek Olšák Fixed piglits: - arb_cull_distance/clip-cull-3 - arb_cull_distance/clip-cull-4 --- src/gallium/drivers/radeonsi/si_state.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 00/12] docs: split devinfo.html, releasing.html et al.

Hi all, Here's a lovely series that's been baking for a while. Considering format and density (plus how often people read it) I've went ahead and split many things out of devinfo.html. Along the way a few HTML errors were squashed and some extensive releasing.html (et al.) came to be. Let's s

[Mesa-dev] [Bug 98691] egl.h:55: error: redefinition of typedef ‘EGLDisplay’

https://bugs.freedesktop.org/show_bug.cgi?id=98691 Daniel Stone changed: What|Removed |Added Product|a big freedesktop.org fly |Mesa |ribbon

[Mesa-dev] [PATCH 04/12] docs: split Submitting Patches into separate document

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/contents.html | 1 + docs/devinfo.html | 285 docs/submittingpatches.html | 309 3 files changed, 310 insertions(+), 285 deletions(-

[Mesa-dev] [PATCH 08/12] docs/submittingpatches: fix tags mis/abuse

From: Emil Velikov Fix the odd tag so that we're HTML 4.01 Traditional compliant Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 0ab..9af1cb7

[Mesa-dev] [PATCH 07/12] docs/submittingpatches: flesh out "how to nominate" methods

From: Emil Velikov Currently things are a bit buried within the text, making it harder to find out. Move at the top and be clear what is _not_ a good idea. We had some people consistently using the "bad" way and then being unhappy that their patches were missed/delayed. Cc: Marek Olšák Signed-

[Mesa-dev] [PATCH 05/12] docs/repository: refer to Submitting patches

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/repository.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/repository.html b/docs/repository.html index 784ae2c..e4731d2 100644 --- a/docs/repository.html +++ b/docs/repository.html @@ -75,7 +75,8 @@ follow

[Mesa-dev] [PATCH 01/12] docs: mention that coding style can differ between drivers

From: Emil Velikov ... and point people to use/honour the EditorConfig/Emacs files, where applicable. Signed-off-by: Emil Velikov --- docs/devinfo.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index afd92fd..c75fa8e 100644 --- a/docs/devin

[Mesa-dev] [PATCH 09/12] docs: flesh out releasing.html

From: Emil Velikov Properly document the whole process: - Brief on what, when, where - Picking, testing, branchpoints, pre-release announcement - Releasing, announcement, website and bugzilla updates Signed-off-by: Emil Velikov --- docs/devinfo.html | 239 - docs/r

[Mesa-dev] [PATCH 03/12] docs: split Codying style into separate document

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/codingstyle.html | 142 ++ docs/contents.html| 1 + docs/devinfo.html | 128 + 3 files changed, 145 insertions(+), 126 deletions(-) crea

[Mesa-dev] [PATCH 11/12] docs: rework/update install.html

From: Emil Velikov Still far from perfect, but a few small steps in the right direction. - Split build systems, compilers, third party tools - Mention building mesa for Android (part of AOSP) - Drop explicit "other" dependencies. Reference to disto methods to get them. - HTML 4.01 Traditiona

[Mesa-dev] [PATCH 06/12] docs/autoconf: update glx driver / enable-debug text

From: Emil Velikov With earlier commit we folded all the xlib handling in --enable-glx, but we forgot to update the documentation. Elaborate on --enable-debug and drop mentions about depenencies. Signed-off-by: Emil Velikov --- docs/autoconf.html | 31 +-- 1 file c

[Mesa-dev] [PATCH 12/12] docs: recommend using --enable-mangling over the manual -DUSE...

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/contents.html | 2 +- docs/mangling.html | 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/contents.html b/docs/contents.html index d2b63a3..c2fe391 100644 --- a/docs/contents.html +++ b/docs/contents.h

[Mesa-dev] [PATCH 10/12] docs: sourcetree.html misc updates

From: Emil Velikov A mixed bag of updates/fixes - mostly aiming at removing no longer applicable directories. Add a few more state-trackers, drivers, etc. alongside "XXX more" where applicable. Attribute for the GLSL/NIR movement and nukage of src/egl/docs. Signed-off-by: Emil Velikov --- doc

[Mesa-dev] [PATCH 02/12] docs: mention/suggest testing your patch against dEQP

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/devinfo.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index c75fa8e..58025e6 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -250,8 +250,9 @@ to update the tes

[Mesa-dev] [PATCH] vc4: Fix resource leak

Add missed free() CID 1394322 Signed-off-by: Mun Gwan-gyeong --- src/gallium/drivers/vc4/vc4_register_allocate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_register_allocate.c b/src/gallium/drivers/vc4/vc4_register_allocate.c index 72e453a..247467b 100644

Re: [Mesa-dev] [PATCH] i965: "Fix" aux offsets

On Tue, Nov 15, 2016 at 5:35 PM, Ben Widawsky wrote: > From: Ben Widawsky > > When 1 BO is used for aux data, it needs to point to the correct offset, > which will not be the BOs offset but instead an offset from the BOs > offset. Since today there are always multiple BOs for aux, this doesn't >

[Mesa-dev] [PATCH 02/13] spirv: Handle the InputAttachmentIndex decoration

--- src/compiler/spirv/vtn_private.h | 1 + src/compiler/spirv/vtn_variables.c | 4 2 files changed, 5 insertions(+) diff --git a/src/compiler/spirv/vtn_private.h b/src/compiler/spirv/vtn_private.h index 6f34f09..47579fe 100644 --- a/src/compiler/spirv/vtn_private.h +++ b/src/compiler/spir

[Mesa-dev] [PATCH 10/13] anv/cmd_buffer: Fix pipeline barriers for input attachments

We were using VK_IMAGE_ACCESS_COLOR_ATTACHMENT_READ_BIT to detect an input attachment read. We should use VK_IMAGE_ACCESS_INPUT_ATTACHMENT_READ_BIT instead. --- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.

[Mesa-dev] [PATCH 03/13] spirv: Stop warning about input attachments

--- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 9c5d331..9440341 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -2443,6

[Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

The lower_input_attachments pass that we're about to add will generate additional uses of system values and we want those to be reflected in gather_info. --- src/intel/vulkan/anv_pipeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/sr

[Mesa-dev] [PATCH 00/13] anv: Implement input attachments

This series adds input attachment support to the Intel Vulkan driver. It applies on top of my series to implement CCS. It can be found here: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=review/anv-input-att Jason Ekstrand (13): compiler: Add the rest of the subpassInput types spirv:

[Mesa-dev] [PATCH 04/13] nir: Add a layer_id system value intrinsic

--- src/compiler/nir/nir_intrinsics.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_intrinsics.h b/src/compiler/nir/nir_intrinsics.h index 00bd294..f45bfe2 100644 --- a/src/compiler/nir/nir_intrinsics.h +++ b/src/compiler/nir/nir_intrinsics.h @@ -328,6 +328,7 @@ SYSTEM_

[Mesa-dev] [PATCH 09/13] anv/pipeline: Add a input_attachment_index to the bindings

This allows us to go from the binding to either the descriptor or the input attachment at will. --- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 27 src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 30 insertions(+) diff --git a/src/intel/v

[Mesa-dev] [PATCH 05/13] i965/fs: Implement load_layer_id for fragment shaders

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index e84e371..864f754 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 01/13] compiler: Add the rest of the subpassInput types

There are actually 6 of them according to the GL_KHR_vulkan_glsl spec. --- src/compiler/builtin_type_macros.h | 7 ++- src/compiler/glsl_types.cpp| 20 +++- src/compiler/glsl_types.h | 1 + src/mesa/program/prog_to_nir.c | 1 + 4 files changed, 23 insert

[Mesa-dev] [PATCH 11/13] anv: Use pass attachment information to insert flushes

Input and resolve attachments can cause an implicit dependency in the pipeline. It's our job to insert the needed flushes. Fortunately, we can easily reuse the usage tracking that we use for CCS resolves. --- src/intel/vulkan/anv_blorp.c | 60 1 file

[Mesa-dev] [PATCH 08/13] anv/pass: Calculate the combined image usage of attachments

--- src/intel/vulkan/anv_pass.c| 12 +++- src/intel/vulkan/anv_private.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 8d7a43b..897adbd 100644 --- a/src/intel/vulkan/anv_pass.c +++ b/src/intel/vulk

[Mesa-dev] [PATCH 12/13] anv/pipeline: Handle depth/stencil self-dependencies

--- src/intel/vulkan/anv_pass.c | 4 src/intel/vulkan/anv_private.h | 3 +++ src/intel/vulkan/genX_pipeline.c | 30 -- 3 files changed, 31 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 897adbd..

[Mesa-dev] [PATCH 13/13] anv: Set up binding tables and surface states for input attachments

This commit adds the last remaining bits to support input attachments in the Intel Vulkan driver. For color and depth attachments, we allocate an input attachment surface state during vkCmdBeginRenderPass like we do for the render target surface states. This is so that we can incorporate the clea

[Mesa-dev] [PATCH 07/13] anv: Add an input attachment lowering pass

--- src/intel/vulkan/Makefile.sources | 1 + src/intel/vulkan/anv_nir.h | 2 + src/intel/vulkan/anv_nir_lower_input_attachments.c | 141 + src/intel/vulkan/anv_pipeline.c| 3 + 4 files changed, 147 insertions(+)

[Mesa-dev] [Bug 83596] reuse_framebuffer_texture_attachment does not set Layered field

https://bugs.freedesktop.org/show_bug.cgi?id=83596 Nanley Chery changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965: "Fix" aux offsets

On 16-11-16 11:25:32, Jason Ekstrand wrote: On Tue, Nov 15, 2016 at 5:35 PM, Ben Widawsky wrote: From: Ben Widawsky When 1 BO is used for aux data, it needs to point to the correct offset, which will not be the BOs offset but instead an offset from the BOs offset. Since today there are alway

Re: [Mesa-dev] [PATCH 08/70] mesa: make use of ralloc when creating ARB program instructions

On 11 November 2016 at 00:45, Timothy Arceri wrote: > This will allow us to move the ARB asm fields in gl_program into > a union as we will be able call ralloc_free() on the entire struct > when destroying the context. > --- > src/mesa/main/ffvertex_prog.c | 7 +++ > src/mesa/program/a

Re: [Mesa-dev] [PATCH] mesa: fix empty program log length

On 08/17/2016 01:18 AM, Tapani Pälli wrote: > In case we have empty log (""), we should return 0. This fixes > Khronos WebGL conformance test 'program-infolog'. > > From OpenGL ES 3.1 (and OpenGL 4.5 Core) spec: >"If pname is INFO_LOG_LENGTH , the length of the info log, including > a null

Re: [Mesa-dev] [PATCH 09/70] st/mesa/r200/i915/i965: move ARB program fields into a union

On 11 November 2016 at 00:45, Timothy Arceri wrote: > It's common for games to compile 2000 programs or more so at > > 32bits x 2000 programs x 22 fields x 2 (at least) stages > > This should give us something like 352 kilobytes in savings. > --- At first I was going to say "sed job", only to noti

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

On 16.11.2016 16:38, Tom Stellard wrote: On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: Have you looked at the shader-db impact? shader-db is mostly unchanged. There are a few decreases in SGPR usage and code size, and a 4 byte increase in code size for one shader. Okay, i

  1   2   >