Re: [Mesa-dev] [PATCH 8/9] i965/vec4: Handle saturated constants in opt_vector_float

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965/brw_vec4.cpp > index 155a550..02a00b3 100644

Re: [Mesa-dev] [PATCH] doc: document spilling options accepted by INTEL_DEBUG

2016-03-19 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-03-18 00:41:08, Iago Toral Quiroga wrote: > --- > docs/envvars.html | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/envvars.html b/docs/envvars.html > index 06aa0ac..6b5511b 100644 > --- a/docs/envvars.html > +++ b/docs/envvars.html > @@ -163,6

[Mesa-dev] [PATCH 2/4] st/mesa: simplify bitmap shader code with tgsi transform helper functions

2016-03-19 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_bitmap_shader.c | 45 +--- 1 file changed, 8 insertions(+), 37 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bitmap_shader.c b/src/mesa/state_tracker/st_cb_bitmap_shader.c index cddea36..88779bc 100644 --- a/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-19 Thread Jason Ekstrand
On Wed, Mar 16, 2016 at 2:01 AM, Iago Toral wrote: > On Wed, 2016-03-16 at 09:48 +0100, Samuel Iglesias Gonsálvez wrote: > > > > On 15/03/16 08:41, Iago Toral wrote: > > > On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > > [...] > > >> + nir_alu_type type; + union { - uint32_t u;

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #14 from Pekka Paalanen --- (In reply to Jose Fonseca from comment #13) > I wonder if 0xa8ec01b0 is some sort of funky device memory, or if that > device memory was destroyed before llvmpipe was done. > > After all this is SwapBuffer

Re: [Mesa-dev] [PATCH 7/9] i965/vec4: Don't allow type conversion in opt_vector_float

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 11:17 AM, Matt Turner wrote: > On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand > wrote: > > --- > > src/mesa/drivers/dri/i965/brw_vec4.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965

[Mesa-dev] [Bug 91556] [Clover / OpenCL] struct and union arguments handled incorrectly, producing CL_INVALID_ARG_SIZE

2016-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91556 --- Comment #12 from Pavan Yalamanchili --- Is this patch going through into a future release? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH mesa 4/6] nouveau: codegen: s/FILE_MEMORY_GLOBAL/FILE_MEMORY_BUFFER/

2016-03-19 Thread Ilia Mirkin
This approach leads to the emitters needing to know about both global and buffer, even though at that point, they are identical. I was thinking that in the lowering logic, buffer would just get rewritten as global (with the offset added), thus not needing any change to the emitters. What do you thi

[Mesa-dev] [PATCH] doc: add 'vec4' option in INTEL_DEBUG

2016-03-19 Thread Juan A. Suarez Romero
--- docs/envvars.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/envvars.html b/docs/envvars.html index 06aa0ac..e21b7c1 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -163,6 +163,7 @@ See the Xlib software driver page for details. blorp - emit messages about the blor

Re: [Mesa-dev] [PATCH] configure.ac: enable_asm=yes when x-compiling across same X86 arch

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 3:53 PM, dw kim wrote: > Matt, > > I uploaded v2 patch with corrected commit message. Other than > commit message, everything is still same. Can you please re-review > it and merge it if there's no issue? Pushed. Thanks! ___ mes

Re: [Mesa-dev] [PATCH 1/5] meta: Use the _mesa_meta_compile_and_link_program helper more places.

2016-03-19 Thread Pohjolainen, Topi
On Wed, Mar 16, 2016 at 12:12:58AM -0700, Kenneth Graunke wrote: > Less boilerplate. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/common/meta.c | 34 > - > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 14 +++--- > 2 files changed,

[Mesa-dev] need help to build mesa with ASAN

2016-03-19 Thread comic fans
Hello everyone, I'd like to build mesa with address sanitizer to help finding bugs , I''m using mesa-11.1.2 autogen.sh/configure with env CFLAGS="-fsanitize=address" CXXFLAGS="-fsanitize=address" LDFLAGS="-fsanitize=address" and then make, but it failed when linking .libs/pipe_r300.so with lots

Re: [Mesa-dev] [PATCH 2/9] nir/algebraic: Add two more fsat optimizations

2016-03-19 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

2016-03-19 Thread Jason Ekstrand
On Fri, Mar 4, 2016 at 5:43 AM, Andres Gomez wrote: > Hi, > > as complementary work to the one done to "Add FP64 support to the i965 > shader backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features > added by t

Re: [Mesa-dev] [PATCH 05/10] radeonsi: ignore PIPE_BIND_LINEAR in si_is_format_supported

2016-03-19 Thread Christian König
Am 09.03.2016 um 15:53 schrieb Marek Olšák: On Wed, Mar 9, 2016 at 4:54 AM, Michel Dänzer wrote: On 08.03.2016 21:21, Christian König wrote: From: Christian König Linear layout should work for all formats as well. The hardware actually doesn't support linear e.g. for compressed formats or d

[Mesa-dev] lvm pipe crash under windows

2016-03-19 Thread Jason Anderssen
Hi all, I was wondering if anyone knows of or has seen a crash when Mesa is compiled for with LVM Pipe ? The reason I ask is that if our user uses a compiled version of Mesa using the slower software render, it works fine, the moment we compile it with LVM, it crashes. I have an api trace that

[Mesa-dev] [PATCH 9/9] i965/vec4: Disable algebraic optimizations on floats

2016-03-19 Thread Jason Ekstrand
No shader-db change on Haswell --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 40 +- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 02a00b3..0a11991 100644 --- a/sr

Re: [Mesa-dev] [PATCH] nv50/ra: `isinf()` is in namespace `std` since C++11

2016-03-19 Thread Ilia Mirkin
On Mar 17, 2016 8:27 PM, "Matt Turner" wrote: > > On Thu, Mar 17, 2016 at 5:17 PM, Pierre Moreau wrote: > > This fixes a compile error while building Nouveau with C++11 enabled (and > > glibc >= 2.23). This happens if SWR is enabled, as it forces C++11. > > That seems bad, right? > > Enabling Ope

[Mesa-dev] [PATCH 00/12] compiler: Actually handle invariant and precise

2016-03-19 Thread Jason Ekstrand
Previously, the GLSL compiler successfully parsed the "invariant" and "precise" keywords and set bits on the variables, but we never did anything with them. This series adds code to propagate "invariant" and "precise" all the way thorugh NIR and bail in unsafe optimizations if we see it. The GLSL

[Mesa-dev] [PATCH 10/12] glsl/opt_algebraic: Don't handle invariant or precise trees

2016-03-19 Thread Jason Ekstrand
--- src/compiler/glsl/opt_algebraic.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/compiler/glsl/opt_algebraic.cpp b/src/compiler/glsl/opt_algebraic.cpp index 1e58062..2fea240 100644 --- a/src/compiler/glsl/opt_algebraic.cpp +++ b/src/compiler/glsl/opt_algebraic.cpp

[Mesa-dev] [PATCH 03/12] nir/search: Propagate exactness into newly created expressions

2016-03-19 Thread Jason Ekstrand
--- src/compiler/nir/nir_search.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c index 56d7e81..4cb2d4d 100644 --- a/src/compiler/nir/nir_search.c +++ b/src/compiler/nir/nir_search.c @@ -246,7 +246,7 @@ mat

[Mesa-dev] [PATCH 4/9] i965/fs: Get rid of all remaining algebraic optimizations for floats

2016-03-19 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 74 +--- 1 file changed, 18 insertions(+), 56 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 365231e..9f303d5 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Remove the RCP+RSQ peephole

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand wrote: > NIR already has this optimization and it can do much better than the little > peephole in the backend. > > No shader-db change on Broadwell. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 11 --- > 1 file changed, 11 deletions(-) >

Re: [Mesa-dev] [PATCH 1/5] nv50, nvc0: replace resInfoCBSlot by auxCBSlot

2016-03-19 Thread Pierre Moreau
Acked-by: Pierre Moreau On 09:55 PM - Mar 15 2016, Samuel Pitoiset wrote: > Having two different variables for the driver constant buffer slot > is confusing and really useless. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 3 +-- >

Re: [Mesa-dev] [PATCH] i965: Fix gl_TessLevelOuter[] for isolines.

2016-03-19 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-03-14 15:00:06, Kenneth Graunke wrote: > Thanks to James Legg for finding this! > > From the ARB_tessellation_shader spec: > "The number of isolines generated is derived from the first outer > tessellation level; the number of segments in each isoline is > de

[Mesa-dev] [PATCH 06/12] nir/cse: Properly handle nir_ssa_def.exact

2016-03-19 Thread Jason Ekstrand
--- src/compiler/nir/nir_instr_set.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_instr_set.c b/src/compiler/nir/nir_instr_set.c index 159ded0..00e4784 100644 --- a/src/compiler/nir/nir_instr_set.c +++ b/src/compiler/nir/nir_instr_set.c

[Mesa-dev] [PATCH 1/9] i965/fs: Remove the RCP+RSQ peephole

2016-03-19 Thread Jason Ekstrand
NIR already has this optimization and it can do much better than the little peephole in the backend. No shader-db change on Broadwell. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 0/9] i965: Remove unneeded algebraic optimizations

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand wrote: > This little series prepares the backend compiler for invariant and precise > by removing any potentially unsafe optimizations. The easiest > implementation for invariant and precise seems to be the same: Don't change > the semantics of in

[Mesa-dev] [PATCH 6/9] i965/vec4: Don't constant propagate saturated values

2016-03-19 Thread Jason Ekstrand
The FS backend bails as well. --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp index 92423e1..2dfe623 100644 --- a/sr

Re: [Mesa-dev] [PATCH] i965: Work around SIN/COS output range problem.

2016-03-19 Thread Martin Peres
On 16/03/16 19:33, Kenneth Graunke wrote: The SIN and COS instructions on Intel hardware can produce values slightly outside of the [-1.0, 1.0] range for a small set of values. Obviously, this can break everyone's expectations about trig functions. According to an internal presentation, the COS

[Mesa-dev] [PATCH 0/9] i965: Remove unneeded algebraic optimizations

2016-03-19 Thread Jason Ekstrand
This little series prepares the backend compiler for invariant and precise by removing any potentially unsafe optimizations. The easiest implementation for invariant and precise seems to be the same: Don't change the semantics of invariant or precise values. This means that we need to track what

Re: [Mesa-dev] [PATCH 3/4] mesa: simplify and inline _mesa_lookup_parameter_index()

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 6:14 PM, Timothy Arceri wrote: > The function has only one user and strings are always null terminated. > --- > src/mesa/program/ir_to_mesa.cpp | 2 +- > src/mesa/program/prog_parameter.c | 38 -- > src/mesa/program/prog_parameter.h |

Re: [Mesa-dev] [PATCH 4/4] mesa: inline _mesa_add_unnamed_constant()

2016-03-19 Thread Matt Turner
Series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Remove the RCP+RSQ peephole

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 10:45 AM, Matt Turner wrote: > On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand > wrote: > > NIR already has this optimization and it can do much better than the > little > > peephole in the backend. > > > > No shader-db change on Broadwell. > > --- > > src/mesa/drivers/

[Mesa-dev] [PATCH 01/12] nir: Add an "exact" bit to nir_alu_instr

2016-03-19 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 11 +++ src/compiler/nir/nir_clone.c | 1 + src/compiler/nir/nir_print.c | 2 ++ 3 files changed, 14 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 34f31eb..94b981b 100644 --- a/src/compiler/nir/nir.h +++ b/src/compile

[Mesa-dev] [PATCH mesa v2 2/2] nouveau: codegen: Add support for OpenCL global memory buffers

2016-03-19 Thread Hans de Goede
Add support for OpenCL global memory buffers, note this has only been tested with regular load and stores and likely needs more work for e.g. atomic ops. Signed-off-by: Hans de Goede --- Changes in v2: -Redo on top of new "Use FILE_MEMORY_BUFFER for buffers" patch --- src/gallium/drivers/nouveau

[Mesa-dev] [PATCH] i965/ir: Fix invalid bblock_t pointer dereference in dead_control_flow_eliminate.

2016-03-19 Thread Francisco Jerez
For the first basic block in the program 'block->prev()' would return an incorrectly cast list head sentinel and the subsequent 'prev_block->end()' dereference would read invalid memory. Introduced in c7deee69ea6f64ea5b563985bf19d9deebe73b5b. CC: Ian Romanick --- src/mesa/drivers/dri/i965/brw_d

[Mesa-dev] [PATCH] st/nine: specify WINAPI only for i386 and amd64

2016-03-19 Thread Christian Schmidbauer
Currently mesa fails building with the x32 abi as ms_abi is not defined in such a case. The patch uses ms_abi only for amd64 targets and stdcall only for i386 targets to be sure that those are defined. This patch additionally checks for __GNUC__ to guarantee that __attribute__ is available. ---

Re: [Mesa-dev] [PATCH] nv50/ra: `isinf()` is in namespace `std` since C++11

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 5:17 PM, Pierre Moreau wrote: > This fixes a compile error while building Nouveau with C++11 enabled (and > glibc >= 2.23). This happens if SWR is enabled, as it forces C++11. That seems bad, right? Enabling OpenSWR should affect how any other drivers are built. Why does

Re: [Mesa-dev] lvm pipe crash under windows

2016-03-19 Thread Roland Scheidegger
Am 17.03.2016 um 01:52 schrieb Jason Anderssen: > Hi all, > > I was wondering if anyone knows of or has seen a crash when Mesa is > compiled for with LVM Pipe ? > The reason I ask is that if our user uses a compiled version of Mesa > using the slower software render, it works fine, the moment we c

[Mesa-dev] [PATCH 11/20] radeonsi: Lower TGSI_OPCODE_LOAD down to LLVM op (v2)

2016-03-19 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: new signature style for buffer intrinsics --- I want to change the signature for buffer intrinsics while it is still feasible to do so; the only difference with v1 is two lines that are removed in buffer_append_args, but you'll need a new version of LLVM, which I've pushe

[Mesa-dev] [PATCH 4/4] st/mesa: clean up st_translate_texture_target()

2016-03-19 Thread Brian Paul
Reformat code. Improve assertion. --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 69 1 file changed, 44 insertions(+), 25 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index 8772efb..8a12ce4 100644

Re: [Mesa-dev] [PATCH 8/9] i965/vec4: Handle saturated constants in opt_vector_float

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 11:55 AM, Matt Turner wrote: > On Thu, Mar 17, 2016 at 11:52 AM, Jason Ekstrand > wrote: > > > > > > On Thu, Mar 17, 2016 at 11:18 AM, Matt Turner > wrote: > >> > >> On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand > >> wrote: > >> > --- > >> > src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH] i965: Set address rounding bits for GL_NEAREST filtering as well.

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 4:42 PM, Jordan Justen wrote: > On 2016-03-17 01:04:27, Kenneth Graunke wrote: > > Yuanhan Liu decided these were useful for linear filtering in > > commit 76669381 (circa 2011). Prior to that, we never set them; > > it seems he tried to preserve that behavior for nearest

Re: [Mesa-dev] [PATCH 3/9] i965/fs: Get rid of the sel.sat peephole

2016-03-19 Thread Francisco Jerez
Matt Turner writes: > On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand wrote: >> Shader-db results on Broadwell: >> >> total instructions in shared programs: 7517815 -> 7517816 (0.00%) >> instructions in affected programs: 46 -> 47 (2.17%) >> HURT: 1 >> >> Th

[Mesa-dev] Best way to create a debug version of Mesa

2016-03-19 Thread Jason Anderssen
Hi, This is probably a very simple question I hope, using scons, what is the easiest way to create a debug build, the Doc on the website I think only refers to Make-Config ? I am also cross compiling for windows. Cheers and thanks again in advance. Jason Internet Email Confidentiality Footer: T

[Mesa-dev] [PATCH] mesa: remove remaining tabs in prog_parameter.c

2016-03-19 Thread Timothy Arceri
--- src/mesa/program/prog_parameter.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/prog_parameter.c index 470c98e..02d84f2 100644 --- a/src/mesa/program/prog_parameter.c +++ b/src/mesa/program/prog_parame

Re: [Mesa-dev] [PATCH 01/12] nir: Add an "exact" bit to nir_alu_instr

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 6:10 PM, Matt Turner wrote: > On Thu, Mar 17, 2016 at 5:51 PM, Jason Ekstrand > wrote: > > --- > > src/compiler/nir/nir.h | 11 +++ > > src/compiler/nir/nir_clone.c | 1 + > > src/compiler/nir/nir_print.c | 2 ++ > > 3 files changed, 14 insertions(+) > >

[Mesa-dev] [PATCH mesa v2 3/3] gallium: Remove unused TGSI_RESOURCE_ defines

2016-03-19 Thread Hans de Goede
These magic file-index defines where only ever used in the nouveau code and that no longer uses them. Signed-off-by: Hans de Goede --- Changes in v2: -Split out of "nouveau: codegen: Disable more old resource handling code" --- src/gallium/include/pipe/p_shader_tokens.h | 9 - 1 file cha

Re: [Mesa-dev] [PATCH 4/4] st/mesa: clean up st_translate_texture_target()

2016-03-19 Thread Charmaine Lee
For the series: Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, March 16, 2016 5:43 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 4/4] st/mesa: clean up st_translate_texture_target() Reformat code. Improve assertio

[Mesa-dev] EXTENDED: 2016 X.Org Board of Directors Elections Nomination period is NOW

2016-03-19 Thread Peter Hutterer
We had a number of last-minute nominations and this did not give all nominees the chance to respond to the nominations. Hence, we are extending the nomination period for two weeks. All election dates thus move back by two weeks. Below is the original text of the nomination request email. We are s

[Mesa-dev] [PATCH 1/4] mesa: remove unused function

2016-03-19 Thread Timothy Arceri
--- src/mesa/program/prog_parameter.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/program/prog_parameter.h b/src/mesa/program/prog_parameter.h index c04d7a2..acc5b6c 100644 --- a/src/mesa/program/prog_parameter.h +++ b/src/mesa/program/prog_parameter.h @@ -99,12 +99,6 @@ _me

Re: [Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

2016-03-19 Thread Kai Wasserbäch
Edward O'Callaghan wrote on 19.03.2016 07:41: > Signed-off-by: Edward O'Callaghan > --- > docs/GL3.txt | 2 +- > docs/relnotes/11.3.0.html | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 3058996..b9fc86b 100644 > --- a/do

Re: [Mesa-dev] [PATCH 0/3] st/mesa, radeonsi: some MemoryBarrier fixes

2016-03-19 Thread eocallaghan
Hi Nicolai, This series is, Reviewed-by: Edward O'Callaghan Thanks, On 2016-03-19 14:37, Nicolai Hähnle wrote: Hi, these patches apply on top of my ARB_shader_image_load_store series. Together, they fix a few remaining fails with piglit's arb_shader_image_load_store-host-mem-barrier. You c

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Ilia Mirkin
On Thu, Mar 17, 2016 at 12:47 PM, Nicolai Hähnle wrote: > On 16.03.2016 19:43, Brian Paul wrote: >> >> The return type is float, which is what was implicitly used before, >> AFAICT. > > > Isn't this technically incorrect when the uploaded texture is integer? > > To be honest, it's not really clear

Re: [Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

2016-03-19 Thread eocallaghan
On 2016-03-19 21:08, Kai Wasserbäch wrote: Edward O'Callaghan wrote on 19.03.2016 07:41: Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 3058

Re: [Mesa-dev] [PATCH 12/12] nir/glsl: Propagate invariant into NIR alu ops

2016-03-19 Thread Francisco Jerez
Jason Ekstrand writes: > --- > src/compiler/nir/glsl_to_nir.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/compiler/nir/glsl_to_nir.cpp > b/src/compiler/nir/glsl_to_nir.cpp > index 613b138..f592c57 100644 > --- a/src/compiler/nir/glsl_to_nir.cpp > +++ b/src/compiler/nir/glsl

Re: [Mesa-dev] [PATCH 5/9] i965/fs: Don't constant-fold RCP

2016-03-19 Thread Matt Turner
This code predates me. I can't believe it's been useful for a long time. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Nicolai Hähnle
On 17.03.2016 11:50, Ilia Mirkin wrote: On Thu, Mar 17, 2016 at 12:47 PM, Nicolai Hähnle wrote: On 16.03.2016 19:43, Brian Paul wrote: The return type is float, which is what was implicitly used before, AFAICT. Isn't this technically incorrect when the uploaded texture is integer? To be h

[Mesa-dev] [PATCH 2/2] mesa: Do proper format error checks for GenerateMipmap in ES 3.x.

2016-03-19 Thread Kenneth Graunke
According to the OpenGL ES 3.2 spec's description of GenerateMipmap: "An INVALID_OPERATION error is generated if the levelbase array was not specified with an unsized internal format from table 8.3 or a sized internal format that is both color-renderable and texture-filterable according to tabl

[Mesa-dev] [PATCH] r300g: add missing layer argument to rws->buffer_get_handle() call

2016-03-19 Thread Brian Paul
Fixes compilation error since 5aea0d691. --- src/gallium/drivers/r300/r300_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r300/r300_texture.c b/src/gallium/drivers/r300/r300_texture.c index 22a613f..709345a 100644 --- a/src/gallium/drivers/r300/r

[Mesa-dev] [PATCH 1/4] tgsi: add tgsi_transform_op3_inst() function

2016-03-19 Thread Brian Paul
--- src/gallium/auxiliary/tgsi/tgsi_transform.h | 34 + 1 file changed, 34 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.h b/src/gallium/auxiliary/tgsi/tgsi_transform.h index 27e6179..4dd7dda 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_transfor

Re: [Mesa-dev] [PATCH] i965: Work around SIN/COS output range problem.

2016-03-19 Thread Kenneth Graunke
On Thursday, March 17, 2016 6:18:39 PM PDT Martin Peres wrote: > On 16/03/16 19:33, Kenneth Graunke wrote: > > The SIN and COS instructions on Intel hardware can produce values > > slightly outside of the [-1.0, 1.0] range for a small set of values. > > Obviously, this can break everyone's expectat

Re: [Mesa-dev] [PATCH 1/4] gallium/radeon: remove old CS tracing

2016-03-19 Thread Marek Olšák
Ping On Fri, Mar 11, 2016 at 4:01 PM, Marek Olšák wrote: > From: Marek Olšák > > Cons: > - it was only integrated in r600g > - it doesn't work with GPUVM > - it records buffer contents at the end of IBs instead of at the beginning, > so the replay isn't exact > - it lacks an IB parser and user

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in prog_parameter.c

2016-03-19 Thread Matt Turner
Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Fix stencil texturing in ES 3.1.

2016-03-19 Thread Kenneth Graunke
Stencil texturing is required by ES 3.1. Apparently we never actually turned it on, and we missed some necessary code. Fixes nine dEQP-GLES31.functional tests: stencil_texturing.format.stencil_index8_2d texture.border_clamp.formats.stencil_index8.nearest_size_pot texture.border_clamp.formats.ste

Re: [Mesa-dev] [PATCH 8/9] i965/vec4: Handle saturated constants in opt_vector_float

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 11:18 AM, Matt Turner wrote: > On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand > wrote: > > --- > > src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/sr

[Mesa-dev] [PATCH 3/3] nvc0: avoid using magic numbers for the uniform_bo offsets

2016-03-19 Thread Samuel Pitoiset
Instead make use of constants to improve readability. The first 32 bytes of the driver constant buffer are unknown... This doesn't seem to be used in the codegen part, but if the texBindBase offset is shifted from 0x20 to 0x00, this breaks the universe for really weird reasons. This sounds like to

[Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Brian Paul
The return type is float, which is what was implicitly used before, AFAICT. --- src/mesa/state_tracker/st_cb_texture.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index bffa4d0..6ee55c6 100644 --- a/src/

[Mesa-dev] [PATCH] st/mesa: use the texture view's format for render-to-texture

2016-03-19 Thread Nicolai Hähnle
From: Nicolai Hähnle Aside from the bug below, it fixes a simplistic test I've written locally, and I see no regression in Piglit for radeonsi. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94595 Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_cb_fbo.c | 22

Re: [Mesa-dev] [PATCH 2/2] glsl: Don't require matching interpolation qualifiers for newer GLSL

2016-03-19 Thread Tapani Pälli
On 03/16/2016 09:57 PM, Jordan Justen wrote: The OpenGLES GLSL 3.1 and OpenGL GLSL 4.3 specifications both remove the requirement for the output and input interpolation qualifiers to match. Note: I'm changing desktop OpenGL to allow the interpolation to differ, starting with 4.3, whereas the co

[Mesa-dev] [PATCH] compiler: Check if check_explicit_uniform_locations has failed.

2016-03-19 Thread Plamena Manolova
We should check whether check_explicit_uniform_locations has failed before we pass the number of explicit uniform locations to link_assign_uniform_locations. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94549#c3 --- src/compiler/glsl/linker.cpp | 7 ++- 1 file changed, 6 insertions(

[Mesa-dev] [PATCH 2/2] st/omx/dec: Correct the timestamping

2016-03-19 Thread Leo Liu
From: Nishanth Peethambaran Attach the timestamp to the dpb buffer and use that timestamp while pushing buffer from dpb list to the omx client. Reviewed-by: Christian König Signed-off-by: Nishanth Peethambaran Cc: "11.1 11.2" --- src/gallium/state_trackers/omx/vid_dec.c| 11 +

[Mesa-dev] [PATCH] doc: document spilling options accepted by INTEL_DEBUG

2016-03-19 Thread Iago Toral Quiroga
--- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 06aa0ac..6b5511b 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -163,6 +163,8 @@ See the Xlib software driver page for details. blorp - emit messages about the bl

Re: [Mesa-dev] Building Mesa and LLVM cross compiling Linux to Windows issue

2016-03-19 Thread Roland Scheidegger
I suspect you simply ran into an issue with old mesa and new llvm. Unfortunately some usage of the c++ abi of llvm is unavoidable, and the abi is unstable, thus breaking quite often. And we do not generally backport such fixes to older mesa releases (if only mostly because nobodoy would actually te

Re: [Mesa-dev] [PATCH] i965: Set address rounding bits for GL_NEAREST filtering as well.

2016-03-19 Thread Jordan Justen
On 2016-03-17 01:04:27, Kenneth Graunke wrote: > Yuanhan Liu decided these were useful for linear filtering in > commit 76669381 (circa 2011). Prior to that, we never set them; > it seems he tried to preserve that behavior for nearest filtering. > > It turns out they're useful for nearest filteri

Re: [Mesa-dev] [PATCH] nv50,nvc0: Fix invalid constant.

2016-03-19 Thread Pierre Moreau
On 06:34 PM - Mar 18 2016, Vinson Lee wrote: > Fix clang build error. > > CXX codegen/nv50_ir_lowering_nvc0.lo > codegen/nv50_ir_lowering_nvc0.cpp:1783:42: error: invalid suffix 'd' on > floating constant > Value *zero = bld.loadImm(NULL, 0.0d); >

Re: [Mesa-dev] [PATCH 8/9] i965/vec4: Handle saturated constants in opt_vector_float

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 11:52 AM, Jason Ekstrand wrote: > > > On Thu, Mar 17, 2016 at 11:18 AM, Matt Turner wrote: >> >> On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand >> wrote: >> > --- >> > src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 +++- >> > 1 file changed, 7 insertions(+), 1 deletion

[Mesa-dev] [PATCH v3] nv50/ir: Check for valid insn instead of def size

2016-03-19 Thread Pierre Moreau
Functions arguments get a definition from the function itself, a definition which is therefore not linked to any instruction. If a value ends up having a definition but no linked instruction, the register allocation pass doesn't need to consider that value. This fixes a null pointer dereference du

Re: [Mesa-dev] [PATCH 5/5] nvc0: shift driver constant buffer offsets by 32 bytes

2016-03-19 Thread Samuel Pitoiset
On 03/16/2016 11:17 AM, Samuel Pitoiset wrote: The offsets are wrong in this patch... But even after fixing them I have a few number of regressions (~10 piglit tests). Anyway, these changes are not too useful for now, so I'm going to get rid of it. I'll now try with Kepler. Confirmed, no reg

Re: [Mesa-dev] [PATCH 01/12] nir: Add an "exact" bit to nir_alu_instr

2016-03-19 Thread Francisco Jerez
Jason Ekstrand writes: > --- > src/compiler/nir/nir.h | 11 +++ > src/compiler/nir/nir_clone.c | 1 + > src/compiler/nir/nir_print.c | 2 ++ > 3 files changed, 14 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index 34f31eb..94b981b 100644 > ---

Re: [Mesa-dev] [PATCH 08/12] nir/alu_to_scalar: Propagate the "exact" bit

2016-03-19 Thread Francisco Jerez
Jason Ekstrand writes: > --- > src/compiler/nir/nir_lower_alu_to_scalar.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/nir/nir_lower_alu_to_scalar.c > b/src/compiler/nir/nir_lower_alu_to_scalar.c > index 312d2f9..082242e 100644 > --- a/src/compiler/nir/nir_lower_alu_to_

[Mesa-dev] [PATCH 1/2] st/omx: Remove trailing spaces

2016-03-19 Thread Leo Liu
From: Nishanth Peethambaran Reviewed-by: Christian König Signed-off-by: Nishanth Peethambaran Cc: "11.1 11.2" --- src/gallium/state_trackers/omx/vid_dec.c | 10 +++--- src/gallium/state_trackers/omx/vid_dec_h264.c | 8 ++--- src/gallium/state_trackers/omx/vid_enc.c | 44 +++

[Mesa-dev] [PATCH 09/12] glsl: Add a pass to propagate the "invariant" and "precise" qualifiers

2016-03-19 Thread Jason Ekstrand
--- src/compiler/Makefile.sources | 1 + src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/propagate_invariance.cpp | 125 + 4 files changed, 128 insertions(+) create mode 100644 src

Re: [Mesa-dev] [PATCH 10/21] nir/dominance: Handle unreachable blocks

2016-03-19 Thread Jason Ekstrand
On Wed, Feb 24, 2016 at 10:02 PM, Connor Abbott wrote: > I believe this is correct, and won't cause any issues with phi node > placement, etc. before dead_cf comes and gets rid any code in the > unreachable block(s). > > Reviewed-by: Connor Abbott > > BTW, I'd ask that you hold off on pushing th

Re: [Mesa-dev] [PATCH] compiler: Check if check_explicit_uniform_locations has failed.

2016-03-19 Thread Eduardo Lima Mitev
On 03/18/2016 04:41 PM, Plamena Manolova wrote: We should check whether check_explicit_uniform_locations has failed before we pass the number of explicit uniform locations to link_assign_uniform_locations. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94549#c3 --- src/compiler/glsl/li

[Mesa-dev] [PATCH 01/11] gallium/tgsi: pass TGSI tex target to tgsi_transform_tex_inst()

2016-03-19 Thread Brian Paul
Instead of hard-coded 2D tex target in tgsi_transform_tex_2d_inst() --- src/gallium/auxiliary/draw/draw_pipe_aaline.c| 10 +- src/gallium/auxiliary/tgsi/tgsi_transform.h | 17 ++--- src/gallium/auxiliary/util/u_pstipple.c | 10 +- src/mesa/state_tracke

Re: [Mesa-dev] [PATCH] meta: Make BlitFramebuffer() do sRGB encoding in ES 3.x.

2016-03-19 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-03-15 00:49:47, Kenneth Graunke wrote: > According to the ES 3.0 and GL 4.4 specifications, glBlitFramebuffer > is supposed to perform sRGB decoding and encoding whenever sRGB formats > are in use. The ES 3.0 specification is completely clear, and has > always

Re: [Mesa-dev] [PATCH] nv50,nvc0: Fix invalid constant.

2016-03-19 Thread Ilia Mirkin
On Mar 19, 2016 8:44 AM, "Pierre Moreau" wrote: > > On 06:34 PM - Mar 18 2016, Vinson Lee wrote: > > Fix clang build error. > > > > CXX codegen/nv50_ir_lowering_nvc0.lo > > codegen/nv50_ir_lowering_nvc0.cpp:1783:42: error: invalid suffix 'd' on floating constant > > Value *zero = bld.

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Ilia Mirkin
Why not derive this information from is_format_supported with rgba8 format? Seems like that would do the trick. Look at how the st already does something similar in st_extensions.c iirc. Your scheme only enables power-of-two msaa levels, and is redundant wrt the function I mentioned earlier... As

Re: [Mesa-dev] [PATCH] i965: Fix stencil texturing in ES 3.1.

2016-03-19 Thread Nanley Chery
On Wed, Mar 16, 2016 at 07:25:56PM -0700, Kenneth Graunke wrote: > Stencil texturing is required by ES 3.1. Apparently we never actually > turned it on, and we missed some necessary code. > > Fixes nine dEQP-GLES31.functional tests: > > stencil_texturing.format.stencil_index8_2d > texture.border

Re: [Mesa-dev] [PATCH 02/12] nir/builder: Add a flag for setting exact

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 5:51 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_builder.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h > index d546e41..1d61ff9 100644 > --- a/src/compiler/nir/nir_builder.h >

[Mesa-dev] [PATCH 4/4] st/mesa: emit sampler view declarations for ARB vert/frag programs

2016-03-19 Thread Brian Paul
--- src/mesa/state_tracker/st_mesa_to_tgsi.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index 8a12ce4..7a686b1 100644 --- a/src/mesa/state_tracker/st_mesa_to_tgsi.c +++ b/src/mesa/

[Mesa-dev] [PATCH 1/4] st/mesa: emit sampler view declaration in bitmap shader

2016-03-19 Thread Brian Paul
In June 2015, Rob Clark started updating the tgsi utility code to emit SVIEW declarations in various shaders (for polygon stipple, blitting, etc). These patches do the same for the Mesa state tracker. The VMware driver will use this. --- src/mesa/state_tracker/st_cb_bitmap_shader.c | 4 1 f

Re: [Mesa-dev] [PATCH 13/17] radeonsi: Enable ARB_framebuffer_no_attachments

2016-03-19 Thread Bas Nieuwenhuizen
On Sat, Mar 19, 2016 at 7:41 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c > b/src/gallium/drivers/radeonsi/si_pi

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Bas Nieuwenhuizen
That would limit us to supporting sample counts for which we have texture formats. As far as I understand with radeonsi we can support 16 samples without any attachments, but all formats are limited to <= 8 samples. - Bas On Sat, Mar 19, 2016 at 3:00 PM, Ilia Mirkin wrote: > Why not derive this

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Ilia Mirkin
On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen wrote: > That would limit us to supporting sample counts for which we have > texture formats. > > As far as I understand with radeonsi we can support 16 samples without > any attachments, but all formats are limited to <= 8 samples. So you're go

Re: [Mesa-dev] [PATCH 16/17] nvc0: Enable ARB_framebuffer_no_attachment

2016-03-19 Thread Ilia Mirkin
On Sat, Mar 19, 2016 at 2:41 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > b/src/gallium/driver

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #15 from comicfans44 --- (In reply to Pekka Paalanen from comment #14) > (In reply to Jose Fonseca from comment #13) > > I wonder if 0xa8ec01b0 is some sort of funky device memory, or if that > > device memory was destroyed before llv

Re: [Mesa-dev] [PATCH 3/9] i965/fs: Get rid of the sel.sat peephole

2016-03-19 Thread Matt Turner
On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand wrote: > Shader-db results on Broadwell: > > total instructions in shared programs: 7517815 -> 7517816 (0.00%) > instructions in affected programs: 46 -> 47 (2.17%) > HURT: 1 > > The one hurt shader is a shader f

  1   2   3   >