Matt Turner <matts...@gmail.com> writes: > On Thu, Mar 17, 2016 at 10:21 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> Shader-db results on Broadwell: >> >> total instructions in shared programs: 7517815 -> 7517816 (0.00%) >> instructions in affected programs: 46 -> 47 (2.17%) >> HURT: 1 >> >> The one hurt shader is a shader from "The Swapper" that writes to >> gl_FrontColor and, as such, gets an implicit sat added to the output write. >> Since this is invisible to NIR, the optimization in the previous commit >> can't fix it for us. >> --- > > How could this possibly cause problems? I don't understand why you're > trying to remove it.
Yeah, this optimization seems invariant- and precise-safe modulo the handling of NaNs in the src[1] >= 1.0 case (the <= 0 case is NaN and denorm-correct AFAICT because MOV.sat flushes them to zero just like 'SEL.sat.g(e) x, 0'), and it seems moderately useful, not sure it's a good plan to just get rid of it. > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
