Re: [Mesa-dev] [PATCH v5 40/70] nir: Implement __intrinsic_load_ssbo

On 22/09/15 20:57, Kristian Høgsberg wrote: > On Mon, Sep 21, 2015 at 11:03:41AM +0200, Samuel Iglesias Gonsálvez wrote: >> >> >> On 19/09/15 00:30, Kristian Høgsberg wrote: >>> On Thu, Sep 10, 2015 at 03:35:56PM +0200, Iago Toral Quiroga wrote: v2: - Fix ssbo loads with boolean variabl

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

On 19/09/15 01:56, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiroga wrote: >> Hi, >> >> this is the latest version of the ARB_shader_storage_buffer_object >> implementation. A good part of the frontend bits for this are already in >> master, but this adds so

Re: [Mesa-dev] [PATCH v5 02/70] i965: Use 16-byte offset alignment for shader storage buffers

On 23/09/15 02:28, Ben Widawsky wrote: > On Tue, Sep 15, 2015 at 11:37:22AM -0700, Kristian Høgsberg wrote: >> On Thu, Sep 10, 2015 at 03:35:18PM +0200, Iago Toral Quiroga wrote: >>> This is the same we do for other things like uniforms because it ensures >>> optimal performance. >>> >>> Reviewed

Re: [Mesa-dev] [PATCH] glsl: correctly detect inactive UBO arrays

Reviewed-by: Samuel Iglesias Gonsálvez On 23/09/15 05:23, Timothy Arceri wrote: > Previously the code was trying to get the packing type from the array not the > interface. > > Cc: Ian Romanick > Cc: Antia Puentes > --- > src/glsl/link_uniform_block_active_visitor.cpp | 6 ++ > src/glsl/o

[Mesa-dev] [PATCH 4/4] i965/gs/gen6: Maximum allowed size of SEND messages is 15 (4 bits)

Comit d48ac9306619 addressed this for VS, but we forgot to do the same for URB writes generated by the gen6 GS. --- src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp | 30 --- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_gs_visi

Re: [Mesa-dev] [PATCH 0/3] Make pull constant loads in gen6 start at MRFs 16/17

On Tue, 2015-09-22 at 14:00 +0200, Iago Toral Quiroga wrote: > Originally, these could conflict with our spills, but now that we moved the > latter to MRFs 21..23, that is no longer the case. Still, in gen6 we > now use MRFs 1..15 for URB writes, so we probably want to make our pull > constant load

[Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption

From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 9b94b39..eda7204 100644 --- a/s

[Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode

From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 6 ++ src/gallium/drivers/radeon/radeon_video.c | 5 + 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/s

[Mesa-dev] [PATCH 0/7] Enable GL_OES_geometry_shader for OpenGL ES 3.1

This is an initial patch set for enabling GL_OES_geometry_shader for OpenGL ES 3.1. For verification I am using the GL_EXT_geometry_shader tests that are part of the OpenGL ES 3.1 CTS suit. I keep the patches here: https://github.com/MartaLo/mesa/tree/gl_oes_geometry_shaders About the patches:

[Mesa-dev] [PATCH 3/7] mesa: Add extension enable for GL_OES_geometry_shader

From: Marta Lofstedt Exposes the GL_OES_geometry_shader extension for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + src/mesa/main/tests/dispatch_sanity.cpp | 3 +++ 3 files changed, 5 insertions(+)

[Mesa-dev] [PATCH 1/7] gles2: Update gl2ext.h to revision: 31902

From: Marta Lofstedt This is needed to be able to implement the accepted OES extensions. Signed-off-by: Marta Lofstedt --- include/GLES2/gl2ext.h | 921 - 1 file changed, 915 insertions(+), 6 deletions(-) diff --git a/include/GLES2/gl2ext.h b/in

[Mesa-dev] [PATCH 4/7] glsl: add support for GL_OES_geometry_shader

From: Marta Lofstedt This adds glsl support of GL_OES_geometry_shader for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/glsl/builtin_variables.cpp | 16 +--- src/glsl/glsl_parser.yy | 4 ++-- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h |

[Mesa-dev] [PATCH 2/7] glapi: add GL_OES_geometry_shader extension

From: Marta Lofstedt Adds xml definitions for the GL_OES_geometry_shader extension and exposes the glFrameBufferTexture function as an alias of glFramebufferTextureOES. Signed-off-by: Marta Lofstedt --- src/mapi/glapi/gen/apiexec.py | 2 +- src/mapi/glapi/gen/es_EXT.xml | 43 +

[Mesa-dev] [PATCH 6/7] mesa: Update _mesa_has_geometry_shaders

From: Marta Lofstedt Updates the _mesa_has_geometry_shaders function to also look for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. --- src/mesa/main/context.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/contex

[Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as started

From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 92941cf..e1c6049 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -238,7 +238,7 @@ GLES3.2, GLSL ES 3.2 GL_OES_copy_image

[Mesa-dev] [PATCH 5/7] mesa: enable enums for OES_geometry_shader

From: Marta Lofstedt Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 18 +++ src/mesa/main/get_hash_params.py | 50 2 files changed, 48 insertions(+), 20 deletions(-

Re: [Mesa-dev] [PATCH 2/2] nir/lower_vec_to_movs: Don't emit unneeded movs

On 09/23/2015 07:18 AM, Jason Ekstrand wrote: > > On Sep 22, 2015 10:01 PM, "Jason Ekstrand" > wrote: >> >> It's possible that, if a vecN operation is involved in a phi node, that we >> could end up moving from a register to itself. If swizzling is involved, >> we ne

[Mesa-dev] [PATCH 2/2] nir: Implement __intrinsic_load_ssbo

From: Iago Toral Quiroga v2: - Fix ssbo loads with boolean variables. v3: - Simplify the changes (Kristian) Reviewed-by: Connor Abbott --- src/glsl/nir/glsl_to_nir.cpp| 66 + src/glsl/nir/nir_intrinsics.h | 2 +- src/glsl/nir/nir_lower_ph

[Mesa-dev] [PATCH 0/2] Simplify nir_visitor::visit(ir_call *ir) changes for SSBO load

Following what Kristian suggested, I wrote these two patches. They are meant to be applied on top of: [PATCH v5 39/70] i965/vec4: Implement __intrinsic_store_ssbo replacing: [PATCH v5 40/70] nir: Implement __intrinsic_load_ssbo First patch moves nir_instr_insert_after_cf_list call into ea

[Mesa-dev] [PATCH 1/2] nir: modify the instruction insertion in nir_visitor::visit(ir_call *ir)

This patch moves nir_instr_insert_after_cf_list call into each case in the intrinsics switch at nir_visitor::visit(ir_call *ir) and define a nir_dest variable which will be used when handling ir->return_deref after the switch. This patch simplifies the code for nir_intrinsic_load_ssbo implementati

Re: [Mesa-dev] [PATCH] nir: Don't fuse fmul into ffma if used by more than 4 fadds.

On Tue, 2015-09-22 at 15:52 -0700, Matt Turner wrote: > total instructions in shared programs: 6596689 -> 6595563 (-0.02%) > instructions in affected programs: 103154 -> 102028 (-1.09%) > helped:253 > HURT: 217 > > It's kind of a

Re: [Mesa-dev] [PATCH v5 70/70] glsl: Mark as active all elements of shared/std140 block arrays

On 21/09/15 13:11, Samuel Iglesias Gonsálvez wrote: > On 21/09/15 09:41, Tapani Pälli wrote: >> Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on Haswell >> (most failing tests are with ubos). >> >> Tested-by: Tapani Pälli >> > > OK thanks! > >> This is individual patch not relat

[Mesa-dev] [Bug 92072] Wine breakage since d082c5324 (st/mesa: don't call st_validate_state in BlitFramebuffer)

https://bugs.freedesktop.org/show_bug.cgi?id=92072 Andrew Randrianasulu changed: What|Removed |Added Component|Mesa core |Drivers/DRI/nouveau Ass

Re: [Mesa-dev] [PATCH 03/17] mesa: fix deletion of inactive bound transform feedback object

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 30/07/15 07:02, Samuel Iglesias Gonsálvez wrote: > On Wed, 2015-07-29 at 12:31 -0700, Ian Romanick wrote: >> On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: >>> When a transform feedback object is bound and not active, the >>> OpenGL E

Re: [Mesa-dev] [PATCH 00/17] dEQP fixes

Hello, This is just a reminder. There are still patches of this series waiting for review: * [PATCH 01/17] glsl: Add variables to symbol table also for single declarations - http://lists.freedesktop.org/archives/mesa-dev/2015-July/090106.html * [PATCH 02/17] glsl: Add function parameter declara

Re: [Mesa-dev] [PATCH v5 25/70] glsl: Add std430 related member functions to glsl_type class

On 16/09/15 10:52, Samuel Iglesias Gonsálvez wrote: [...] As way of validation, have you tried running your modified script against any other drivers? They may well have bugs in them as well, but it should be possible to determine if the bug is in the script or the other impl,

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > Reviewed-by: Samuel Iglesias Gonsálvez > Forgot to say that we need to implement a similar patch for std430_size() function, right? I will write a follow-up patch adding std430 support for AoA. Sam > On 20/09/15 14:07, Timothy Arceri wrote:

Re: [Mesa-dev] [PATCH 3/7] mesa: Add extension enable for GL_OES_geometry_shader

First line of commit message reads weird, what about: mesa: Add GL_OES_geometry_shader to enabled extensions On 09/23/2015 10:42 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Exposes the GL_OES_geometry_shader extension for OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt > --- > src/

Re: [Mesa-dev] [PATCH 6/7] mesa: Update _mesa_has_geometry_shaders

On 09/23/2015 10:42 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Updates the _mesa_has_geometry_shaders function to also look > for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. > --- > src/mesa/main/context.h | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as started

On 09/23/2015 10:42 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Signed-off-by: Marta Lofstedt > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 92941cf..e1c6049 100644 > --- a/docs/GL3.txt > +++ b/docs/GL3

Re: [Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as started

On Wed, 2015-09-23 at 14:07 +0200, Eduardo Lima Mitev wrote: > On 09/23/2015 10:42 AM, Marta Lofstedt wrote: > > From: Marta Lofstedt > > > > Signed-off-by: Marta Lofstedt > > --- > > docs/GL3.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/docs/GL3.txt b/doc

Re: [Mesa-dev] [PATCH v5 70/70] glsl: Mark as active all elements of shared/std140 block arrays

On Wed, 2015-09-23 at 12:25 +0200, Samuel Iglesias Gonsálvez wrote: > > On 21/09/15 13:11, Samuel Iglesias Gonsálvez wrote: > > On 21/09/15 09:41, Tapani Pälli wrote: > > > Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on > > > Haswell > > > (most failing tests are with ubos). > > >

Re: [Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as started

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Iago Toral > Sent: Wednesday, September 23, 2015 3:18 PM > To: Eduardo Lima Mitev > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader a

Re: [Mesa-dev] [PATCH 2/2] nir/lower_vec_to_movs: Don't emit unneeded movs

On Sep 23, 2015 02:19, "Eduardo Lima Mitev" wrote: > > On 09/23/2015 07:18 AM, Jason Ekstrand wrote: > > > > On Sep 22, 2015 10:01 PM, "Jason Ekstrand" > > wrote: > >> > >> It's possible that, if a vecN operation is involved in a phi node, that we > >> could end up mo

Re: [Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as started

On Wed, 2015-09-23 at 14:34 +, Lofstedt, Marta wrote: > > -Original Message- > > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > > Behalf Of Iago Toral > > Sent: Wednesday, September 23, 2015 3:18 PM > > To: Eduardo Lima Mitev > > Cc: mesa-dev@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH v5 70/70] glsl: Mark as active all elements of shared/std140 block arrays

Hi! Timothy, thanks for your review. Seeing your patch in: http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.html The condition in my patch: (var->type->interface_packing != GLSL_INTERFACE_PACKING_PACKED) should also be changed to: (var->get_interface_type()->interface_packing

Re: [Mesa-dev] [PATCH 3/7] mesa: Add extension enable for GL_OES_geometry_shader

On Wed, Sep 23, 2015 at 4:42 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Exposes the GL_OES_geometry_shader extension for OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > src/mesa/

Re: [Mesa-dev] [PATCH 4/7] glsl: add support for GL_OES_geometry_shader

On Wed, Sep 23, 2015 at 4:42 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > This adds glsl support of GL_OES_geometry_shader for > OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt > --- > src/glsl/builtin_variables.cpp | 16 +--- > src/glsl/glsl_parser.yy | 4 ++-- >

Re: [Mesa-dev] [PATCH 6/7] mesa: Update _mesa_has_geometry_shaders

On Wed, Sep 23, 2015 at 4:36 AM, Eduardo Lima Mitev wrote: > On 09/23/2015 10:42 AM, Marta Lofstedt wrote: >> From: Marta Lofstedt >> >> Updates the _mesa_has_geometry_shaders function to also look >> for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. >> --- >> src/mesa/main/contex

Re: [Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption

Should these patches go to the stable branch as well? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/7] mesa: enable enums for OES_geometry_shader

On Wed, Sep 23, 2015 at 4:42 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/get.c | 18 +++ > src/mesa/main/get_hash_params.py | 50 > ++

Re: [Mesa-dev] [PATCH 05/12] i965/vec4/skl+: Use lcd2dms_w instead of lcd2dms

Ben Widawsky writes: >>} else if (op == ir_txf_ms) { >> emit(MOV(dst_reg(MRF, param_base + 1, sample_index.type, >> WRITEMASK_X), >>sample_index)); >> - if (devinfo->gen >= 7) { >> + if (opcode == SHADER_OPCODE_TXF_CMS_W) { >> +/*

Re: [Mesa-dev] [PATCH 5/7] mesa: enable enums for OES_geometry_shader

On Wed, Sep 23, 2015 at 8:45 AM, Ilia Mirkin wrote: > These 2 should probably be in the below GL_CORE/GLES31 section. As > probably should all or most of these, but ... meh. I guess someone > still has ARB_gs4 aspirations. I don't think so actually -- reading through these patches made me wonder

Re: [Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption

On 23.09.2015 17:34, Matt Turner wrote: Should these patches go to the stable branch as well? Good point, most likely yes. Thanks, Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-

Re: [Mesa-dev] [PATCH 1/2] nir/lower_vec_to_movs: Properly handle source modifiers on vecN ops

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] nir/lower_vec_to_movs: Don't emit unneeded movs

On Tue, Sep 22, 2015 at 10:01 PM, Jason Ekstrand wrote: > It's possible that, if a vecN operation is involved in a phi node, that we > could end up moving from a register to itself. If swizzling is involved, > we need to emit the move but. However, if there is no swizzling, then the > mov is a n

Re: [Mesa-dev] [PATCH 5/7] mesa: enable enums for OES_geometry_shader

On Wednesday, September 23, 2015 08:50:34 AM Matt Turner wrote: > On Wed, Sep 23, 2015 at 8:45 AM, Ilia Mirkin wrote: > > These 2 should probably be in the below GL_CORE/GLES31 section. As > > probably should all or most of these, but ... meh. I guess someone > > still has ARB_gs4 aspirations. >

[Mesa-dev] mesa: rework Driver.CopyImageSubData() and related code (v3)

Ilia, can you check that my updates to your temporary st_CopyImageSubData function still works with Bioshock Infinite? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: rework Driver.CopyImageSubData() and related code

Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker because we had to basically undo that wrapping. Instead, change ctx->Driver.CopyImageSubData() to take both gl_rende

Re: [Mesa-dev] mesa: rework Driver.CopyImageSubData() and related code (v3)

On Wed, Sep 23, 2015 at 12:53 PM, Brian Paul wrote: > Ilia, can you check that my updates to your temporary st_CopyImageSubData > function still works with Bioshock Infinite? I don't have a copy of the game. Unlike Valve, the publisher does not make their games freely available to mesa developers

Re: [Mesa-dev] [PATCH 06/12] i965/fs: Add a sampler program key for whether the texture is 16x MSAA

Ben Widawsky writes: > On Thu, Sep 17, 2015 at 05:00:08PM +0100, Neil Roberts wrote: >> When 16x MSAA is used for sampling with texelFetch the compiler needs >> to use a different instruction which passes more arguments for the MCS >> data. Previously on skl+ it was unconditionally using this new

[Mesa-dev] [PATCH v2] nir/cf: Alter block successors before adding a fake link.

Consider the case of "while (...) { break }". Or in NIR: block block_0 (0x7ab640): ... /* succs: block_1 */ loop { block block_1: /* preds: block_0 */ break /* succs: block_2 */ } block

Re: [Mesa-dev] [PATCH 0/2] Simplify nir_visitor::visit(ir_call *ir) changes for SSBO load

On Wed, Sep 23, 2015 at 3:07 AM, Samuel Iglesias Gonsalvez wrote: > Following what Kristian suggested, I wrote these two patches. They are > meant to be applied on top of: > >[PATCH v5 39/70] i965/vec4: Implement __intrinsic_store_ssbo > > replacing: > >[PATCH v5 40/70] nir: Implement __in

Re: [Mesa-dev] [PATCH 04/12] i965/fs/skl+: Use lcd2dms_w instead of lcd2dms

Ben Widawsky writes: >> + /* On Gen9+ we'll use lcd2ms_w instead which has two registers for >> + * the MCS data. >> + */ >> + if (op == SHADER_OPCODE_TXF_CMS_W) { >> +bld.MOV(retype(sources[length], BRW_REGISTER_TYPE_UD), >> +mcs.

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

On Wed, Sep 23, 2015 at 12:06 AM, Samuel Iglesias Gonsálvez wrote: > > > On 19/09/15 01:56, Kristian Høgsberg wrote: >> On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiroga wrote: >>> Hi, >>> >>> this is the latest version of the ARB_shader_storage_buffer_object >>> implementation. A good

Re: [Mesa-dev] [PATCH 06/11] nir/cf: Fix unlink_block_successors to actually unlink the second one.

Reviewed-by: Jason Ekstrand On Tue, Sep 22, 2015 at 8:01 PM, Kenneth Graunke wrote: > Calling unlink_blocks(block, block->successors[0]) will successfully > unlink the first successor, but then will shift block->successors[1] > down to block->successor[0]. So the successors[1] != NULL check wil

Re: [Mesa-dev] [PATCH 07/11] nir/cf: Fix dominance metadata in the dead control flow pass.

5, 6, and 7 are Reviewed-by: Jason Ekstrand On Tue, Sep 22, 2015 at 9:37 PM, Connor Abbott wrote: > On Tue, Sep 22, 2015 at 11:01 PM, Kenneth Graunke > wrote: >> The NIR control flow modification API churns the block structure, >> splitting blocks, stitching them back together, and so on. Pr

Re: [Mesa-dev] [PATCH 04/11] nir/cf: Conditionally do block_add_normal_succs() in unlink_jump();

Reviewed-by: Jason Ekstrand On Tue, Sep 22, 2015 at 8:01 PM, Kenneth Graunke wrote: > There is a bug where we mess up predecessors/successors due to the > ordering of unlinking/recreating edges/adding fake edges. In order to > fix that, I need everything in one routine. > > However, calling blo

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode

Hi, On 23.09.2015 10:11, Christian König wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > Reviewed-by: Christian König > --- Thanks, nice to see this finally getting fixed, and it was a pretty simple thing after all... well, not quite yet apparently. Sometimes playback works corr

Re: [Mesa-dev] [PATCH 06/12] i965/fs: Add a sampler program key for whether the texture is 16x MSAA

On Wed, Sep 23, 2015 at 06:08:33PM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > > On Thu, Sep 17, 2015 at 05:00:08PM +0100, Neil Roberts wrote: > >> When 16x MSAA is used for sampling with texelFetch the compiler needs > >> to use a different instruction which passes more arguments for t

Re: [Mesa-dev] [PATCH] meta: Handle array textures in scaled MSAA blits

On Tue, Sep 22, 2015 at 3:00 PM, Ian Romanick wrote: > From: Ian Romanick > > The old code had some significant problems with respect to > sampler2DArray textures. The biggest problem was that some of the code > would use vec3 for the texture coordinate type, and other parts of the > code would

Re: [Mesa-dev] [RFC] nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

On Tue, Sep 22, 2015 at 4:20 PM, Jason Ekstrand wrote: > On Tue, Sep 22, 2015 at 4:04 PM, Matt Turner wrote: >> On Fri, Sep 18, 2015 at 12:49 AM, Eduardo Lima Mitev >> wrote: >>> When both fadd and fmul instructions have at least one operand that is a >>> constant and it is only used once, the

Re: [Mesa-dev] [PATCH 04/12] i965/fs/skl+: Use lcd2dms_w instead of lcd2dms

On Wed, Sep 23, 2015 at 06:28:42PM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > >> + /* On Gen9+ we'll use lcd2ms_w instead which has two registers > >> for > >> + * the MCS data. > >> + */ > >> + if (op == SHADER_OPCODE_TXF_CMS_W) { > >> +b

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode

Hi Grigori, On 23.09.2015 19:46, Grigori Goronzy wrote: Hi, On 23.09.2015 10:11, Christian König wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Christian König --- Thanks, nice to see this finally getting fixed, and it was a pretty simple thing after all... well, not q

[Mesa-dev] [RFC v1] i965/vec4: add a swizzle check on the uniform bail condition

Without this commit, an uniform is bailed out if the instruction has 3 sources. This commit allow to go on if the combined swizzle is a single value. WIP: it can be clearly cleaned, as the condition is somewhat ugly right now. Shader-db results for vec4 programs on Haswell: total instruction

Re: [Mesa-dev] [PATCH] i965: add ARB_texture_barrier support

As Eric mentioned, we may not *need* the extra PIPE_CONTROL. However, that's going to take some thinking and it's mostly a performance thing; this patch should be correct. Reviewed-by: Jason Ekstrand On Thu, Sep 10, 2015 at 5:56 PM, Ilia Mirkin wrote: > ping > > On Thu, Aug 13, 2015 at 3:42 PM

Re: [Mesa-dev] [RFC v1] i965/vec4: add a swizzle check on the uniform bail condition

On Sep 23, 2015 12:29, "Alejandro Piñeiro" wrote: > > Without this commit, an uniform is bailed out if the instruction > has 3 sources. This commit allow to go on if the combined > swizzle is a single value. This is interesting and, in general, I like it. > WIP: it can be clearly cleaned, as the

Re: [Mesa-dev] [RFC v1] i965/vec4: add a swizzle check on the uniform bail condition

On Wed, Sep 23, 2015 at 12:29 PM, Alejandro Piñeiro wrote: > Without this commit, an uniform is bailed out if the instruction "an uniform" -> "a uniform" (because the 'u' actually makes a consonant sound) I'm not sure what is meant by "bailed out" > has 3 sources. This commit allow to go on if

[Mesa-dev] [PATCH] radeon/vce: fix vui time_scale zero error

if app pass 0 as frame_rate_num, it should not be encoded to the VUI. Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Reviewed-by: Christian König Cc: "10.6" --- src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/r

Re: [Mesa-dev] [RFC v1] i965/vec4: add a swizzle check on the uniform bail condition

On Wed, Sep 23, 2015 at 1:07 PM, Jason Ekstrand wrote: > On Sep 23, 2015 12:29, "Alejandro Piñeiro" wrote: >> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp >> b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp >> index d3f0ddd..400a13a 100644 >> --- a/src/mesa/driver

Re: [Mesa-dev] [RFC v1] i965/vec4: add a swizzle check on the uniform bail condition

On Wed, Sep 23, 2015 at 1:15 PM, Matt Turner wrote: > On Wed, Sep 23, 2015 at 1:07 PM, Jason Ekstrand wrote: >> On Sep 23, 2015 12:29, "Alejandro Piñeiro" wrote: >>> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp >>> b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp

[Mesa-dev] [PATCH] android: radeonsi: fix sid_tables.h missing LOCAL_MODULE_CLASS

--- src/gallium/drivers/radeonsi/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/Android.mk b/src/gallium/drivers/radeonsi/Android.mk index b469aca..7e5e54b 100644 --- a/src/gallium/drivers/radeonsi/Android.mk +++ b/src/gallium/drivers/radeonsi/Android.

[Mesa-dev] [PATCH] android: fix shader_enums.c building error

Android.mk in src/mesa/program folder needs an adjustement, because shader_enums.c can only be found in the relative path ../../glsl/shader_enums.c --- src/mesa/program/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/Android.mk b/src/mesa/program/An

Re: [Mesa-dev] [PATCH 2/2] mesa: Moves up error check for subtexture dimensions

On Tue, Sep 15, 2015 at 3:01 PM, Eduardo Lima Mitev wrote: > On 09/15/2015 09:23 PM, Jason Ekstrand wrote: >> On Tue, Sep 15, 2015 at 4:47 AM, Eduardo Lima Mitev wrote: >>> For consistency and efficiency, the (sub)texture dimension error check >>> should go before the validation of format, type a

Re: [Mesa-dev] [PATCH] mesa: fix mipmap generation for immutable, compressed textures

Ping? Am 20.09.2015 um 04:33 schrieb srol...@vmware.com: > From: Roland Scheidegger > > If the immutable compressed texture didn't have the full mip pyramid, > this didn't work, because it tried to generate mip levels for non-existing > levels. _mesa_prepare_mipmap_level() would correctly handle

Re: [Mesa-dev] [PATCH] i965/gen9: Add a condition for starting pixel in fast copy blit

On Mon, Aug 10, 2015 at 11:20 AM, Anuj Phogat wrote: > This condition restricts the use of fast copy blit to cases > where starting pixel of src and dst is oword (16 byte) aligned. > > Many piglit tests (if using fast copy blit in Mesa) failed earlier > because I missed adding this condition.Fast

Re: [Mesa-dev] [PATCH] i965/gen9: Don't use fast copy blit in case of non power of 2 cpp

On Mon, Aug 10, 2015 at 1:59 PM, Anuj Phogat wrote: > > > On Mon, Aug 10, 2015 at 11:17 AM, Anuj Phogat wrote: >> >> Many piglit tests (if using fast copy blit in Mesa) failed earlier >> because I missed adding this condition. Fast copy blit is currently >> enabled for use only with Yf/Ys tiling.

Re: [Mesa-dev] [PATCH 06/12] i965/fs: Add a sampler program key for whether the texture is 16x MSAA

Ben Widawsky writes: > Hmm. As I read it, it sounded like you didn't have to send LOD it's > implied to be 0 if you don't send it. If I am wrong about that, then I > agree with you completely. I'm a bit lost. You're right that it's not necessary to send the LOD when it's zero. In fact Mesa never

Re: [Mesa-dev] [PATCH 06/12] i965/fs: Add a sampler program key for whether the texture is 16x MSAA

On Wed, Sep 23, 2015 at 11:12:26PM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > > Hmm. As I read it, it sounded like you didn't have to send LOD it's > > implied to be 0 if you don't send it. If I am wrong about that, then I > > agree with you completely. > > I'm a bit lost. You're righ

Re: [Mesa-dev] [PATCH] mesa: fix mipmap generation for immutable, compressed textures

On 09/23/2015 04:03 PM, Roland Scheidegger wrote: Ping? Am 20.09.2015 um 04:33 schrieb srol...@vmware.com: From: Roland Scheidegger If the immutable compressed texture didn't have the full mip pyramid, this didn't work, because it tried to generate mip levels for non-existing levels. _mesa_pr

Re: [Mesa-dev] [PATCH 1/2] mesa: Use the effective internal format instead for validation

Hi Eduardo, I can't get this patch to apply to any recent version of glformats.c Can you double check it? thanks, Mark Eduardo Lima Mitev writes: > When validating format+type+internalFormat for texture pixel operations > on GLES3, the effective internal format should be used if the one > sp

Re: [Mesa-dev] [PATCH] st/mesa: keep track of saturated writes when eliminating dead code

On Wed, Sep 23, 2015 at 12:33 AM, Ilia Mirkin wrote: > It doesn't matter whether a write is saturated or not, in another > implementation it might even have been a separate opcode. This code was > most likely copied from the copy-propagation pass (where one does have > to distinguish saturation).

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > The flags to be enabled in the control registers have been taken from > Catalyst traces. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 1 + > src/gallium/drivers/radeon/r600_texture.c |

Re: [Mesa-dev] [PATCH v2] nir/cf: Alter block successors before adding a fake link.

On Wed, Sep 23, 2015 at 1:09 PM, Kenneth Graunke wrote: > Consider the case of "while (...) { break }". Or in NIR: > > block block_0 (0x7ab640): > ... > /* succs: block_1 */ > loop { > block block_1: > /* preds: block_0 */ >

[Mesa-dev] [PATCH V2 1/7] i965/gen9: Don't use intel_..._texture_alignment_unit() for linear 1D layout

If gen9_use_linear_1d_layout() returns true, we discards the align_w computed earlier and use fixed align_w = 64 in gen9_miptree_layout_1d(). So, avoid computing align_w when not required. V2: Rebased on master. Signed-off-by: Anuj Phogat --- Bump for the series. src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH v5 70/70] glsl: Mark as active all elements of shared/std140 block arrays

On Wed, 2015-09-23 at 17:02 +0200, Antía Puentes wrote: > Hi! Timothy, > thanks for your review. > > Seeing your patch in: > http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070. > html > > The condition in my patch: > (var->type->interface_packing != GLSL_INTERFACE_PACKING_PACKED

Re: [Mesa-dev] [PATCH 4/8] radeonsi: Add DCC fast clear.

On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > We cannot use the clear words from the cmask fast clear, so the > fast clears are somewhat limited. > > The clear patterns have been taken from Catalyst traces. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeon/r600

[Mesa-dev] [PATCH] i965: Respect stride and subreg_offset for ATTR registers

When we assign hw regs to attributes, we don't incorporate the stride and subreg_offset from the fs_reg. It's rarely used, but the integer multiplication lowering uses unusual stride and subreg_offset combination breaks when one source is an attribute. Bugzilla: https://bugs.freedesktop.org/show_b

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: > On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > > Reviewed-by: Samuel Iglesias Gonsálvez > > > > Forgot to say that we need to implement a similar patch for > std430_size() function, right? Yeah I think so. > > I will

Re: [Mesa-dev] [PATCH 5/8] radeonsi: Invalidate the L2 cache on framebuffer change.

On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > This is needed by DCC when using compressed textures. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeonsi/si_state.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [PATCH] i965: Respect stride and subreg_offset for ATTR registers

On Wed, Sep 23, 2015 at 5:11 PM, Kristian Høgsberg Kristensen wrote: > When we assign hw regs to attributes, we don't incorporate the stride > and subreg_offset from the fs_reg. It's rarely used, but the integer > multiplication lowering uses unusual stride and subreg_offset > combination breaks w

Re: [Mesa-dev] [PATCH] i965: Respect stride and subreg_offset for ATTR registers

On Wed, Sep 23, 2015 at 5:11 PM, Kristian Høgsberg Kristensen wrote: > When we assign hw regs to attributes, we don't incorporate the stride > and subreg_offset from the fs_reg. It's rarely used, but the integer > multiplication lowering uses unusual stride and subreg_offset > combination breaks w

Re: [Mesa-dev] [PATCH 2/8] radeonsi: Add DCC compression tracking machinery.

On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > As textures can be sampled without decompression and the fastclear bits > can be erased without decompressing, so add a new set of flags. Since CMASK clear isn't allowed with DCC (even though it might work for most cases, there are issues

Re: [Mesa-dev] [PATCH] i965: Respect stride and subreg_offset for ATTR registers

On Wed, Sep 23, 2015 at 5:25 PM, Jason Ekstrand wrote: > On Wed, Sep 23, 2015 at 5:11 PM, Kristian Høgsberg Kristensen > wrote: >> When we assign hw regs to attributes, we don't incorporate the stride >> and subreg_offset from the fs_reg. It's rarely used, but the integer >> multiplication loweri

Re: [Mesa-dev] [PATCH] i965: Respect stride and subreg_offset for ATTR registers

On Wed, Sep 23, 2015 at 5:29 PM, Matt Turner wrote: > On Wed, Sep 23, 2015 at 5:25 PM, Jason Ekstrand wrote: >> On Wed, Sep 23, 2015 at 5:11 PM, Kristian Høgsberg Kristensen >> wrote: >>> When we assign hw regs to attributes, we don't incorporate the stride >>> and subreg_offset from the fs_reg.

Re: [Mesa-dev] [PATCH 6/8] radeonsi: Add sampling of DCC compressed textures.

On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > The values for resource word 6 have been taken from Catalyst traces. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 5 + > src/gallium/drivers/radeonsi/si_pipe.h| 1 + > src/gal

Re: [Mesa-dev] [PATCH 8/8] radeonsi: Add DCC for multisampled textures.

On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > The DCC fast clear for multisampled textures is still disabled > as that does not work correctly yet. Maybe it will work after my comments from the previous patches are applied. Marek ___ mesa-

Re: [Mesa-dev] [PATCH 0/8] Add DCC support.

FYI, I've reviewed all patches now. Marek On Sat, Sep 5, 2015 at 12:28 AM, Marek Olšák wrote: > Thank you very much. I'm impressed. > > Sorry, but this will take some time for me to review because I'm very > busy currently. I will have to check with internal documentation if > everything is corr

Re: [Mesa-dev] mesa: rework Driver.CopyImageSubData() and related code (v3)

Hi, The game still works for me with your patch. Tested-by: Nick Sarnie Thanks On Wed, Sep 23, 2015 at 12:55 PM, Ilia Mirkin wrote: > On Wed, Sep 23, 2015 at 12:53 PM, Brian Paul wrote: > > Ilia, can you check that my updates to your temporary st_CopyImageSubData > > function still works wi

Re: [Mesa-dev] [PATCH 8/8] radeonsi: Add DCC for multisampled textures.

On Thu, Sep 24, 2015 at 2:44 AM, Marek Olšák wrote: > On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen > wrote: >> The DCC fast clear for multisampled textures is still disabled >> as that does not work correctly yet. > > Maybe it will work after my comments from the previous patches are applied

  1   2   >