https://bugs.freedesktop.org/show_bug.cgi?id=91673
Tapani Pälli changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|mesa-dev@list
We have to re-validate FBOs rendering to the texture like is done
with TexImage and CopyTexImage.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91673
Cc: "10.6"
---
src/mesa/main/texstorage.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
On Wed, Aug 19, 2015 at 05:54:18PM +0300, Francisco Jerez wrote:
> Topi Pohjolainen writes:
>
> > v2: Non-trivial rebase
> >
> > Reviewed-by: Matt Turner (v1)
> > Reviewed-by: Kenneth Graunke (v1)
> > Signed-off-by: Topi Pohjolainen
> >
> > Signed-off-by: Topi Pohjolainen
>
> Uhm, and here y
On Wed, Aug 19, 2015 at 05:34:14PM +0300, Francisco Jerez wrote:
> Topi Pohjolainen writes:
>
> > All generations do the same exact dispatch and it could be
> > therefore done in the hardware independent stage.
> >
> > v2: Rebased where there are still duplicate calls in gen7 and gen8
> > han
On Thu, Aug 20, 2015 at 11:20:31AM +0300, Pohjolainen, Topi wrote:
> On Wed, Aug 19, 2015 at 05:34:14PM +0300, Francisco Jerez wrote:
> > Topi Pohjolainen writes:
> >
> > > All generations do the same exact dispatch and it could be
> > > therefore done in the hardware independent stage.
> > >
> >
On Wed, Aug 19, 2015 at 05:24:49PM -0700, Anuj Phogat wrote:
> This will require change in the parameters passed to
> intel_miptree_get_tile_masks().
>
> V2: Rearrange the order of parameters. (Ben)
> Change the name to intel_get_tile_masks(). (Topi)
>
> Cc: Ben Widawsky
> Cc: Topi Pohjolain
On 08/19/2015 02:36 PM, Francisco Jerez wrote:
Ian Romanick writes:
On 08/17/2015 09:56 AM, Ilia Mirkin wrote:
On Mon, Aug 17, 2015 at 12:46 PM, Francisco Jerez wrote:
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git
Tapani Pälli writes:
> On 08/19/2015 02:36 PM, Francisco Jerez wrote:
>> Ian Romanick writes:
>>
>>> On 08/17/2015 09:56 AM, Ilia Mirkin wrote:
On Mon, Aug 17, 2015 at 12:46 PM, Francisco Jerez
wrote:
> ---
> src/mesa/main/extensions.c | 1 +
> src/mesa/main/mtypes.h
2015-08-20 6:37 GMT+02:00 Timothy Arceri :
> These changes are also needed to allow linking of
> struct and interface arrays of arrays.
> ---
> src/glsl/link_uniforms.cpp | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/link_uniforms.cpp b/src/gls
OpenGL 2.0 function StencilOp() is in part internally implemented via
StencilOpSeparate(). This change happened some time ago, however the
accompanying doxygen todo comment was not accordingly updated.
Replace the outdated portion of this doxygen todo comment, leaving the
remainder unchanged.
Als
2015-08-20 15:03 GMT+02:00 Rhys Kidd :
> OpenGL 2.0 function StencilOp() is in part internally implemented via
> StencilOpSeparate(). This change happened some time ago, however the
> accompanying doxygen todo comment was not accordingly updated.
>
> Replace the outdated portion of this doxygen tod
Jason Ekstrand writes:
> This way they don't implicitly increment the uniforms variable and don't
> have to be called in-sequence during uniform setup.
>
> Cc: Francisco Jerez
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 7 ---
> src/mesa/drivers/dri/i965/brw_fs.h |
On Thu, Aug 20, 2015 at 7:20 AM, Francisco Jerez wrote:
> Jason Ekstrand writes:
>
>> This way they don't implicitly increment the uniforms variable and don't
>> have to be called in-sequence during uniform setup.
>>
>> Cc: Francisco Jerez
>> ---
>> src/mesa/drivers/dri/i965/brw_fs.cpp
Hello list,
The candidate for the Mesa 10.6.5 is now available. Currently we have:
- 20 queued
- 16 nominated (outstanding)
- and 3 rejected/obsolete patches
Apart from the usual nouveau, i965 and radeon driver fixes, the series
resolves a few serious issues with nouveau_vieux users and big en
On Wed, 2015-08-19 at 18:44 -0400, Ilia Mirkin wrote:
Maybe quote or at least make mention of Issue 3 of the ARB_texture_query_lod
spec in the commit message so anyone searching git history can easily discover
why there are two differently named versions.
Otherwise Reviewed-by: Timothy Arceri
>
So just stick something like
"""
From the ARB_texture_query_lod spec:
(3) The core specification uses the "Lod" spelling, not "LOD". Should
this extension be modified to use "Lod"?
RESOLVED: The "Lod" spelling is the correct spelling for the core
specification and the pre
On Thu, Aug 20, 2015 at 11:08 AM, Emil Velikov wrote:
> Hello list,
>
> The candidate for the Mesa 10.6.5 is now available. Currently we have:
> - 20 queued
> - 16 nominated (outstanding)
> - and 3 rejected/obsolete patches
>
> Apart from the usual nouveau, i965 and radeon driver fixes, the ser
On 14 August 2015 at 13:49, Kai Wasserbäch wrote:
> Fixes a crash in Piglit's
> spec@arb_shader_subroutine@lin...@no-mutual-recursion.vert for me.
>
> Signed-off-by: Kai Wasserbäch
> ---
>
> Hey everyone,
> I ran the Piglit quick test suite afterwards and haven't observed any
> regressions over m
Matt Turner writes:
> On Tue, Aug 18, 2015 at 6:49 PM, Ilia Mirkin wrote:
>> Some shaders appear to extract bits using shift/and combos. Detect
>> (some) of those and convert to EXTBF instead.
>
> What is EXTBF? Extract byte to float?
>
> I ask because Unigine Heaven has shaders that pack 3x byt
https://bugs.freedesktop.org/show_bug.cgi?id=91691
--- Comment #1 from Emil Velikov ---
Unfortunately scons does not produce any .pc files, not just gl.pc. It is
fixable, but I don't have any plans on tackling it. Patches welcome though :)
--
You are receiving this mail because:
You are the QA
On 08/19/2015 08:51 PM, Matt Turner wrote:
> Patches 1 and 6 were too large for the mailing list, so I checked them
> in your tree. Patch 6 has some diffs that leave lines badly wrapped:
>
> + * THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
> + * DAMAGES OR OTHER
> + * LIABI
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> V2: move single dimensional array detection into a helper
>
> Signed-off-by: Timothy Arceri
> Reviewed-by: Samuel Iglesias Gonsálvez
> ---
> src/glsl/ast.h | 8
> src/glsl/ast_to_hir.cpp | 3 ++-
> 2 files changed, 10 insertions(
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> Signed-off-by: Timothy Arceri
> Reviewed-by: Ilia Mirkin
> ---
> src/glsl/link_varyings.cpp | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
> index f7a
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> These changes are also needed to allow linking of
> struct and interface arrays of arrays.
> ---
> src/glsl/link_uniforms.cpp | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/link_uniforms.cpp b/src
On 08/20/2015 10:31 AM, Ian Romanick wrote:
> On 08/19/2015 09:37 PM, Timothy Arceri wrote:
>> These changes are also needed to allow linking of
>> struct and interface arrays of arrays.
>> ---
>> src/glsl/link_uniforms.cpp | 16 ++--
>> 1 file changed, 6 insertions(+), 10 deletions(-)
This patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> ---
> src/glsl/link_uniform_initializers.cpp | 68
> --
> 1 file changed, 41 insertions(+), 27 deletions(-)
>
> diff --git a/src/glsl/link_uniform_initializers.cpp
> b/src/
This patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> V2: rebase on SSBO changes
> ---
> src/glsl/ast_to_hir.cpp | 27 +--
> 1 file changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hi
This patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> V2: return 0 if not array rather than -1
>
> Reviewed-by: Tapani Pälli
> ---
> src/glsl/glsl_types.h | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/src/glsl/glsl_types.h b/s
I might have been tempted to put this and the previous patch before
patch 6, but meh.
This patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> Reviewed-by: Tapani Pälli
> ---
> src/glsl/ast_to_hir.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 08/20/2015 10:24 AM, Ian Romanick wrote:
> On 08/19/2015 09:37 PM, Timothy Arceri wrote:
>> V2: move single dimensional array detection into a helper
>>
>> Signed-off-by: Timothy Arceri
>> Reviewed-by: Samuel Iglesias Gonsálvez
>> ---
>> src/glsl/ast.h | 8
>> src/glsl/ast_t
On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin wrote:
> So just stick something like
>
> """
> From the ARB_texture_query_lod spec:
>
> (3) The core specification uses the "Lod" spelling, not "LOD". Should
> this extension be modified to use "Lod"?
>
> RESOLVED: The "Lod" spelling
On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák wrote:
> On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin wrote:
>> So just stick something like
>>
>> """
>> From the ARB_texture_query_lod spec:
>>
>> (3) The core specification uses the "Lod" spelling, not "LOD". Should
>> this extension be
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> Currently only one ir assignment is removed for each var in a single
> dead code optimisation pass. This means if a var has more than one
> assignment, then it requires all the glsl optimisations to be run again
> for each additional assignment to be
I had thought about doing something similar once upon a time, but I
never got around to it. I'm glad you got some good performance data.
With the couple typos fixed, this patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> The constant folding pass can take a long
On Thu, Aug 20, 2015 at 2:08 PM, Ian Romanick wrote:
> s/optimisation/optimization/ elsewhere (including the commit message) too.
Does mesa standardise on US spelling?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org
This patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> Reviewed-by: Tapani Pälli
> ---
> src/glsl/nir/nir_types.cpp | 6 ++
> src/glsl/nir/nir_types.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/n
On 08/20/2015 11:12 AM, Ilia Mirkin wrote:
> On Thu, Aug 20, 2015 at 2:08 PM, Ian Romanick wrote:
>> s/optimisation/optimization/ elsewhere (including the commit message) too.
>
> Does mesa standardise on US spelling?
I did not realize that the British spelling was different. I think we
mostly
On Thu, Aug 20, 2015 at 04:08:33PM +0100, Emil Velikov wrote:
> Hello list,
>
[snip]
> Neil Roberts (2):
> i965: Swap the order of the vertex ID and edge flag attributes
> i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used
I'm still working on these patches and I'd prefe
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> Desktop GL supports interface block AoA however AMD and Nvidia
> dont support it in their drivers curently so we can get away
> with disabling it for now.
> ---
> src/glsl/ast_to_hir.cpp | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> V2: add missing 's' to the extension name in error messages
> and add decimal place in version string
>
> Reviewed-by: Ilia Mirkin
> ---
> src/glsl/ast_to_hir.cpp | 13 -
> src/glsl/glsl_parser.yy | 22 ++---
With this change, what tests pass / fail in piglit and es31 conformance?
I assume there are still some failures, or does everything work now?
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> ---
> src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
Once all the other stuff lands, this patch is
Reviewed-by: Ian Romanick
On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> ---
> docs/GL3.txt | 4 ++--
> docs/relnotes/11.0.0.html | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/docs/GL3.txt b/docs/GL3.txt
>
2015-08-12 0:07 GMT+01:00 Nanley Chery :
> From: Nanley Chery
>
> Combine the adjacent cases which have the same GL type in the switch statemnt.
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/main/formats.c | 152
> ++--
> 1 file changed, 17 inserti
Hi Edward,
On 19 August 2015 at 09:58, Edward O'Callaghan
wrote:
> From: Edward O'Callaghan
>
> This struct was getting a bit crowded, following the lead of
> radeonsi, mirror the idea of having sub-structures for each
> shader type. Turning 'r600_shader_key' into an union saves
> some trivial m
Hi Alexander,
Please use a commit summary consistent with what we're using. I'm
thinking of "egl: scons: fix the haiku build, do not build the dri2
backend" but feel free to pick a better one.
On 19 August 2015 at 02:45, Alexander von Gluck IV
wrote:
> ---
> src/egl/SConscript |2 +-
> 1 fi
---
src/gallium/drivers/vc4/vc4_program.c | 20
src/gallium/drivers/vc4/vc4_qir.c | 5 +
src/gallium/drivers/vc4/vc4_qir.h | 10 ++
src/gallium/drivers/vc4/vc4_qpu_emit.c | 5 +
4 files changed, 40 insertions(+)
diff --git a/src/gallium/drivers/vc
The splats the first component to all the channels, so later channels
packing from it can be skipped.
total instructions in shared programs: 98170 -> 98168 (-0.00%)
instructions in affected programs: 257 -> 255 (-0.78%)
---
src/gallium/drivers/vc4/vc4_program.c | 10 +++---
1 file ch
This corresponds to instructions used on vc4 for its blending inside of
shaders. I've seen these opcodes on other architectures before, but I
think it's the first time these are needed in Mesa.
---
src/glsl/nir/nir_opcodes.py | 45 +++
src/glsl/nir/nir_op
We can't do this all the time, because you want blending to be done in
linear space, and sRGB would lose too much precision being done in 4x8.
total uniforms in shared programs: 32066 -> 32088 (0.07%)
uniforms in affected programs: 327 -> 349 (6.73%)
total instructions in shared programs: 9816
Shader-db results for vec4 on i965:
total instructions in shared programs: 1499894 -> 1502261 (0.16%)
instructions in affected programs: 1414224 -> 1416591 (0.17%)
helped:2434
HURT: 10543
GAINED:
> Shader-db results for vec4 on i965:
reads like a Johnny Cash cover of NIN.
sorry couldn't resist :-P
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Ping?
Am 09.08.2015 um 17:28 schrieb srol...@vmware.com:
> From: Roland Scheidegger
>
> I used this as some testing ground for investigating some compiler
> bits initially (e.g. lrint calls etc.), figured I could do much better
> in the end just for fun...
> This is mathematically equivalent, bu
https://bugs.freedesktop.org/show_bug.cgi?id=91020
Julien Isorce changed:
What|Removed |Added
CC||julien.iso...@gmail.com
--
You are rece
I pushed this out without the Android.mk change:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a4af36517333ef61d5f7ca2264fec3f49ee3662
I don't know anything about Android makefiles and didn't feel like I
knew enough about what was going on there to make any change. Feel
free to resubmit that
On Thu, Aug 20, 2015 at 11:34 AM, Emil Velikov
wrote:
> 2015-08-12 0:07 GMT+01:00 Nanley Chery :
> > From: Nanley Chery
> >
> > Combine the adjacent cases which have the same GL type in the switch
> statemnt.
> >
> > Signed-off-by: Nanley Chery
> > ---
> > src/mesa/main/formats.c | 152
> +
On Thu, 2015-08-20 at 14:06 -0400, Ilia Mirkin wrote:
> On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák
> wrote:
> > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin
> > wrote:
> > > So just stick something like
> > >
> > > """
> > > From the ARB_texture_query_lod spec:
> > >
> > > (3) The core sp
On Thu, Aug 20, 2015 at 7:08 PM, Timothy Arceri wrote:
> On Thu, 2015-08-20 at 14:06 -0400, Ilia Mirkin wrote:
>> On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák
>> wrote:
>> > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin
>> > wrote:
>> > > So just stick something like
>> > >
>> > > """
>> > > From
On Thu, Aug 20, 2015 at 12:52 AM, Tapani Pälli wrote:
> We have to re-validate FBOs rendering to the texture like is done
> with TexImage and CopyTexImage.
>
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91673
> Cc: "10.6"
> ---
> src/mesa/main/texstorag
On Fri, Aug 21, 2015 at 1:10 AM, Ilia Mirkin wrote:
> On Thu, Aug 20, 2015 at 7:08 PM, Timothy Arceri wrote:
>> On Thu, 2015-08-20 at 14:06 -0400, Ilia Mirkin wrote:
>>> On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák
>>> wrote:
>>> > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin
>>> > wrote:
>>> >
> Can anyone take a look at this simple one-liner ? Afaics Dave added
> the pass earlier in 10.7-devel.
Looks good, pushed it, thanks.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Signed-off-by: Ilia Mirkin
Cc: "10.6"
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index c8e1b8f..76a77f0 100644
--- a/src/mesa/state_tra
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 76a77f0..eb47685 100644
--- a/src/mesa/state_tr
It is fairly tricky to detect the proper conditions for using bitfield
insert, but easy to just use it up front. This removes a lot of
instructions on nvc0 when invoking the packing builtins.
Signed-off-by: Ilia Mirkin
---
Not sure if all backends will benefit from this, but nvc0 definitely
does
This greatly improves generated code, especially for the snorm variants,
since it is able to get rid of the lshift/rshift for sext, as well as
replacing each shift + mask with a single op.
Signed-off-by: Ilia Mirkin
---
This actually slightly pessimizes nvc0 generated code for the unorm
case bec
On Thu, Aug 20, 2015 at 9:58 PM, Ilia Mirkin wrote:
> This greatly improves generated code, especially for the snorm variants,
> since it is able to get rid of the lshift/rshift for sext, as well as
> replacing each shift + mask with a single op.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> This actu
On 08/21/2015 02:20 AM, Anuj Phogat wrote:
On Thu, Aug 20, 2015 at 12:52 AM, Tapani Pälli wrote:
We have to re-validate FBOs rendering to the texture like is done
with TexImage and CopyTexImage.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91673
Cc: "10
On Thu, 2015-08-20 at 11:31 -0700, Ian Romanick wrote:
> With this change, what tests pass / fail in piglit and es31 conformance?
All es31 conformance tests pass (there was one failing waiting on an SSBO
patch to land).
All piglit tests besides interface tests and some indirect sampler tests whic
On Thu, 2015-08-20 at 10:46 -0700, Ian Romanick wrote:
> I might have been tempted to put this and the previous patch before
> patch 6, but meh.
Yeah I did it this way as 6 is really a fix independent of AoA and I wanted to
be able to push it without waiting on the AoA patches to be fully reviewed
On Thu, 2015-08-20 at 10:39 -0700, Ian Romanick wrote:
> On 08/20/2015 10:31 AM, Ian Romanick wrote:
> > On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> > > These changes are also needed to allow linking of
> > > struct and interface arrays of arrays.
> > > ---
> > > src/glsl/link_uniforms.cpp | 1
69 matches
Mail list logo
