Re: [Mesa-dev] [PATCH] mesa/formats: Fix swizzle flipping for big-endian targets

2015-08-10 Thread Jason Ekstrand
On Sun, Aug 9, 2015 at 11:55 PM, Oded Gabbay wrote: > On Mon, Aug 10, 2015 at 9:52 AM, Jason Ekstrand wrote: >> For those of you tracking the big-endian stuff, I've pushed a couple >> patches to a branch: >> >> http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/be-fixes >> >> I've removed the

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 Jose Fonseca changed: What|Removed |Added CC||matts...@gmail.com Assignee|jfo

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-10 Thread Oded Gabbay
On Mon, Aug 10, 2015 at 7:58 AM, Jason Ekstrand wrote: > On Sun, Aug 9, 2015 at 3:11 AM, Oded Gabbay wrote: >> On Sun, Aug 9, 2015 at 2:43 AM, Jason Ekstrand wrote: >>> On Sat, Aug 8, 2015 at 3:14 PM, Oded Gabbay wrote: On Sun, Aug 9, 2015 at 12:26 AM, Jason Ekstrand wrote: >>>

[Mesa-dev] [Bug 91474] egl initializes wrong card with hybrid graphics card

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91474 Marek Chalupa changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 12:07 AM, Oded Gabbay wrote: > On Mon, Aug 10, 2015 at 7:58 AM, Jason Ekstrand wrote: >> On Sun, Aug 9, 2015 at 3:11 AM, Oded Gabbay wrote: >>> On Sun, Aug 9, 2015 at 2:43 AM, Jason Ekstrand wrote: On Sat, Aug 8, 2015 at 3:14 PM, Oded Gabbay wrote: > On Sun, Au

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-10 Thread Oded Gabbay
On Mon, Aug 10, 2015 at 10:30 AM, Jason Ekstrand wrote: > On Mon, Aug 10, 2015 at 12:07 AM, Oded Gabbay wrote: >> On Mon, Aug 10, 2015 at 7:58 AM, Jason Ekstrand wrote: >>> On Sun, Aug 9, 2015 at 3:11 AM, Oded Gabbay wrote: On Sun, Aug 9, 2015 at 2:43 AM, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 12:41 AM, Oded Gabbay wrote: > On Mon, Aug 10, 2015 at 10:30 AM, Jason Ekstrand wrote: >> On Mon, Aug 10, 2015 at 12:07 AM, Oded Gabbay wrote: >>> On Mon, Aug 10, 2015 at 7:58 AM, Jason Ekstrand >>> wrote: On Sun, Aug 9, 2015 at 3:11 AM, Oded Gabbay wrote: > O

[Mesa-dev] [PATCH 1/4] mesa: expose dimension check for glTex*Storage functions

2015-08-10 Thread Tapani Pälli
This is done so that following patch can use it to verify dimenstions for multisample variants of glTex*Storage. Signed-off-by: Tapani Pälli --- src/mesa/main/texstorage.c | 22 +- src/mesa/main/texstorage.h | 3 +++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH 3/4] mesa: set correct error for non-renderable multisample textures

2015-08-10 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/teximage.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 3ea7b2a..c6fd0be 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5639,9

[Mesa-dev] [PATCH 0/4] OpenGL ES 3.1 texture storage changes

2015-08-10 Thread Tapani Pälli
Hello; Here's bunch of changes to texture storage. I have a branch to enable GL_OES_texture_storage_multisample_2d_array and I extracted changes not directly related to extension itself and I see generic to OpenGL ES 3.1. Hopefully I haven't overlapped too much with your work here Marta, sorry if

[Mesa-dev] [PATCH 2/4] mesa: validate size parameters for glTexStorage*Multisample

2015-08-10 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/teximage.c | 28 1 file changed, 28 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index fc69387..3ea7b2a 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5782,6 +57

[Mesa-dev] [PATCH 4/4] mesa: allow multisampled integer texture formats for ES 3.1

2015-08-10 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/multisample.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c index 490bad5..aac5a15 100644 --- a/src/mesa/main/multisample.c +++ b/src/mesa/main/multisample.c @@ -164

Re: [Mesa-dev] [PATCH v2] gles/es3.1: Implement glMemoryBarrierByRegion

2015-08-10 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Friday, August 7, 2015 9:56 PM > To: Matt Turner > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2] gles/es3.1: Implement > glMemoryBarrierByRegion

[Mesa-dev] [PATCH] mesa/formats: Don't flip channels of null array formats

2015-08-10 Thread Jason Ekstrand
Before, if we encountered an array format of 0 on a BE system, we would flip all the channels even though it's an invalid format. This would result in a mostly invalid format with a swizzle of or . Instead, we should just return 0 if the array format stashed in the format info is invalid

Re: [Mesa-dev] [PATCH 57/70] i965: Stage blitted buffer uploads through the common upload bo

2015-08-10 Thread Daniel Vetter
On Fri, Aug 07, 2015 at 09:14:01PM +0100, Chris Wilson wrote: > Reuse the common upload bo for the temporary blitter storage to try and > minimise resource usage. > > Caveats: this may impose a read-read relationship on the buffer between > the blitter and render engines, and may add stalls on old

Re: [Mesa-dev] [PATCH 57/70] i965: Stage blitted buffer uploads through the common upload bo

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 10:40:29AM +0200, Daniel Vetter wrote: > On Fri, Aug 07, 2015 at 09:14:01PM +0100, Chris Wilson wrote: > > Reuse the common upload bo for the temporary blitter storage to try and > > minimise resource usage. > > > > Caveats: this may impose a read-read relationship on the b

Re: [Mesa-dev] [PATCH 1/4] mesa: expose dimension check for glTex*Storage functions

2015-08-10 Thread Timothy Arceri
On Mon, 2015-08-10 at 11:06 +0300, Tapani Pälli wrote: > This is done so that following patch can use it to verify dimenstions > for multisample variants of glTex*Storage. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/texstorage.c | 22 +- > src/mesa/main/texstorage.h

[Mesa-dev] [PATCH] st/dri: Use packed RGB formats

2015-08-10 Thread Michel Dänzer
From: Michel Dänzer Fixes Gallium based DRI drivers failing to load on big endian hosts because they can't find any matching fbconfigs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71789 Signed-off-by: Michel Dänzer --- src/gallium/state_trackers/dri/dri2.c | 26 +

Re: [Mesa-dev] [PATCH 1/4] mesa: expose dimension check for glTex*Storage functions

2015-08-10 Thread Tapani Pälli
On 08/10/2015 12:04 PM, Timothy Arceri wrote: On Mon, 2015-08-10 at 11:06 +0300, Tapani Pälli wrote: This is done so that following patch can use it to verify dimenstions for multisample variants of glTex*Storage. Signed-off-by: Tapani Pälli --- src/mesa/main/texstorage.c | 22

Re: [Mesa-dev] [PATCH 02/70] i965: Pack read-only booleans into a bitfield

2015-08-10 Thread Chris Wilson
On Fri, Aug 07, 2015 at 09:13:06PM +0100, Chris Wilson wrote: > GCC's read access for single bits in a bitfield is reasonable (just a > move + flag comparison), so let's save some cachelines by packing the > write-once/read-many booleans together. > >text data bss dec hex

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 Bug ID: 91596 Summary: EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI Product: Mesa Version: git Hardware: All OS: other Status:

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #1 from Mauro Rossi --- Created attachment 117608 --> https://bugs.freedesktop.org/attachment.cgi?id=117608&action=edit dmesg, NOTE: segfaults are due to an independent problem -- You are receiving this mail because: You are the Q

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #2 from Mauro Rossi --- Created attachment 117609 --> https://bugs.freedesktop.org/attachment.cgi?id=117609&action=edit dumpsys SurfaceFlinger -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [PATCH 0/4] OpenGL ES 3.1 texture storage changes

2015-08-10 Thread Tapani Pälli
On 08/10/2015 11:06 AM, Tapani Pälli wrote: Hello; Here's bunch of changes to texture storage. I have a branch to enable GL_OES_texture_storage_multisample_2d_array and I extracted changes not directly related to extension itself and I see generic to OpenGL ES 3.1. Hopefully I haven't overlapp

Re: [Mesa-dev] [PATCH 4/4] r600g: use a bitfield to track dirty atoms

2015-08-10 Thread Marek Olšák
Please never use "long" in Mesa. It only has 32 bits on 32-bit systems. uint64_t is generally used for all unsigned 64-bit variables and "llu" or "ull" is the number suffix. Also, the 64-bit ctz is ctzll and a proper HAVE macro should be added for it too. The general idea is nice, thanks. The num

[Mesa-dev] [PATCH] mesa: add NV_read_{depth, stencil, depth_stencil} extensions

2015-08-10 Thread Rob Clark
From: Rob Clark These extensions allow reading depth/stencil for GLES contexts, which is useful for tools like apitrace. Signed-off-by: Rob Clark --- I have a patch, which I will send out after some cleanup, that makes apitrace able to dump depth/stencil buffers with GLES, thanks to this extens

[Mesa-dev] [PATCH v2] glsl/es3.1: Fix up GL_ARB_compute_shader for GLSL ES 3.1

2015-08-10 Thread Marta Lofstedt
From: Marta Lofstedt GL_ARB_compute_shader is limited for GLSL version 430. This enables for GLSL ES version 310. V2: Updated error string to also include GLSL 3.10 Signed-off-by: Marta Lofstedt --- src/glsl/glsl_parser.yy | 5 ++--- src/glsl/glsl_parser_extras.h | 5 + 2 files chan

Re: [Mesa-dev] [PATCH 01/70] util/list: Add convenience functions for moving a list element

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Just a couple of functions for removing an element from one list and adding to another (perhaps even the same list, just at the head or tail). Used in future patches. Signed-off-by: Chris Wilson --- src/util/list.h | 27 +-- 1 f

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Neil Roberts
If we go with this patch perhaps it would be good to remove supports_simd16_3src entirely from brw_device_info and any code that is referring to it in order to avoid carrying around useless code. Currently it seems like it would be quite easy to add a new brw_device_info and forget to add supports_

[Mesa-dev] [PATCH] mesa/es3.1: Enable GL_MAX_VERTEX_ATTRIB enums for GLES 3.1

2015-08-10 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get_hash_params.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 7dc92f1..66c47de 100644 --- a/src/mesa/main/get_ha

Re: [Mesa-dev] [PATCH 04/70] i965: Share the workaround bo between all contexts

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Since the workaround bo is used strictly as a write-only buffer, we need only allocate one per screen and use the same one from all contexts. (The caveat here is during extension initialisation, where we write into and read back register values from the buf

Re: [Mesa-dev] [PATCH 04/70] i965: Share the workaround bo between all contexts

2015-08-10 Thread Martin Peres
On 10/08/15 14:25, Martin Peres wrote: On 07/08/15 23:13, Chris Wilson wrote: Since the workaround bo is used strictly as a write-only buffer, we need only allocate one per screen and use the same one from all contexts. (The caveat here is during extension initialisation, where we write into

Re: [Mesa-dev] [PATCH] mesa/es3.1: Enable GL_ARB_separate_shader_objects for GLES 3.1

2015-08-10 Thread Lofstedt, Marta
This patch has the wrong name also the MAX_VERTEX_ATTRIB_STRIDE was missing and this needs to go under a GLES 3.1 label. I have sent a replacement patch for this: http://patchwork.freedesktop.org/patch/56761/ /Marta > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.fr

Re: [Mesa-dev] [PATCH 04/70] i965: Share the workaround bo between all contexts

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 02:25:41PM +0300, Martin Peres wrote: > On 07/08/15 23:13, Chris Wilson wrote: > >Since the workaround bo is used strictly as a write-only buffer, we need > >only allocate one per screen and use the same one from all contexts. > > > >(The caveat here is during extension init

Re: [Mesa-dev] [PATCH] mesa/format_utils: Add src_bits == dst_bits cases to [us]norm functions

2015-08-10 Thread Neil Roberts
Jason Ekstrand writes: > @@ -151,8 +153,10 @@ _mesa_snorm_to_snorm(int x, unsigned src_bits, unsigned > dst_bits) >return -MAX_INT(dst_bits); > else if (src_bits < dst_bits) >return EXTEND_NORMALIZED_INT(x, src_bits - 1, dst_bits - 1); > - else > + else if (src_bits > dst

Re: [Mesa-dev] [PATCH 05/70] i965: Move the pipelined test for SO register access to the screen

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Moving the test to the screen places it alongside the other global HW feature tesst that want to be shared between contexts. Signed-off-by: Chris Wilson Cc: Kenneth Graunke Seems like a good idea and I am also much more comfortable with this as the wor

Re: [Mesa-dev] [PATCH 06/70] i965: Move the OACONTROL pipelined access check from context to screen

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Similarly to the pipelined SO_OFFSET check, this moves the global HW compatability check to the screen next to the other global checks. Reviewed-by: Martin Peres Signed-off-by: Chris Wilson --- src/mesa/drivers/dri/i965/intel_extensions.c | 68 +

[Mesa-dev] [PATCH] i965: Fix HW binding tables editing

2015-08-10 Thread Chris Wilson
Since the introduction of new gl_shader_stages in commit a2af956963b6bc4d29f37485e44c98008d2ef077 Author: Fabian Bieler Date: Fri Mar 7 10:19:09 2014 +0100 mesa: add tessellation shader enums the translation table for the stage into the HW binding table edit command was broken, and so we

Re: [Mesa-dev] [PATCH] i965: Fix HW binding tables editing

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 12:49:47PM +0100, Chris Wilson wrote: > Since the introduction of new gl_shader_stages in > > commit a2af956963b6bc4d29f37485e44c98008d2ef077 > Author: Fabian Bieler > Date: Fri Mar 7 10:19:09 2014 +0100 > > mesa: add tessellation shader enums > > the translation t

[Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2015-08-10 Thread Chris Wilson
"X rendering calls made prior to glXWaitX are guaranteed to be executed before GL rendering calls made after glXWaitX." The goal is to implement that without adding a round-trip to the Xserver. Adding one using XSync() is easy, but we can piggy-back another, the DRI2GetBuffers request made to upda

Re: [Mesa-dev] [PATCH 07/70] i965: Combine the multiple pipelined register detection into one round-trip

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Combining the multiple access checks into a few batches and a single serialising read can reduce detection times from around 100us to 70us on a fast Haswell system. Signed-off-by: Chris Wilson Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_scre

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: intel_update_winsys_renderbuffer_miptree() will release the existing miptree when wrapping a new DRI2 buffer, so we can remove the early release and so prevent a NULL mt dereference should importing the new DRI2 name fail for any reason. (Reusing the old DRI

Re: [Mesa-dev] [PATCH v2] glsl/es3.1: Fix up GL_ARB_compute_shader for GLSL ES 3.1

2015-08-10 Thread Timothy Arceri
On Mon, 2015-08-10 at 13:04 +0200, Marta Lofstedt wrote: > From: Marta Lofstedt > > GL_ARB_compute_shader is limited for GLSL version 430. > This enables for GLSL ES version 310. > > V2: Updated error string to also include GLSL 3.10 > > Signed-off-by: Marta Lofstedt > --- > src/glsl/glsl_par

Re: [Mesa-dev] [PATCH 09/70] i965: Remove direct includes of intel_batchbuffer.h

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Upcoming patches eliminate the intel_batchbuffer interface and one of the minor changes that causes a lot of churn is the removal of the header, along with the occassional need to now call intel_reg.h themselves. This patch moves the individual includes into

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 03:18:09PM +0300, Martin Peres wrote: > On 07/08/15 23:13, Chris Wilson wrote: > >intel_update_winsys_renderbuffer_miptree() will release the existing > >miptree when wrapping a new DRI2 buffer, so we can remove the early > >release and so prevent a NULL mt dereference shoul

Re: [Mesa-dev] [PATCH 12/70] i965: Rename intel_batchbuffer to brw_batch

2015-08-10 Thread Martin Peres
10-12 are: Reviewed-by: Martin Peres On 07/08/15 23:13, Chris Wilson wrote: In order to reduce future churn, rename the intel_batchbuffer struct. Signed-off-by: Chris Wilson --- src/mesa/drivers/dri/i965/brw_batch.h | 4 ++-- src/mesa/drivers/dri/i965/brw_context.h | 2 +-

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

2015-08-10 Thread Martin Peres
On 10/08/15 15:26, Chris Wilson wrote: On Mon, Aug 10, 2015 at 03:18:09PM +0300, Martin Peres wrote: On 07/08/15 23:13, Chris Wilson wrote: intel_update_winsys_renderbuffer_miptree() will release the existing miptree when wrapping a new DRI2 buffer, so we can remove the early release and so pre

Re: [Mesa-dev] [PATCH 12/70] i965: Rename intel_batchbuffer to brw_batch

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 03:37:24PM +0300, Martin Peres wrote: > 10-12 are: > > Reviewed-by: Martin Peres One thing to consider, do we want to do a s/typedef/struct brw_batch/ cleanup after the transition is complete? brw_batch vs struct brw_batch ? brw_bo vs struct brw_bo ? -Chris -- Chris Wi

Re: [Mesa-dev] [PATCH 12/70] i965: Rename intel_batchbuffer to brw_batch

2015-08-10 Thread Martin Peres
On 10/08/15 15:45, Chris Wilson wrote: On Mon, Aug 10, 2015 at 03:37:24PM +0300, Martin Peres wrote: 10-12 are: Reviewed-by: Martin Peres One thing to consider, do we want to do a s/typedef/struct brw_batch/ cleanup after the transition is complete? brw_batch vs struct brw_batch ? brw_bo vs

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-10 Thread Oded Gabbay
On Mon, Aug 10, 2015 at 10:43 AM, Jason Ekstrand wrote: > On Mon, Aug 10, 2015 at 12:41 AM, Oded Gabbay wrote: >> On Mon, Aug 10, 2015 at 10:30 AM, Jason Ekstrand >> wrote: >>> On Mon, Aug 10, 2015 at 12:07 AM, Oded Gabbay wrote: On Mon, Aug 10, 2015 at 7:58 AM, Jason Ekstrand wrot

Re: [Mesa-dev] [PATCH 13/70] i965: Add a couple of utility functions to ref/unref a brw_bo

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: To further reduce churn when replacing the buffer object implementation, wrap the existing drm_intel_bo_reference/drm_intel_bo_unreference. Signed-off-by: Chris Wilson --- src/mesa/drivers/dri/i965/brw_batch.h | 12 +++ src/mesa/dri

Re: [Mesa-dev] [PATCH 07/70] i965: Combine the multiple pipelined register detection into one round-trip

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 03:17:26PM +0300, Martin Peres wrote: > >+static int > >+intel_detect_pipelined_oacontrol(struct intel_screen *screen, > >+ struct detect_pipelined_register *detect) > > { > > if (screen->devinfo->gen < 6 || screen->devinfo->gen >= 8) > >

Re: [Mesa-dev] [PATCH 07/70] i965: Combine the multiple pipelined register detection into one round-trip

2015-08-10 Thread Martin Peres
On 10/08/15 16:00, Chris Wilson wrote: On Mon, Aug 10, 2015 at 03:17:26PM +0300, Martin Peres wrote: +static int +intel_detect_pipelined_oacontrol(struct intel_screen *screen, + struct detect_pipelined_register *detect) { if (screen->devinfo->gen < 6 || s

Re: [Mesa-dev] [PATCH 07/70] i965: Combine the multiple pipelined register detection into one round-trip

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 04:08:07PM +0300, Martin Peres wrote: > > > On 10/08/15 16:00, Chris Wilson wrote: > >On Mon, Aug 10, 2015 at 03:17:26PM +0300, Martin Peres wrote: > >>>+static int > >>>+intel_detect_pipelined_oacontrol(struct intel_screen *screen, > >>>+ s

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-10 Thread Roland Scheidegger
Am 10.08.2015 um 07:00 schrieb Jason Ekstrand: > On Sun, Aug 9, 2015 at 6:46 AM, Roland Scheidegger wrote: >> Am 09.08.2015 um 12:11 schrieb Oded Gabbay: >>> On Sun, Aug 9, 2015 at 2:43 AM, Jason Ekstrand wrote: On Sat, Aug 8, 2015 at 3:14 PM, Oded Gabbay wrote: > On Sun, Aug 9, 2015 at

Re: [Mesa-dev] [PATCH] mesa/format_utils: Add src_bits == dst_bits cases to [us]norm functions

2015-08-10 Thread Roland Scheidegger
Am 10.08.2015 um 07:03 schrieb Jason Ekstrand: > This better ensures that the src_bits == dst_bits case gets optimized away. > --- > src/mesa/main/format_utils.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/format_utils.h b/src/mesa/main/format_ut

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- Comment #8 from Roland Scheidegger --- What a mess... I found some reference that for c++ you need to define __STDC_LIMIT_MACROS before including to make it work. Dunno though if that's the problem here. Also, do we need to include ? Otherwi

Re: [Mesa-dev] [PATCH 22/70] i965: Add dword aliases to bitfield structs

2015-08-10 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: When processing the packed fields, it often much easier to pass around verb missing after "it"? the dword value (as would be seen by hardware) than it is manipulating the bitfield. By aliasing the bitfield with a uint32_t member, we can treat the value a

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- Comment #9 from Jose Fonseca --- (In reply to Roland Scheidegger from comment #8) > I found some reference that for c++ you need to define __STDC_LIMIT_MACROS > before including to make it work. Dunno though if that's the > problem here. We

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Jason Ekstrand
On Aug 10, 2015 4:14 AM, "Neil Roberts" wrote: > > If we go with this patch perhaps it would be good to remove > supports_simd16_3src entirely from brw_device_info and any code that is > referring to it in order to avoid carrying around useless code. > Currently it seems like it would be quite eas

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- Comment #10 from Roland Scheidegger --- (In reply to Jose Fonseca from comment #9) > Anwyay, roundeven_test.c is a C file, so I don't believe that's the problem. Well the last build failure showed a failure with glsl_types.cpp - only the pre

[Mesa-dev] [PATCH 2/3] gallium: add GREMEDY_string_marker

2015-08-10 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpi

[Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

2015-08-10 Thread Rob Clark
From: Rob Clark Punch it through mesa and gallium, plus implementation in freedreno to serve as an example. Radeon should be able to do a similar thing with no-op packets. Not sure about other drivers. Plan to use this extension from apitrace, to emit call and frame #'s for draw commands, so I

[Mesa-dev] [PATCH 1/3] mesa: add GREMEDY_string_marker

2015-08-10 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/mapi/glapi/gen/GREMEDY_string_marker.xml | 18 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml| 2 ++ src/mesa/main/dd.h | 6 ++ src/mesa/main/d

[Mesa-dev] [PATCH 3/3] freedreno: implement emit_string_marker

2015-08-10 Thread Rob Clark
From: Rob Clark Writes string to cmdstream in payload of a no-op packet. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 27 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 2 +- 2 files changed, 28 insertions(+), 1 deletion(-) dif

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-08-10 Thread Matt Turner
On Fri, Aug 7, 2015 at 10:09 AM, Ian Romanick wrote: > I know we've talked about this about 100 times, but something in the > back of my mind tells me that we have a pre-existing race. What happens > if the p_atomic_dec_zero happens on thread A while thread B is between > the _mesa_lookup_renderb

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- Comment #11 from Matt Turner --- Created attachment 117615 --> https://bugs.freedesktop.org/attachment.cgi?id=117615&action=edit patch Try this -- defines __STDC_LIMIT_MACROS before including limits.h. -- You are receiving this mail beca

[Mesa-dev] [PATCH] Add mesa.icd to the .gitignore

2015-08-10 Thread Neil Roberts
Since 4d7e0fa8c731776 this file is generated by the configure script. --- src/gallium/targets/opencl/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 src/gallium/targets/opencl/.gitignore diff --git a/src/gallium/targets/opencl/.gitignore b/src/gallium/targets/opencl/.gitigno

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Ben Widawsky
On Mon, Aug 10, 2015 at 09:09:41AM -0700, Jason Ekstrand wrote: > On Aug 10, 2015 4:14 AM, "Neil Roberts" wrote: > > > > If we go with this patch perhaps it would be good to remove > > supports_simd16_3src entirely from brw_device_info and any code that is > > referring to it in order to avoid car

Re: [Mesa-dev] [PATCH 1/4] mesa: expose dimension check for glTex*Storage functions

2015-08-10 Thread Brian Paul
On 08/10/2015 02:06 AM, Tapani Pälli wrote: This is done so that following patch can use it to verify dimenstions for multisample variants of glTex*Storage. Signed-off-by: Tapani Pälli --- src/mesa/main/texstorage.c | 22 +- src/mesa/main/texstorage.h | 3 +++ 2 files c

Re: [Mesa-dev] [PATCH] mesa: add NV_read_{depth, stencil, depth_stencil} extensions

2015-08-10 Thread Marek Olšák
On Mon, Aug 10, 2015 at 1:02 PM, Rob Clark wrote: > From: Rob Clark > > These extensions allow reading depth/stencil for GLES contexts, which is > useful for tools like apitrace. > > Signed-off-by: Rob Clark > --- > I have a patch, which I will send out after some cleanup, that makes > apitrace

Re: [Mesa-dev] [PATCH] st/dri: Use packed RGB formats

2015-08-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 10, 2015 at 11:44 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes Gallium based DRI drivers failing to load on big endian hosts > because they can't find any matching fbconfigs. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71789

[Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-10 Thread Ian Romanick
From: Ian Romanick On many CPU-limited applications, this is *the* hot path. The idea is to generate per-API versions of brw_draw_prims that elide some checks. This patch removes render-mode and "is everything in VBOs" checks from core-profile contexts. On my IVB laptop (which may have experien

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- Comment #12 from Jose Fonseca --- if __STDC_LIMIT_MACROS is indeed the problem, then it must be defined globally in configure.ac. Defining in rounding.h won't be effective if by any reason limits.h is included before rounding.h is (ie, the t

[Mesa-dev] [Bug 91468] LLVM 3.8(svn): llvm changes llvm-config output again?

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91468 Krzysztof A. Sobiecki changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 Matt Turner changed: What|Removed |Added Attachment #117615|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 9:49 AM, Ben Widawsky wrote: > On Mon, Aug 10, 2015 at 09:09:41AM -0700, Jason Ekstrand wrote: >> On Aug 10, 2015 4:14 AM, "Neil Roberts" wrote: >> > >> > If we go with this patch perhaps it would be good to remove >> > supports_simd16_3src entirely from brw_device_info an

Re: [Mesa-dev] [PATCH] mesa/format_utils: Add src_bits == dst_bits cases to [us]norm functions

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 4:35 AM, Neil Roberts wrote: > Jason Ekstrand writes: > >> @@ -151,8 +153,10 @@ _mesa_snorm_to_snorm(int x, unsigned src_bits, unsigned >> dst_bits) >>return -MAX_INT(dst_bits); >> else if (src_bits < dst_bits) >>return EXTEND_NORMALIZED_INT(x, src_bit

Re: [Mesa-dev] [PATCH 3/5] i965/vec4-nir: Handle boolean resolvese on ILK-

2015-08-10 Thread Matt Turner
On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote: > The analysis code was already there and running, we just weren't doing > anything with the result of it yet. > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/mesa/

Re: [Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-10 Thread Matt Turner
On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote: > On BDW+, the negation source modifier on NOT, AND, OR, and XOR, is actually > a boolean negate and not an integer negate. However, NIR's soruce > modifiers are the integer version. We have to resolve it with a MOV prior > to emitting the ac

[Mesa-dev] [PATCH] i965/gen9: Don't use fast copy blit in case of non power of 2 cpp

2015-08-10 Thread Anuj Phogat
Many piglit tests (if using fast copy blit in Mesa) failed earlier because I missed adding this condition. Fast copy blit is currently enabled for use only with Yf/Ys tiling. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c | 6 -- 1 file changed, 4 insertions(+), 2 dele

Re: [Mesa-dev] [PATCH 12/70] i965: Rename intel_batchbuffer to brw_batch

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 5:49 AM, Martin Peres wrote: > On 10/08/15 15:45, Chris Wilson wrote: >> >> On Mon, Aug 10, 2015 at 03:37:24PM +0300, Martin Peres wrote: >>> >>> 10-12 are: >>> >>> Reviewed-by: Martin Peres >> >> One thing to consider, do we want to do a s/typedef/struct brw_batch/ >> cle

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- Comment #14 from Jose Fonseca --- Comment on attachment 117618 --> https://bugs.freedesktop.org/attachment.cgi?id=117618 patch Review of attachment 117618: - Looks great. Re

Re: [Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 11:16 AM, Matt Turner wrote: > On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote: >> On BDW+, the negation source modifier on NOT, AND, OR, and XOR, is actually >> a boolean negate and not an integer negate. However, NIR's soruce >> modifiers are the integer version.

[Mesa-dev] [PATCH] i965/gen9: Add a condition for starting pixel in fast copy blit

2015-08-10 Thread Anuj Phogat
This condition restricts the use of fast copy blit to cases where starting pixel of src and dst is oword (16 byte) aligned. Many piglit tests (if using fast copy blit in Mesa) failed earlier because I missed adding this condition.Fast copy blit is currently enabled for use only with Yf/Ys tiling.

Re: [Mesa-dev] [PATCH 0/5] i965/vec4_nir: Various fixes for ILK- and BDW+

2015-08-10 Thread Matt Turner
On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote: > This is a quick little series that fixes a bunch of piglit regressions with > vec4 NIR on ILK- and BDW+. With this series, vec4 NIR has (I think) zero > regressions versus non-NIR on all intel platforms. I haven't yet tested > NIR with vec4

Re: [Mesa-dev] [PATCH 0/5] Some register allocation improvements

2015-08-10 Thread Matt Turner
On Fri, Jul 31, 2015 at 10:05 AM, Jason Ekstrand wrote: > The following 5 patches contain a few register allocation cleanups and > performance improvements. Chris Wilson noticed that setting up register > sets on i965 calls reralloc an absurd number of times. I did a little > hacking and found o

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Don't do redundant RA setup on IVB+

2015-08-10 Thread Matt Turner
On Fri, Jul 31, 2015 at 10:05 AM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > index 211f

Re: [Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-10 Thread Matt Turner
On Mon, Aug 10, 2015 at 11:19 AM, Jason Ekstrand wrote: > On Mon, Aug 10, 2015 at 11:16 AM, Matt Turner wrote: >> On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote: >>> On BDW+, the negation source modifier on NOT, AND, OR, and XOR, is actually >>> a boolean negate and not an integer negate.

[Mesa-dev] [PATCH 1/2] clover: upload sample bitfield to kernel

2015-08-10 Thread Zoltan Gilian
--- src/gallium/state_trackers/clover/core/kernel.cpp | 7 +++ src/gallium/state_trackers/clover/core/sampler.cpp | 12 src/gallium/state_trackers/clover/core/sampler.hpp | 1 + 3 files changed, 20 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b

Re: [Mesa-dev] [PATCH v2] glsl: avoid compiler's segfault when processing operators with void arguments

2015-08-10 Thread Mark Janes
Should this patch be cc'd to stable branches? Without it, the compiler crashes on invalid inputs, instead of generating an error. This patch applies cleanly to 10.5 and 10.6. -Mark Renaud Gaubert writes: > This is done by returning an rvalue of type void in the > ast_function_expression::hi

[Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-10 Thread Zoltan Gilian
--- src/gallium/drivers/r600/evergreen_compute.c | 25 ++ src/gallium/drivers/r600/evergreen_state.c | 30 -- src/gallium/drivers/r600/evergreend.h| 5 + src/gallium/drivers/r600/r600_pipe.h | 7 +- src/gallium/drivers/r600/r6

[Mesa-dev] [PATCH 2/2] clover: recognize sampler kernel arguments

2015-08-10 Thread Zoltan Gilian
--- src/gallium/state_trackers/clover/llvm/invocation.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 86859af..50c4557 100644 --- a/src/gallium/state_trackers/clove

[Mesa-dev] [PATCH 2/2] r600, compute: setup RATs for write-only images

2015-08-10 Thread Zoltan Gilian
--- src/gallium/drivers/r600/evergreen_compute.c | 101 --- src/gallium/drivers/r600/evergreen_state.c | 44 +++- src/gallium/drivers/r600/r600_pipe.h | 4 +- src/gallium/drivers/radeon/r600_texture.c| 1 + 4 files changed, 109 insertions(+), 41 d

Re: [Mesa-dev] [PATCHv2 07/14] i965: Implement surface state set-up for shader images.

2015-08-10 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 4:04 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Wed, May 13, 2015 at 9:43 AM, Francisco Jerez >> wrote: >>> v2: Add SKL support. >>> --- >>> src/mesa/drivers/dri/i965/brw_context.h | 2 + >>> src/mesa/drivers/dri/i965/brw_surface_formats.c |

[Mesa-dev] [PATCH 1/2] r600, compute: refactor 1st arg of evergreen_set_rat

2015-08-10 Thread Zoltan Gilian
--- src/gallium/drivers/r600/evergreen_compute.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c index d89e3de..8b27a66 100644 --- a/src/gallium/drivers/r600/ever

Re: [Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 11:30 AM, Matt Turner wrote: > On Mon, Aug 10, 2015 at 11:19 AM, Jason Ekstrand wrote: >> On Mon, Aug 10, 2015 at 11:16 AM, Matt Turner wrote: >>> On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote: On BDW+, the negation source modifier on NOT, AND, OR, and XOR, i

Re: [Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-10 Thread Matt Turner
On Mon, Aug 10, 2015 at 11:37 AM, Jason Ekstrand wrote: > On Mon, Aug 10, 2015 at 11:30 AM, Matt Turner wrote: >> On Mon, Aug 10, 2015 at 11:19 AM, Jason Ekstrand >> wrote: >>> On Mon, Aug 10, 2015 at 11:16 AM, Matt Turner wrote: On Mon, Aug 3, 2015 at 5:22 PM, Jason Ekstrand wrote

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-10 Thread Matt Turner
On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: > From: Ian Romanick > > On many CPU-limited applications, this is *the* hot path. The idea is > to generate per-API versions of brw_draw_prims that elide some checks. > This patch removes render-mode and "is everything in VBOs" checks from >

[Mesa-dev] [PATCH 1/2] i965/vec4_visitor: Make some function arguments const references

2015-08-10 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4.h | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index 0c13d43..24bf354 100644 --- a/src/

  1   2   >