Re: [Mesa-dev] [PATCH 1/3] winsys/radeon: Use separate caching buffer manager for each set of flags

2014-10-16 Thread Michel Dänzer
On 15.10.2014 20:24, Marek Olšák wrote: With so many cache managers, memory usage might be a bigger problem. Usually when a cache manager fails to allocate a new buffer, it clears the cache and tries again. This is not so useful when there are a lot of them, because the other managers aren't cle

Re: [Mesa-dev] [PATCH] glsl: Lower constant arrays to uniform arrays.

2014-10-16 Thread Eric Anholt
Kenneth Graunke writes: > Consider GLSL code such as: > >const ivec2 offsets[] = > ivec2[](ivec2(-1, -1), ivec2(-1, 0), ivec2(-1, 1), > ivec2(0, -1), ivec2(0, 0), ivec2(0, 1), > ivec2(1, -1), ivec2(1, 0), ivec2(1, 1)); > >ivec2 offset = offsets[]; > >

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #24 from Iago Toral --- Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP? Currently this is handled as a special case in the texstore.c ubyte path (store_ubyte_texture), specifically, the special case handles extr

Re: [Mesa-dev] [PATCH 1/3] gallium/vc4: correctly include the source files

2014-10-16 Thread Eric Anholt
Emil Velikov writes: > The kernel files are built into a separate static library and > all the functions that require it are already wrapped in ifdef > USE_VC4_SIMULATOR. Don't forget the header file :) I'm probably going to be using a bunch of this code for dumping of debug traces on non-simula

[Mesa-dev] [PATCH] glsl: Update and fix typos in README.

2014-10-16 Thread Andres Gomez
--- src/glsl/README | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/README b/src/glsl/README index 0a0afcc..2f93f12 100644 --- a/src/glsl/README +++ b/src/glsl/README @@ -8,7 +8,7 @@ passed straight through. See glcpp/* 2) lex and yacc-based parser

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #43 from Ernst Sjöstrand --- Commit? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedes

Re: [Mesa-dev] [PATCH] glsl: Lower constant arrays to uniform arrays.

2014-10-16 Thread Marek Olšák
The radeonsi LLVM backend handles this very poorly too. It seems to do the same thing that i965 does. Marek On Thu, Oct 16, 2014 at 2:32 AM, Kenneth Graunke wrote: > Consider GLSL code such as: > >const ivec2 offsets[] = > ivec2[](ivec2(-1, -1), ivec2(-1, 0), ivec2(-1, 1), >

[Mesa-dev] [WIP 02/25] mesa: Teach uniform update to take into account double precision

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/main/uniform_query.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index f5787a9..e71b46f 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform

[Mesa-dev] [WIP] i965/fs: Initial support for arb_gpu_shader_fp64

2014-10-16 Thread Topi Pohjolainen
Here is some basis for supporting double precision floats on i965 hw. On IVB this gives (details below): piglit-run.py --include-tests "ARB_gpu_shader_fp64" tests/all.py /tmp/foo [32/32] crash: 2, fail: 5, pass: 24, skip: 1 This sits on top of Dave Airlie's and Ilia Mirkin's f

[Mesa-dev] [WIP 04/25] i965: Tell backend register about double precision type

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen Signed-off-by: Tapani P\344lli Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_shader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp i

[Mesa-dev] [WIP 08/25] i965/fs: Add support for double precision uniform loading

2014-10-16 Thread Topi Pohjolainen
Unfortunately the safety assertion needs to be dropped as the amount occupied by different types of uniforms is not the same anymore. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/

[Mesa-dev] [WIP 05/25] i965/fs: Prepare virtual registers for double precision floats

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index e2e942c..bec7418 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp ++

[Mesa-dev] [WIP 01/25] i965: Lower DFRACEXP/DLDEXP

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_shader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 187470c..ddef818 100644 --- a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [WIP 10/25] i965/fs: Double precision to single conversion support

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 13 - 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.c

[Mesa-dev] [WIP 03/25] i965: Determine size of double precision float register

2014-10-16 Thread Topi Pohjolainen
This is used to determine how many registers an instruction reads and writes as well as for offseting register region into a desired component. Signed-off-by: Topi Pohjolainen Signed-off-by: Tapani P\344lli Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_reg.h | 2 ++ 1 file c

[Mesa-dev] [WIP 06/25] i965/fs: Take double float into account in register offsets

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 4 +++- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 8 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 943e6

[Mesa-dev] [WIP 12/25] i965: Add helper telling if a register is scalar

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_reg.h | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa/drivers/dri/i965/brw_reg.h index cf2ef13..7cf748f 100644 --- a/src/mesa/drivers/dri/i965/brw_reg.h +++ b/src/mesa/dri

[Mesa-dev] [WIP 17/25] i965/fs: Make generator to emit two instructions for double floats

2014-10-16 Thread Topi Pohjolainen
TODO: 3-src operations Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 39 + 1 file changed, 39 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index 92f19e2..a5e3475 1006

[Mesa-dev] [WIP 16/25] i965/gen7: Add support for double precision constant operands

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index c352631..fa3fc41 100644 --- a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [WIP 15/25] i965/gen8: Add support for double precision constant operands

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen Signed-off-by: Tapani P\344lli Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 3 +++ src/mesa/drivers/dri/i965/

[Mesa-dev] [WIP 07/25] i965/fs: Prepare live interval analysis for double precision

2014-10-16 Thread Topi Pohjolainen
TODO: Prevent double precision being split between push and pull. Perhaps it would be easiest just to force them into pull. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [WIP 11/25] i965/fs: Prepare register allocator for double precision floats

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h| 1 + src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 29 +++ 2 files changed, 30 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h in

[Mesa-dev] [WIP 19/25] i965/fs: Collect results for double precision conditionals

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 43 src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ 2 files changed, 46 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 717

[Mesa-dev] [WIP 20/25] i965/gen7: Add support for loading double float scalars in 16-width

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_eu.h | 4 src/mesa/drivers/dri/i965/brw_eu_emit.c | 24 2 files changed, 28 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu.h b/src/mesa/drivers/dri/i965/brw_eu.h index 22d5a0a..2d2

[Mesa-dev] [WIP 13/25] i965/fs: Add pack_double_2x32 virtual opcode

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_fs.h | 5 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 96 ++ 3 files changed, 102 insertions(+) diff --git a/src/mesa/drivers/dri/

[Mesa-dev] [WIP 09/25] i965/fs: Generator support for converting double to float

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h| 2 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 45 ++ 2 files changed, 47 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defi

[Mesa-dev] [WIP 21/25] i965/fs/gen7: Add generator support for loading double precision uniforms

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 32 ++ 3 files changed, 36 insertions(+) diff --git a/src/mesa/drivers/dri/

[Mesa-dev] [WIP 24/25] i965/fs: Add unpack_double_2x32 virtual opcode

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h| 2 + src/mesa/drivers/dri/i965/brw_fs.h | 5 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 52 ++ 3 files changed, 59 insertions(+) diff --git a/src/mesa/drivers/dri/

[Mesa-dev] [WIP 22/25] i965: Add helper telling if uniform is double and requires special load

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_shader.cpp | 36 src/mesa/drivers/dri/i965/brw_shader.h | 2 ++ 2 files changed, 38 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cp

[Mesa-dev] [WIP 25/25] i965/fs: Add support for ir_unop_unpack_double_2x32

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 2 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp b/src

[Mesa-dev] [WIP 18/25] i965/fs: Generate two instructions for double precision comparison

2014-10-16 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_eu_emit.c| 6 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 7 --- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_em

Re: [Mesa-dev] [WIP] i965/fs: Initial support for arb_gpu_shader_fp64

2014-10-16 Thread Pohjolainen, Topi
On Thu, Oct 16, 2014 at 03:24:12PM +0300, Topi Pohjolainen wrote: > Here is some basis for supporting double precision floats on i965 hw. > On IVB this gives (details below): > > piglit-run.py --include-tests "ARB_gpu_shader_fp64" tests/all.py /tmp/foo > [32/32] crash: 2, fail: 5, pass: 24, skip:

Re: [Mesa-dev] [WIP] i965/fs: Initial support for arb_gpu_shader_fp64

2014-10-16 Thread Ilia Mirkin
On Thu, Oct 16, 2014 at 8:24 AM, Topi Pohjolainen wrote: > Here is some basis for supporting double precision floats on i965 hw. > On IVB this gives (details below): > > piglit-run.py --include-tests "ARB_gpu_shader_fp64" tests/all.py /tmp/foo > [32/32] crash: 2, fail: 5, pass: 24, skip: 1 This s

Re: [Mesa-dev] [PATCH 1/3] gallium/vc4: correctly include the source files

2014-10-16 Thread Emil Velikov
On 16/10/14 09:39, Eric Anholt wrote: > Emil Velikov writes: > >> The kernel files are built into a separate static library and >> all the functions that require it are already wrapped in ifdef >> USE_VC4_SIMULATOR. Don't forget the header file :) > > I'm probably going to be using a bunch of th

Re: [Mesa-dev] [WIP 05/25] i965/fs: Prepare virtual registers for double precision floats

2014-10-16 Thread Jason Ekstrand
On Oct 16, 2014 5:24 AM, "Topi Pohjolainen" wrote: > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp > index e2e

Re: [Mesa-dev] [PATCH 3/8] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2014-10-16 Thread Ian Romanick
On 10/01/2014 12:00 PM, Neil Roberts wrote: > Previously the CreateContext method of __DriverApiRec took a set of arguments > to describe the attribute values from the window system API's > CreateContextAttribs function. As more attributes get added this could quickly > get unworkable and every new

[Mesa-dev] [PATCH 3/4] glsl_to_tgsi: fix the value of gl_FrontFacing with native integers

2014-10-16 Thread Marek Olšák
From: Marek Olšák We must convert it to boolean from the DX9 float encoding that Gallium specifies. Later, we should probably define that FACE should be 0 or ~0 if native integers are supported. Cc: 10.2 10.3 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 +- 1 file changed,

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #25 from Kenneth Graunke --- I thought we killed color indexing with fire a while back. Did we miss some? -- You are receiving this mail because: You are the QA Contact for the bug. ___ m

[Mesa-dev] [PATCH 4/4] glsl_to_tgsi: use _mesa_copy_linked_program_data

2014-10-16 Thread Marek Olšák
From: Marek Olšák This deduplicates some code. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 21f4cb8..a6ce033 100644 --- a/src/m

[Mesa-dev] [PATCH 03/10] radeonsi: generate shader pm4 states right after shader compilation

2014-10-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 1 + src/gallium/drivers/radeonsi/si_state.h | 2 ++ src/gallium/drivers/radeonsi/si_state_draw.c | 38 +++- 3 files changed, 24 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 06/10] radeonsi: statically declare resource and sampler arrays

2014-10-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 6f2fb7b..cd78f66 100644 --- a/src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 10/10] r600g, radeonsi: convert TGSI shader type to LLVM shader type

2014-10-16 Thread Marek Olšák
From: Marek Olšák The values are hardcoded in the LLVM backend, but the TGSI definitions are going to be changed with tessellation, e.g. TGSI_PROCESSOR_COMPUTE will be increased by 2. We'll use VS for LS and HS, because there's nothing special about them from the LLVM backend point of view, even

[Mesa-dev] [PATCH 01/10] radeonsi: inline si_pm4_alloc_state

2014-10-16 Thread Marek Olšák
From: Marek Olšák It seemed like the function needed a context pointer. Let's remove it to make it less confusing. --- src/gallium/drivers/radeonsi/si_pm4.c| 5 - src/gallium/drivers/radeonsi/si_pm4.h| 1 - src/gallium/drivers/radeonsi/si_state.c | 14 +++--- s

[Mesa-dev] [PATCH 05/10] radeonsi: remove conversion of DX9 FACE input to GL

2014-10-16 Thread Marek Olšák
From: Marek Olšák st/mesa and gallium expect the DX9 format, so this is useless. --- src/gallium/drivers/radeonsi/si_shader.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c i

[Mesa-dev] [PATCH 07/10] radeonsi: clarify shader constant load functions

2014-10-16 Thread Marek Olšák
From: Marek Olšák I'll need indexed loads without the meta data flag for tessellation later. Also rename load_const to buffer_load_const to distinguish it from indexed const loads. --- src/gallium/drivers/radeonsi/si_shader.c | 68 +--- 1 file changed, 36 insertions(+

[Mesa-dev] [PATCH 09/10] radeonsi: add some missing register definitions

2014-10-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/sid.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/gallium/drivers/radeonsi/sid.h b/src/gallium/drivers/radeonsi/sid.h index 3241725..c4d4afd 100644 --- a/src/gallium/drivers/radeonsi/sid.h +++ b/src/gallium/

[Mesa-dev] [PATCH 1/4] gallium: add PIPE_SHADER_CAP_MAX_OUTPUTS and use it in st/mesa

2014-10-16 Thread Marek Olšák
From: Marek Olšák With 5 shader stages and various combinations of enabled and disabled shaders, the maximum number of outputs in one shader doesn't have to be equal to the maximum number of inputs in the following shader. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 2 ++ src/gallium/

Re: [Mesa-dev] [PATCH 5/8] glx: Add the GLX_ARB_flush_control extension

2014-10-16 Thread Ian Romanick
On 10/01/2014 12:00 PM, Neil Roberts wrote: > This adds the framework for the GLX flush control extension. It is advertised > if the DRI driver implements the new __DRI2_FLUSH_CONTROL extension. The GLX > attributes are converted to the appropriate DRI attributes. > --- > src/glx/dri2_glx.c |

Re: [Mesa-dev] [PATCH 7/8] i965: Implement the __DRI2_FLUSH_CONTROL extension

2014-10-16 Thread Ian Romanick
On 10/01/2014 12:00 PM, Neil Roberts wrote: > Implementing the extension just involves copying the release behaviour value > from the context config to the GL context's constants. The upper layers of > Mesa handles the actual flushing. > --- > src/mesa/drivers/dri/i965/brw_context.c | 20

Re: [Mesa-dev] [PATCH 0/8] Implement GL_KHR_flush_control

2014-10-16 Thread Ian Romanick
Patches 1, 2, and 8 are Reviewed-by: Ian Romanick I sent out comments that affect the other five in the series. The comment on patch 3 affects patches 3, 4, and, trivially, 7. On 10/01/2014 12:00 PM, Neil Roberts wrote: > Here's a series of patches to implement GL_KHR_flush_control and > GLX_A

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Generate better code for ir_triop_csel.

2014-10-16 Thread Ian Romanick
Yeah... I recall observing this when I was doing other bool related optimization work, but I never got around to fixing it. Reviewed-by: Ian Romanick On 10/15/2014 08:51 PM, Kenneth Graunke wrote: > Previously, we generated an extra CMP instruction: > >cmp.ge.f0(8) g4<1>D g2<0,1,

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Delete some dead code in visit(ir_expression *).

2014-10-16 Thread Ian Romanick
On 10/15/2014 08:51 PM, Kenneth Graunke wrote: > Nothing uses the vector_elements temporary variable. That's weird... was vector_elements ever used? Either way, the changes are pretty straightforward. Reviewed-by: Ian Romanick > Setting this->result.file is dead because we overwrite this->resu

Re: [Mesa-dev] [PATCH 4/4] i965/vec4: Generate better code for ir_triop_csel.

2014-10-16 Thread Ian Romanick
On 10/15/2014 08:51 PM, Kenneth Graunke wrote: > Previously, we generated an extra CMP instruction: > >cmp.ge.f0(8)g6<1>D g1<0,4,1>F 0F >cmp.nz.f0(8)nullg6<4,4,1>D 0D >(+f0) sel(8)g5<1>F g1.4<0,4,1>Fg2<0,4,1>F > > The first opera

[Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-16 Thread Kenneth Graunke
A while back, Matt made the uniform upload functions simply upload ctx->Const.UniformBooleanTrue for boolean values instead of 0/1, which removed the need to convert it later. We also set UniformBooleanTrue to 1.0f for drivers which want to treat booleans as 0.0/1.0f. Nothing ever sets these, so

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #44 from Marek Olšák --- The patch was rejected. Christian said he would take a look at the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev ma

Re: [Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread Roland Scheidegger
On 10/16/2014 08:33 AM, bugzilla-dae...@freedesktop.org wrote: *Comment # 25 I thought we killed color indexing with fire a while back. Did we miss some? You can't kill glBitmap (in a non-core context, anyway). Strictly speaking these aren't color indexed textures, but still hit all the same

Re: [Mesa-dev] [PATCH] glsl: Update and fix typos in README.

2014-10-16 Thread Kenneth Graunke
On Thursday, October 16, 2014 11:40:39 AM Andres Gomez wrote: > --- > src/glsl/README | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Pushed, thanks! signature.asc Description: This is a digitally signed message part. ___ mesa-

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-16 Thread Tapani
Reviewed-by: Tapani Pälli On 10/16/2014 07:28 PM, Kenneth Graunke wrote: A while back, Matt made the uniform upload functions simply upload ctx->Const.UniformBooleanTrue for boolean values instead of 0/1, which removed the need to convert it later. We also set UniformBooleanTrue to 1.0f for dr

Re: [Mesa-dev] [WIP 05/25] i965/fs: Prepare virtual registers for double precision floats

2014-10-16 Thread Pohjolainen, Topi
On Thu, Oct 16, 2014 at 07:29:10AM -0700, Jason Ekstrand wrote: >On Oct 16, 2014 5:24 AM, "Topi Pohjolainen" >wrote: >> >> Signed-off-by: Topi Pohjolainen >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH] winsys/radeon: Use a single buffer cache manager again

2014-10-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 16, 2014 at 8:58 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The trick is to generate a unique buffer usage value for each possible > combination of domains and flags, with only one bit set each for the > domains and flags. This ensures pb_chec

Re: [Mesa-dev] [PATCH 6/8] intel: Don't flush the old context in intelMakeCurrent

2014-10-16 Thread Neil Roberts
Ian Romanick writes: > I'm a little bit skeptical of this. _mesa_make_current doesn't call > intelMakeCurrent. intelMakeCurrent calls _mesa_make_current, and it > calls _mesa_make_current much later in this function. By the time > _mesa_make_current is called, a bunch of driver state has been

Re: [Mesa-dev] [WIP] i965/fs: Initial support for arb_gpu_shader_fp64

2014-10-16 Thread Pohjolainen, Topi
On Thu, Oct 16, 2014 at 09:50:44AM -0400, Ilia Mirkin wrote: > On Thu, Oct 16, 2014 at 8:24 AM, Topi Pohjolainen > wrote: > > Here is some basis for supporting double precision floats on i965 hw. > > On IVB this gives (details below): > > > > piglit-run.py --include-tests "ARB_gpu_shader_fp64" tes

Re: [Mesa-dev] [WIP] i965/fs: Initial support for arb_gpu_shader_fp64

2014-10-16 Thread Ilia Mirkin
On Thu, Oct 16, 2014 at 1:25 PM, Pohjolainen, Topi wrote: > On Thu, Oct 16, 2014 at 09:50:44AM -0400, Ilia Mirkin wrote: >> On Thu, Oct 16, 2014 at 8:24 AM, Topi Pohjolainen >> wrote: >> > Here is some basis for supporting double precision floats on i965 hw. >> > On IVB this gives (details below)

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #45 from Christian König --- (In reply to Marek Olšák from comment #44) > The patch was rejected. Christian said he would take a look at the issue. I unfortunately got distracted by something else. Feel free to commit the workaround

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #26 from Jason Ekstrand --- (In reply to Iago Toral from comment #24) > Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP? > > Currently this is handled as a special case in the texstore.c ubyte path > (store_ubyte

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #27 from Jason Ekstrand --- (In reply to Iago Toral from comment #23) > (In reply to Jason Ekstrand from comment #21) > > (In reply to Iago Toral from comment #19) > > > Jason, for conversions where we cannot use a fast path in the ma

Re: [Mesa-dev] [PATCH 1/4] gallium: add PIPE_SHADER_CAP_MAX_OUTPUTS and use it in st/mesa

2014-10-16 Thread Roland Scheidegger
On 10/16/2014 08:33 AM, Marek Olšák wrote: From: Marek Olšák With 5 shader stages and various combinations of enabled and disabled shaders, the maximum number of outputs in one shader doesn't have to be equal to the maximum number of inputs in the following shader. --- src/gallium/auxiliary/g

Re: [Mesa-dev] [PATCH 4/4] i965/vec4: Generate better code for ir_triop_csel.

2014-10-16 Thread Matt Turner
On Thu, Oct 16, 2014 at 9:01 AM, Ian Romanick wrote: > On 10/15/2014 08:51 PM, Kenneth Graunke wrote: >> Previously, we generated an extra CMP instruction: >> >>cmp.ge.f0(8)g6<1>D g1<0,4,1>F 0F >>cmp.nz.f0(8)nullg6<4,4,1>D 0D >>(+f0) sel(8)g5<

Re: [Mesa-dev] [PATCH 4/4] i965/vec4: Generate better code for ir_triop_csel.

2014-10-16 Thread Matt Turner
On Wed, Oct 15, 2014 at 8:51 PM, Kenneth Graunke wrote: > Previously, we generated an extra CMP instruction: > >cmp.ge.f0(8)g6<1>D g1<0,4,1>F 0F >cmp.nz.f0(8)nullg6<4,4,1>D 0D >(+f0) sel(8)g5<1>F g1.4<0,4,1>Fg2<0,4,1>F > > The fir

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-16 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/4] gallium: add PIPE_SHADER_CAP_MAX_OUTPUTS and use it in st/mesa

2014-10-16 Thread Marek Olšák
On Thu, Oct 16, 2014 at 8:40 PM, Roland Scheidegger wrote: > On 10/16/2014 08:33 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> With 5 shader stages and various combinations of enabled and disabled >> shaders, >> the maximum number of outputs in one shader doesn't have to be equal to >> the

Re: [Mesa-dev] [PATCH 3/4] glsl_to_tgsi: fix the value of gl_FrontFacing with native integers

2014-10-16 Thread Roland Scheidegger
Looks correct to me. I agree a boolean face var would be nice. Last time looking at it it seemed a bit non trivial (because the face var isn't just used in glsl fragment shaders). Roland On 10/16/2014 08:33 AM, Marek Olšák wrote: From: Marek Olšák We must convert it to boolean from the DX9

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] i965/fs: Change the type of booleans to UD and emit correct immediates

2014-10-16 Thread Jason Ekstrand
Before, we used the a signed d-word for booleans and the immedates we emitted varried between signed and unsigned. This commit changes the type to unsigned (I think that makes more sense) and makes immediates more consistent. This allows copy propagation to work better cleans up some instructions

Re: [Mesa-dev] [PATCH] i965/fs: Change the type of booleans to UD and emit correct immediates

2014-10-16 Thread Kenneth Graunke
On Thursday, October 16, 2014 03:40:31 PM Jason Ekstrand wrote: > Before, we used the a signed d-word for booleans and the immedates we > emitted varried between signed and unsigned. This commit changes the type > to unsigned (I think that makes more sense) and makes immediates more > consistent.

Re: [Mesa-dev] [PATCH] i965/fs: Change the type of booleans to UD and emit correct immediates

2014-10-16 Thread Matt Turner
On Thu, Oct 16, 2014 at 3:40 PM, Jason Ekstrand wrote: > Before, we used the a signed d-word for booleans and the immedates we > emitted varried between signed and unsigned. This commit changes the type > to unsigned (I think that makes more sense) and makes immediates more > consistent. This al

[Mesa-dev] [PATCH 2/3] r600g/compute: Enable PIPE_SHADER_IR_NATIVE for compute shaders v2

2014-10-16 Thread Tom Stellard
v2: - Drop dependency on LLVM >= 3.5.1 --- src/gallium/drivers/r600/evergreen_compute.c | 167 + .../drivers/r600/evergreen_compute_internal.h | 12 +- src/gallium/drivers/r600/r600_llvm.c | 71 ++--- src/gallium/drivers/r600/r600_llvm.h

[Mesa-dev] [PATCH 3/3] radeonsi/compute: Enable PIPE_SHADER_IR_NATIVE for compute shaders v2

2014-10-16 Thread Tom Stellard
v2: - Drop dependency on LLVM >= 3.5.1 - Rename si_create_shader() to si_shader_binary_read() --- src/gallium/drivers/radeonsi/si_compute.c | 79 ++- src/gallium/drivers/radeonsi/si_pipe.c| 4 ++ src/gallium/drivers/radeonsi/si_shader.c | 104 ++-

[Mesa-dev] [PATCH 1/3] gallium/radeon: Add query for symbol specific config information

2014-10-16 Thread Tom Stellard
This adds a query which allows drivers to access the config information of a specific function within the LLVM generated ELF binary. This makes it possible for the driver to handle ELF binaries with multiple kernels / global functions. --- src/gallium/drivers/radeon/r600_pipe_common.h | 8

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #28 from Iago Toral --- (In reply to Kenneth Graunke from comment #25) > I thought we killed color indexing with fire a while back. Did we miss some? I see multiple references to GL_COLOR_INDEX in src/mesa/main and at least these pi

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #29 from Iago Toral --- (In reply to Jason Ekstrand from comment #26) > (In reply to Iago Toral from comment #24) > > Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP? > > > > Currently this is handled as a specia

Re: [Mesa-dev] [PATCH 1/4] gallium: add PIPE_SHADER_CAP_MAX_OUTPUTS and use it in st/mesa

2014-10-16 Thread Roland Scheidegger
On 10/16/2014 12:55 PM, Marek Olšák wrote: On Thu, Oct 16, 2014 at 8:40 PM, Roland Scheidegger wrote: On 10/16/2014 08:33 AM, Marek Olšák wrote: From: Marek Olšák With 5 shader stages and various combinations of enabled and disabled shaders, the maximum number of outputs in one shader doesn