On 10/15/2014 08:51 PM, Kenneth Graunke wrote:
> Nothing uses the vector_elements temporary variable.
That's weird... was vector_elements ever used?
Either way, the changes are pretty straightforward.
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
> Setting this->result.file is dead because we overwrite this->result a
> few lines later.
>
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> ---
> src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 8e32d8b..683d1f5 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -1289,14 +1289,6 @@ vec4_visitor::visit(ir_expression *ir)
> assert(!ir->operands[operand]->type->is_matrix());
> }
>
> - int vector_elements = ir->operands[0]->type->vector_elements;
> - if (ir->operands[1]) {
> - vector_elements = MAX2(vector_elements,
> - ir->operands[1]->type->vector_elements);
> - }
> -
> - this->result.file = BAD_FILE;
> -
> /* Storage for our result. Ideally for an assignment we'd be using
> * the actual storage for the result here, instead.
> */
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
