[Mesa-dev] [PATCH] i965: Delete bogus BRW_REGISTER_TYPE_HF define.

git blame ascribes this to the initial commit of the driver. No released hardware has ever supported half float, according to the documentation for SrcType in the ISA reference. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 1 - src/mesa/drivers/dri/i965/brw_reg.h

Re: [Mesa-dev] i965: Remove surface state Tile-X / Tile-Y offsets (GEN8 enabling)

On Monday, December 09, 2013 10:21:24 AM Jordan Justen wrote: > > Gen 6/7 hardware support for tile_x and tile_y offset fields in > > SURFACE_STATE has been removed in Gen8. All code dependencies must be > > removed. This patch series completely eliminates the tile_x and y fields > > in the normal

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #18 from James Cook --- Created attachment 90563 --> https://bugs.freedesktop.org/attachment.cgi?id=90563&action=edit /proc/cpuinfo from james.c...@utoronto.ca Whoops, I must have sent cpuinfo from the laptop I sent the e-mail from

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=67672 James Cook changed: What|Removed |Added CC||james.c...@utoronto.ca -- You are receivin

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #19 from James Cook --- Note, I might be running a different kernel version now compared to before; not sure whether that affects the contents of /proc/cpuinfo. -- You are receiving this mail because: You are the assignee for the bu

Re: [Mesa-dev] [PATCH 08/15] i965: Reserve space for "Vertex Count" in GS outputs.

On 12/01/2013 08:14 AM, Paul Berry wrote: > On 30 November 2013 13:14, Kenneth Graunke > wrote: > > On 11/30/2013 10:29 AM, Paul Berry wrote: > > On 12 November 2013 17:51, Kenneth Graunke > >

[Mesa-dev] [PATCH 1/7] i965: Include brw_reg.h in brw_disasm.c.

We're going to move some things from brw_defines.h there in a moment. Both files contain symbols named negate, so we need to arbitrarily rename them. (The "m_" prefix is a convention I adopted in the Gen8+ code). We can always rename the brw_reg.h copy of negate at a later date. Signed-off-by: K

[Mesa-dev] [PATCH 5/7] i965: Abstract BRW_REGISTER_TYPE_* into an enum with unique values.

On released hardware, values 4-6 are overloaded. For normal registers, they mean UB/B/DF. But for immediates, they mean UV/VF/V. Previously, we just created #defines for each name, reusing the same value. This meant we could directly splat the brw_reg::type field into the assembly encoding, whi

[Mesa-dev] [PATCH 6/7] i965: Add BRW_REGISTER_TYPE_DF.

Ivybridge, Baytrail, and Haswell support double float register types, but do not support them as immediate values. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +++ src/mesa/drivers/dri/i965/brw_reg.h | 2 ++ 3

[Mesa-dev] [PATCH 3/7] i965: Disassemble UV types, not UB types.

UB types have never been supported as immediates. On Gen4-5, register encoding 4 is "Reserved." On Gen6+, it means UV. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_disasm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 7/7] i965: Add support for Broadwell's new register types.

Broadwell introduces support for Q, UQ, and HF types. It also extends DF support to allow immediate values. Irritatingly, although HF and DF both support immediates, they're represented by a different value depending on the register file. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri

[Mesa-dev] [PATCH 4/7] i965: Decode three-source register types directly.

Three-source instructions use a different encoding for register types (and have a much more limited set to choose from). Previously, we translated those into BRW_REGISTER_TYPE_* values, then reused the existing reg_encoding mapping. Doing it directly is more straightforward and actually less code

[Mesa-dev] [PATCH 2/7] i965: Add missing BRW_REGISTER_TYPE_UV.

Sandybridge added support for packed unsigned vectors. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 3c43f8a..abecfc8 100644 -

[Mesa-dev] [PATCH] mesa: fix a typo in glDetachShader error message

Signed-off-by: Tapani Pälli --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 1d9aac3..4f3be68 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -414,7 +414,7 @@ det

[Mesa-dev] [Bug 70250] weston-terminal rendering corrupted with output transform 90 and 270

https://bugs.freedesktop.org/show_bug.cgi?id=70250 --- Comment #6 from U. Artie Eoff --- (In reply to comment #5) > Since you marked the bug as VERIFIED, I'll call that a Tested-by. Sorry for > the noise. Correct. This is how I've been doing it over here in "Wayland Land"... marking the bug as

Re: [Mesa-dev] [PATCH 1/2] draw: fix vbuf caching of vertices with inject front face

- Original Message - > Caching in the vbuf module meant that once a vertex has been > emitted it was cached, but it's possible for a vertex at the > same location to be emitted again, but this time with a different > front-face semantic. Caching was causing the first version of the > vertex

[Mesa-dev] [PATCH 0/5] Newbie Project : Implement ARB_clear_buffer_object

Hello, these are some patches to implement "ARB_clear_buffer_object" (as suggested by Ian Romanick). I also wrote some piglit tests and will be submitting those in a minute. Best Regards, Pi Tabred *Note* that I don't have write access. Pi Tabred (5): mesa: Add infrastructure for GL_ARB_clea

[Mesa-dev] [PATCH 4/5] mesa: Implement functions for clear_buffer_object extensions

- _mesa_buffer_clear_subdata: default callback for dd function table - _mesa_ClearBufferData: API function - _mesa_ClearBufferSubData: API function *NOTE* According to the spec, it should be possible to clear some part of a buffer, even if a different, non-overlapping part is mapped, this is cu

[Mesa-dev] [PATCH 2/5] mesa: Make validate_texbuffer_format function available externally

- change storage class from static to extern - rename validate_texbuffer_format to _mesa_validate_texbuffer_format --- src/mesa/main/teximage.c | 398 --- src/mesa/main/teximage.h | 4 + 2 files changed, 206 insertions(+), 196 deletions(-) diff --gi

[Mesa-dev] [PATCH 3/5] mesa: add _mesa_bufferobj_range_mapped function

Add function to test if the buffer is already mapped and if so, if the to be mapped range overlaps with the mapped range. Modify the _mesa_InvalidateBufferSubData function to use the new function. --- src/mesa/main/bufferobj.c | 52 +-- 1 file changed, 3

[Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

- add xml file for extension - add reference in gl_API.xml - add pointer to device driver function table - add new functions to list of available functions --- src/mapi/glapi/gen/ARB_clear_buffer_object.xml | 50 ++ src/mapi/glapi/gen/gl_API.xml | 6 ++

[Mesa-dev] [PATCH 5/5] mesa: Add extension to release notes and to list of supported extensions

--- docs/relnotes/10.1.html| 1 + src/mesa/main/extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/10.1.html b/docs/relnotes/10.1.html index dfb0969..778ae6a 100644 --- a/docs/relnotes/10.1.html +++ b/docs/relnotes/10.1.html @@ -45,6 +45,7 @@ Note: some of the new

Re: [Mesa-dev] PATCHES: R600: Register machine passes and code cleanups

On Mon, Dec 9, 2013 at 11:02 AM, Tom Stellard wrote: > Hi, > > The first two patches register the R600EmitClauseMarkers and > AMDGPUCFGStructurizer passes, so that -print-*-all will now work with > them. The third patch is a cleanup of Processors.td and the fourth > patch adds the wavefront size

Re: [Mesa-dev] [PATCH] llvmpipe: fix blending with half-float formats

Am 10.12.2013 04:57, schrieb Zack Rusin: > The fact that we flush denorms to zero breaks our half-float > conversion and blending. This patches enables denorms for > blending. It's a little tricky due to the llvm bug that makes > it incorrectly reorder the mxcsr intrinsics: > http://llvm.org/bugs/s

Re: [Mesa-dev] [PATCH] mesa: fix a typo in glDetachShader error message

On 12/10/2013 05:28 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 1d9aac3..4f3be68 100644 --- a/src/mesa/main/shaderapi.c +++ b/s

Re: [Mesa-dev] [PATCH 2/5] mesa: Make validate_texbuffer_format function available externally

On 12/10/2013 06:13 AM, Pi Tabred wrote: - change storage class from static to extern - rename validate_texbuffer_format to _mesa_validate_texbuffer_format --- src/mesa/main/teximage.c | 398 --- src/mesa/main/teximage.h | 4 + 2 files changed

Re: [Mesa-dev] [PATCH 3/5] mesa: add _mesa_bufferobj_range_mapped function

On 12/10/2013 06:13 AM, Pi Tabred wrote: Add function to test if the buffer is already mapped and if so, if the to be mapped range overlaps with the mapped range. That could be worded better. How about: "and if so, if the mapped range overlaps the given range." Modify the _mesa_InvalidateBu

Re: [Mesa-dev] [PATCH] drisw/gallium/llvmpipe: add MESA_copy_sub_buffer support (v2)

Sorry for the delay. Thanks for the update. Please update the other sw_winsys implementations in src/gallium/winsys/sw too. I think that updating the prototype and ignoring the new parameter should be fine. Otherwise looks good. Jose - Original Message - > This patches add MESA_cop

Re: [Mesa-dev] [PATCH 4/5] mesa: Implement functions for clear_buffer_object extensions

On 12/10/2013 06:13 AM, Pi Tabred wrote: - _mesa_buffer_clear_subdata: default callback for dd function table - _mesa_ClearBufferData: API function - _mesa_ClearBufferSubData: API function *NOTE* According to the spec, it should be possible to clear some part of a buffer, even if a differe

Re: [Mesa-dev] [PATCH 5/5] mesa: Add extension to release notes and to list of supported extensions

On 12/10/2013 06:13 AM, Pi Tabred wrote: --- docs/relnotes/10.1.html| 1 + src/mesa/main/extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/10.1.html b/docs/relnotes/10.1.html index dfb0969..778ae6a 100644 --- a/docs/relnotes/10.1.html +++ b/docs/relnotes/10.

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

Brian Paul writes: > On 12/07/2013 06:17 PM, Francisco Jerez wrote: >>[...] >> + default: >> + unreachable(); > > I think I'd like to see an assertion or _mesa_problem() call to catch > unhandled cases if new texture targets are added in the future. > > How about having the unreachable()

Re: [Mesa-dev] [PATCH 2/5] mesa: Make validate_texbuffer_format function available externally

On 10.12.2013 17:23, Brian Paul wrote: > On 12/10/2013 06:13 AM, Pi Tabred wrote: >> - change storage class from static to extern >> - rename validate_texbuffer_format to _mesa_validate_texbuffer_format >> --- >> src/mesa/main/teximage.c | 398 >>

Re: [Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

On Tue, Dec 10, 2013 at 2:13 PM, Pi Tabred wrote: > - add xml file for extension > - add reference in gl_API.xml > - add pointer to device driver function table > - add new functions to list of available functions > --- > src/mapi/glapi/gen/ARB_clear_buffer_object.xml | 50 >

Re: [Mesa-dev] [PATCH 08/11] mesa: Implement the GL entry points defined by ARB_shader_image_load_store.

Paul Berry writes: > On 7 December 2013 17:11, Francisco Jerez wrote: > >> Paul Berry writes: >[...] > > Wow, that explains why I never managed to pick up the convention by > osmosis. Thanks for explaining. > > BTW, after reading through format_pack.c, I found some exceptions to what > you sai

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

On 12/10/2013 09:42 AM, Francisco Jerez wrote: Brian Paul writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachable(); I think I'd like to see an assertion or _mesa_problem() call to catch unhandled cases if new texture targets are added in the future.

[Mesa-dev] Gallium3d Documentation

Hi All, I'm currently working on a project for teaching driver development using virtual machines. We have developed in QEMU a virtual graphics adapter capable of a reasonable feature set. Note that because it's used in a teaching course, it is not very high-performance, as it is designed to look

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

On 10 December 2013 08:42, Francisco Jerez wrote: > Brian Paul writes: > > > On 12/07/2013 06:17 PM, Francisco Jerez wrote: > >>[...] > >> + default: > >> + unreachable(); > > > > I think I'd like to see an assertion or _mesa_problem() call to catch > > unhandled cases if new texture targ

[Mesa-dev] [Bug 72572] New: [llvmpipe] no error on draw call without vbo set

https://bugs.freedesktop.org/show_bug.cgi?id=72572 Priority: medium Bug ID: 72572 Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] no error on draw call without vbo set Severity: normal Classification: Unclassified

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

Paul Berry writes: > On 10 December 2013 08:42, Francisco Jerez wrote: > >> Brian Paul writes: >> >> > On 12/07/2013 06:17 PM, Francisco Jerez wrote: >> >>[...] >> >> + default: >> >> + unreachable(); >> > >> > I think I'd like to see an assertion or _mesa_problem() call to catch >> > un

Re: [Mesa-dev] [PATCH] i965: Delete bogus BRW_REGISTER_TYPE_HF define.

On Tue, Dec 10, 2013 at 12:09 AM, Kenneth Graunke wrote: > git blame ascribes this to the initial commit of the driver. > > No released hardware has ever supported half float, according to the > documentation for SrcType in the ISA reference. > > Signed-off-by: Kenneth Graunke > --- I noticed th

Re: [Mesa-dev] Nesa-dev now integrated with patchwork

Paul Berry writes: > I just pushed some patches to piglit and mesa, and the script seems to be > working well now. Thanks for all your hard work on this, Carl! Cool! When I saw the subject of your mail, I was afraid something wasn't working again. I'm glad to know it's all working. > Anyway, it

[Mesa-dev] [PATCH 3/3] radeonsi: Write htile state to hardware.

--- src/gallium/drivers/radeonsi/si_state.c | 33 ++--- src/gallium/drivers/radeonsi/si_state.h | 1 - 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 7bae72a..68e8

[Mesa-dev] [PATCH 2/3] radeon: Allocate htile buffer for SI in r600_texture.

--- src/gallium/drivers/radeon/r600_texture.c | 82 +-- 1 file changed, 67 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index e7ce103..99db4df 100644 --- a/src/gallium/drivers/radeon/

[Mesa-dev] radeonsi htile (aka HyperZ) support v2

Performance numbers are still the same. I've addressed almost all the concerns. Registers that shouldn't be used when depth htile is disabled are still written anyway because I figured it's no big overhead, simpler, and possibly safer. si_texture_htile_alloc_size() is modeled after si_texture_get_c

[Mesa-dev] [PATCH 1/3] radeon: rearrange r600_texture and related code a bit.

This should make the differences and similarities between color and depth buffer handling more clear. --- src/gallium/drivers/r600/evergreen_state.c| 10 ++--- src/gallium/drivers/r600/r600_blit.c | 6 +-- src/gallium/drivers/r600/r600_state.c | 10 ++--- src/gallium/drivers/

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry writes: On 10 December 2013 08:42, Francisco Jerez wrote: Brian Paul writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachable(); I think I'd like to see an assertion or _mesa_problem() call t

[Mesa-dev] radeonsi htile (aka HyperZ) support v2 (fixed)

Fixed patch 3, the previous one didn't compile and would also have had a bug where it didn't compile. The storage location of db_render_override is a bit dubious, any better ideas? Create si_db_misc_state? Create si_db_framebuffer_state? ___ mesa-dev mai

[Mesa-dev] [PATCH] radeonsi: Write htile state to hardware.

--- src/gallium/drivers/radeonsi/si_state.c | 38 +++-- src/gallium/drivers/radeonsi/si_state.h | 2 +- 2 files changed, 32 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 7bae72a..67c

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

On Tue, Dec 10, 2013 at 1:31 PM, Brian Paul wrote: > On 12/10/2013 11:06 AM, Francisco Jerez wrote: >> >> Paul Berry writes: >> >>> On 10 December 2013 08:42, Francisco Jerez wrote: >>> Brian Paul writes: > On 12/07/2013 06:17 PM, Francisco Jerez wrote: >> >> [...] >>

Re: [Mesa-dev] [PATCH] radeonsi: Write htile state to hardware.

Hi Andreas, The setup of DB_RENDER_OVERRIDE isn't much different from your previous patch, but you probably know that already. You have 2 options: 1) You can emit DB_RENDER_OVERRIDE in the same way as CB_TARGET_MASK is emitted. It's a good example how to combine multiple states. 2) You can emit

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

Brian Paul writes: > On 12/10/2013 11:06 AM, Francisco Jerez wrote: >> Paul Berry writes: >> >>> On 10 December 2013 08:42, Francisco Jerez wrote: >>> Brian Paul writes: > On 12/07/2013 06:17 PM, Francisco Jerez wrote: >> [...] >> + default: >> + unreachable();

[Mesa-dev] [PATCH 2/9] glsl: Add extension tracking for AMD_shader_trinary_minmax

--- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 7edc274..7b07498 100644 --- a/src/glsl/glcpp/glcpp-parse.y ++

[Mesa-dev] [PATCH 1/9] mesa: add entry AMD_shader_trinary_minmax to extension_table

i --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index db3cc3b..48f10e3 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3427,6 +3427,7 @@ struct gl_extensions /* vendor extensions */ GLbool

[Mesa-dev] [PATCH 7/9] mesa: enable AMD_shader_trinary_minmax

--- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 0828c60..ee27556 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -302,6 +302,7 @@ static const struct extension extension_tab

[Mesa-dev] [PATCH 5/9] glsl: implement max3 built-in function

--- src/glsl/builtin_functions.cpp | 44 ++ src/glsl/ir_builder.cpp| 5 + src/glsl/ir_builder.h | 1 + 3 files changed, 50 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 7399e8f..1f21a

[Mesa-dev] [PATCH 3/9] glsl: add a shader_trinary_minmax predicate

--- src/glsl/builtin_functions.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 6af587a..481a456 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp @@ -334,6 +334,12 @@ shader_atomic_co

[Mesa-dev] [PATCH 6/9] glsl: implement mid3 built-in function

--- src/glsl/builtin_functions.cpp | 44 ++ 1 file changed, 44 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 1f21a37..b9beffd 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH 8/9] glsl: switch AMD_shader_trinary_minmax support flag to dummy_true

--- src/glsl/glsl_parser_extras.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 00d85c7..03394c6 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -544,7 +544,7 @@ st

[Mesa-dev] [PATCH 4/9] glsl: Implement min3 built-in function

--- src/glsl/builtin_functions.cpp | 45 ++ src/glsl/ir_builder.cpp| 5 + src/glsl/ir_builder.h | 2 ++ 3 files changed, 52 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 481a456..7399

[Mesa-dev] [PATCH 9/9] docs/relnotes/10.1.html: report AMD_shader_trinary_minmax support

--- docs/relnotes/10.1.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.1.html b/docs/relnotes/10.1.html index dfb0969..91173b6 100644 --- a/docs/relnotes/10.1.html +++ b/docs/relnotes/10.1.html @@ -45,6 +45,7 @@ Note: some of the new features are only available with cert

Re: [Mesa-dev] [PATCH 4/9] glsl: Implement min3 built-in function

On Tue, Dec 10, 2013 at 2:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > --- > src/glsl/builtin_functions.cpp | 45 > ++ > src/glsl/ir_builder.cpp| 5 + > src/glsl/ir_builder.h | 2 ++ > 3 files changed, 52 insertions(+) > > d

Re: [Mesa-dev] [PATCH 5/9] glsl: implement max3 built-in function

On Tue, Dec 10, 2013 at 2:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > --- > src/glsl/builtin_functions.cpp | 44 > ++ > src/glsl/ir_builder.cpp| 5 + > src/glsl/ir_builder.h | 1 + > 3 files changed, 50 insertions(+) > > di

Re: [Mesa-dev] [PATCH 1/9] mesa: add entry AMD_shader_trinary_minmax to extension_table

On Tue, Dec 10, 2013 at 2:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > i Not a commit message. :) Overall the series looks good. I'd make the following changes: - Split the ir_builder changes in 4/9 and 5/9 into separate patches. - Squash patches 1/9, 2/9, 7/9, and 8/9 into the first p

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

Matt Turner writes: > On Tue, Dec 10, 2013 at 1:31 PM, Brian Paul wrote: >> On 12/10/2013 11:06 AM, Francisco Jerez wrote: >>> >>> Paul Berry writes: >>> On 10 December 2013 08:42, Francisco Jerez wrote: > Brian Paul writes: > >> On 12/07/2013 06:17 PM, Francisco Jerez w

[Mesa-dev] [Bug 72582] New: [swrast] piglit getteximage-targets S3TC 2D_ARRAY regression

https://bugs.freedesktop.org/show_bug.cgi?id=72582 Priority: medium Bug ID: 72582 Keywords: regression CC: bri...@vmware.com, i...@freedesktop.org, jljus...@gmail.com Assignee: mesa-dev@lists.freedesktop.org S

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

On Tue, Dec 10, 2013 at 5:55 PM, Francisco Jerez wrote: > It just seems annoying and unnecessary to me to have to repeat the same > pattern before each use of unreachable(). If by definition the > unreachable macro wants to be accompanied with an assert, why don't we > save ourselves pain by havi

[Mesa-dev] [PATCH] radeonsi: Write htile state to hardware.

--- src/gallium/drivers/radeonsi/si_state.c | 67 +--- src/gallium/drivers/radeonsi/si_state.h | 5 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 7 +-- 3 files changed, 66 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] radeonsi htile (aka HyperZ) support v3

Another attempt at patch 3. I've picked Marek's suggestion 1, do it like CB_TARGET_MASK. The other option would probably be a lot less code but also a bit more "ad hoc" because it relies on the fact that state is only emitted just before drawing anyway (right?). I do not quite have the hang of git

[Mesa-dev] [PATCH] radeonsi: Write htile state to hardware.

--- src/gallium/drivers/radeonsi/si_state.c | 67 +--- src/gallium/drivers/radeonsi/si_state.h | 4 +- src/gallium/drivers/radeonsi/si_state_draw.c | 7 +-- 3 files changed, 65 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] radeonsi htile (aka HyperZ) support v4

Removed the now unused db_render_override from si_state_dsa. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Avoid extraneous fast depth clears

When the depth buffer is already cleared, skip GEN6_HIZ_OP_DEPTH_CLEAR. This is made possible by tracking which slices have been cleared in "struct intel_mipmap_level". The hiz_cleared flag is unset when the depth buffer is rendered to or when a HiZ resolve is needed. For Unigine Tropics, the FP

[Mesa-dev] [PATCH 7/8] i965: Create a new fragment shader backend for Broadwell.

This replaces the old fs_generator backend. v2: Port to the C-based representation of assembly instructions. Fix texturing after the texture-grf merge. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources |1 + src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 8/8] i965: Reserve space for "Vertex Count" in GS outputs.

v2: Also increment ir->offset in the GS visitor, rather than at the final assembly generation stage (requested by Paul). Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vec4_gs.c | 6 ++ src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 7 +++ 2 files cha

[Mesa-dev] [PATCH 6/8] i965: Create a new vec4 backend for Broadwell.

This replaces the old vec4_generator backend. v2: Port to use the C-based instruction representation. Also, remove Geometry Shader offset hacks - the visitor will handle those instead of this code. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources|

[Mesa-dev] [PATCH 1/8] i965: Add #defines for new Broadwell math functions.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 3e01db3..f24d7ab 100644 --- a/src/mesa/drivers/dri/i965/brw_defines.h +++ b/src

[Mesa-dev] [PATCH 2/8] i965: Add SFID #defines for media stuff.

While we probably won't ever use these, having them makes it easy to share disassembler code between intel-gpu-tools and Mesa. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h

[Mesa-dev] [PATCH 4/8] i965: Implement a disassembler for Broadwell's new instruction encoding

Heavily based on Keith Packard's existing brw_disasm.c code. I've tried to go through most of the pieces (like SFIDs) and update the lists to include features added in recent generations. I had to use C++ since my new instruction representation requires it. Unfortunately, C++98 doesn't allow the

[Mesa-dev] [PATCH 3/8] i965: Add a new representation for Broadwell shader instructions.

Broadwell significantly changes the EU instruction encoding. Many of the fields got moved to different bit positions; some even got split in two. With so many changes, it was infeasible to continue using struct brw_instruction. We needed a new representation. This new approach is a bit differen

[Mesa-dev] [PATCH 5/8] i965: Add a new infrastructure for generating Broadwell shader assembly.

This replaces the brw_eu_emit.c layer for Broadwell. It will be used by both the vector and scalar shader backends. v2: Port to use the C-based instruction representation. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/gen8_ge

Re: [Mesa-dev] [PATCH 1/9] mesa: add entry AMD_shader_trinary_minmax to extension_table

On 12/10/2013 02:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > i > --- > src/mesa/main/mtypes.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index db3cc3b..48f10e3 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src/mesa/main/mty

Re: [Mesa-dev] [PATCH 8/9] glsl: switch AMD_shader_trinary_minmax support flag to dummy_true

On 12/10/2013 02:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > --- > src/glsl/glsl_parser_extras.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp > index 00d85c7..03394c6 100644 > --- a/src/glsl/

Re: [Mesa-dev] [PATCH 3/9] glsl: add a shader_trinary_minmax predicate

On 12/10/2013 02:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > --- > src/glsl/builtin_functions.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp > index 6af587a..481a456 100644 > --- a/src/glsl/builtin_funct

Re: [Mesa-dev] [PATCH 4/9] glsl: Implement min3 built-in function

On 12/10/2013 03:52 PM, Matt Turner wrote: > On Tue, Dec 10, 2013 at 2:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= > wrote: >> --- >> src/glsl/builtin_functions.cpp | 45 >> ++ >> src/glsl/ir_builder.cpp| 5 + >> src/glsl/ir_builder.h

Re: [Mesa-dev] [PATCH 4/9] glsl: Implement min3 built-in function

On 12/10/2013 02:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > --- > src/glsl/builtin_functions.cpp | 45 > ++ > src/glsl/ir_builder.cpp| 5 + > src/glsl/ir_builder.h | 2 ++ > 3 files changed, 52 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 6/9] glsl: implement mid3 built-in function

On 12/10/2013 02:43 PM, =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= wrote: > --- > src/glsl/builtin_functions.cpp | 44 > ++ > 1 file changed, 44 insertions(+) > > diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp > index 1f21a37..b9be

Re: [Mesa-dev] [PATCH 6/9] glsl: implement mid3 built-in function

Why not computing the max3(min(x,y),min(x,z),min(y,z))? For the six possible cases: x < y < z --> max(x, x, y) -> y ==> works x < z < y --> max(x, z, z) -> z ==> works y < x < z --> max(y, x, y) -> x ==> works y < z < x --> max(y, z, y) -> z ==> works z < x < y --> max(x, z, z) -> x ==> works z <