Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Dave Airlie
On 24 July 2018 at 03:14, Gert Wollny wrote: > Am Montag, den 23.07.2018, 21:17 +1000 schrieb Dave Airlie: >> On 23 July 2018 at 17:28, Gert Wollny >> wrote: >> > Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: >> > > On 23 July 2018 at 16:46, Gert Wollny >> > > wrote: >> > > > Am Mo

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Gert Wollny
Am Montag, den 23.07.2018, 21:17 +1000 schrieb Dave Airlie: > On 23 July 2018 at 17:28, Gert Wollny > wrote: > > Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: > > > On 23 July 2018 at 16:46, Gert Wollny > > > wrote: > > > > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie:

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Dave Airlie
On 23 July 2018 at 17:28, Gert Wollny wrote: > Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: >> On 23 July 2018 at 16:46, Gert Wollny >> wrote: >> > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: >> > > >> > > > > + uint32_t max_shader_buffer = shader == >> > > > > PI

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Gert Wollny
Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: > On 23 July 2018 at 16:46, Gert Wollny > wrote: > > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: > > > > > > > > + uint32_t max_shader_buffer = shader == > > > > > PIPE_SHADER_FRAGMENT ? > > > > > + rs->caps.caps.v

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Dave Airlie
On 23 July 2018 at 16:46, Gert Wollny wrote: > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: >> >> > > + uint32_t max_shader_buffer = shader == PIPE_SHADER_FRAGMENT ? >> > > + rs->caps.caps.v2.max_shader_buffer_frag_compute : >> > >> > Shouldn't max_shader_buffer_frag_compute

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-22 Thread Gert Wollny
Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: > > > > + uint32_t max_shader_buffer = shader == PIPE_SHADER_FRAGMENT ? > > > + rs->caps.caps.v2.max_shader_buffer_frag_compute : > > > > Shouldn't max_shader_buffer_frag_compute also be used for > > PIPE_SHADER_COMPUTE? > > virg

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-22 Thread Dave Airlie
On 20 July 2018 at 21:13, Gert Wollny wrote: > There still seem to be a few quirks (see below) > > Best, >> >> diff --git a/src/gallium/drivers/virgl/virgl_buffer.c >> >> +static void virgl_set_shader_buffers(struct pipe_context *ctx, >> + enum pipe_shader_typ

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-20 Thread Gert Wollny
There still seem to be a few quirks (see below) Best, Gert Am Freitag, den 20.07.2018, 06:36 +1000 schrieb Dave Airlie: > From: Dave Airlie > > This adds the guest side support for > ARB_shader_storage_buffer_object. > > Co-authors: Gurchetan Singh > > v2: move to using separate maximums

[Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-19 Thread Dave Airlie
From: Dave Airlie This adds the guest side support for ARB_shader_storage_buffer_object. Co-authors: Gurchetan Singh v2: move to using separate maximums --- src/gallium/drivers/virgl/virgl_buffer.c | 2 ++ src/gallium/drivers/virgl/virgl_context.c | 44 ++ src/