Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 1:12 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 9:49 PM, Erik Faye-Lund > wrote: > > On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund > wrote: > >> On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset > >> wrote: > >>> > >>> > >>> On 01/11/2017 07:34 PM, Erik Faye-L

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 9:49 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset >> wrote: >>> >>> >>> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset > wrote: >> >> >> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: >>> >>> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand >>> wrote: On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset wrote: > > > On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: >> >> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand >> wrote: >>> >>> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund >>> wrote: On Wed, Jan 11, 2017 at 7:22 PM, Marek Ol

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: On Wed, Jan 11, 2017 a

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 07:33 PM, Jason Ekstrand wrote: One trivial request: If we do land this patch, please include a link the the mailing list archives in the commit message so that we can easily track down this discussion if we ever need to in the future. Sure, I was planning to do it. :-) But it

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Ilia Mirkin
On Wed, Jan 11, 2017 at 2:33 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 7:34 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: >>> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund >>> wrote: On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 7:34 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: >> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund >> wrote: >>> >>> On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >>> > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand >>> >

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: > On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund > wrote: >> >> On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >> > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand >> > wrote: >> >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset >>

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
One trivial request: If we do land this patch, please include a link the the mailing list archives in the commit message so that we can easily track down this discussion if we ever need to in the future. On Fri, Jan 6, 2017 at 1:42 AM, Samuel Pitoiset wrote: > D3D always computes the absolute v

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: > > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand > wrote: > >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset < > samuel.pitoi...@gmail.com> > >> wrote: > >>> > >>> > >>> > >>> On

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 01/11/2017 05:32 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wr

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: > On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset > wrote: >> >> >> >> On 01/11/2017 05:32 PM, Marek Olšák wrote: >>> >>> On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund >>> wrote: On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset wrote: > > > On 01/11/2017 05:32 PM, Marek Olšák wrote: > >> On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund >> wrote: >> >>> On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle >>> wrote: >>> On 11.01.2017 13:17, Marek Olšák wrote: > >

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Samuel Pitoiset
On 01/11/2017 05:32 PM, Marek Olšák wrote: On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: On 11.01.2017 13:17, Marek Olšák wrote: On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: I'll be honest, I'm not a fan... Given

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 5:32 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: >>> On 11.01.2017 13:17, Marek Olšák wrote: On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: > > I'

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: >> On 11.01.2017 13:17, Marek Olšák wrote: >>> >>> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >>> wrote: I'll be honest, I'm not a fan... Given that D3D10 has one define

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Jason Ekstrand
On Jan 11, 2017 7:34 AM, "Erik Faye-Lund" wrote: On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: > On 11.01.2017 13:17, Marek Olšák wrote: >> >> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >> wrote: >>> >>> I'll be honest, I'm not a fan... Given that D3D10 has one defined >>> behavio

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: > On 11.01.2017 13:17, Marek Olšák wrote: >> >> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >> wrote: >>> >>> I'll be honest, I'm not a fan... Given that D3D10 has one defined >>> behavior, >>> D3D9 has another, and GL doesn't specify, I

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Nicolai Hähnle
On 11.01.2017 13:17, Marek Olšák wrote: On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: I'll be honest, I'm not a fan... Given that D3D10 has one defined behavior, D3D9 has another, and GL doesn't specify, I don't really think we should be making a global change to all drivers to do the

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Marek Olšák
On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand wrote: > I'll be honest, I'm not a fan... Given that D3D10 has one defined behavior, > D3D9 has another, and GL doesn't specify, I don't really think we should be > making a global change to all drivers to do the D3D9 behavior just to fix > one app.

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-10 Thread Krzysztof Cybulski
W dniu 10.01.2017 o 18:48, Jason Ekstrand pisze: Hi, Can we add workaround to drirc and enable this only when needed? Best Regards Krzysztof Cybulski I'll be honest, I'm not a fan... Given that D3D10 has one defined behavior, D3D9 has another, and GL doesn't specify, I don't really think we

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-10 Thread Samuel Pitoiset
On 01/09/2017 10:03 PM, Roland Scheidegger wrote: Am 06.01.2017 um 10:42 schrieb Samuel Pitoiset: D3D always computes the absolute value while GLSL says that the That should probably say "d3d9" - it is completely wrong for d3d10 and later (which have it to be defined as a guaranteed NaN). (Ot

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-10 Thread Ilia Mirkin
On Tue, Jan 10, 2017 at 12:51 PM, Jason Ekstrand wrote: > On Tue, Jan 10, 2017 at 9:48 AM, Jason Ekstrand > wrote: >> >> I'll be honest, I'm not a fan... Given that D3D10 has one defined >> behavior, D3D9 has another, and GL doesn't specify, I don't really think we >> should be making a global ch

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-10 Thread Jason Ekstrand
On Tue, Jan 10, 2017 at 9:48 AM, Jason Ekstrand wrote: > I'll be honest, I'm not a fan... Given that D3D10 has one defined > behavior, D3D9 has another, and GL doesn't specify, I don't really think we > should be making a global change to all drivers to do the D3D9 behavior > just to fix one app.

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-10 Thread Jason Ekstrand
I'll be honest, I'm not a fan... Given that D3D10 has one defined behavior, D3D9 has another, and GL doesn't specify, I don't really think we should be making a global change to all drivers to do the D3D9 behavior just to fix one app. Sure, other apps probably have the same bug, but are we going t

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-10 Thread Samuel Pitoiset
On 01/09/2017 10:03 PM, Roland Scheidegger wrote: Am 06.01.2017 um 10:42 schrieb Samuel Pitoiset: D3D always computes the absolute value while GLSL says that the That should probably say "d3d9" - it is completely wrong for d3d10 and later (which have it to be defined as a guaranteed NaN). (Ot

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-09 Thread Roland Scheidegger
Am 06.01.2017 um 10:42 schrieb Samuel Pitoiset: > D3D always computes the absolute value while GLSL says that the That should probably say "d3d9" - it is completely wrong for d3d10 and later (which have it to be defined as a guaranteed NaN). (Otherwise, I'm still not quite convinced it's the right

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-09 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Fri, Jan 6, 2017 at 10:42 AM, Samuel Pitoiset wrote: > D3D always computes the absolute value while GLSL says that the > result of inversesqrt() is undefined if x <= 0 (and undefined if > x < 0 for sqrt()). But some apps rely on this specific behaviour > which is

[Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-06 Thread Samuel Pitoiset
D3D always computes the absolute value while GLSL says that the result of inversesqrt() is undefined if x <= 0 (and undefined if x < 0 for sqrt()). But some apps rely on this specific behaviour which is not clearly defined by OpenGL. Computing the absolute value before sqrt()/inversesqrt() will pr