[Mesa-dev] [PATCH 1/1] intel: corrected the header include path for recent Valgrind versions.

2012-10-22 Thread Oliver McFadden
intel_bufmgr_gem.c:67:22: fatal error: valgrind.h: No such file or directory Signed-off-by: Oliver McFadden --- intel/intel_bufmgr_gem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c index 8d45839..f5a468c 100644

Re: [Mesa-dev] [PATCH v3 1/2] intel: print debug either to stdout or `logcat' depending on platform.

2012-10-10 Thread Oliver McFadden
On Wed, Oct 10, 2012 at 11:15:27AM -0700, Eric Anholt wrote: > Kenneth Graunke writes: > > > On 10/09/2012 09:49 PM, Oliver McFadden wrote: > >> Signed-off-by: Oliver McFadden > >> CC: Chad Versace > >> --- > >> v3: split the unconditional

[Mesa-dev] [PATCH v3 2/2] intel: always print performance debugging to `logcat' on Android.

2012-10-09 Thread Oliver McFadden
Signed-off-by: Oliver McFadden CC: Chad Versace --- v3: split the unconditional DEBUG_PERF printing for Android into a separate patch. The second patch doesn't necessarily need to be upstreamed; I'm open to feedback here... src/mesa/drivers/dri/intel/intel_context.c |5

[Mesa-dev] [PATCH v3 1/2] intel: print debug either to stdout or `logcat' depending on platform.

2012-10-09 Thread Oliver McFadden
Signed-off-by: Oliver McFadden CC: Chad Versace --- v3: split the unconditional DEBUG_PERF printing for Android into a separate patch. The second patch doesn't necessarily need to be upstreamed; I'm open to feedback here... src/mesa/drivers/dri/Android.mk|3 ++-

Re: [Mesa-dev] [PATCH v2 3/3] mesa: meta: don't compile integer texture shader on ES3.0; it's broken.

2012-10-08 Thread Oliver McFadden
On Mon, Oct 08, 2012 at 02:24:44PM +0300, Oliver McFadden wrote: > On Thu, Oct 04, 2012 at 02:21:32PM +0300, Oliver McFadden wrote: > > CC: Kenneth Graunke > > Signed-off-by: Oliver McFadden > > --- > > src/mesa/drivers/common/meta.c |3 +-- > > 1 files chan

Re: [Mesa-dev] [PATCH v2 3/3] mesa: meta: don't compile integer texture shader on ES3.0; it's broken.

2012-10-08 Thread Oliver McFadden
On Thu, Oct 04, 2012 at 02:21:32PM +0300, Oliver McFadden wrote: > CC: Kenneth Graunke > Signed-off-by: Oliver McFadden > --- > src/mesa/drivers/common/meta.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/common/meta

Re: [Mesa-dev] [PATCH v2 1/3] mesa: setup_glsl_generate_mipmap(): meta program compile failed

2012-10-05 Thread Oliver McFadden
On Thu, Oct 04, 2012 at 02:05:07PM -0700, Eric Anholt wrote: > Oliver McFadden writes: > > > Discovered while attempting to run GLBenchMark 2.5 with test > > GLB25_TriangleTexVertexLitTestC24Z16 on an ES2.0 context. > > > > NOTE: This is a candidate for the 9.0

Re: [Mesa-dev] [PATCH] android: generate matching remap_helper to dispatch table

2012-10-04 Thread Oliver McFadden
On Thu, Oct 04, 2012 at 02:18:44PM +0300, Tapani Pälli wrote: > On 10/04/2012 02:11 PM, Negreanu, Adrian M wrote: > > > > > > On Thu, Oct 4, 2012 at 1:58 PM, Oliver McFadden > > > <mailto:oliver.mcfad...@linux.intel.com>> wrote: > > > >

[Mesa-dev] [PATCH v2 1/3] mesa: setup_glsl_generate_mipmap(): meta program compile failed

2012-10-04 Thread Oliver McFadden
Discovered while attempting to run GLBenchMark 2.5 with test GLB25_TriangleTexVertexLitTestC24Z16 on an ES2.0 context. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

[Mesa-dev] [PATCH v2 3/3] mesa: meta: don't compile integer texture shader on ES3.0; it's broken.

2012-10-04 Thread Oliver McFadden
CC: Kenneth Graunke Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index d148c88..7ae32b5 100644 --- a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH v2 2/3] mesa: meta: use consistent `if-else' statement throughout the function.

2012-10-04 Thread Oliver McFadden
Note the blocks of the `if-else' statement are swapped; the functional change is only inside the condition of the `if' statement. Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c | 46 1 files changed, 23 insertions(+), 23

Re: [Mesa-dev] [PATCH] android: generate matching remap_helper to dispatch table

2012-10-04 Thread Oliver McFadden
ssing dependency and need to fix the Makefile. > > > > -- > Adrian Marius Negreanu > Open Source Technology Center > iNET: 88451009 Desk: +40 31 86 04 709 > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Oliver McFadden. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC] [PATCH 1/1] mesa: setup_glsl_generate_mipmap(): meta program compile failed

2012-10-04 Thread Oliver McFadden
On Wed, Oct 03, 2012 at 09:31:39PM -0700, Kenneth Graunke wrote: > On 10/03/2012 05:59 PM, Oliver McFadden wrote: > > Discovered while attempting to run GLBenchMark 2.5 with test > > GLB25_TriangleTexVertexLitTestC24Z16 on an ES2.0 context. > > Ouch :( Nice catch. > &g

Re: [Mesa-dev] [RFC] [PATCH 1/1] mesa: setup_glsl_generate_mipmap(): meta program compile failed

2012-10-04 Thread Oliver McFadden
hing. I'd include Mesa's error message describing _why_ the failure occurred, if it wasn't a bunch of corrupt bytes (another bug...) -- Oliver McFadden. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [RFC] [PATCH 1/1] mesa: setup_glsl_generate_mipmap(): meta program compile failed

2012-10-03 Thread Oliver McFadden
-else' statement. Signed-off-by: Oliver McFadden CC: Brian Paul --- I seem to have a habit of getting these GL context version/GLSL version checks not quite correct, so I'd like to have a review/idiot-check here. :-) src/mesa/drivers/common/meta.c | 48 -

Re: [Mesa-dev] [PATCH] mesa: don't enable glVertexPointer() when using API_OPENGLES2.

2012-10-03 Thread Oliver McFadden
> Which is: 0x41af72 > i = 321 > [ FAILED ] DispatchSanity_test.GLES2 (4 ms) > [--] 1 test from DispatchSanity_test (4 ms total) Reviewed-by: Oliver McFadden Tested-by: Oliver McFadden > --- You should really signoff your patches; for example: git commit -a -s

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-03 Thread Oliver McFadden
On Wed, Oct 03, 2012 at 07:45:12AM -0600, Brian Paul wrote: > On 10/03/2012 02:37 AM, Oliver McFadden wrote: > > On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote: > >> On 10/02/2012 04:00 AM, Oliver McFadden wrote: > >>> This reverts commit 85cd30406f

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-03 Thread Oliver McFadden
On Wed, Oct 03, 2012 at 11:53:55AM +0200, Andreas Boll wrote: > 2012/10/3 Oliver McFadden : > > On Wed, Oct 03, 2012 at 11:37:33AM +0300, Oliver McFadden wrote: > >> On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote: > >> > On 10/02/2012 04:00 AM, Oliver

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-03 Thread Oliver McFadden
On Wed, Oct 03, 2012 at 11:37:33AM +0300, Oliver McFadden wrote: > On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote: > > On 10/02/2012 04:00 AM, Oliver McFadden wrote: > > > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. > >

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-03 Thread Oliver McFadden
On Wed, Oct 03, 2012 at 11:37:33AM +0300, Oliver McFadden wrote: > On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote: > > On 10/02/2012 04:00 AM, Oliver McFadden wrote: > > > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. > >

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-03 Thread Oliver McFadden
On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote: > On 10/02/2012 04:00 AM, Oliver McFadden wrote: > > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 > > Signed-off-

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-02 Thread Oliver McFadden
On Tue, Oct 02, 2012 at 01:20:42PM +0200, Andreas Boll wrote: > 2012/10/2 Oliver McFadden : > > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 > > You should probably add the fol

Re: [Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-02 Thread Oliver McFadden
On Tue, Oct 02, 2012 at 02:00:39PM +0300, Oliver McFadden wrote: > This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 > Signed-off-by: Oliver McFadden > CC: Kenneth Graunke > --- NOTE: This is a can

Re: [Mesa-dev] [PATCH 2/2] Revert "i965: Implement guardband clipping on Ivybridge."

2012-10-02 Thread Oliver McFadden
On Tue, Oct 02, 2012 at 02:00:40PM +0300, Oliver McFadden wrote: > This reverts commit 610910a66d1a97ca51ad8a003bdeadfe9563d721. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 > Signed-off-by: Oliver McFadden > CC: Kenneth Graunke > --- > v1: note tha

[Mesa-dev] [PATCH 1/2] Revert "i965: Implement guardband clipping on Sandybridge."

2012-10-02 Thread Oliver McFadden
This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 Signed-off-by: Oliver McFadden CC: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_clip_state.c |1 - src/mesa/drivers/dri/i965/gen6_viewport_state.c | 24

[Mesa-dev] [PATCH 2/2] Revert "i965: Implement guardband clipping on Ivybridge."

2012-10-02 Thread Oliver McFadden
This reverts commit 610910a66d1a97ca51ad8a003bdeadfe9563d721. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 Signed-off-by: Oliver McFadden CC: Kenneth Graunke --- v1: note that I have not actually verified this bug exists on IvyBridge, however given the severity of the bug (major

Re: [Mesa-dev] [PATCH] adroid : glcpp: fix abuse of yylex

2012-10-01 Thread Oliver McFadden
On Tue, Oct 02, 2012 at 12:38:02PM +1000, Dave Airlie wrote: > On Tue, Oct 2, 2012 at 12:16 AM, Oliver McFadden > wrote: > > On Fri, Sep 28, 2012 at 05:36:40PM +0300, Negreanu Marius Adrian wrote: > >> Port the 'glcpp: fix abuse of yylex' commit to Android.mk > &

Re: [Mesa-dev] [PATCH 2/7] i965: Allow fast depth clears if scissoring doesn't do anything.

2012-10-01 Thread Oliver McFadden
me numbers during this week. If I have time; my schedule is fairly packed. > > > Signed-off-by: Kenneth Graunke > > Signed-off-by: Chad Versace > > Cc: Oliver McFadden > > --- > > src/mesa/drivers/dri/i965/brw_clear.c | 14 +- > > 1 file

Re: [Mesa-dev] [PATCH 19/19] mesa/tests: Sanity check the ES2 dispatch table

2012-10-01 Thread Oliver McFadden
i \ > > "--prefix=$PLATFORM_INSTALL_DIR" \ > > --with-dri-drivers=swrast,i915,i965 \ > > CFLAGS="-O0 $CFLAGS" \ > > CXXFLAGS="-O0 $CXXFLAGS" > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Oliver McFadden. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/1] mesa: tests: EnumStrings.LookUpByNumber

2012-10-01 Thread Oliver McFadden
43: Failure Value of: _mesa_lookup_enum_by_nr(everything[i].value) Actual: "GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE" Expected: everything[i].name Which is: "GL_COMPRESSED_RGBA_S3TC_DXT5_EXT" [ FAILED ] EnumStrings.LookUpByNumber (2 ms) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55505

Re: [Mesa-dev] [PATCH v2 1/1] intel: print performance debug messages to `logcat' on Android.

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 02:55:31PM -0700, Kenneth Graunke wrote: > On 10/01/2012 02:35 PM, Eric Anholt wrote: > > Oliver McFadden writes: > >> diff --git a/src/mesa/drivers/dri/intel/intel_context.c > >> b/src/mesa/drivers/dri/intel/intel_context.c > >> inde

Re: [Mesa-dev] [PATCH v6 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 08:04:17AM -0600, Brian Paul wrote: > On 10/01/2012 04:12 AM, Oliver McFadden wrote: > > Signed-off-by: Oliver McFadden > > CC: Brian Paul > > --- > > v6: API == ES2 checks. > > LGTM. Reviewed-by: Brian Paul Great, pushed! Sorry for

Re: [Mesa-dev] [PATCH] adroid : glcpp: fix abuse of yylex

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 05:16:55PM +0300, Oliver McFadden wrote: > On Fri, Sep 28, 2012 at 05:36:40PM +0300, Negreanu Marius Adrian wrote: > > Port the 'glcpp: fix abuse of yylex' commit to Android.mk > > Also, since the Android.*.mk are sourced in a global namespace, >

Re: [Mesa-dev] [PATCH] adroid : glcpp: fix abuse of yylex

2012-10-01 Thread Oliver McFadden
The initial fix commit is 53d46bc787318ccf9911fdd1d5fe99ee4db7f41a > > There's also a bugzilla for this: 54947 > > Signed-off-by: Negreanu Marius Adrian Reviewed-by: Oliver McFadden Adding Dave Airlie to CC due to his authorship of the original fix commit. Dave, could you also re

Re: [Mesa-dev] [PATCH v3 8/8] mesa: glGet: remove the unused TYPE_API_MASK flags

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 01:38:05PM +0300, Imre Deak wrote: > Since we generate the hash tables in build time, these flags aren't used > any more, remove them. > > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Reviewed-by: Oliver McFadden > --- > src/mesa/mai

Re: [Mesa-dev] [PATCH v3 7/8] mesa: glGet: use the build time generated hash tables

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 01:38:04PM +0300, Imre Deak wrote: > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Reviewed-by: Oliver McFadden > --- > src/mesa/main/get.c| 1026 > +--- > src/mesa/main/mtypes.h |2 - >

Re: [Mesa-dev] [PATCH v3 5/8] scons/android: add flag to check for enabled GL APIs

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 01:38:02PM +0300, Imre Deak wrote: > Needed by the next patch. > > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Reviewed-by: Oliver McFadden > --- > src/mesa/Android.mk |9 - > src/mesa/SConscript |9 + > 2 fil

Re: [Mesa-dev] [PATCH v3 4/8] mesa: glGet: rename *{_EXT, _ARB} enums missing from the XML spec

2012-10-01 Thread Oliver McFadden
HEIGHT_EXT > GL_PACK_SKIP_IMAGES_EXT > GL_SECONDARY_COLOR_ARRAY_EXT > GL_SECONDARY_COLOR_ARRAY_SIZE_EXT > GL_SECONDARY_COLOR_ARRAY_STRIDE_EXT > GL_SECONDARY_COLOR_ARRAY_TYPE_EXT > GL_UNPACK_IMAGE_HEIGHT_EXT > GL_UNPACK_SKIP_IMAGES_EXT > > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Review

Re: [Mesa-dev] [PATCH v3 3/8] mesa: glGet: simplify the 'enum not found' condition

2012-10-01 Thread Oliver McFadden
SK and related flags > completly. > > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Reviewed-by: Oliver McFadden > --- > src/mesa/main/get.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/get.c b/src/mesa/main/

Re: [Mesa-dev] [PATCH v3 2/8] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-10-01 Thread Oliver McFadden
arameter was invalid in another context created earlier. > > Fix this by using a separate hash table for each API. > > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Reviewed-by: Oliver McFadden > --- > src/mesa/main/context.c |5 ++---

Re: [Mesa-dev] [PATCH v3 1/8] glapi: rename/move GL_POLYGON_OFFSET_BIAS to its extension section

2012-10-01 Thread Oliver McFadden
On Mon, Oct 01, 2012 at 01:37:58PM +0300, Imre Deak wrote: > This should be named GL_POLYGON_OFFSET_BIAS_EXT and listed under the > EXT_polygon_offset section. (Solution by Ian Romanick) > > Signed-off-by: Imre Deak > Reviewed-by: Brian Paul Reviewed-by: Oliver McFadden > ---

[Mesa-dev] [PATCH v2 1/1] intel: print performance debug messages to `logcat' on Android.

2012-10-01 Thread Oliver McFadden
Signed-off-by: Oliver McFadden CC: Chad Versace --- v2: don't split drv/app debug messages; instead print everything that may be useful. Suggested by community on mailing list. src/mesa/drivers/dri/Android.mk|3 ++- src/mesa/drivers/dri/intel/intel_context.c |5 +

[Mesa-dev] [PATCH v6 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-10-01 Thread Oliver McFadden
Signed-off-by: Oliver McFadden CC: Brian Paul --- v6: API == ES2 checks. src/mapi/glapi/gen/es_EXT.xml |6 ++ src/mesa/drivers/dri/intel/intel_extensions.c |1 + src/mesa/main/APIspec.xml |3 +++ src/mesa/main/extensions.c

Re: [Mesa-dev] [PATCH 17/19] glx: Replace DRI2SwapBuffers() custom protocol with XCB.

2012-10-01 Thread Oliver McFadden
col needs to die. Agreed. > Reviewed-by: Chad Versace > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Oliver McFadden. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
tion below... > >> > >> On 09/27/2012 02:56 AM, Oliver McFadden wrote: > >>> Signed-off-by: Oliver McFadden > >>> --- > >>> v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could > >>> cause a >

Re: [Mesa-dev] [PATCH v5 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Fri, Sep 28, 2012 at 07:54:14AM -0600, Brian Paul wrote: > On 09/28/2012 03:52 AM, Oliver McFadden wrote: > > Signed-off-by: Oliver McFadden > > --- > > v5: reuse the _EXT defines instead of defining new _ANGLE defines. > > v5: removed unnessacary enum in glxext

[Mesa-dev] [PATCH v3 1/1] intel: print performance debug messages to `logcat' on Android.

2012-09-28 Thread Oliver McFadden
Split the perf_debug() messages into performance debugging information which may be useful for application developers or driver developers. Always print the information useful for application developers on the Android platform. Signed-off-by: Oliver McFadden CC: Chad Versace --- v3: forgot to

[Mesa-dev] [PATCH v2 1/1] intel: print performance debug messages to `logcat' on Android.

2012-09-28 Thread Oliver McFadden
Split the perf_debug() messages into performance debugging information which may be useful for application developers or driver developers. Always print the information useful for application developers on the Android platform. Signed-off-by: Oliver McFadden CC: Chad Versace --- v2: Split

[Mesa-dev] [PATCH v5 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- v5: reuse the _EXT defines instead of defining new _ANGLE defines. v5: removed unnessacary enum in glxextensions.h src/mapi/glapi/gen/es_EXT.xml |6 ++ src/mesa/drivers/dri/intel/intel_extensions.c |1 + src/mesa/main/APIspec.xml

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Fri, Sep 28, 2012 at 02:29:12AM -0700, Kenneth Graunke wrote: > On 09/28/2012 02:20 AM, Oliver McFadden wrote: > > On Fri, Sep 28, 2012 at 01:12:55AM -0700, Kenneth Graunke wrote: > >> On 09/27/2012 01:56 AM, Oliver McFadden wrote: > >>> Signed-off-by: Oliver McF

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Thu, Sep 27, 2012 at 07:28:47AM -0600, Brian Paul wrote: > Looks good to me, Oliver. > > Reviewed-by: Brian Paul Thanks Brian. Please also check Kenneth's comments and my reply; I'd like your input there. > > One question below... OK. > > On 09/27/2012

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-28 Thread Oliver McFadden
On Fri, Sep 28, 2012 at 01:12:55AM -0700, Kenneth Graunke wrote: > On 09/27/2012 01:56 AM, Oliver McFadden wrote: > > Signed-off-by: Oliver McFadden > > --- > > v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could > > cause a >

[Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-27 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx/glxextensions.h |3 ++- src/mapi/glapi/gen/es_EXT.xml |6 ++ src/mesa/drivers/dri/intel/intel_extens

[Mesa-dev] [PATCH v3 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-26 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- I believe this is approximately v3; after two iterations and the FEATURE_x defines removal. The patch becomes much smaller after that! Hopefully I've addressed everybody's comments but I expect to have missed something... src/glx/glxex

Re: [Mesa-dev] [PATCH 2/7] i965: Allow fast depth clears if scissoring doesn't do anything.

2012-09-25 Thread Oliver McFadden
f-by: Kenneth Graunke > Signed-off-by: Chad Versace > Cc: Oliver McFadden Reviewed-by: Oliver McFadden Tested-by: Oliver McFadden > --- > src/mesa/drivers/dri/i965/brw_clear.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/

Re: [Mesa-dev] [PATCH 46/47] mesa: remove remaining FEATURE_* defines where protected by API check.

2012-09-17 Thread Oliver McFadden
On Sun, Sep 16, 2012 at 01:32:00PM +0300, Ian Romanick wrote: > On 09/15/2012 06:04 PM, Török Edwin wrote: > > On 09/13/2012 11:19 AM, Oliver McFadden wrote: > >> Signed-off-by: Oliver McFadden > >> > >> diff --git a/src/mesa/main/context.c b/src/mesa/main/c

Re: [Mesa-dev] [PATCH 47/47] mesa: remove never-defined FEATURE_histogram conditional.

2012-09-17 Thread Oliver McFadden
On Sun, Sep 16, 2012 at 01:31:52PM +0300, Ian Romanick wrote: > On 09/13/2012 11:19 AM, Oliver McFadden wrote: > > Signed-off-by: Oliver McFadden > > --- > > src/mesa/main/histogram.c |4 > > src/mesa/main/histogram.h | 11 --- > > 2 f

Re: [Mesa-dev] [PATCH v2 00/45] Remove many of the FEATURE_* defines.

2012-09-15 Thread Oliver McFadden
On Fri, Sep 14, 2012 at 07:59:38AM -0600, Brian Paul wrote: > On 09/14/2012 04:30 AM, Oliver McFadden wrote: > > On Thu, Sep 13, 2012 at 03:00:48PM -0600, Brian Paul wrote: > >> On 09/13/2012 02:18 AM, Oliver McFadden wrote: > >>> Hi, > >>> > >&

Re: [Mesa-dev] [PATCH v2 00/45] Remove many of the FEATURE_* defines.

2012-09-14 Thread Oliver McFadden
On Thu, Sep 13, 2012 at 03:00:48PM -0600, Brian Paul wrote: > On 09/13/2012 02:18 AM, Oliver McFadden wrote: > > Hi, > > > > As requested here is the second version of the patch series which removes > > almost > > all of the FEATURE_* defines, typically

Re: [Mesa-dev] [PATCH 1/1] main: validate the type correctly against the OpenGL ES spec.

2012-09-13 Thread Oliver McFadden
On Thu, Sep 13, 2012 at 12:18:09PM +0300, Oliver McFadden wrote: > On Wed, Sep 12, 2012 at 11:26:55AM +0300, Oliver McFadden wrote: > > On Tue, Sep 11, 2012 at 11:15:18AM -0600, Brian Paul wrote: > > > On 09/11/2012 10:21 AM, Oliver McFadden wrote: > > > > On Tue, Se

Re: [Mesa-dev] [PATCH 1/1] main: validate the type correctly against the OpenGL ES spec.

2012-09-13 Thread Oliver McFadden
On Wed, Sep 12, 2012 at 11:26:55AM +0300, Oliver McFadden wrote: > On Tue, Sep 11, 2012 at 11:15:18AM -0600, Brian Paul wrote: > > On 09/11/2012 10:21 AM, Oliver McFadden wrote: > > > On Tue, Sep 11, 2012 at 07:54:36AM -0600, Brian Paul wrote: > > >> On 09/11/2012 0

[Mesa-dev] [PATCH 44/47] mesa: remove FEATURE_ATI_fragment_shader define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/atifragshader.c |4 src/mesa/main/atifragshader.h | 22 -- src/mesa/main/dlist.c |8 src/mesa/main/enable.c|4 src/mesa/main/extensions.c|2 -- src/mesa/main/mfeatures.h

[Mesa-dev] [PATCH 26/47] mesa: remove FEATURE_ARB_shader_objects and related defines.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_exec.c |6 -- src/mesa/main/context.c|4 src/mesa/main/extensions.c | 10 +- src/mesa/main/fbobject.c |2 -- src/mesa/main/getstring.c |2 -- src/mesa/main/mfeatures.h |3 --- src/mesa/main

[Mesa-dev] [PATCH 27/47] mesa: remove FEATURE_EXT_framebuffer_object define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/drivers/dri/nouveau/nouveau_fbo.c |2 -- src/mesa/drivers/dri/radeon/radeon_fbo.c |2 -- src/mesa/main/api_exec.c |6 -- src/mesa/main/context.c|2 -- src/mesa/main/dlist.c

[Mesa-dev] [PATCH 40/47] mesa: remove FEATURE_EXT_framebuffer_blit define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/drivers/dri/nouveau/nouveau_driver.c |2 -- src/mesa/drivers/dri/radeon/radeon_fbo.c |2 -- src/mesa/main/api_exec.c |2 -- src/mesa/main/dlist.c |7 --- src/mesa/main/extensions.c

[Mesa-dev] [PATCH 33/47] mesa: remove FEATURE_NV_(fragment|vertex)_program defines.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_exec.c |6 -- src/mesa/main/dlist.c | 28 src/mesa/main/enable.c | 16 ++-- src/mesa/main/extensions.c |6 -- src/mesa/main/getstring.c |3 --- src/mesa/main

[Mesa-dev] [PATCH 24/47] mesa: remove FEATURE_ARB_vertex_shader define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/context.c|2 -- src/mesa/main/extensions.c |4 src/mesa/main/mfeatures.h |3 +-- src/mesa/main/shaderapi.c |9 + 4 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa

[Mesa-dev] [PATCH 09/47] mesa: remove FEATURE_convolve define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/convolve.c |5 - src/mesa/main/convolve.h | 12 src/mesa/main/mfeatures.h |1 - 3 files changed, 0 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/convolve.c b/src/mesa/main/convolve.c index 74f28da..cac8a99

[Mesa-dev] [PATCH 45/47] mesa: remove obsolete comments from mfeatures.h

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/mfeatures.h | 27 --- 1 files changed, 0 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/mfeatures.h b/src/mesa/main/mfeatures.h index 36724bd..3162a0b 100644 --- a/src/mesa/main/mfeatures.h +++ b/src/mesa/main

[Mesa-dev] [PATCH 36/47] mesa: remove FEATURE_ARB_map_buffer_range define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_exec.c |2 -- src/mesa/main/dlist.c |2 -- src/mesa/main/mfeatures.h |1 - 3 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index 1ceb494..74a74fb 100644 --- a

[Mesa-dev] [PATCH 37/47] mesa: remove FEATURE_ARB_pixel_buffer_object define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/context.c |3 --- src/mesa/main/mfeatures.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index e1f124e..abce52e 100644 --- a/src/mesa/main/context.c +++ b/src/mesa

[Mesa-dev] [PATCH 43/47] mesa: remove FEATURE_APPLE_object_purgeable define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/drivers/dri/intel/intel_buffer_objects.c |4 src/mesa/main/api_exec.c |2 -- src/mesa/main/bufferobj.c |3 --- src/mesa/main/bufferobj.h |2 -- src/mesa/main

[Mesa-dev] [PATCH 22/47] mesa: remove FEATURE_es2_glsl and related defines.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_validate.c |6 -- src/mesa/main/mfeatures.h|2 -- src/mesa/program/program.c |4 3 files changed, 0 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index

[Mesa-dev] [PATCH 28/47] mesa: remove FEATURE_EXT_pixel_buffer_object define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/extensions.c |4 src/mesa/main/mfeatures.h |3 +-- src/mesa/main/pixelstore.c |6 -- 3 files changed, 1 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 40cf309

[Mesa-dev] [PATCH 29/47] mesa: remove FEATURE_OES_EGL_image define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/drivers/dri/intel/intel_extensions.c |2 -- src/mesa/drivers/dri/intel/intel_fbo.c|5 - src/mesa/drivers/dri/intel/intel_tex_image.c |5 - src/mesa/drivers/dri/r200/r200_context.c |3 --- src/mesa/drivers/dri

[Mesa-dev] [PATCH 38/47] mesa: remove FEATURE_ARB_sampler_objects define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_exec.c |4 src/mesa/main/mfeatures.h |1 - src/mesa/main/shared.c|8 src/mesa/main/texstate.c |2 -- 4 files changed, 0 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main

[Mesa-dev] [PATCH 25/47] mesa: remove FEATURE_ARB_fragment_shader define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/extensions.c |4 src/mesa/main/mfeatures.h |3 +-- src/mesa/main/shaderapi.c |6 -- 3 files changed, 1 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index aaee0af

[Mesa-dev] [PATCH 19/47] mesa: remove FEATURE_texture_s3tc define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/extensions.c |2 -- src/mesa/main/formats.c|2 -- src/mesa/main/mfeatures.h |2 -- src/mesa/main/texcompress.c|3 --- src/mesa/main/texcompress_s3tc.c |6 -- src/mesa/main

[Mesa-dev] [PATCH 30/47] mesa: remove unused FEATURE_OES_mapbuffer define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/mfeatures.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/mfeatures.h b/src/mesa/main/mfeatures.h index 38903bc..ab0ba7b 100644 --- a/src/mesa/main/mfeatures.h +++ b/src/mesa/main/mfeatures.h @@ -104,6

[Mesa-dev] [PATCH 31/47] mesa: remove unused FEATURE_OES_framebuffer_object define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/mfeatures.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/mfeatures.h b/src/mesa/main/mfeatures.h index ab0ba7b..4653581 100644 --- a/src/mesa/main/mfeatures.h +++ b/src/mesa/main/mfeatures.h @@ -103,6

[Mesa-dev] [PATCH 08/47] mesa: remove FEATURE_colortable define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/colortab.c |5 - src/mesa/main/colortab.h | 26 -- src/mesa/main/mfeatures.h |1 - 3 files changed, 0 insertions(+), 32 deletions(-) diff --git a/src/mesa/main/colortab.c b/src/mesa/main/colortab.c index

[Mesa-dev] [PATCH 10/47] mesa: remove FEATURE_dlist define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/context.c |2 -- src/mesa/main/dlist.c|8 src/mesa/main/dlist.h| 28 src/mesa/main/mfeatures.h|1 - src/mesa/vbo/vbo_context.h |2 -- src/mesa

[Mesa-dev] [PATCH 15/47] mesa: remove FEATURE_pixel_transfer define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/mfeatures.h |1 - src/mesa/main/pixel.c |6 -- src/mesa/main/pixel.h | 23 --- 3 files changed, 0 insertions(+), 30 deletions(-) diff --git a/src/mesa/main/mfeatures.h b/src/mesa/main/mfeatures.h index

[Mesa-dev] [PATCH 41/47] mesa: remove FEATURE_EXT_texture_sRGB define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/extensions.c |4 src/mesa/main/formats.c|4 src/mesa/main/glformats.c |2 -- src/mesa/main/mfeatures.h |1 - src/mesa/main/texcompress.c|2 -- src/mesa/main

[Mesa-dev] [PATCH 35/47] mesa: remove FEATURE_ARB_framebuffer_object define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_exec.c |7 --- src/mesa/main/extensions.c |4 src/mesa/main/mfeatures.h |1 - 3 files changed, 0 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index d236dd7..1ceb494

[Mesa-dev] [PATCH 01/47] mesa: remove FEATURE_dispatch define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/context.c |2 -- src/mesa/main/mfeatures.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 6b28690..dbd79e9 100644 --- a/src/mesa/main/context.c +++ b/src/mesa

[Mesa-dev] [PATCH 23/47] mesa: remove FEATURE_OES_draw_texture define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |2 -- src/mesa/main/drawtex.c|5 - src/mesa/main/drawtex.h|4 src/mesa/main/extensions.c |2 -- src/mesa/main/mfeatures.h |1 - src

[Mesa-dev] [PATCH 46/47] mesa: remove remaining FEATURE_* defines where protected by API check.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/gallium/targets/egl-static/egl_st.c |2 -- src/mesa/main/buffers.c |2 -- src/mesa/main/context.c |4 src/mesa/main/enable.c |7 +-- src/mesa/main/get.c |2

[Mesa-dev] [PATCH 20/47] mesa: remove unused FEATURE_extra_context_init define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/mfeatures.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/mfeatures.h b/src/mesa/main/mfeatures.h index 1cbeed6..b9e1c55 100644 --- a/src/mesa/main/mfeatures.h +++ b/src/mesa/main/mfeatures.h @@ -84,7 +84,6

[Mesa-dev] [PATCH 39/47] mesa: remove FEATURE_ARB_sync define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/extensions.c |2 -- src/mesa/main/get.c|4 src/mesa/main/mfeatures.h |2 -- src/mesa/main/syncobj.c|3 --- src/mesa/main/syncobj.h| 40 5 files changed, 0 insertions

[Mesa-dev] [PATCH 18/47] mesa: remove FEATURE_texture_fxt1 define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/extensions.c |2 -- src/mesa/main/formats.c |2 -- src/mesa/main/mfeatures.h|1 - src/mesa/main/texcompress.c |2 -- src/mesa/main/texcompress_fxt1.c |6 -- src/mesa/main/texcompress_fxt1.h

[Mesa-dev] [PATCH 42/47] mesa: remove FEATURE_EXT_transform_feedback define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |6 src/mesa/main/api_validate.c |4 --- src/mesa/main/api_validate.h |3 -- src/mesa/main/bufferobj.c |2 - src/mesa/main/dlist.c |4 --- src/mesa

[Mesa-dev] [PATCH 47/47] mesa: remove never-defined FEATURE_histogram conditional.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/histogram.c |4 src/mesa/main/histogram.h | 11 --- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/histogram.c b/src/mesa/main/histogram.c index 44fc132..d3dc7dd 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 21/47] mesa: remove FEATURE_point_size_array define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/arrayobj.c |2 -- src/mesa/main/enable.c|4 +--- src/mesa/main/ffvertex_prog.c |2 -- src/mesa/main/getstring.c |2 -- src/mesa/main/mfeatures.h |2 -- 5 files changed, 1 insertions(+), 11 deletions

[Mesa-dev] [PATCH 17/47] mesa: remove FEATURE_rastpos define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/mfeatures.h|1 - src/mesa/main/rastpos.c |6 -- src/mesa/main/rastpos.h | 11 --- src/mesa/state_tracker/st_cb_rasterpos.c |4 src/mesa/state_tracker

[Mesa-dev] [PATCH 13/47] mesa: remove FEATURE_evaluators define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/eval.c|6 -- src/mesa/main/eval.h| 19 --- src/mesa/main/mfeatures.h |1 - src/mesa/vbo/vbo_exec_api.c |4 src/mesa/vbo/vbo_noop.c |4 5 files changed, 0 insertions(+), 34

[Mesa-dev] [PATCH 16/47] mesa: remove FEATURE_queryobj define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/dlist.c | 10 -- src/mesa/main/extensions.c |2 -- src/mesa/main/mfeatures.h |1 - src/mesa/main/queryobj.c|6 -- src/mesa/main/queryobj.h| 22

[Mesa-dev] [PATCH 12/47] mesa: remove FEATURE_drawpix define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/drawpix.c |6 - src/mesa/main/drawpix.h | 11 -- src/mesa/main/mfeatures.h |1 - src/mesa/state_tracker/st_cb_bitmap.c |4 --- src/mesa/state_tracker/st_cb_bitmap.h

[Mesa-dev] [PATCH 03/47] mesa: remove FEATURE_userclip define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/enable.c|2 -- src/mesa/main/matrix.c|2 -- src/mesa/main/mfeatures.h |2 -- 3 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 14eea53..78ce471 100644 --- a/src

[Mesa-dev] [PATCH 07/47] mesa: remove FEATURE_beginend define.

2012-09-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- src/mesa/main/api_loopback.c |6 --- src/mesa/main/api_loopback.h | 11 -- src/mesa/main/mfeatures.h|4 +-- src/mesa/main/vtxfmt.c |5 --- src/mesa/main/vtxfmt.h | 16 - src/mesa/vbo/vbo_exec.h | 15

  1   2   3   >