On Wed, Oct 03, 2012 at 07:45:12AM -0600, Brian Paul wrote: > On 10/03/2012 02:37 AM, Oliver McFadden wrote: > > On Tue, Oct 02, 2012 at 06:47:49PM -0700, Kenneth Graunke wrote: > >> On 10/02/2012 04:00 AM, Oliver McFadden wrote: > >>> This reverts commit 85cd30406ff8414bc6ac6de1064d059a4c564160. > >>> > >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55523 > >>> Signed-off-by: Oliver McFadden<oliver.mcfad...@linux.intel.com> > >>> CC: Kenneth Graunke<kenn...@whitecape.org> > >>> --- > >>> src/mesa/drivers/dri/i965/gen6_clip_state.c | 1 - > >>> src/mesa/drivers/dri/i965/gen6_viewport_state.c | 24 > >>> +++++++++------------- > >>> 2 files changed, 10 insertions(+), 15 deletions(-) > >> > >> Oliver, > >> > >> I'm fine with reverting these patches on the 9.0 branch...especially > >> given how close we are to a release. I'd like to leave them on master > >> for a little while and do some investigation. If we can't solve it, we > >> can revert it...but if it ends up being something easy, I'd rather just > >> fix it... > > > > Okay. I am unfamiliar with the process for applying patches onto the > > release branches... May I simply push the revert patches there, with > > your Reviewed-by (which I assume you have given implicitly,) or must I > > involve Brian? > > I'm not involved in the i965 driver but it sounds like you should go > ahead and revert the patches in question on the stable branch.
Yes, I have pushed the reverts to the 9.0 branch, but not yet to master. Kenneth wants to try to debug the problem before we resort to reverting on master, too. I have provided him with an APItrace so that he can debug. I found that the guard band clipping doesn't increase performance noticeably for me, however I am only testing with Dante, so it's possible that other programs may receive more significant benefits. Since we're close to a 9.0 release, I would prefer see that released with a correct rendering, rather than noticeably incorrect rendering and a potential minor performance increase. -- Oliver McFadden. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
