[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #4 from Alexander Tsoy --- Also both demos causes VM faults: [39619.603973] amdgpu :01:00.0: GPU fault detected: 146 0x0e68240c [39619.610244] amdgpu :01:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x001197CD [39619.617749]

[Mesa-dev] [Bug 107564] AttributeError: 'module' object has no attribute 'combinations_with_replacement'

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107564 Bug ID: 107564 Summary: AttributeError: 'module' object has no attribute 'combinations_with_replacement' Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH] virgl: ARB_texture_barrier support

2018-08-13 Thread Tomeu Vizoso
Reviewed-by: Tomeu Vizoso On 14 August 2018 at 07:40, Dave Airlie wrote: > ping? > On Wed, 8 Aug 2018 at 08:46, Dave Airlie wrote: >> >> From: Dave Airlie >> >> --- >> src/gallium/drivers/virgl/virgl_context.c | 9 +++-- >> src/gallium/drivers/virgl/virgl_encode.c | 8 >> src/

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #3 from Alexander Tsoy --- This is a regression in mesa-18.2. Demos rendered just fine on the same system with mesa-18.1. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

[Mesa-dev] [PATCH] [V2] i965: Context aware user space EU control through application

2018-08-13 Thread aravindan . muthukumar
From: "Muthukumar, Aravindan" The Patch here is to give control to user/ application to really decide what's the max GPU load it would put. If that can be known in advance, rpcs can be programmed accordingly. This solution has changes across i915, drm and mesa (not limited only to kernel).

Re: [Mesa-dev] [PATCH] virgl: ARB_texture_barrier support

2018-08-13 Thread Dave Airlie
ping? On Wed, 8 Aug 2018 at 08:46, Dave Airlie wrote: > > From: Dave Airlie > > --- > src/gallium/drivers/virgl/virgl_context.c | 9 +++-- > src/gallium/drivers/virgl/virgl_encode.c | 8 > src/gallium/drivers/virgl/virgl_encode.h | 2 ++ > src/gallium/drivers/virgl/virgl_hw.h

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #2 from Alexander Tsoy --- Created attachment 141076 --> https://bugs.freedesktop.org/attachment.cgi?id=141076&action=edit VikingVillage.png -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #1 from Alexander Tsoy --- Created attachment 141075 --> https://bugs.freedesktop.org/attachment.cgi?id=141075&action=edit CorridorLightingExample.png -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 Bug ID: 107563 Summary: [RADV] Broken rendering in Unity demos Product: Mesa Version: 18.2 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 3/3] radv: Add on-demand compilation of built-in shaders.

2018-08-13 Thread Dave Airlie
On Tue, 14 Aug 2018 at 09:01, Bas Nieuwenhuizen wrote: > > In environments where we cannot cache, e.g. Android (no homedir), > ChromeOS (readonly rootfs) or sandboxes (cannot open cache), the > startup cost of creating a device in radv is rather high, due > to compiling all possible built-in pipe

[Mesa-dev] [PATCH] virgl: bump 3D texture limit to 2048, as GL4.1 requires

2018-08-13 Thread Gurchetan Singh
This is virgl analogue to cf6dad. Fixes: dEQP-GLES31.functional.image_load_store.3d.atomic.* Example test cases: dEQP-GLES31.functional.image_load_store.3d.atomic.add_r32ui_return_value dEQP-GLES31.functional.image_load_store.3d.atomic.min_r32ui_return_value dEQP-GLES31.functional.image_l

Re: [Mesa-dev] [PATCH] anv: add VK_EXT_sampler_filter_minmax support

2018-08-13 Thread Jason Ekstrand
On August 10, 2018 19:18:53 Yunchao He wrote: This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* --- src/intel/vulkan/anv_

Re: [Mesa-dev] [PATCH] anv: add VK_EXT_sampler_filter_minmax support

2018-08-13 Thread Jason Ekstrand
On August 10, 2018 19:18:53 Yunchao He wrote: This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* --- src/intel/vulkan/anv_

Re: [Mesa-dev] [PATCH 2/2] blorp: Properly handle Z24X8 blits.

2018-08-13 Thread Jason Ekstrand
On August 10, 2018 04:18:51 Kenneth Graunke wrote: One of the reasons we didn't notice that R24_UNORM_X8_TYPELESS destinations were broken was that an earlier layer was swapping it out for B8G8R8A8_UNORM. That made Z24X8 -> Z24X8 blits work. However, R32_FLOAT -> R24_UNORM_X8_TYPELESS was sti

[Mesa-dev] [PATCH 1/2] intel: decoder: handle 0 sized structs

2018-08-13 Thread Lionel Landwerlin
Gen7.5 has a BLEND_STATE of size 0 which includes a variable length group. We did not deal with that very well, leading to an endless loop. Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107544 --- src/intel/common/gen_decoder.c | 28 +

[Mesa-dev] [PATCH 2/2] intel: batch-decoder: fix parsing of BLEND_STATE

2018-08-13 Thread Lionel Landwerlin
The previous implementation seemed to imply that 3DSTATE_BLEND_STATE_POINTERS had a pointer to an array of BLEND_STATE. This is true on Gen7.5 but not on Gen8+. The actual array is made up of BLEND_STATE_ENTRY elements following BLEND_STATE (which is empty on Gen7.5). Signed-off-by: Lionel Landwer

[Mesa-dev] [PATCH 1/5] intel/compiler: Silence unused parameter warning

2018-08-13 Thread Ian Romanick
From: Ian Romanick A later commit would have added the warning below. All of the other brw_*_desc take and use a gen_device_info parameter. All of the functions are static and inline, so the compiler optimizes the parameter away. To maintain the pattern, just mark the parameter UNUSED. In fil

[Mesa-dev] [PATCH 5/5] nir: Lower flrp differently when the alpha value is reused

2018-08-13 Thread Ian Romanick
From: Ian Romanick For some reason, if I did not move the regular lowering to late optimizations, the new lowering would never trigger. This also means that the fsub lowering had to be added to late optimizations, and this requires "intel/compiler: Repeat nir_opt_algebraic_late until no more pro

[Mesa-dev] [PATCH 4/5] nir: Lower flrp(1.0, b, c) and flrp(a, 1.0, c) differently

2018-08-13 Thread Ian Romanick
From: Ian Romanick Instead of lowering as (a + c(b - a)), lower as (a(1 - c) + bc). Since either a or b is 1.0, some of the multiplications drop out. I am CC'ing people who are responsible for drivers that set lower_flrp32 as this patch will likely affect shader-db results for those drivers. N

[Mesa-dev] [PATCH 3/5] intel/compiler: Don't emit flrp for Gen4 or Gen5

2018-08-13 Thread Ian Romanick
From: Ian Romanick No changes on any Gen6+ platform. The shaders with loops hurt are SIMD8 and SIMD16 shaders for a text-identical fragment shader. The loops are unrolled again in a later patch that may or may not be included in the final series (nir: Lower flrp differently when the alpha value

[Mesa-dev] [PATCH 2/5] intel/compiler: Repeat nir_opt_algebraic_late until no more progress

2018-08-13 Thread Ian Romanick
From: Ian Romanick Withouth this, a pattern that creates a sequence that another pattern can match will never perform the second match. This can mean either lost optimization opportunity (and a lot of frustration... "Why the %@#$ isn't my optimization happening?!?") or, even worse, missed loweri

[Mesa-dev] [PATCH 0/5] Do better for flrp on platforms that lack flrp instruction

2018-08-13 Thread Ian Romanick
This series is a prerequisite for the optimizations that I actually wanted to do. That series, which affects the use of nir_op_flrp, will come later. For some reason, Intel Gen5 and earlier platforms don't lower flrp instructions in NIR. Instead these instructions are lowered when converting fro

Re: [Mesa-dev] Why are pbuffers backed by a pixmaps (Was Re: [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.)

2018-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2018 at 3:53 AM Emil Velikov wrote: > > Hi Adam, > > Thanks for the extensive write-up. > > On 9 August 2018 at 20:30, Adam Jackson wrote: > > On Thu, 2018-08-09 at 18:22 +0100, Emil Velikov wrote: > > > >> In the GLX case, it's required due to server-side rendering. One needs > >

[Mesa-dev] [PATCH 2/3] radv: Refactor blit pipeline creation.

2018-08-13 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_meta_blit.c | 525 +++- 1 file changed, 175 insertions(+), 350 deletions(-) diff --git a/src/amd/vulkan/radv_meta_blit.c b/src/amd/vulkan/radv_meta_blit.c index f68496d3202..370d4fcd831 100644 --- a/src/amd/vulkan/radv_meta_blit.c +++ b/src/amd/

[Mesa-dev] [PATCH 1/3] radv: Make fs key exemplars ordered to be a reverse fs_key lookup.

2018-08-13 Thread Bas Nieuwenhuizen
While at it, share the exemplars and account for a non-occurring fs key. --- src/amd/vulkan/radv_meta_blit.c | 21 +++-- src/amd/vulkan/radv_meta_blit2d.c | 19 ++- src/amd/vulkan/radv_meta_clear.c | 19 ++- src/amd/vulkan/radv_meta_re

[Mesa-dev] [PATCH 3/3] radv: Add on-demand compilation of built-in shaders.

2018-08-13 Thread Bas Nieuwenhuizen
In environments where we cannot cache, e.g. Android (no homedir), ChromeOS (readonly rootfs) or sandboxes (cannot open cache), the startup cost of creating a device in radv is rather high, due to compiling all possible built-in pipelines up front. This meant depending on the CPU a 1-4 sec cost of c

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-13 Thread Ian Romanick
On 08/09/2018 01:09 PM, Marek Olšák wrote: > On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: >> enable _mesa_PushAttrib() and _mesa_PopAttrib() >> to handle GL_DEPTH_CLAMP_NEAR_AMD and >> GL_DEPTH_CLAMP_FAR_AMD tokens. >> >> Signed-off-by: Sagar Ghuge >> --- >> src/mesa/main/attrib.c | 16 ++

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-13 Thread Ian Romanick
On 08/09/2018 01:14 PM, Sagar Ghuge wrote: > > > On 08/09/2018 01:09 PM, Marek Olšák wrote: >> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: >>> enable _mesa_PushAttrib() and _mesa_PopAttrib() >>> to handle GL_DEPTH_CLAMP_NEAR_AMD and >>> GL_DEPTH_CLAMP_FAR_AMD tokens. >>> >>> Signed-off-b

Re: [Mesa-dev] [RFC][PATCH 0/5] mesa: Add types for AMD_depth_clamp_separate.

2018-08-13 Thread Sagar Ghuge
Hi everyone, I am kind of stuck on this part actually. I don't have latest AMD graphics card to test following behavior which Ian and Marek suggested me. I have written a piglit test : https://gitlab.freedesktop.org/sagarghuge/piglit/blob/320b91ffb131b380f1d27d9c05ab141e0cd9e557/tests/spec/amd_

Re: [Mesa-dev] [PATCH 00/13] Implement INTEL_shader_atomic_float_minmax

2018-08-13 Thread Ian Romanick
bump. I've pushed a rebased version of the branch to the cgit below. On 06/22/2018 10:03 PM, Ian Romanick wrote: > I initially started implementing support for NV_shader_atomic_float. I > had misunderstood the hardware specs, and Intel hardware cannot actually > do that extension. It does have

Re: [Mesa-dev] [PATCH 1/5] egl/android: use drmDevice instead of the manual /dev/dri iteration

2018-08-13 Thread Robert Foss
Hey again On 13/08/2018 21.01, Robert Foss wrote: Hey Emil, On 13/08/2018 16.44, Emil Velikov wrote: From: Emil Velikov Replace the manual handling of /dev/dri in famour of the drmDevice API. The latter provides a consistent way of enumerating the devices, providing device details as needed.

Re: [Mesa-dev] [PATCH 1/5] egl/android: use drmDevice instead of the manual /dev/dri iteration

2018-08-13 Thread Robert Foss
Hey Emil, On 13/08/2018 16.44, Emil Velikov wrote: From: Emil Velikov Replace the manual handling of /dev/dri in famour of the drmDevice API. The latter provides a consistent way of enumerating the devices, providing device details as needed. Cc: Robert Foss Cc: Tomasz Figa Signed-off-by: E

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Dylan Baker
This probably should have a Fixes tag? Quoting Alejandro Piñeiro (2018-08-13 07:50:38) > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other so

Re: [Mesa-dev] [PATCH 1/5] egl/android: use drmDevice instead of the manual /dev/dri iteration

2018-08-13 Thread Robert Foss
Hey, On 13/08/2018 16.44, Emil Velikov wrote: From: Emil Velikov Replace the manual handling of /dev/dri in famour of the drmDevice API. The latter provides a consistent way of enumerating the devices, providing device details as needed. Thanks for coding this up, it's neater and the way to

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-13 Thread Ian Romanick
On 08/13/2018 08:57 AM, Danylo Piliaiev wrote: > Accessing scalar constant as an array in function call or > initializer list triggered assert in get_array_element. > Examples: >func(0[0]); >vec2 t = { 0[0], 0 }; Do we have tests like this in piglit? What happens if 0[0] syntax is used ot

Re: [Mesa-dev] [PATCH 08/11] glsl: add arithmetic builtin functions for EXT_gpu_shader4

2018-08-13 Thread Ian Romanick
On 08/07/2018 10:42 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/compiler/glsl/builtin_functions.cpp | 48 ++--- > 1 file changed, 35 insertions(+), 13 deletions(-) > > diff --git a/src/compiler/glsl/builtin_functions.cpp > b/src/compiler/glsl/builtin_functions.

Re: [Mesa-dev] [PATCH 01/11] mesa: fix glGet for EXT_gpu_shader4

2018-08-13 Thread Ian Romanick
Patches 1 through 4, 6, 7, and 9 are: Reviewed-by: Ian Romanick I sent comments on 5, 8, and 10. I don't have any opinion about 11. :) On 08/07/2018 10:41 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mapi/glapi/gen/EXT_gpu_shader4.xml | 4 > src/mesa/main/get.c

Re: [Mesa-dev] [PATCH 05/11] glsl: enable types for EXT_gpu_shader4

2018-08-13 Thread Ian Romanick
On 08/07/2018 10:42 PM, Marek Olšák wrote: > From: Chris Forbes > > --- > src/compiler/glsl/builtin_types.cpp | 32 ++ > src/compiler/glsl/glsl_lexer.ll | 50 ++--- > 2 files changed, 57 insertions(+), 25 deletions(-) > > diff --git a/src/compiler/gls

[Mesa-dev] [ANNOUNCE] mesa 18.1.6

2018-08-13 Thread Dylan Baker
Hi list, I'm announcing the general availability of the 18.1.6 release. This is an 18.1 bugfix release. There are two more 18.1 bug fix releases planned at this time. We've had another busy cycle the last two weeks, there have been roughly 3 dozen fixes in this release. In brief: - autotools

[Mesa-dev] [PATCH 6/5] egl/android: continue to next device if dri2_create_screen fails

2018-08-13 Thread Emil Velikov
From: Emil Velikov Unlike the other platforms, here we aim do guess if the device that we somewhat arbitrarily picked, is supported or not. It seems a bit fiddly, but considering EGL_EXT_explicit_device and EGL_MESA_query_renderer are MIA, this is the best we can do for the moment. With those (

Re: [Mesa-dev] [PATCH 1/5] egl/android: use drmDevice instead of the manual /dev/dri iteration

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 16:37, Frank Binns wrote: > Hi Emil, > > Emil Velikov writes: > >> From: Emil Velikov >> >> Replace the manual handling of /dev/dri in famour of the drmDevice API. > > s/famour/favour/ > >> The latter provides a consistent way of enumerating the devices, >> providing device

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-13 Thread Ian Romanick
On 08/10/2018 08:14 PM, Marek Olšák wrote: > On Fri, Aug 10, 2018 at 9:04 PM, Ian Romanick wrote: >> On 08/07/2018 10:42 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This is needed for exposing the samplerBuffer functions under >>> EXT_gpu_shader4. >>> >>> glTexBufferEXT is defined in gla

[Mesa-dev] [AppVeyor] mesa 18.1 #8585 completed

2018-08-13 Thread AppVeyor
Build mesa 8585 completed Commit 5343019cfa by Dylan Baker on 8/13/2018 3:36 PM: docs: Add release notes for 18.1.6 Configure your notification preferences ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-13 09:25:01) > On Mon, Aug 13, 2018 at 5:54 PM, Dylan Baker wrote: > > Quoting Emil Velikov (2018-08-13 03:38:13) > >> On 10 August 2018 at 00:57, Dylan Baker wrote: > >> > Quoting Chad Versace (2018-08-09 10:37:33) > >> >> On Tue 07 Aug 2018, Dylan Baker wrote:

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 17:25, Bas Nieuwenhuizen wrote: > On Mon, Aug 13, 2018 at 5:54 PM, Dylan Baker wrote: >> Quoting Emil Velikov (2018-08-13 03:38:13) >>> On 10 August 2018 at 00:57, Dylan Baker wrote: >>> > Quoting Chad Versace (2018-08-09 10:37:33) >>> >> On Tue 07 Aug 2018, Dylan Baker wrot

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Bas Nieuwenhuizen
On Mon, Aug 13, 2018 at 5:54 PM, Dylan Baker wrote: > Quoting Emil Velikov (2018-08-13 03:38:13) >> On 10 August 2018 at 00:57, Dylan Baker wrote: >> > Quoting Chad Versace (2018-08-09 10:37:33) >> >> On Tue 07 Aug 2018, Dylan Baker wrote: >> >> > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) >

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Roland Scheidegger
Am 13.08.2018 um 16:50 schrieb Alejandro Piñeiro: > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. Reviewed-by: Roland Scheidegger > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other sour

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

2018-08-13 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 12:47 AM Emil Velikov wrote: > > On 13 August 2018 at 16:21, Tomasz Figa wrote: > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> > >> The name string is guaranteed to be NULL terminated. Drop the explicit > >> length check t

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov wrote: > > On 13 August 2018 at 16:43, Tomasz Figa wrote: > > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov > > wrote: > >> > >> On 13 August 2018 at 16:16, Tomasz Figa wrote: > >> > Hi Emil, > >> > > >> > On Mon, Aug 13, 2018 at 11:48 PM Emil Velik

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 16:43, Tomasz Figa wrote: > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov > wrote: >> >> On 13 August 2018 at 16:16, Tomasz Figa wrote: >> > Hi Emil, >> > >> > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov >> > wrote: >> >> >> >> From: Emil Velikov >> >> >> >> The functi

[Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-13 Thread Danylo Piliaiev
Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples: func(0[0]); vec2 t = { 0[0], 0 }; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 Signed-off-by: Danylo Piliaiev --- src/compiler/glsl/ir_constant_expr

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Dylan Baker
Quoting Emil Velikov (2018-08-13 03:38:13) > On 10 August 2018 at 00:57, Dylan Baker wrote: > > Quoting Chad Versace (2018-08-09 10:37:33) > >> On Tue 07 Aug 2018, Dylan Baker wrote: > >> > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > >> > > > >> > > anv_extensions_c = custom_target( > >> >

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 16:21, Tomasz Figa wrote: > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > wrote: >> >> From: Emil Velikov >> >> The name string is guaranteed to be NULL terminated. Drop the explicit >> length check that comes with strncmp(). > > Is there anything wrong with that length c

Re: [Mesa-dev] [PATCH 1/3] egl/drm: use gbm_dri_device() wrapper

2018-08-13 Thread Daniel Stone
Hi, On Mon, 13 Aug 2018 at 15:46, Emil Velikov wrote: > Remove the explicit cast, using the appropriate wrapper instead. > > Signed-off-by: Emil Velikov I just compile-tested this, and it went OK - still a bunch of random unrelated warnings throughout the build but this didn't add any new ones.

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov wrote: > > On 13 August 2018 at 16:16, Tomasz Figa wrote: > > Hi Emil, > > > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> > >> The function name is misleading - it effectively checks if > >> loader_ge

Re: [Mesa-dev] [PATCH 1/3] egl/drm: use gbm_dri_device() wrapper

2018-08-13 Thread Eric Engestrom
On Monday, 2018-08-13 15:42:21 +0100, Emil Velikov wrote: > From: Emil Velikov > > Remove the explicit cast, using the appropriate wrapper instead. > > Signed-off-by: Emil Velikov Series is: Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/platform_drm.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 1/5] egl/android: use drmDevice instead of the manual /dev/dri iteration

2018-08-13 Thread Frank Binns
Hi Emil, Emil Velikov writes: > From: Emil Velikov > > Replace the manual handling of /dev/dri in famour of the drmDevice API. s/famour/favour/ > The latter provides a consistent way of enumerating the devices, > providing device details as needed. > > Cc: Robert Foss > Cc: Tomasz Figa > Si

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 16:16, Tomasz Figa wrote: > Hi Emil, > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > wrote: >> >> From: Emil Velikov >> >> The function name is misleading - it effectively checks if >> loader_get_driver_for_fd fails. Which can happen only only on strdup >> error - a clo

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

2018-08-13 Thread Tomasz Figa
On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov wrote: > > From: Emil Velikov > > The name string is guaranteed to be NULL terminated. Drop the explicit > length check that comes with strncmp(). Is there anything wrong with that length check? I feel like it's a good practice to keep it anyway. Be

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 15:56, Alejandro Piñeiro wrote: > > > On 13/08/18 16:50, Alejandro Piñeiro wrote: >> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this >> patch replaces it with unsigned. >> --- >> >> Note that Im not sure if this is the usual solution. As far as I see, >> uin

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Tomasz Figa
Hi Emil, On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov wrote: > > From: Emil Velikov > > The function name is misleading - it effectively checks if > loader_get_driver_for_fd fails. Which can happen only only on strdup > error - a close to impossible scenario. How about a DRI node which doesn't

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Alejandro Piñeiro
On 13/08/18 16:50, Alejandro Piñeiro wrote: > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other source files. Having said so, just replacing

[Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Alejandro Piñeiro
From AppVeyor #8582, it seems that MSVC doesn't like uint, so this patch replaces it with unsigned. --- Note that Im not sure if this is the usual solution. As far as I see, uint is used on other source files. Having said so, just replacing for unsigned seems the easier way to fix this. src/mesa

[Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Emil Velikov
From: Emil Velikov The function name is misleading - it effectively checks if loader_get_driver_for_fd fails. Which can happen only only on strdup error - a close to impossible scenario. Drop the function - we call the loader API at at later stage. Cc: Robert Foss Cc: Tomasz Figa Signed-off-b

[Mesa-dev] [PATCH 4/5] egl/android: remove drmVersion::name NULL check

2018-08-13 Thread Emil Velikov
From: Emil Velikov The name string is guaranteed to be non-NULL. Cc: Robert Foss Cc: Tomasz Figa Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/pla

[Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

2018-08-13 Thread Emil Velikov
From: Emil Velikov The name string is guaranteed to be NULL terminated. Drop the explicit length check that comes with strncmp(). Cc: Robert Foss Cc: Tomasz Figa Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 5/5] egl/android: simplify device open/probe

2018-08-13 Thread Emil Velikov
From: Emil Velikov Currently droid_probe_device, does not do any 'probing' but filtering out a device if it doesn't match the vendor string given. Rename the function, straighten the return type and call it only as needed - an actual vendor string is provided. Cc: Robert Foss Cc: Tomasz Figa

[Mesa-dev] [PATCH 1/5] egl/android: use drmDevice instead of the manual /dev/dri iteration

2018-08-13 Thread Emil Velikov
From: Emil Velikov Replace the manual handling of /dev/dri in famour of the drmDevice API. The latter provides a consistent way of enumerating the devices, providing device details as needed. Cc: Robert Foss Cc: Tomasz Figa Signed-off-by: Emil Velikov --- If using VGEM the following patch is

[Mesa-dev] [PATCH 2/3] egl/drm: use gbm_dri_surface() wrapper

2018-08-13 Thread Emil Velikov
From: Emil Velikov Remove the explicit cast, using the appropriate wrapper instead. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform

[Mesa-dev] [PATCH 3/3] egl/drm: use gbm_dri_bo() wrapper

2018-08-13 Thread Emil Velikov
From: Emil Velikov Remove the explicit cast, using the appropriate wrapper instead. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_d

[Mesa-dev] [PATCH 1/3] egl/drm: use gbm_dri_device() wrapper

2018-08-13 Thread Emil Velikov
From: Emil Velikov Remove the explicit cast, using the appropriate wrapper instead. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c

[Mesa-dev] [AppVeyor] mesa master #8582 failed

2018-08-13 Thread AppVeyor
Build mesa 8582 failed Commit c91a5f70fb by Neil Roberts on 7/31/2018 1:44 PM: i965/nir: Use the nir copy of shader_info to handle gl_PatchVerticesIn\n\nInstead of using the copy of shader_info stored in gl_program, it now\nuses the one in nir_shader. This is n

Re: [Mesa-dev] [PATCH 02/10] spirv: Make VertexIndex and VertexId both non-zero-based

2018-08-13 Thread Alejandro Piñeiro
On 13/08/18 16:14, Jason Ekstrand wrote: > I think this is ok.  The difference in implementation is a bit of an > artifact of history.  When we were working on Vulkan 1.0, we wanted to > make things consistent.  One suggestion for how to do that was to have > Vertex/InstanceId which was zero-based

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 Gregor Münch changed: What|Removed |Added Blocks||77449 Referenced Bugs: https://bugs.fr

[Mesa-dev] [Bug 106877] The game Rise of the Tomb Raider lead to GPU hang when I try in same place jump into the hole.

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106877 Gregor Münch changed: What|Removed |Added Blocks||77449 Referenced Bugs: https://bugs.fr

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Gregor Münch changed: What|Removed |Added Depends on||100069, 101978, 104602,

Re: [Mesa-dev] [PATCH 02/10] spirv: Make VertexIndex and VertexId both non-zero-based

2018-08-13 Thread Jason Ekstrand
I think this is ok. The difference in implementation is a bit of an artifact of history. When we were working on Vulkan 1.0, we wanted to make things consistent. One suggestion for how to do that was to have Vertex/InstanceId which was zero-based and Vertex/InstanceIndex which included the base

Re: [Mesa-dev] [PATCH 02/10] spirv: Make VertexIndex and VertexId both non-zero-based

2018-08-13 Thread Alejandro Piñeiro
This is the only pending patch from this series, would appreciate a review. As everything involving the VertexIndex/Id, it is somewhat tricky. I'm CCing Kenneth too as he was involved on the OpenGL mess with gl_VertexId and similar. FWIW, I already executed the Intel CI, and there are no regressio

Re: [Mesa-dev] [PATCH] glx: fill out GLX_DONT_CARE values

2018-08-13 Thread Eric Engestrom
On Saturday, 2018-08-11 17:19:04 +0100, Lionel Landwerlin wrote: > When associating a template GLX config to a DRI one (filled out by the > driver), we need to update the GLX_DONT_CARE fields (like yInverted > for example). Otherwise those fields will report GLX_DONT_CARE to the > application which

[Mesa-dev] [PATCH mesa] travis: install correct version of mako for each build system

2018-08-13 Thread Eric Engestrom
Meson now uses python3, so let's add a block for Autotools, move that line into the buildsys-specific blocks, and set the correct version for Meson. Fixes: 2ee1c86d71bee5ddca2c "meson: Build with Python 3" Signed-off-by: Eric Engestrom --- .travis.yml | 9 +++-- 1 file changed, 7 insertions(

Re: [Mesa-dev] Why are pbuffers backed by a pixmaps (Was Re: [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.)

2018-08-13 Thread Emil Velikov
Hi Adam, Thanks for the extensive write-up. On 9 August 2018 at 20:30, Adam Jackson wrote: > On Thu, 2018-08-09 at 18:22 +0100, Emil Velikov wrote: > >> In the GLX case, it's required due to server-side rendering. One needs >> a separate primitive for each pbuffer, thus the information can be >>

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Emil Velikov
On 10 August 2018 at 00:57, Dylan Baker wrote: > Quoting Chad Versace (2018-08-09 10:37:33) >> On Tue 07 Aug 2018, Dylan Baker wrote: >> > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) >> > > >> > > anv_extensions_c = custom_target( >> > > @@ -36,10 +37,11 @@ anv_extensions_c = custom_target( >

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #10 from Gert Wollny --- I had a look at VSM versus ESM, and I see a difference that would indicate an error in the ESM shader (be it in blender or the drivers), but there is no specific output (like given in this bug) that would ind

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #9 from Gert Wollny --- @amonpaike thanks for pointing out the problems with blender, yes did a bit of playing around with it, so I hope I'll be able to get some insight of what might go wrong. However, there are some limits on how t