On 08/10/2018 08:14 PM, Marek Olšák wrote: > On Fri, Aug 10, 2018 at 9:04 PM, Ian Romanick <i...@freedesktop.org> wrote: >> On 08/07/2018 10:42 PM, Marek Olšák wrote: >>> From: Marek Olšák <marek.ol...@amd.com> >>> >>> This is needed for exposing the samplerBuffer functions under >>> EXT_gpu_shader4. >>> >>> glTexBufferEXT is defined in glapi, but "make check" fails. >>> What am I doing wrong? >>> --- >>> docs/relnotes/18.3.0.html | 1 + >>> src/mesa/main/extensions_table.h | 1 + >>> src/mesa/main/tests/dispatch_sanity.cpp | 1 + >>> 3 files changed, 3 insertions(+) >>> >>> diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html >>> index 786145ad8da..6274c9147a1 100644 >>> --- a/docs/relnotes/18.3.0.html >>> +++ b/docs/relnotes/18.3.0.html >>> @@ -45,20 +45,21 @@ TBD. >>> >>> >>> <h2>New features</h2> >>> >>> <p> >>> Note: some of the new features are only available with certain drivers. >>> </p> >>> >>> <ul> >>> <li>GL_AMD_framebuffer_multisample_advanced on radeonsi.</li> >>> +<li>GL_EXT_texture_buffer_object on i965, nv50, nvc0, r600, radeonsi.</li> >>> </ul> >>> >>> <h2>Bug fixes</h2> >>> >>> <ul> >>> <li>TBD</li> >>> </ul> >>> >>> <h2>Changes</h2> >>> >>> diff --git a/src/mesa/main/extensions_table.h >>> b/src/mesa/main/extensions_table.h >>> index bdba49d5380..5eb5c3278e9 100644 >>> --- a/src/mesa/main/extensions_table.h >>> +++ b/src/mesa/main/extensions_table.h >>> @@ -263,20 +263,21 @@ EXT(EXT_shadow_funcs , >>> ARB_shadow >>> EXT(EXT_stencil_two_side , EXT_stencil_two_side >>> , GLL, x , x , x , 2001) >>> EXT(EXT_stencil_wrap , dummy_true >>> , GLL, x , x , x , 2002) >>> EXT(EXT_subtexture , dummy_true >>> , GLL, x , x , x , 1995) >>> EXT(EXT_tessellation_point_size , ARB_tessellation_shader >>> , x , x , x , 31, 2013) >>> EXT(EXT_tessellation_shader , ARB_tessellation_shader >>> , x , x , x , 31, 2013) >>> EXT(EXT_texture , dummy_true >>> , GLL, x , x , x , 1996) >>> EXT(EXT_texture3D , dummy_true >>> , GLL, x , x , x , 1996) >>> EXT(EXT_texture_array , EXT_texture_array >>> , GLL, GLC, x , x , 2006) >>> EXT(EXT_texture_border_clamp , ARB_texture_border_clamp >>> , x , x , x , ES2, 2014) >>> EXT(EXT_texture_buffer , OES_texture_buffer >>> , x , x , x , 31, 2014) >>> +EXT(EXT_texture_buffer_object , ARB_texture_buffer_object >>> , GLL, GLC, x , x , 2007) >> >> I doubt we want to actually expose this extension or GL_EXT_gpu_shader4 >> in core profile. Do you know of any applications on any platform that >> need this? If there are any, I want to shame them. :) > > What's the issue with the core profile? > > I'm only adding what our closed driver supports. EXT_gpu_shader4 > wouldn't be complete without it.
Which I also think we should also remove from core profile. The problem is EXT_gpu_shader4 depends on GLSL 1.20 which does not exist in core profile. Both GLSL 1.20 and EXT_gpu_shader4 depend on a bunch of legacy GL state that doesn't exist in core. It's an ill-defined mess. > Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
