Re: [Mesa-dev] [PATCH 11/13] i965/miptree: Refactor miptree_create

2018-06-12 Thread Pohjolainen, Topi
On Tue, Jun 12, 2018 at 12:22:03PM -0700, Nanley Chery wrote: > Enable a future patch to create the r8stencil_mt in this function. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 48 +-- > 1 file changed, 12 insertions(+), 36 deletions(-) > > diff --git a/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 10/13] i965/miptree: Add and use mt_surf_usage

2018-06-12 Thread Pohjolainen, Topi
On Tue, Jun 12, 2018 at 12:22:02PM -0700, Nanley Chery wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 --- > 1 file changed, 26 insertions(+), 14 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/intel_mip

Re: [Mesa-dev] [PATCH 08/13] i965/miptree: Share the miptree format in miptree_create

2018-06-12 Thread Pohjolainen, Topi
On Tue, Jun 12, 2018 at 12:22:00PM -0700, Nanley Chery wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 30 +-- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/intel_mip

Re: [Mesa-dev] RFC about anv change that should be applicable to radv

2018-06-12 Thread Mauro Rossi
+Samuel Pitoiset 2018-06-11 22:31 GMT+02:00 Mauro Rossi : > Hi Bas, > > commit [1] removed a check on 'supported' attribute in > src/intel/vulkan/anv_entrypoints_gen.py > > Should the check on 'supported' attribute be removed also in > src/amd/vulkan/radv_entrypoints_gen.py ? > > Thanks for you

Re: [Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

2018-06-12 Thread Pohjolainen, Topi
On Tue, Jun 12, 2018 at 12:21:56PM -0700, Nanley Chery wrote: > Fix the case where only stencil writes are enabled on a depth stencil Isn't this an issue even when depth writes are enabled? Both would add the same bo to cache? > texture. Found by inspection. > > --- > > I'm looking into writing

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 --- Comment #5 from Sergii Romantsov --- Created attachment 140144 --> https://bugs.freedesktop.org/attachment.cgi?id=140144&action=edit libwayland-dev_installedFiles.png -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 --- Comment #4 from Sergii Romantsov --- Created attachment 140143 --> https://bugs.freedesktop.org/attachment.cgi?id=140143&action=edit libwayland-egl1-mesa_installedFiles.png -- You are receiving this mail because: You are the QA Contact f

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 Sergii Romantsov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG

[Mesa-dev] Mesa GitLab access approval process

2018-06-12 Thread Jason Ekstrand
Since we've been on GitLab (it's been less than a week), we've already gotten a couple of developer access requests through GitLab. As it stands, these just show up as an e-mail to the group owners with zero explanation or opportunity for the requester to provide justification for the request. Thi

Re: [Mesa-dev] [PATCH mesa 3/3] include: sync eglext.h from Khronos

2018-06-12 Thread Tapani Pälli
Acked-by: Tapani Pälli On 10.06.2018 11:35, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- include/EGL/eglext.h | 86 +--- 1 file changed, 81 insertions(+), 5 deletions(-) diff --git a/include/EGL/eglext.h b/include/EGL/eglext.h index 2f990c

[Mesa-dev] [PATCH 1/5] egl/wayland: Add 10bpc BGR configs

2018-06-12 Thread Mario Kleiner
From: Daniel Stone Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Reviewed-by: Eric Engestrom Reviewed-by: Mario Kleiner Tested-by: Mario Kleiner Tested-by: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+)

[Mesa-dev] [PATCH 5/5] egl/wayland-drm: Only announce formats via wl_drm which the driver supports.

2018-06-12 Thread Mario Kleiner
Check if a pixel format is supported by the Wayland servers gpu driver before exposing it to the client via wl_drm, so we avoid reporting formats to the client which the server gpu can't handle. Restrict this reporting to the new color depth 30 formats for now, as the ARGB/XRGB and RGB565 form

[Mesa-dev] [PATCH 2/5] gbm: Add support for 10bpp BGR formats

2018-06-12 Thread Mario Kleiner
From: Daniel Stone Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone Reviewed-by: Mario Kleiner Tested-by: Mario Kleiner Tested-by: Ilia Mirkin --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/

[Mesa-dev] Nouveau depth 30 stuff again..

2018-06-12 Thread Mario Kleiner
A resend of the series, with all of Eric Engestroems review comments addressed and retested on all combos of intel, nvidia, intel+nvidia prime. Rebased and retested against current Mesa master, otherwise only style fixes and an additional assert for documentation, no real functional changes. Plea

[Mesa-dev] [PATCH 3/5] egl/x11: Handle both depth 30 formats for eglCreateImage(). (v4)

2018-06-12 Thread Mario Kleiner
We need to distinguish if the backing storage of a pixmap is XRGB2101010 or XBGR2101010, as different gpu hw supports different formats. NVidia hw prefers XBGR, whereas AMD and Intel are happy with XRGB. Use the red channel mask of the first depth 30 visual of the x-screen to distinguish which hw

[Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload. (v2)

2018-06-12 Thread Mario Kleiner
Support PRIME render offload between a Wayland server gpu and a Wayland client gpu with different channel ordering for their color formats, e.g., between Intel drivers which currently only support ARGB2101010 and XRGB2101010 import/display and nouveau which only supports ABGR2101010 rendering and d

[Mesa-dev] [PATCH 2/2] radeonsi: return real memory usage instead of per-process usage

2018-06-12 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_get.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 01050cf02b4..154fabebdcc 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++

[Mesa-dev] [PATCH 1/2] ac/gpu_info: report real total memory sizes

2018-06-12 Thread Marek Olšák
From: Marek Olšák The change from MIN2 to MAX2 is intentional. --- src/amd/common/ac_gpu_info.c | 82 1 file changed, 54 insertions(+), 28 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 6bee96b9eee..3b6600dcbc6 10

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-12 Thread Rob Clark
On Tue, Jun 12, 2018 at 3:36 PM, Jason Ekstrand wrote: > On Tue, Jun 12, 2018 at 10:49 AM, Rob Clark wrote: >> >> On Mon, Jun 11, 2018 at 10:59 PM, Roland Scheidegger >> wrote: >> > Am 12.06.2018 um 01:17 schrieb Rob Clark: >> >> On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger >> >> wrote:

[Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support. (v2)

2018-06-12 Thread Dave Airlie
From: Dave Airlie This should add all the pieces to enable tess shaders on virgl. v2: fixup transform to handle tess and strip out precise. set default for max patch varyings to work around issue when tess gets enabled from v1 caps but v2 caps aren't in place. (Elie) --- src/gallium/auxiliary/t

Re: [Mesa-dev] [PATCH v4 075/129] nir: convert lower_samplers_as_deref to deref instructions

2018-06-12 Thread Rob Clark
On Tue, Jun 12, 2018 at 6:34 PM, Kenneth Graunke wrote: > On Thursday, May 31, 2018 10:04:05 PM PDT Jason Ekstrand wrote: >> From: Rob Clark >> >> This also removes the legacy version of lower_samplers. > > It does not, that's what patch 76 (the next one) does. > (for lack of good way of viewing

[Mesa-dev] [PATCH 3/3] configure.ac: Test for __atomic_add_fetch in atomic checks

2018-06-12 Thread Matt Turner
From: Andrew Galante Some platforms have 64-bit __atomic_load_n but not 64-bit __atomic_add_fetch, so test for both of them. Bug: https://bugs.gentoo.org/655616 Reviewed-by: Matt Turner --- configure.ac | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/co

[Mesa-dev] [PATCH 2/3] meson: Test for __atomic_add_fetch in atomic checks

2018-06-12 Thread Matt Turner
From: Andrew Galante Some platforms have 64-bit __atomic_load_n but not 64-bit __atomic_add_fetch, so test for both of them. Bug: https://bugs.gentoo.org/655616 Reviewed-by: Matt Turner --- meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/meson.build b/mes

[Mesa-dev] [PATCH 1/3] meson: Fix -latomic check

2018-06-12 Thread Matt Turner
Commit 54ba73ef102f (configure.ac/meson.build: Fix -latomic test) fixed some checks for -latomic, and then commit 54bbe600ec26 (configure.ac: rework -latomic check) further extended the fixes in configure.ac but not in Meson. This commit extends those fixes to the Meson tests. Fixes: 54bbe600ec26

[Mesa-dev] [Bug 106774] GLSL IR copy propagates loads of SSBOs

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106774 --- Comment #17 from Ian Romanick --- I have sent fixes to the mesa-dev list: https://patchwork.freedesktop.org/series/44661/ And an updated version of the test case (that avoids the helper pixels problem) to the piglit list: https://patchwor

[Mesa-dev] [PATCH 1/2] glsl: Don't copy propagate from SSBO or shared variables either

2018-06-12 Thread Ian Romanick
From: Ian Romanick Since SSBOs can be written, copy propagating a read can cause the value to magically change. SSBO reads are also very expensive, so doing it twice will be slower. Haswell, Broadwell, and Skylake had similar results. (Skylake shown) total instructions in shared programs: 14399

[Mesa-dev] [PATCH 2/2] glsl: Don't copy propagate elements from SSBO or shared variables either

2018-06-12 Thread Ian Romanick
From: Ian Romanick Since SSBOs can be written, copy propagating a read can cause the value to magically change. SSBO reads are also very expensive, so doing it twice will be slower. The same shader was helped by this patch and the previous. Haswell, Broadwell, and Skylake had similar results.

Re: [Mesa-dev] [PATCH] intel/aubinator: Use int to store getopt_long flags.

2018-06-12 Thread Ian Romanick
Reviewed-by: Ian Romanick On 06/12/2018 12:23 PM, Rafael Antognolli wrote: > getopt_long flag parameter is an int pointer, so if we use bool to store > those values, when getopt_long writes to one of them, it might end up > overwriting the next one. > --- > src/intel/tools/aubinator.c | 4 ++-- >

Re: [Mesa-dev] [PATCH v4 075/129] nir: convert lower_samplers_as_deref to deref instructions

2018-06-12 Thread Kenneth Graunke
On Thursday, May 31, 2018 10:04:05 PM PDT Jason Ekstrand wrote: > From: Rob Clark > > This also removes the legacy version of lower_samplers. It does not, that's what patch 76 (the next one) does. signature.asc Description: This is a digitally signed message part. _

Re: [Mesa-dev] [PATCH v4 045/129] nir: Add a concept of per-member structs and a lowering pass

2018-06-12 Thread Kenneth Graunke
On Thursday, May 31, 2018 10:02:28 PM PDT Jason Ekstrand wrote: > This adds a concept of "members" to a variable with an interface type. > It allows you to specify the full variable data for each member of the > interface instead of once for the variable. We also add a lowering pass > to lower tho

[Mesa-dev] [PATCH 2/2] anv: Rework push constant packets.

2018-06-12 Thread Rafael Antognolli
Copying from the i965 change: There's a lot of logic on the function that builds the push constants packets. It reads both the push constants and the UBOs, and tries to account for some hardware workarounds. This patch splits the logic to gather the buffers into a function, and the code to emit t

[Mesa-dev] [PATCH 1/2] i965: Rework push constants packets creation.

2018-06-12 Thread Rafael Antognolli
There's a lot of logic on the function that builds the push constants packets. It reads both the push constants and the UBOs, and tries to account for some hardware workarounds. This patch splits the logic to gather the buffers into a function, and the code to emit the packet to another one, where

Re: [Mesa-dev] [PATCH] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-12 Thread Rafael Antognolli
On Tue, Jun 12, 2018 at 01:38:03PM -0700, Rafael Antognolli wrote: > On Mon, Jun 11, 2018 at 02:01:49PM -0700, Kenneth Graunke wrote: > > The UBO push analysis pass incorrectly assumed that all values would fit > > within a 32B chunk, and only recorded a bit for the 32B chunk containing > > the sta

Re: [Mesa-dev] [PATCH] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-12 Thread Rafael Antognolli
On Mon, Jun 11, 2018 at 02:01:49PM -0700, Kenneth Graunke wrote: > The UBO push analysis pass incorrectly assumed that all values would fit > within a 32B chunk, and only recorded a bit for the 32B chunk containing > the starting offset. > > For example, if a UBO contained the following, tightly p

Re: [Mesa-dev] [PATCH v4 029/129] nir: Support deref instructions in lower_wpos_ytransform

2018-06-12 Thread Kenneth Graunke
On Thursday, May 31, 2018 10:02:12 PM PDT Jason Ekstrand wrote: > Reviewed-by: Caio Marcelo de Oliveira Filho > --- > src/compiler/nir/nir_lower_wpos_ytransform.c | 53 > ++-- > 1 file changed, 42 insertions(+), 11 deletions(-) > > diff --git a/src/compiler/nir/nir_lower

Re: [Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support.

2018-06-12 Thread Dave Airlie
On 12 June 2018 at 23:25, Elie Tournier wrote: > On Fri, Jun 08, 2018 at 03:15:36PM +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This should add all the pieces to enable tess shaders on virgl. > > Hi > > I think that we also need to add the following code: > > --- a/src/gallium/drivers/vi

[Mesa-dev] Gitlab access to Mesa

2018-06-12 Thread Hota, Alok
Hello, I created my account on gitlab.fd.o and requested access to the Mesa group. I just wanted to follow it up with an email to the list as well. I will be working specifically on the swr Gallium driver. -Alok ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] [PATCH] intel/aubinator: Use int to store getopt_long flags.

2018-06-12 Thread Rafael Antognolli
On Tue, Jun 12, 2018 at 12:23:17PM -0700, Rafael Antognolli wrote: > getopt_long flag parameter is an int pointer, so if we use bool to store > those values, when getopt_long writes to one of them, it might end up > overwriting the next one. I forgot to mention in the commit message that without t

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-12 Thread Jason Ekstrand
On Tue, Jun 12, 2018 at 10:49 AM, Rob Clark wrote: > On Mon, Jun 11, 2018 at 10:59 PM, Roland Scheidegger > wrote: > > Am 12.06.2018 um 01:17 schrieb Rob Clark: > >> On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger > wrote: > >>> Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: > On Wed,

Re: [Mesa-dev] [PATCH v4 000/129] nir: Move to using instructions for derefs

2018-06-12 Thread Kenneth Graunke
On Thursday, May 31, 2018 10:01:43 PM PDT Jason Ekstrand wrote: > Ideally, I'd like the series to get some amount of real review before it > lands. Honestly, it's been baking long enough and tested by enough people > on enough drivers that we can probably throw a bunch of Acked-by and > Tested-bys

[Mesa-dev] [PATCH] intel/aubinator: Use int to store getopt_long flags.

2018-06-12 Thread Rafael Antognolli
getopt_long flag parameter is an int pointer, so if we use bool to store those values, when getopt_long writes to one of them, it might end up overwriting the next one. --- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

2018-06-12 Thread Chad Versace
On Thu 07 Jun 2018, Fritz Koenig wrote: > Adds an extension to glFramebufferParameteri > that will specify if the framebuffer is vertically > flipped. Historically system framebuffers are > vertically flipped and user framebuffers are not. > Checking to see the state was done by looking at > the na

[Mesa-dev] [PATCH 10/13] i965/miptree: Add and use mt_surf_usage

2018-06-12 Thread Nanley Chery
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 --- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index cfb83d15ecc..5e00da86d32 100644 --- a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 06/13] i965/miptree: Delete MIPTREE_CREATE_LINEAR

2018-06-12 Thread Nanley Chery
This enum constant was introduced to enable blit maps with intel_miptree_create da2880bea05bfc87109477ab026a7f5401fc8f0c. Now that such maps use the more direct make_surface function which allows you to specify the tiling directly, the constant is no longer being used. --- src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 09/13] i965/miptree: Share alloc_flags in miptree_create

2018-06-12 Thread Nanley Chery
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 97de30076e0..cfb83d15ecc 100644 --- a/src/mesa/drivers/dri/i965/int

[Mesa-dev] [PATCH 11/13] i965/miptree: Refactor miptree_create

2018-06-12 Thread Nanley Chery
Enable a future patch to create the r8stencil_mt in this function. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 48 +-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tre

[Mesa-dev] [PATCH 08/13] i965/miptree: Share the miptree format in miptree_create

2018-06-12 Thread Nanley Chery
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 03628e3fd9f..97de30076e0 100644 --- a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 12/13] i965/miptree: Create the r8stencil_mt immediately

2018-06-12 Thread Nanley Chery
The current behavior masked two bugs where the flag was not set to true after modifying the stencil texture. One case was a regression introduced with commit bdbb527a65fc729e7a9319ae67de60d03d06c3fd and another was a bug in the depthstencil mapping code. These have since been fixed. To prevent su

[Mesa-dev] [PATCH 03/13] i965/draw: Set the r8stencil flag after drawing

2018-06-12 Thread Nanley Chery
Fixes the regresion introduced with commit bdbb527a65fc729e7a9319ae67de60d03d06c3fd "i965: Use ISL for emitting depth/stencil/hiz state on gen6+" Found by inspection. Prevents regressing the piglit test, fbo-depth-array stencil-draw, later on in this series. Cc: Jason Ekstrand --- src/mesa/dri

[Mesa-dev] [PATCH 02/13] i965/miptree: Set the r8stencil flag in map_depthstencil

2018-06-12 Thread Nanley Chery
Found by initializing the r8stencil_needs_update to false in make_separate_stencil_surface. Prevents regressing the piglit test arb_stencil_texturing-draw, later on in the series. Cc: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

[Mesa-dev] [PATCH 05/13] i965/miptree: Use make_surface in map_blit

2018-06-12 Thread Nanley Chery
Do this so that we don't have to special case linearly-tiled depth buffers in miptree_create. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 13/13] i965/miptree: Inline make_separate_stencil

2018-06-12 Thread Nanley Chery
Note that the separate stencil miptree now has the same alloc_flag as the depth component. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 --- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dr

[Mesa-dev] [Bug 34401] glXGetScreenDriver doesn't report the same driver name as used in ~/.drirc

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34401 Bug 34401 depends on bug 42035, which changed state. Bug 42035 Summary: no way to turn off vline wait at runtime https://bugs.freedesktop.org/show_bug.cgi?id=42035 What|Removed |Added ---

[Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

2018-06-12 Thread Nanley Chery
Fix the case where only stencil writes are enabled on a depth stencil texture. Found by inspection. --- I'm looking into writing a test for this. src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/

[Mesa-dev] [PATCH 00/13] Fix stencil texturing and BO caching bugs

2018-06-12 Thread Nanley Chery
This series fixes a couple stencil texturing bugs on HSW and cache-tracking for certain stencil BOs on all platforms. Nanley Chery (13): i965: Set the r8stencil flag in miptree_finish_write i965/miptree: Set the r8stencil flag in map_depthstencil i965/draw: Set the r8stencil flag after drawi

[Mesa-dev] [PATCH 07/13] i965/miptree: Share tiling_flags in miptree_create

2018-06-12 Thread Nanley Chery
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index ca909c3fab7..03628e3fd9f 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 01/13] i965: Set the r8stencil flag in miptree_finish_write

2018-06-12 Thread Nanley Chery
This seems to be the most appropriate place. --- src/mesa/drivers/dri/i965/brw_blorp.c | 6 +- src/mesa/drivers/dri/i965/brw_clear.c | 8 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- src/mesa/drivers/dri/i965/intel_tex_image.c | 3 --- 4 files changed, 4 i

[Mesa-dev] [Bug 106903] radv: Fragment shader output goes to wrong attachments when render targets are sparse

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106903 Bug ID: 106903 Summary: radv: Fragment shader output goes to wrong attachments when render targets are sparse Product: Mesa Version: git Hardware: Other OS

[Mesa-dev] [Bug 106774] GLSL IR copy propagates loads of SSBOs

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106774 --- Comment #16 from Caio Marcelo de Oliveira Filho --- (In reply to Caio Marcelo de Oliveira Filho from comment #11) > Even with the fixes to the GLSL copy propagation (and other passes) logic, > the shader was still hanging. After a debugging

Re: [Mesa-dev] [PATCH 2/2] i965: implement MESA_framebuffer_flip_y

2018-06-12 Thread Chad Versace
On Thu 07 Jun 2018, Jason Ekstrand wrote: > There are also a pile of places where we look at rb->Name == 0 to determine if > it's a window-system framebuffer For the public record, Fritz and I discussed this in person. I recommend that the patches replace each checking on rb->Name == 0 to instead

Re: [Mesa-dev] [PATCH 46/48] appveyor: Add support for meson as well as scons

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:46:19) > On Monday, 2018-06-11 15:56:13 -0700, Dylan Baker wrote: > > This currently builds softpipe only > > --- > > appveyor.yml | 28 +++- > > 1 file changed, 19 insertions(+), 9 deletions(-) > > > > diff --git a/appveyor.yml b/appv

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-12 Thread Rob Clark
On Mon, Jun 11, 2018 at 10:59 PM, Roland Scheidegger wrote: > Am 12.06.2018 um 01:17 schrieb Rob Clark: >> On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger >> wrote: >>> Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark >>>

[Mesa-dev] [PATCH] configure.ac/meson.build: Add options for library suffixes

2018-06-12 Thread bmgordon
From: Benjamin Gordon When building the Chrome OS Android container, we need to build copies of mesa that don't conflict with the Android system-supplied libraries. This adds options to create suffixed versions of EGL and GLES libraries: libEGL.so -> libEGL${egl-lib-suffix}.so libGLESv1_CM.so ->

[Mesa-dev] [PATCH] intel/fs: use uint type for per_slot_offset at GS

2018-06-12 Thread Jose Maria Casanova Crespo
This helps us to compact original instruction: mul(8) g3<1>D g6<8,8,1>UD 0x0006UD { align1 1Q }; So now we emit: mul(8) g3<1>UD g6<8,8,1>UD 0x0006UD { align1 1Q compacted }; --- src/intel/compiler/brw_fs_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 44/48] meson: add windows specific linker flags

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:38:04) > On Monday, 2018-06-11 15:56:11 -0700, Dylan Baker wrote: > > --- > > meson.build | 21 + > > 1 file changed, 21 insertions(+) > > > > diff --git a/meson.build b/meson.build > > index a244694fd4a..e1b3afbe688 100644 > > --- a/meson

Re: [Mesa-dev] [PATCH 35/48] util/tests: Use define instead of VLA

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:01:57) > On Monday, 2018-06-11 15:56:02 -0700, Dylan Baker wrote: > > To allow the this test to be built with MSVC, which doesn't support > > VLAs. > > --- > > src/util/tests/hash_table/clear.c | 13 +++-- > > src/util/tests/hash_table/dele

Re: [Mesa-dev] [PATCH 26/48] meson: fix pipe-loader compilation for windows

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 03:39:17) > On Monday, 2018-06-11 15:55:53 -0700, Dylan Baker wrote: > > --- > > src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/src/gallium/auxiliary/pipe-loader/meson.build

Re: [Mesa-dev] [PATCH 14/48] meson: don't build shader cache on windows

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:30:47) > On Monday, 2018-06-11 15:55:41 -0700, Dylan Baker wrote: > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meson.build b/meson.build > > index 4247d195bc1..ed63276b63e 100644 > > --- a/meson.build

Re: [Mesa-dev] [PATCH v1] configure.ac: Missed package 'wayland-egl-backend'

2018-06-12 Thread Eric Engestrom
On Tuesday, 2018-06-12 11:07:40 -0500, Aaron Watry wrote: > On Tue, Jun 12, 2018 at 10:31 AM, Eric Engestrom > wrote: > > On Tuesday, 2018-06-12 18:22:03 +0300, Sergii Romantsov wrote: > >> Added support of wayland-egl-backend for old Ubuntus. > >> Building of mesa with parameter "--with-egl-platf

Re: [Mesa-dev] [PATCH 10/48] meson: Add a platform for windows

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:58:53) > On Monday, 2018-06-11 15:55:37 -0700, Dylan Baker wrote: > > This mirrors the haiku build which uses a platform. > > --- > > meson.build | 16 ++-- > > meson_options.txt | 1 + > > 2 files changed, 15 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH v2 6/6] meson: remove a bunch of out of date TODO's

2018-06-12 Thread Eric Engestrom
On Tuesday, 2018-06-12 09:05:58 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-06-12 05:08:57) > > On Monday, 2018-06-11 10:19:01 -0700, Dylan Baker wrote: > > > Some of these are done already, some of them are things we're not going > > > to do, like have a toggle for GLX_TLS. > > > > I

Re: [Mesa-dev] [PATCH v1] configure.ac: Missed package 'wayland-egl-backend'

2018-06-12 Thread Aaron Watry
On Tue, Jun 12, 2018 at 10:31 AM, Eric Engestrom wrote: > On Tuesday, 2018-06-12 18:22:03 +0300, Sergii Romantsov wrote: >> Added support of wayland-egl-backend for old Ubuntus. >> Building of mesa with parameter "--with-egl-platforms=x11,wayland" >> fails: >> "configure: error: Package requiremen

Re: [Mesa-dev] [PATCH v2 6/6] meson: remove a bunch of out of date TODO's

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 05:08:57) > On Monday, 2018-06-11 10:19:01 -0700, Dylan Baker wrote: > > Some of these are done already, some of them are things we're not going > > to do, like have a toggle for GLX_TLS. > > I'm not 100% sure which is which, and I might not be the only one; > co

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:25:10) > Copied from configure.ac:1950 > > Signed-off-by: Eric Engestrom > --- > Is it still needed? We've been building on MacOS for a while, > yet nobody noticed anything (Dylan?) > If not, we should probably avoid unnecessary differences with Khronos' > he

Re: [Mesa-dev] [PATCH v1] configure.ac: Missed package 'wayland-egl-backend'

2018-06-12 Thread Eric Engestrom
On Tuesday, 2018-06-12 18:22:03 +0300, Sergii Romantsov wrote: > Added support of wayland-egl-backend for old Ubuntus. > Building of mesa with parameter "--with-egl-platforms=x11,wayland" > fails: > "configure: error: Package requirements (wayland-egl-backend >= 3) > were not met: No package 'wayla

[Mesa-dev] [PATCH v1] configure.ac: Missed package 'wayland-egl-backend'

2018-06-12 Thread Sergii Romantsov
Added support of wayland-egl-backend for old Ubuntus. Building of mesa with parameter "--with-egl-platforms=x11,wayland" fails: "configure: error: Package requirements (wayland-egl-backend >= 3) were not met: No package 'wayland-egl-backend' found" Ubuntu's releases less than 18.10 don't have pack

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 --- Comment #1 from Denis --- ./autogen.sh --with-egl-platforms=x11,wayland --with-gallium-drivers="" --with-dri-drivers=i965 --enable-debug that's how I configured mesa -- You are receiving this mail because: You are the QA Contact for the b

[Mesa-dev] [Bug 106861] fatal error: wayland-egl-backend.h: No such file or directory compilation terminated.

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106861 Denis changed: What|Removed |Added See Also||https://bugs.freedesktop.or |

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 Bug ID: 106897 Summary: Ubuntu 16.04. Mesa can't be built with specified configurations Product: Mesa Version: git Hardware: Other OS: All Stat

Re: [Mesa-dev] [PATCH 0/1] Code formatting changes in swr driver

2018-06-12 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak (and thanks for not emailing such a huge patch) > On Jun 8, 2018, at 3:01 PM, Alok Hota wrote: > > Sorry for the large patch - the changes are all whitespace and code > formatting for the swr driver and its rasterizer. > The patch file itself is available on Github

[Mesa-dev] winsys/svga/drm: Include sys/types.h

2018-06-12 Thread Ross Burton
From: Khem Raj vmw_screen.h uses dev_t which is defines in sys/types.h this header is required to be included for getting dev_t definition. This issue happens on musl C library, it is hidden on glibc since sys/types.h is included through another system headers Upstream-Status: Submitted Signed-o

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: handle SHLADD in IndirectPropagation

2018-06-12 Thread Karol Herbst
this can potentially lead to worse code, but shladd is usually only used in regards to load, and the shader-db result also states there are no regressions. I would really like to be able to do certain ops conditionally, but that's kind of a bigger project. Anyway... Reviewed-by: Karol Herbst On

[Mesa-dev] [PATCH v2 0/2] nv50/ir: SHLADD related improvements

2018-06-12 Thread Rhys Perry
This series implements an alternative solution to the problem fixed in 0bd83d0 ("nv50/ir: move LateAlgebraicOpt to the very end"). Overall, it slightly helps various shaders while slightly hurting a few others. Effects of both patches: total instructions in shared programs : 5265148 -> 5256901 (-

[Mesa-dev] [PATCH v2 2/2] nv50/ir: move LateAlgebraicOpt back to right after ConstantFolding

2018-06-12 Thread Rhys Perry
Reverts 3072bbe ("nv50/ir: move LateAlgebraicOpt to the very end") since SHLADD is now handled in IndirectPropagation. total instructions in shared programs : 5264804 -> 5256901 (-0.15%) total gprs used in shared programs: 624341 -> 624328 (-0.00%) total shared used in shared programs : 36070

[Mesa-dev] [PATCH v2 1/2] nv50/ir: handle SHLADD in IndirectPropagation

2018-06-12 Thread Rhys Perry
An alternative solution to the problem fixed in 0bd83d0 ("nv50/ir: move LateAlgebraicOpt to the very end"). total instructions in shared programs : 5265148 -> 5264804 (-0.01%) total gprs used in shared programs: 624346 -> 624341 (-0.00%) total shared used in shared programs : 360704 -> 360704

Re: [Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support.

2018-06-12 Thread Elie Tournier
On Fri, Jun 08, 2018 at 03:15:36PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This should add all the pieces to enable tess shaders on virgl. Hi I think that we also need to add the following code: --- a/src/gallium/drivers/virgl/virgl_winsys.h +++ b/src/gallium/drivers/virgl/virgl_wins

Re: [Mesa-dev] [PATCH] vkpipeline_db: add support for multi-threading

2018-06-12 Thread Samuel Pitoiset
Very nice. :-) Reviewed-by: Samuel Pitoiset On 06/09/2018 03:23 AM, Timothy Arceri wrote: --- CMakeLists.txt | 1 + run.c | 169 +++-- 2 files changed, 121 insertions(+), 49 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt in

Re: [Mesa-dev] [PATCH 1/2] vkpipeline-db: add sType to pipeline info

2018-06-12 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/12/2018 07:05 AM, Timothy Arceri wrote: From: Timothy Arceri This avoids hitting asserts in anv. --- run.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/run.c b/run.c index eafbd7d..a962887 100644 --- a/run.c +++ b/run.c @@ -264,6 +264,7 @@ create

Re: [Mesa-dev] [PATCH 2/2] vkpipeline-db: add support for anv

2018-06-12 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 06/12/2018 07:05 AM, Timothy Arceri wrote: From: Timothy Arceri --- anv-report.py | 191 ++ run.c | 75 +--- 2 files changed, 239 insertions(+), 27 deletions(-) create mode 100755 anv-r

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-12 Thread Erik Faye-Lund
On Tue, Jun 12, 2018 at 2:12 PM Erik Faye-Lund wrote: > > On Tue, Jun 12, 2018 at 1:59 PM Ilia Mirkin wrote: > > > > On Tue, Jun 12, 2018 at 7:04 AM, Erik Faye-Lund wrote: > > > I've updated my attempt here, to now have the original colors, and > > > centered the M-corners on the text a bit more

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-12 Thread Rob Clark
On Tue, Jun 12, 2018 at 7:04 AM, Erik Faye-Lund wrote: > I've updated my attempt here, to now have the original colors, and > centered the M-corners on the text a bit more properly: > > https://codepen.io/kusma/pen/vrXppL very nice :-) BR, -R > > On Tue, Jun 12, 2018 at 2:51 AM Rob Clark wrote

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-12 Thread Erik Faye-Lund
On Tue, Jun 12, 2018 at 1:59 PM Ilia Mirkin wrote: > > On Tue, Jun 12, 2018 at 7:04 AM, Erik Faye-Lund wrote: > > I've updated my attempt here, to now have the original colors, and > > centered the M-corners on the text a bit more properly: > > > > https://codepen.io/kusma/pen/vrXppL > > > Erik -

Re: [Mesa-dev] [PATCH v2 6/6] meson: remove a bunch of out of date TODO's

2018-06-12 Thread Eric Engestrom
On Monday, 2018-06-11 10:19:01 -0700, Dylan Baker wrote: > Some of these are done already, some of them are things we're not going > to do, like have a toggle for GLX_TLS. I'm not 100% sure which is which, and I might not be the only one; could you split these two into two patches? Thanks :) The

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-12 Thread Ilia Mirkin
On Tue, Jun 12, 2018 at 7:04 AM, Erik Faye-Lund wrote: > I've updated my attempt here, to now have the original colors, and > centered the M-corners on the text a bit more properly: > > https://codepen.io/kusma/pen/vrXppL > > On Tue, Jun 12, 2018 at 2:51 AM Rob Clark wrote: >> >> On Mon, Jun 11,

Re: [Mesa-dev] [PATCH 10/48] meson: Add a platform for windows

2018-06-12 Thread Eric Engestrom
On Monday, 2018-06-11 15:55:37 -0700, Dylan Baker wrote: > This mirrors the haiku build which uses a platform. > --- > meson.build | 16 ++-- > meson_options.txt | 1 + > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 634a7a

Re: [Mesa-dev] [PATCH 23/48] meson: Add support for wrapping llvm

2018-06-12 Thread Eric Engestrom
On Monday, 2018-06-11 15:55:50 -0700, Dylan Baker wrote: > For building on Windows (when not using cygwin), the assumption is that > LLVM will have to be handled via a binary wrap. In this case the user > wanting to use LLVM is this way will need to create a directory in > subprojects (any name is

Re: [Mesa-dev] [PATCH 47/48] appveyor: use chocolatey (cinst) to isntall winflexbixon

2018-06-12 Thread Eric Engestrom
(couple typos in the subject) On Monday, 2018-06-11 15:56:14 -0700, Dylan Baker wrote: > --- > appveyor.yml | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/appveyor.yml b/appveyor.yml > index 06063feba93..f544314e730 100644 > --- a/appveyor.yml > +++ b/appveyor.yml

Re: [Mesa-dev] [PATCH 46/48] appveyor: Add support for meson as well as scons

2018-06-12 Thread Eric Engestrom
On Monday, 2018-06-11 15:56:13 -0700, Dylan Baker wrote: > This currently builds softpipe only > --- > appveyor.yml | 28 +++- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/appveyor.yml b/appveyor.yml > index bd33e2e9554..06063feba93 100644 > --- a/ap

Re: [Mesa-dev] [PATCH 44/48] meson: add windows specific linker flags

2018-06-12 Thread Eric Engestrom
On Monday, 2018-06-11 15:56:11 -0700, Dylan Baker wrote: > --- > meson.build | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/meson.build b/meson.build > index a244694fd4a..e1b3afbe688 100644 > --- a/meson.build > +++ b/meson.build > @@ -847,6 +847,27 @@ else >e

  1   2   >