Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
On 06/12/2018 12:23 PM, Rafael Antognolli wrote:
> getopt_long flag parameter is an int pointer, so if we use bool to store
> those values, when getopt_long writes to one of them, it might end up
> overwriting the next one.
> ---
> src/intel/tools/aubinator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
> index 930cc92f132..9c14a9d4c97 100644
> --- a/src/intel/tools/aubinator.c
> +++ b/src/intel/tools/aubinator.c
> @@ -71,8 +71,8 @@ memfd_create(const char *name, unsigned int flags)
>
> /* options */
>
> -static bool option_full_decode = true;
> -static bool option_print_offsets = true;
> +static int option_full_decode = true;
> +static int option_print_offsets = true;
> static int max_vbo_lines = -1;
> static enum { COLOR_AUTO, COLOR_ALWAYS, COLOR_NEVER } option_color;
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
