Quoting Eric Engestrom (2018-06-12 04:58:53) > On Monday, 2018-06-11 15:55:37 -0700, Dylan Baker wrote: > > This mirrors the haiku build which uses a platform. > > --- > > meson.build | 16 ++++++++++++++-- > > meson_options.txt | 1 + > > 2 files changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/meson.build b/meson.build > > index 634a7a21758..9c8b9ca9ba5 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -222,14 +222,24 @@ else > > with_dri_platform = 'none' > > endif > > > > +with_platform_android = false > > +with_platform_haiku = false > > +with_platform_windows = false > > +with_platform_wayland = false > > +with_platform_x11 = false > > +with_platform_drm = false > > +with_platform_surfaceless = false > > +egl_native_platform = '' > > guessing that's a rebase fail :P
Yeah, git didn't generate very good diffs for this...
>
> > _platforms = get_option('platforms')
> > if _platforms.contains('auto')
> > if system_has_kms_drm
> > _platforms = ['x11', 'wayland', 'drm', 'surfaceless']
> > - elif ['darwin', 'windows', 'cygwin'].contains(host_machine.system())
> > + elif ['darwin', 'cygwin'].contains(host_machine.system())
> > _platforms = ['x11', 'surfaceless']
> > elif ['haiku'].contains(host_machine.system())
> > _platforms = ['haiku']
> > + elif host_machine.system() == 'windows'
> > + _platforms = ['windows']
>
> I'm not convinced by this though; if you add `-D platforms=windows` on
> non-Windows, what do you get?
> If you remove `windows` from `platforms` on Windows, what do you get?
The intention was (and I may have failed at this), that platform_windows was for
building a driver that would integrate with Window's libGL, which IIRC is an ICD
similar to glvnd on *nix. There are other use cases for windows though, among
them you could build an software rasterizer (swrast, llvmpipe, swr) with osmesa,
and there are certainly people who do that.
Dylan
>
> It seems to me like all the places where `with_platform_windows` is used
> in your series, it should be `host_machine.system() == 'windows'` instead.
>
> This is the only patch I'm (soft) NAK'ing in your series; the rest of it
> is:
> Acked-by: Eric Engestrom <eric.engest...@intel.com>
>
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
