On 22/06/17 11:02, Marek Olšák wrote:
Hi,
This series:
- cleans up glthread, mainly switches the implementation to u_queue
and rearranges it so that it looks like gallium/u_threaded_context
- adds "performance" counters for monitoring glthread behavior and
display them on the gallium HUD
-
@Kristian
-Original Message-
From: Lin, Johnson
Sent: Thursday, June 22, 2017 11:28 AM
To: mesa-dev@lists.freedesktop.org
Cc: Lin, Johnson
Subject: [PATCH v4 1/3] dri: Add UYVY as available format
UYVY is diffrent with YUYV in byte order.
YUYV is already declared in dri_interface.h, thi
Similar with support for YUYV but with byte order difference in sampler
---
src/compiler/nir/nir.h | 1 +
src/compiler/nir/nir_lower_tex.c | 18 ++
2 files changed, 19 insertions(+)
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
index ab7ba14303b7..1b4e470
UYVY is diffrent with YUYV in byte order.
YUYV is already declared in dri_interface.h,
this CL add the difinitions for UYVY.
Drivers can add UYVY as supported format
---
include/GL/internal/dri_interface.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/GL/internal/d
Trigger the correct sampler options for it. Similar with YUYV
---
src/intel/compiler/brw_compiler.h| 1 +
src/intel/compiler/brw_nir.c | 1 +
src/mesa/drivers/dri/i915/intel_screen.c | 21 -
src/mesa/drivers/dri/i965/brw_wm.c | 7 +++
src/mesa/d
https://bugs.freedesktop.org/show_bug.cgi?id=101552
--- Comment #2 from Shmerl ---
Thanks for the pointer! That helps indeed. I think for something like FPS
metric, it can be a useful default. But then I guess you might want to have a
negative modifier (counterpart to d).
--
You are receiving t
On 22/06/17 02:56 AM, Grazvydas Ignotas wrote:
> Looks like nobody tested radeonsi on BE for 5 months at least. You can
> try the attached patch, but I suspect there will be other places like
> this...
Yeah, this is just the tip of the iceberg. There are many reasons why
radeonsi currently can't (
https://bugs.freedesktop.org/show_bug.cgi?id=101552
Michel Dänzer changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=101552
Bug ID: 101552
Summary: Make GALLIUM_HUD lower the grid max value if metric
stays much lower all the time
Product: Mesa
Version: git
Hardware: All
OS: Linu
On Wed, Jun 21, 2017 at 8:15 PM, Marek Olšák wrote:
> On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote:
>> On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote:
>>> Hi,
>>>
>>> This series updates pipe loaders so that flags such as drirc options
>>> can be passed to create_screen(). I have compil
Counter related to timings will be sensitive to any delay introduced
by the software. In particular if our begin & end of performance
queries end up in different batches, time related counters will
exhibit biffer values caused by the time it takes for the kernel
driver to load new requests into the
On Wed, Jun 21, 2017 at 2:48 PM, Jason Ekstrand
wrote:
> Reviewed-by: Jason Ekstrand
>
> On Wed, Jun 21, 2017 at 12:35 PM, Topi Pohjolainen <
> topi.pohjolai...@gmail.com> wrote:
>
>> Fixes dEQP-EGL.functional.image.render_multiple_contexts.
>> gles2_renderbuffer_stencil_stencil_buffer
>>
>> CC:
I never liked the gpu_memcpy name anyway because I knew something like this
would come up. I left you one trivial comment on patch 1. Other than
that, the series is
Reviewied-by: Jason Ekstrand
Given that you're changing core blorp, please make sure you run this
through Jenkins on GL. :-)
--J
On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote:
> In the future, we plan on using this method to resolve images whose
> surface state fast-clear value is dynamically updated during command
> buffer execution. Start using it now for testing and to reduce churn
> later on.
>
> Signed-off-by: N
On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote:
> v2 (Jason Ekstrand):
> - Update commit title
> - Check aux level and layer as well
>
> Signed-off-by: Nanley Chery
> Reviewed-by: Iago Toral Quiroga (v1)
> ---
> src/intel/blorp/blorp.c | 7 +++
> src/intel/blorp/blorp_clear.c |
From: Marek Olšák
This is the key to better performance.
---
src/mesa/main/glthread.h | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/glthread.h b/src/mesa/main/glthread.h
index 36692fe..dd65931 100644
--- a/src/mesa/main/glthread.h
+++ b/src/mes
From: Marek Olšák
---
src/gallium/auxiliary/hud/hud_context.c | 9
src/gallium/auxiliary/hud/hud_cpu.c | 74 +
src/gallium/auxiliary/hud/hud_private.h | 8
3 files changed, 91 insertions(+)
diff --git a/src/gallium/auxiliary/hud/hud_context.c
b/s
From: Marek Olšák
for later use
---
src/gallium/auxiliary/hud/hud_context.c | 8 +---
src/gallium/auxiliary/hud/hud_private.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context.c
b/src/gallium/auxiliary/hud/hud_context.c
index 551cea9
From: Marek Olšák
Performance deltas:
Alien Isolation: +17% (it varies depending on the location)
Borderlands 2: +50% (it varies depending on the location)
BioShock Infinite: +76% (benchmark)
Civilization 6: +20% (benchmark)
---
src/mesa/drivers/dri/common/drirc | 16
From: Marek Olšák
for HUD integration in following commits. This valuable profiling data
will allow us to see on the HUD how well glthread is able to utilize
parallelism. This is better than benchmarking, because you can see
exactly what's happening and you don't have to be CPU-bound.
u_threaded
From: Marek Olšák
---
src/gallium/auxiliary/hud/hud_context.c | 5 -
src/gallium/auxiliary/hud/hud_cpu.c | 19 +--
src/gallium/auxiliary/hud/hud_private.h | 2 +-
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context.c
b/
From: Marek Olšák
---
src/gallium/auxiliary/hud/hud_context.c | 46 ---
src/gallium/auxiliary/hud/hud_private.h | 48 +
2 files changed, 48 insertions(+), 46 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context.c
b/src/gall
From: Marek Olšák
---
src/gallium/auxiliary/os/os_thread.h | 11 ---
src/gallium/state_trackers/nine/nine_state.c | 2 +-
src/util/u_thread.h | 12
3 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/src/gallium/auxiliary/os/os_
From: Marek Olšák
This mirrors exactly how u_threaded_context works.
If you understand this, you also understand u_threaded_context.
---
src/mesa/main/glthread.c | 191 ++-
src/mesa/main/glthread.h | 88 --
src/mesa/main/marshal.h
Hi,
This series:
- cleans up glthread, mainly switches the implementation to u_queue
and rearranges it so that it looks like gallium/u_threaded_context
- adds "performance" counters for monitoring glthread behavior and
display them on the gallium HUD
- decreases the batch size for much better
From: Marek Olšák
---
src/gallium/auxiliary/hud/hud_context.c | 4 ++--
src/gallium/auxiliary/hud/hud_cpu.c | 4 ++--
src/gallium/auxiliary/hud/hud_private.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context.c
b/src/gallium/auxiliar
From: Marek Olšák
we are switching to util_queue.
---
src/mapi/glapi/gen/gl_marshal.py | 5 +
src/mesa/main/glthread.c | 4
src/mesa/main/glthread.h | 30 --
src/mesa/main/marshal.c | 4
src/mesa/main/marshal.h | 27 -
On Fri, Jun 16, 2017 at 3:41 PM, Jason Ekstrand
wrote:
> This series is a rework of Ben's series to enable the CCS format modifier.
> It started as an attempt to rebase his original patches on top of my
> resolve reworks inside the miptree code. However, as I started to dive
> deeper, I found a
On Wed, Jun 21, 2017 at 4:32 PM, Roland Scheidegger wrote:
> Am 21.06.2017 um 00:54 schrieb Marek Olšák:
>> From: Marek Olšák
>>
>> This needs to be passed to gallium drivers.
>> ---
>> src/gallium/include/pipe/p_defines.h| 6 ++
>> src/gallium/state_trackers/dri/dri_screen.c
Thanks. Applied locally to my branch. If I get an OK to push my
series, I'll push your patch too.
Marek
On Wed, Jun 21, 2017 at 10:40 PM, Edmondo Tommasina
wrote:
> This fixes the long-standing problem with black transitions in The Wicher 2.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cg
For 3D image subresources undergoing a layout transition via
PipelineBarrier, we increase the number of fast-cleared layers to match
the intended behaviour of KHR_maintenance1. When such subresources
undergo layout transitions between subpasses, we don't do this to avoid
failing incorrect CTS tests
On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote:
> On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote:
>> Hi,
>>
>> This series updates pipe loaders so that flags such as drirc options
>> can be passed to create_screen(). I have compile-tested everything
>> except clover.
>>
>> The first pipe_s
This will be used in the next patch.
v2:
- Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand)
- Update commit message.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulkan/anv_blorp.c | 38 ++
src/intel/vulkan/anv_private.h
Splitting out these fields will make the color buffer transitioning
function simpler when it gains more features.
v2: Remove unintended blank line (Iago Toral)
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulkan/anv_blorp.c | 33 --
Make the function take in an image instead of an image view. This
enables us to record relocations for surfaces states created outside of
the anv_CreateImageView path.
v2 (Jason Ekstrand):
- Use image->offset instead of surf_offset in aux_offset calculation.
Signed-off-by: Nanley Chery
Reviewed-
In the future, we plan on using this method to resolve images whose
surface state fast-clear value is dynamically updated during command
buffer execution. Start using it now for testing and to reduce churn
later on.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulka
v2:
- Do layered resolves.
(Jason Ekstrand):
- Replace "bt" suffix with "attachment".
- Rename helper function to prepare_ccs_resolve.
- Move blorp_params_init() into helper function.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/blorp/blorp.h | 11
sr
v2:
- Check for aux levels in layer helper (Jason Ekstrand)
- Don't assert aux is present, return 0 if it isn't.
- Use the helpers.
v3:
- Make the helpers aspect-agnostic (Jason Ekstrand)
- Drop anv_image_has_color_aux()
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v2)
---
src/i
A GPU memcpy function could alternatively be implemented using MI_*
commands. Provide more detail into how this one operates in case another
memcpy function is created.
v2:
- Update the commit message.
v3:
- Use 'memcpy' instead of 'cpy' (Jason Ekstrand)
- Shorten 'streamout' to 'so'
Suggested-by
Reflect the fact that an image view or subresource range with the color
aspect cannot have any other aspect.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulkan/genX_cmd_buffer.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/intel/v
v2: Omit the commit message.
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand (v1)
Reviewed-by: Iago Toral Quiroga
---
src/intel/isl/isl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index ba56d86c17..bbbdb19df2 100644
--
v2 (Jason Ekstrand):
- Remove Vulkan-specific terminology from the commit title.
- Replace '== 7' with '<= 7' to hint that this is a new feature on BDW+.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
---
src/intel/isl/isl.c | 9 +++--
1 file changed, 7 insertions(+), 2 de
v2 (Jason Ekstrand):
- Update commit title
- Check aux level and layer as well
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
---
src/intel/blorp/blorp.c | 7 +++
src/intel/blorp/blorp_clear.c | 4
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/s
v2: Update commit title (Jason Ekstrand)
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
---
src/intel/blorp/blorp_clear.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index 369e18726f..0e523dfe5b 100644
Reviewed-by: Rafael Antognolli
On Tue, Jun 13, 2017 at 11:28:20AM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/intel/genxml/gen10.xml | 69
> +++---
> 1 file changed, 65 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/genx
On Wed, Jun 21, 2017 at 09:04:01AM +0200, Iago Toral wrote:
> On Tue, 2017-06-20 at 12:21 -0700, Nanley Chery wrote:
> > On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote:
> > > On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery > > m> wrote:
> > >
> > > > On Wed, Jun 14, 2017 at 09:32:22
On Tue, Jun 20, 2017 at 10:56 PM, Samuel Pitoiset
wrote:
>
>
> On 06/20/2017 10:53 PM, Samuel Pitoiset wrote:
>>
>> I have just tested this patch with Hero Siege, it still crashes.
>>
>> As you said, it's definitely a multithreading issue because it crashes
>> differently all the time.
>>
>> Let m
>-Original Message-
>From: Anuj Phogat [mailto:anuj.pho...@gmail.com]
>Sent: Wednesday, June 21, 2017 12:32 PM
>To: Srivatsa, Anusha
>Cc: mesa-dev@lists.freedesktop.org; Vivi, Rodrigo ;
>Phogat, Anuj ; Widawsky, Benjamin
>
>Subject: Re: [Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee
On Thu, 22 Jun 2017 at 00:12 Matt Turner wrote:
> On Wed, Jun 21, 2017 at 3:50 PM, Mike Lothian wrote:
> > Do intel run mesa through any of their test boxes like they do with
> kernel
> > patches?
>
> Don't top quote.
>
> Yes, we have a CI system that we use extensively and has massively
> reduc
Emil,
If I understand you correctly, you're proposing to add the ability to use
the kms_swrast driver in platform_x11.c (the host is a standard Ubuntu box
for the emulator use case, not CrOS) alongside swrast.
In that case, we would need to:
1) Have a dri2_initialize_x11_kms_swrast function that
> configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes
> x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met:
> No package 'xdamage' found
> No package 'xfixes' found
They each depend on their own *proto.
Signed-off-by: Eric Engestrom
---
.travis.yml | 20 ++
On 22/06/17 02:41, Juan A. Suarez Romero wrote:
On Wed, 2017-06-21 at 20:24 +1000, Timothy Arceri wrote:
On 21/06/17 18:13, Juan A. Suarez Romero wrote:
link_xfb_stride_layout_qualifiers() can be called multiple times, and
each time we call prog->TransformFeedback.BufferStride is reset to 0.
On 22/06/17 02:41, Juan A. Suarez Romero wrote:
link_xfb_stride_layout_qualifiers() can be called multiple times, and
each time we call prog->TransformFeedback.BufferStride is reset to 0.
But we should only reset it if the shaders provide an explicit stride.
Fixes:
KHR-GL45.enhanced_layouts.xfb
On Wed, Jun 21, 2017 at 3:50 PM, Mike Lothian wrote:
> Do intel run mesa through any of their test boxes like they do with kernel
> patches?
Don't top quote.
Yes, we have a CI system that we use extensively and has massively
reduced the number of regressions we have. Immense thanks to Mark
Janes
Tapani Pälli writes:
> On 06/14/2017 01:12 AM, Eric Anholt wrote:
>> Tapani Pälli writes:
>>
>>> On 06/12/2017 09:52 AM, Tapani Pälli wrote:
On 05/18/2017 09:39 PM, Eric Anholt wrote:
> Eric Anholt writes:
>
>> This series came out of fixing dEQP failures on vc4's GLES2 co
Do intel run mesa through any of their test boxes like they do with kernel
patches?
On Wed, 21 Jun 2017 at 19:23 Jason Ekstrand wrote:
> On Wed, Jun 21, 2017 at 11:20 AM, Pohjolainen, Topi <
> topi.pohjolai...@gmail.com> wrote:
>
>> On Wed, Jun 21, 2017 at 11:16:39AM -0700, Jason Ekstrand wrote:
Oops missed these,
Reviewed-by: Dave Airlie
On 11 June 2017 at 08:02, Bas Nieuwenhuizen wrote:
> Don't rename the enums and constants used for metadata.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 4 +--
> src/amd/vulkan/radv_descriptor_set.c
On 06/21/2017 10:38 AM, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> gl_FragCoord contains the window coordinates so it seems to me that
> we should not use perspective correct interpolation for it. At least
> now I get similar output as i965/swrast/llvmpipe produce.
>
> This f
On 22/06/17 01:42, Eero Tamminen wrote:
Hi,
On 21.06.2017 13:12, Timothy Arceri wrote:
The main reason these restriction exist is because glsl the loop
unrolling pass is super slow with large loops.
be5f27a84d0d fixed things so that expression trees were counted
against the limit, however it l
Reviewed-by: Jason Ekstrand
On Wed, Jun 21, 2017 at 12:35 PM, Topi Pohjolainen <
topi.pohjolai...@gmail.com> wrote:
> Fixes dEQP-EGL.functional.image.render_multiple_contexts.
> gles2_renderbuffer_stencil_stencil_buffer
>
> CC: Mark Janes
> CC: Jason Ekstrand
> CC: Kenneth Graunke
> Signed-of
On Friday, 2017-06-16 19:37:48 -0700, Chad Versace wrote:
> Rename 'config' to 'config_count'. I didn't understand what the variable
I think you mean "Rename 'count' to 'config_count'" :)
Agreed with Emil about making the same change across all platforms (one
of these days I'll dedup those, altho
On Friday, 2017-06-16 19:37:50 -0700, Chad Versace wrote:
> Many Android apps (such as Google's official NDK GLES2 example app), and
> even portions the core framework code (such as SystemServiceManager in
> Nougat), incorrectly choose their EGLConfig. They neglect to match the
> EGLConfig's EGL_N
On Wed 21 Jun 2017, Jason Ekstrand wrote:
> On Wed, Jun 21, 2017 at 12:33 PM, Chad Versace <[1]chadvers...@chromium.org>
> wrote:
>
> On Fri 16 Jun 2017, Jason Ekstrand wrote:
> > This commit replaces the complex and confusing set of disable flags with
> > two fairly straightforward fi
dri2_conf represents another config (which shouldn't be counted)
if it doesn't have the requested ID.
Reported-by: Liu Zhiquan
Signed-off-by: Eric Engestrom
---
v2: use original `count+1` comparison.
---
src/egl/drivers/dri2/platform_android.c | 3 ++-
src/egl/drivers/dri2/platform_drm.c
This fixes the long-standing problem with black transitions in The Wicher 2.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238
---
This patch depends on Marek's series:
https://patchwork.freedesktop.org/series/26089/
src/mesa/drivers/dri/co
On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote:
> Hi,
>
> This series updates pipe loaders so that flags such as drirc options
> can be passed to create_screen(). I have compile-tested everything
> except clover.
>
> The first pipe_screen flag is a drirc option to fix incorrect grass
> renderi
Passes texwrap GL_ARB_texture_rg piglit (with faked full texture rg support).
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c
b/src/gallium/drivers/
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +-
src/gallium/drivers/etnaviv/etnaviv_format.h | 1 +
src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++
src/gallium/drivers/etnaviv/etnaviv_texture.c | 8 +---
4 files changed, 10 insertions(+), 4 d
Passes all ext_texture_swizzle piglits.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 91 ++-
src/gallium/drivers/etnaviv/etnaviv_format.h | 4 ++
src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-
src/gallium/drivers/etnaviv/e
Based on a patch from Wladimir J. van der Laan and untested due
to lack of hardware. Binary blob emits those formats if GPU supports
HALTI1 (faked with ibvivhook).
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 7 ---
src/gallium/drivers/etnaviv/etnaviv_s
On Tue 20 Jun 2017, Jason Ekstrand wrote:
> On Wed, Jun 7, 2017 at 4:45 PM, Chad Versace <[1]chadvers...@chromium.org>
> wrote:
>
> On Tue 06 Jun 2017, Daniel Stone wrote:
> > Hi Chad,
> >
> > On 6 June 2017 at 21:36, Chad Versace <[2]chadvers...@chromium.org>
> wrote:
> >
On Wed, Jun 21, 2017 at 12:33 PM, Chad Versace
wrote:
> On Fri 16 Jun 2017, Jason Ekstrand wrote:
> > This commit replaces the complex and confusing set of disable flags with
> > two fairly straightforward fields which describe the intended auxiliary
> > surface usage and whether or not the miptr
Hi Marek
In patch 5 you say the words KILL and WQM and I automatically
think at Witcher 2.
This series with a the drirc option set for Witcher 2 fixes the
longstanding black transition bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238
It's quite probable that VP will not update
On Fri 16 Jun 2017, Jason Ekstrand wrote:
> This commit replaces the complex and confusing set of disable flags with
> two fairly straightforward fields which describe the intended auxiliary
> surface usage and whether or not the miptree supports fast clears.
> Right now, supports_fast_clear can be
Fixes dEQP-EGL.functional.image.render_multiple_contexts.
gles2_renderbuffer_stencil_stencil_buffer
CC: Mark Janes
CC: Jason Ekstrand
CC: Kenneth Graunke
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 19 ---
1 file changed, 16 insertions(+
On Fri 16 Jun 2017, Jason Ekstrand wrote:
> This commit replaces the complex and confusing set of disable flags with
> two fairly straightforward fields which describe the intended auxiliary
> surface usage and whether or not the miptree supports fast clears.
> Right now, supports_fast_clear can be
On Wed, Jun 21, 2017 at 11:19 AM, Anusha Srivatsa
wrote:
> Coffee Lake has a gen9 graphics following KBL.
> From 3D perspective, CFL is a clone of KBL/SKL features.
>
> v2: Change commit message, correct alignment
> v3: Update IDs.
>
> Cc: Benjamin Widawsky
> Cc: Anuj Phogat
> Cc: Rodrigo Vivi
Johnson Lin writes:
> Trigger the correct sampler options for it. Similar with YUYV
> ---
> src/intel/compiler/brw_compiler.h| 1 +
> src/intel/compiler/brw_nir.c | 1 +
> src/mesa/drivers/dri/i915/intel_screen.c | 9 ++---
> src/mesa/drivers/dri/i965/brw_wm.c | 7 +
Johnson Lin writes:
> UYVY is diffrent with YUYV in byte order.
> YUYV is already declared in dri_interface.h,
> this CL add the difinitions for UYVY.
> Drivers can add UYVY as supported format
This series looks good now. There are a few stylistic nits in the
comment formatting below, but with t
On Fri, Jun 16, 2017 at 03:41:28PM -0700, Jason Ekstrand wrote:
> This is mostly a direct port. The only bit of refactoring that was done
> was to make creating a planar miptree be an early return from the
> non-planar case. Alternatively, we could have three functions: two
> helpers and a main f
Ian Romanick writes:
> On 06/20/2017 01:33 PM, Kristian Høgsberg wrote:
>> On Mon, Jun 19, 2017 at 2:33 PM, Ian Romanick wrote:
>>> From: Ian Romanick
>>>
>>> These locks were added in 2f28a0dc, but I don't see anything in the
>>> intel_miptree_blit path that should make this necessary.
>>
>>
Wait, this is actively buggy! How did this ever work :( I guess we
don't split immediates too frequently, and I was testing it with
zero's or something.
Can you figure out the commit where I added this idiotic code and add
a Fixes: tag?
Reviewed-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.
On Wed, Jun 21, 2017 at 11:20 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Wed, Jun 21, 2017 at 11:16:39AM -0700, Jason Ekstrand wrote:
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101538
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101539
>
> I guess
On Wed, Jun 21, 2017 at 11:16:39AM -0700, Jason Ekstrand wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101538
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101539
I guess also:
https://bugs.freedesktop.org/show_bug.cgi?id=101535
Thanks for the quick fix!!
Reviewed-b
Coffee Lake has a gen9 graphics following KBL.
From 3D perspective, CFL is a clone of KBL/SKL features.
v2: Change commit message, correct alignment
v3: Update IDs.
Cc: Benjamin Widawsky
Cc: Anuj Phogat
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
include/pci_ids/i965_pci_ids.h |
Add the PCI IDs for U SKU IN CFL by following the spec.
v2: Update IDs
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
intel/intel_chipset.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index fed5a0d..891b50f
Add the PCI IDs for H SKU IN CFL by following the spec.
v2: Update IDs
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
intel/intel_chipset.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index aeb72ba..fed5a0d 10064
Add the PCI IDs for S SKU IN CFL by following the spec.
v2: Update IDs.
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
intel/intel_chipset.h | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 41fc0da..a
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101538
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101539
Cc: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i9
Use set_blend_entry_bits and set_depth_stencil_bits to fill most of the
color calc struct, and then manually update the rest.
v2:
- Always check for depth_irb (Ken)
- Always set Backface Stencil Ref (Ken)
- Always set alpha reference value (Ken)
Signed-off-by: Rafael Antognolli
---
src
The code doesn't get exactly a lot simpler but at least it is in a
single place, and we delete more than we add.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_clip_state.c| 147 ---
src/mesa/drive
The code doesn't get exactly a lot simpler but at least it is in a single
place, and we delete more than we add.
Another good point is that you get rid of struct brw_wm_unit_state
which was a third mechanism for encoding GEN state. We used to have
GENXML, manual packing and these bitfield structs.
This function only emits a particular case of 3DSTATE_GS. Instead, we can do
that inside genX(upload_gs_state), and later reuse part of that code for
emitting gen4-5 state.
There's the additional benefit of allowing us to remove gen6_gs_state.c, which
was only left because of this function.
Signe
From: Kenneth Graunke
Gen4-5 basically glue DEPTH_STENCIL_STATE, COLOR_CALC_STATE, and
BLEND_STATE together into a single COLOR_CALC_STATE structure.
By making a helper function, we'll be able to reuse it when filling
out Gen4-5 COLOR_CALC_STATE without replicating any actual logic.
We use gene
Add a helper function to reuse code that fills blend entry related
state, and make genX(upload_blend_state) use it. This function can later
be used by gen4-5 color calc state to set the blend related bits.
Signed-off-by: Rafael Antognolli
Reviewed-by: Kenneth Graunke
---
src/mesa/drivers/dri/i9
These were originally used to submit state changes using manual packing
of instructions, but we are now using genxml for that. So it should be
safe to just remove them.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_defines.h | 729 +---
1 file cha
gen6+ uses _mesa_base_format_has_channel() to check for the alpha
channel, while gen4-5 use ctx->DrawBuffer->Visual.alphaBits. By using
_mesa_base_format_has_channel() here we keep the same behavior accross
all gen.
While initially both ways of checking the alpha channel seemed correct
to me, this
Since we always call brw_batch_emit anyways, we can hopefully make things
simpler by calling it only once, and then branching inside its body. This
can be helpful when bringing the gen4-5 code into this function.
Additionally, check for GEN_GEN == 6 instead of < 7 in cases that won't apply
to lowe
Merge the code with gen6+ 3DSTATE_GS, and delete brw_gs_state.c,
together with brw_gs_unit_state.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_gs_state.c | 101 --
src/mesa/drivers/dri/i965/
It's a very simple conversion, and it allows us to delete brw_cc.c.
Signed-off-by: Rafael Antognolli
Reviewed-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_cc.c| 62 ---
src/mesa/drivers/dri/i965/g
1 - 100 of 156 matches
Mail list logo
