I never liked the gpu_memcpy name anyway because I knew something like this
would come up. I left you one trivial comment on patch 1. Other than
that, the series is
Reviewied-by: Jason Ekstrand <ja...@jlekstrand.net>
Given that you're changing core blorp, please make sure you run this
through Jenkins on GL. :-)
--Jason
On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery <nanleych...@gmail.com> wrote:
> A GPU memcpy function could alternatively be implemented using MI_*
> commands. Provide more detail into how this one operates in case another
> memcpy function is created.
>
> v2:
> - Update the commit message.
> v3:
> - Use 'memcpy' instead of 'cpy' (Jason Ekstrand)
> - Shorten 'streamout' to 'so'
>
> Suggested-by: Jason Ekstrand <ja...@jlekstrand.net>
> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com>
> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> (v2)
> ---
> src/intel/vulkan/anv_genX.h | 8 ++++----
> src/intel/vulkan/genX_cmd_buffer.c | 6 +++---
> src/intel/vulkan/genX_gpu_memcpy.c | 8 ++++----
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/vulkan/anv_genX.h
> index 67147b0e92..8da5e075dc 100644
> --- a/src/intel/vulkan/anv_genX.h
> +++ b/src/intel/vulkan/anv_genX.h
> @@ -64,10 +64,10 @@ genX(emit_urb_setup)(struct anv_device *device, struct
> anv_batch *batch,
> VkShaderStageFlags active_stages,
> const unsigned entry_size[4]);
>
> -void genX(cmd_buffer_gpu_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> - struct anv_bo *dst, uint32_t dst_offset,
> - struct anv_bo *src, uint32_t src_offset,
> - uint32_t size);
> +void genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> + struct anv_bo *dst, uint32_t dst_offset,
> + struct anv_bo *src, uint32_t src_offset,
> + uint32_t size);
>
> void genX(blorp_exec)(struct blorp_batch *batch,
> const struct blorp_params *params);
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 6a3e525eb3..53c58ca5b3 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -710,9 +710,9 @@ genX(CmdExecuteCommands)(
> struct anv_state dst_state = secondary->state.render_pass_
> states;
> assert(src_state.alloc_size == dst_state.alloc_size);
>
> - genX(cmd_buffer_gpu_memcpy)(primary, ss_bo, dst_state.offset,
> - ss_bo, src_state.offset,
> - src_state.alloc_size);
> + genX(cmd_buffer_so_memcpy)(primary, ss_bo, dst_state.offset,
> + ss_bo, src_state.offset,
> + src_state.alloc_size);
> }
>
> anv_cmd_buffer_add_secondary(primary, secondary);
> diff --git a/src/intel/vulkan/genX_gpu_memcpy.c
> b/src/intel/vulkan/genX_gpu_memcpy.c
> index 3cbc7235cf..5ef35e6283 100644
> --- a/src/intel/vulkan/genX_gpu_memcpy.c
> +++ b/src/intel/vulkan/genX_gpu_memcpy.c
> @@ -52,10 +52,10 @@ gcd_pow2_u64(uint64_t a, uint64_t b)
> }
>
> void
> -genX(cmd_buffer_gpu_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> - struct anv_bo *dst, uint32_t dst_offset,
> - struct anv_bo *src, uint32_t src_offset,
> - uint32_t size)
> +genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> + struct anv_bo *dst, uint32_t dst_offset,
> + struct anv_bo *src, uint32_t src_offset,
> + uint32_t size)
> {
> if (size == 0)
> return;
> --
> 2.13.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
