On 16.05.2017 01:14, Marek Olšák wrote:
Do you have a branch somewhere so that I can see the last patch?
Here you go: https://cgit.freedesktop.org/~nh/mesa/log/?h=si_shader_mem
Cheers,
Nicolai
Thanks,
Marek
On Mon, May 15, 2017 at 11:43 PM, Nicolai Hähnle wrote:
Hi all,
This series is
On 05/16/2017 02:04 AM, Chad Versace wrote:
Fixes regressions in Android CtsVerifier.apk on Intel Chrome OS devices
due to incorrect error handling in eglMakeCurrent. See below on how to
confirm the regression is fixed.
This partially reverts
commit 23c86c74cc450a23848b85cfe914376caede1c
On 15/05/17 20:55, Samuel Pitoiset wrote:
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/link_uniforms.cpp | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/compiler/glsl/link_uniforms.cpp
b/src/compiler/glsl/link_uniforms.cpp
index c5db1d62cb..b
On 16/05/17 00:12, Nicolai Hähnle wrote:
On 12.05.2017 06:12, Timothy Arceri wrote:
This reduces duplication between the dsa and non-dsa function
and will also be used in the following commit to add
KHR_no_error support.
---
src/mesa/main/teximage.c | 82
++---
On Mon, Apr 24, 2017 at 4:50 PM, Matt Turner wrote:
> On Thu, Apr 6, 2017 at 12:49 PM, Thomas Helland
> wrote:
>> The conditional discard pass follows the same pattern, so merge the
>> two, and avoid running the visitor two times.
>> ---
>> src/compiler/Makefile.sources | 1 -
>>
V2: call check_layered_texture_target() even for no_error
---
src/mesa/main/fbobject.c | 141 ++-
1 file changed, 41 insertions(+), 100 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 8e25dfa..adebf60 100644
--- a/src
On 16/05/17 10:47, Kenneth Graunke wrote:
On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote:
On 16/05/17 08:13, Ian Romanick wrote:
On 04/23/2017 10:28 PM, Timothy Arceri wrote:
diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
b/src/mapi/glapi/gen/APPLE_vertex_array_
On 05/15/2017 02:27 AM, Nicolai Hähnle wrote:
> Hi all,
>
> This series aims to simplify how we handle unnamed struct types and fix some
> bugs on the way. Some of the patches should be uncontroversial, and all of
> them align with my understanding of the GLSL spec, but the spec isn't
> exactly ex
Ping
On Mon, May 8, 2017 at 3:29 PM, Gurchetan Singh wrote:
> Chrome is going to use EGLSync a lot to synchronize between EGL/KMS (along
> with the flush image external extension). VM's are used for testing, so
> adding this path would be helpful.
>
> On Fri, May 5, 2017 at 5:54 PM, Emil Veliko
On 05/15/2017 05:51 PM, Timothy Arceri wrote:
> On 16/05/17 10:47, Kenneth Graunke wrote:
>> On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote:
>>> On 16/05/17 08:13, Ian Romanick wrote:
On 04/23/2017 10:28 PM, Timothy Arceri wrote:
> diff --git a/src/mapi/glapi/gen/APPLE_ve
On 05/15/2017 04:06 PM, Timothy Arceri wrote:
> On 16/05/17 08:13, Ian Romanick wrote:
>> On 04/23/2017 10:28 PM, Timothy Arceri wrote:
>>
>>> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
>>> deleted file mode 100644
>>> index
On 16/05/17 10:47, Kenneth Graunke wrote:
On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote:
On 16/05/17 08:13, Ian Romanick wrote:
On 04/23/2017 10:28 PM, Timothy Arceri wrote:
diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
b/src/mapi/glapi/gen/APPLE_vertex_array_ob
On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote:
> On 16/05/17 08:13, Ian Romanick wrote:
> > On 04/23/2017 10:28 PM, Timothy Arceri wrote:
> >
> >> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
> >> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
> >> deleted file
On 16/05/17 00:06, Nicolai Hähnle wrote:
On 11.05.2017 14:29, Timothy Arceri wrote:
---
src/mesa/main/fbobject.c | 138
+--
1 file changed, 38 insertions(+), 100 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 8e
On 16/05/17 09:24, Timothy Arceri wrote:
On 15/05/17 19:27, Nicolai Hähnle wrote:
From: Nicolai Hähnle
This changes the logic during the conversion of the declaration list
struct S {
...
} v;
from AST to IR, but should not change the end result.
When assigning the type of v,
On 15/05/17 19:27, Nicolai Hähnle wrote:
From: Nicolai Hähnle
Unnamed struct types are now equal across stages based on the fields they
contain, so this additional check has become unnecessary.
I was a little confused by this change. Maybe change the above sentence to:
"Unnamed struct types
On 16.05.2017 01:24, Timothy Arceri wrote:
On 15/05/17 19:27, Nicolai Hähnle wrote:
From: Nicolai Hähnle
This changes the logic during the conversion of the declaration list
struct S {
...
} v;
from AST to IR, but should not change the end result.
When assigning the type of v
On 16.05.2017 01:32, Timothy Arceri wrote:
On 15/05/17 19:27, Nicolai Hähnle wrote:
From: Nicolai Hähnle
By splitting glsl_type::mutex into two, we can avoid dropping the hash
mutex while creating the new type instance (e.g. struct/record,
interface).
This fixes a time-of-check/time-of-use ra
On 15/05/17 19:27, Nicolai Hähnle wrote:
From: Nicolai Hähnle
By splitting glsl_type::mutex into two, we can avoid dropping the hash
mutex while creating the new type instance (e.g. struct/record,
interface).
This fixes a time-of-check/time-of-use race where two threads would
simultaneously at
On 16 May 2017 at 08:21, Thomas Helland wrote:
> 2017-05-15 21:08 GMT+00:00 Marek Olšák :
>> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland
>> wrote:
>>> Would this be a win for a game limited by the winsys/buffer handling?
>>> I played some Hitman the other day, and noticed my gpu-utilization
2017-05-16 1:05 GMT+02:00 Marek Olšák :
> On Tue, May 16, 2017 at 12:21 AM, Thomas Helland
> wrote:
>> 2017-05-15 21:08 GMT+00:00 Marek Olšák :
>>> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland
>>> wrote:
Would this be a win for a game limited by the winsys/buffer handling?
I played
On 15/05/17 19:27, Nicolai Hähnle wrote:
From: Nicolai Hähnle
This changes the logic during the conversion of the declaration list
struct S {
...
} v;
from AST to IR, but should not change the end result.
When assigning the type of v, instead of looking `S' up in the symbol
ta
Do you have a branch somewhere so that I can see the last patch?
Thanks,
Marek
On Mon, May 15, 2017 at 11:43 PM, Nicolai Hähnle wrote:
> Hi all,
>
> This series is only moving code around. si_shader.c has become pretty
> unwieldy over time, and handling of memory/texture opcodes is a big chunk
>
On Tue, May 16, 2017 at 12:21 AM, Thomas Helland
wrote:
> 2017-05-15 21:08 GMT+00:00 Marek Olšák :
>> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland
>> wrote:
>>> Would this be a win for a game limited by the winsys/buffer handling?
>>> I played some Hitman the other day, and noticed my gpu-uti
On 16/05/17 08:13, Ian Romanick wrote:
On 04/23/2017 10:28 PM, Timothy Arceri wrote:
diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
deleted file mode 100644
index 7312f9b..000
--- a/src/mapi/glapi/gen/APPLE_vertex_array_obje
Fixes regressions in Android CtsVerifier.apk on Intel Chrome OS devices
due to incorrect error handling in eglMakeCurrent. See below on how to
confirm the regression is fixed.
This partially reverts
commit 23c86c74cc450a23848b85cfe914376caede1cdf
Author: Chad Versace
Subject: egl: E
Ping.
On Mon, May 8, 2017 at 3:25 PM, Gurchetan Singh wrote:
> Use the same fence implementation for drisw.c as dri2.c by making
> dri2FenceExtension an external variable. Since the fence implementation
> is not dri2.c specific, put it in a separate file. This is desirable for
> synchronization
2017-05-16 0:24 GMT+02:00 Ian Romanick :
> On 04/06/2017 12:49 PM, Thomas Helland wrote:
>> The pass to optimize two swizzles in a row can be interpreted as
>> a noop swizzle optimization. Merge the two passes, and avoid having
>> the extra pass that runs a visitor pattern.
>> ---
>> src/compiler/
On 2017-05-15 06:04 PM, Ian Romanick wrote:
On 05/12/2017 06:39 AM, John Brooks wrote:
Since release, Dying Light and Dead Island Definitive Edition have been broken
on Mesa, producing at best only a black screen after loading. I found that the
root of the problem is that their vertex shaders re
On 04/06/2017 12:49 PM, Thomas Helland wrote:
> The pass to optimize two swizzles in a row can be interpreted as
> a noop swizzle optimization. Merge the two passes, and avoid having
> the extra pass that runs a visitor pattern.
> ---
> src/compiler/Makefile.sources | 1 -
> src/compi
2017-05-15 21:08 GMT+00:00 Marek Olšák :
> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland
> wrote:
>> Would this be a win for a game limited by the winsys/buffer handling?
>> I played some Hitman the other day, and noticed my gpu-utilization
>> was hovering at about 80%. Some profiling later and
Reviewed-by: Jason Ekstrand
On Mon, May 15, 2017 at 3:11 PM, Anuj Phogat wrote:
> V2: Leave a trailing comma for cnl entry in the table. (Jason)
>
> Signed-off-by: Anuj Phogat
> Cc: Jason Ekstrand
> ---
> src/intel/tools/aubinator.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletion
On 04/23/2017 10:28 PM, Timothy Arceri wrote:
> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
> deleted file mode 100644
> index 7312f9b..000
> --- a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml
> +++ /dev/null
> @@ -1,2
V2: Leave a trailing comma for cnl entry in the table. (Jason)
Signed-off-by: Anuj Phogat
Cc: Jason Ekstrand
---
src/intel/tools/aubinator.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 53b2a27..6e4bb
V2: Remove isl_gen10.c and isl_gen10.h
Signed-off-by: Anuj Phogat
Cc: Jason Ekstrand
---
src/intel/Makefile.isl.am | 4
src/intel/Makefile.sources | 10 --
src/intel/Makefile.vulkan.am | 7 ++-
src/mesa/drivers/dri/i965/Makefile.
Maybe tweak the commit message:
intel/genxml: Update genx_bits for gen10+
This commit adds a gen10 case to the switch statement and drops some
unneeded code for handling gen numbers which doesn't work on gen10 and
above.
On Mon, May 15, 2017 at 3:04 PM, Jason Ekstrand
wrote:
> Reviewed-by: Jas
On 05/12/2017 06:39 AM, John Brooks wrote:
> Since release, Dying Light and Dead Island Definitive Edition have been broken
> on Mesa, producing at best only a black screen after loading. I found that the
> root of the problem is that their vertex shaders redeclare the GLSL builtin
> gl_VertexID, w
Reviewed-by: Jason Ekstrand
On Mon, May 15, 2017 at 3:02 PM, Anuj Phogat wrote:
> V2: Drop "z = float(z)" and the "z *= 10" lines
>
> Signed-off-by: Anuj Phogat
> Reviewed-by: Jason Ekstrand
> ---
> src/intel/genxml/gen_bits_header.py | 6 ++
> 1 file changed, 2 insertions(+), 4 deletion
V2: Drop "z = float(z)" and the "z *= 10" lines
Signed-off-by: Anuj Phogat
Reviewed-by: Jason Ekstrand
---
src/intel/genxml/gen_bits_header.py | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/intel/genxml/gen_bits_header.py
b/src/intel/genxml/gen_bits_header.py
ind
From: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader.c | 26 +++
src/gallium/drivers/radeonsi/si_shader_internal.h | 2 ++
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/rad
From: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader.c | 15 +--
src/gallium/drivers/radeonsi/si_shader_internal.h | 7 +++
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeon
From: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader.c | 32 +++
src/gallium/drivers/radeonsi/si_shader_internal.h | 4 +++
2 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/ra
Hi all,
This series is only moving code around. si_shader.c has become pretty
unwieldy over time, and handling of memory/texture opcodes is a big chunk
that can be nicely extracted elsewhere without a lot of dependencies. It
is analogous to the ALU ops that are already separate.
Even after this r
On Mon, May 15, 2017 at 10:00 PM, Thomas Helland
wrote:
> Would this be a win for a game limited by the winsys/buffer handling?
> I played some Hitman the other day, and noticed my gpu-utilization
> was hovering at about 80%. Some profiling later and I concluded
> that one thread was pegged at 100
On Mon, May 15, 2017 at 4:06 PM, Rob Clark wrote:
> Maybe there is a better way to do this. But by the time we get to
> assigning uniform locs, we want the atomic_uint's to all be gone,
> otherwise we assert in st_glsl_attrib_type_size().
>
> Signed-off-by: Rob Clark
> ---
> Are there any other
All combined depth stencil buffers (even those with just stencil)
require a 4x4 alignment on Sandy Bridge. The only depth/stencil buffer
type that requires 4x2 is separate stencil.
---
src/intel/isl/isl_gen6.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/
Hi Lionel,
On 12 May 2017 at 10:52, Lionel Landwerlin
wrote:
> On 05/05/17 17:47, Daniel Stone wrote:
>> @@ -535,7 +555,7 @@ wsi_wl_swapchain_acquire_next_image(struct
>> wsi_swapchain *wsi_chain,
>> {
>> struct wsi_wl_swapchain *chain = (struct wsi_wl_swapchain
>> *)wsi_chain;
>> - in
On Sat 13 May 2017, Jason Ekstrand wrote:
> On Fri, May 12, 2017 at 3:35 PM, Chad Versace
> wrote:
>
> > On Thu 11 May 2017, Jason Ekstrand wrote:
> > > On Thu, May 11, 2017 at 9:08 PM, Chad Versace
> > > wrote:
> > >
> > > > On Thu 11 May 2017, Jason Ekstrand wrote:
> > > > > On Thu, May 11, 20
Reviewed-by: Bruce Cherniak
> On May 11, 2017, at 12:59 PM, Tim Rowley wrote:
>
> This change fixes the build break with llvm-svn.
>
> r301981 of llvm-svn made add/remove of function attributes
> use AttrBuilder instead of AttributeList.
>
> Tested with llvm-3.9, llvm-4.0, llvm-svn.
> ---
>
Maybe there is a better way to do this. But by the time we get to
assigning uniform locs, we want the atomic_uint's to all be gone,
otherwise we assert in st_glsl_attrib_type_size().
Signed-off-by: Rob Clark
---
Are there any other cases? If atomic_uint is an opaque type, I'm not
sure how it co
Fixes some piglits like arb_shader_atomic_counters-active-counters
Signed-off-by: Rob Clark
---
src/compiler/nir/nir_lower_atomics_to_ssbo.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/nir/nir_lower_atomics_to_ssbo.c
b/src/compiler/nir/nir_lower_atomics_to_ssbo.c
index
Would this be a win for a game limited by the winsys/buffer handling?
I played some Hitman the other day, and noticed my gpu-utilization
was hovering at about 80%. Some profiling later and I concluded
that one thread was pegged at 100% doing buffer handling work.
amdgpu_cs_add_buffer, amdgpu_lookup
On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote:
> ---
> src/intel/Makefile.tools.am | 6 +-
> src/intel/tools/aubinator_error_decode.c | 178
> ++-
> 2 files changed, 180 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/Makefile.tools.am b/sr
On Fri, May 5, 2017 at 12:44 AM, Pohjolainen, Topi
wrote:
> On Mon, May 01, 2017 at 01:54:55PM -0700, Matt Turner wrote:
>> ---
>> src/intel/Makefile.tools.am | 6 +-
>> src/intel/tools/aubinator_error_decode.c | 178
>> ++-
>> 2 files changed, 180 inse
Rob Clark writes:
> Looks like somewhere along the way nir_validate got more thorough about
> checking src/dst sizes.
>
> Rob Clark (3):
> ttn: fix txs dest size
> ttn: fix txd src sizes
> ttn: fix dest size for some texture instructions
Reviewed-by: Eric Anholt
signature.asc
Descriptio
With this patch I applied, I still see this bit used in several
places, including the i915 driver. Did you test that?
rc/compiler/shader_enums.h:#define VARYING_BIT_FOGC
BITFIELD64_BIT(VARYING_SLOT_FOGC)
src/mesa/swrast/s_context.c:VARYING_BIT_FOGC |
VARYING_BITS_TEX_ANY;
sr
2017-05-15 20:28 GMT+02:00 Ian Romanick :
> With this patch I applied, I still see this bit used in several
> places, including the i915 driver. Did you test that?
>
> rc/compiler/shader_enums.h:#define VARYING_BIT_FOGC
> BITFIELD64_BIT(VARYING_SLOT_FOGC)
> src/mesa/swrast/s_context.c:
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index 3b8e321..bdcf218 100644
--- a/src/gallium/auxiliary/nir/tgsi
Some, like lod, don't return 4 components.
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index bdcf218..d4914ac 100644
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index 1d68c22..3b8e321 100644
--- a/src/gallium/auxiliary/nir/tgsi_to_nir.c
Looks like somewhere along the way nir_validate got more thorough about
checking src/dst sizes.
Rob Clark (3):
ttn: fix txs dest size
ttn: fix txd src sizes
ttn: fix dest size for some texture instructions
src/gallium/auxiliary/nir/tgsi_to_nir.c | 17 +++--
1 file changed, 11 i
On Sat, May 13, 2017 at 11:59 AM, Francisco Jerez
wrote:
> Anuj Phogat writes:
>
> > Cherryview and Broxton are always gt1. So, remove the redundant checks.
> >
> > Signed-off-by: Anuj Phogat
> > ---
> > src/intel/common/gen_l3_config.c | 10 --
> > 1 file changed, 4 insertions(+), 6 d
On 15 May 2017 at 17:50, Rob Herring wrote:
> On Mon, May 15, 2017 at 11:23 AM, Emil Velikov
> wrote:
>> On 11 May 2017 at 19:57, Emil Velikov wrote:
>>> From: Emil Velikov
>>>
>>> Don't fetch/manage our set of extensions apart from __DRI_CORE,
>>> __DRI_DRI2 and __DRI_SWRAST. We require these
On Sat, May 13, 2017 at 9:47 AM, Jason Ekstrand
wrote:
> Most of these still point to gen9 functions even though we have gen10
> versions now. We should point to the gen10 versions. Yes, I know some of
> that is in a later patch but I see no reason why we can't roll those into
> this patch and
On Sat, May 13, 2017 at 9:37 AM, Jason Ekstrand
wrote:
> If everything truely is the same here, I see no reason why we should add a
> gen10 version. I know this appears to contradict what I said before but
> the difference is that this file is handwritten and not just a recompile of
> an already
On Sat, May 13, 2017 at 12:18 PM, Kenneth Graunke
wrote:
> On Friday, May 12, 2017 4:38:25 PM PDT Anuj Phogat wrote:
> > v1: By Ben Widawsky
> > v2: Add the restriction for GS, HS and DS and make sure
> > the allocated sizes are not multiple of 3.
> >
> > Signed-off-by: Anuj Phogat
> > Cc:
On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand
wrote:
> On May 12, 2017 4:41:36 PM Anuj Phogat wrote:
>
> Signed-off-by: Anuj Phogat
>> ---
>> src/intel/compiler/brw_compiler.h | 2 +-
>> src/mesa/drivers/dri/i965/brw_program.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletio
On Mon, May 15, 2017 at 11:23 AM, Emil Velikov wrote:
> On 11 May 2017 at 19:57, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Don't fetch/manage our set of extensions apart from __DRI_CORE,
>> __DRI_DRI2 and __DRI_SWRAST. We require these to setup a screen and
>> context (in case of bo map/un
On 11 May 2017 at 19:57, Emil Velikov wrote:
> From: Emil Velikov
>
> Don't fetch/manage our set of extensions apart from __DRI_CORE,
> __DRI_DRI2 and __DRI_SWRAST. We require these to setup a screen and
> context (in case of bo map/unmap).
>
> The rest are fetched and kept in sync with the rest
From: Tapani Pälli
With later commits we'll split and reuse the destroy side of the
function for the initialize_foo error path.
In such cases, driver_configs may be NULL leading to a crash.
Signed-off-by: Tapani Pälli
[Emil Velikov: reword commit message]
Signed-off-by: Emil Velikov
---
src/
On 12 May 2017 at 13:19, Emil Velikov wrote:
> On 12 May 2017 at 09:20, Tapani Pälli wrote:
>> this patch causes a crash with egl-create-surface Piglit test
>>
> Seems like we have a bunch of missing NULL checks throughout.
> Please ignore the patch dri2_display_destroy patches for the times bein
On Sat, May 13, 2017 at 9:39 AM, Jason Ekstrand wrote:
> On May 12, 2017 4:41:22 PM Anuj Phogat wrote:
>
>> Signed-off-by: Anuj Phogat
>> ---
>> src/intel/tools/aubinator.c | 8 +---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/intel/tools/aubinator.c b/src/inte
On Sat, May 13, 2017 at 9:31 AM, Jason Ekstrand wrote:
> On May 12, 2017 4:41:26 PM Anuj Phogat wrote:
>
>> Signed-off-by: Anuj Phogat
>> Reviewed-by: Jason Ekstrand
>> ---
>> src/intel/genxml/gen_bits_header.py | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/
On Mon, May 15, 2017 at 8:12 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Mon, May 15, 2017 at 07:55:46AM -0700, Jason Ekstrand wrote:
> > We've discovered in the Vulkan driver that simply doing the end-of-pipe
> > sync afterwards is insufficient. The specific requirement state
On Monday, 2017-05-15 16:14:17 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> With the final place that modifies the vtbl removed as of last commit we
> can annotate the symbols accordingly.
>
> Signed-off-by: Emil Velikov
Nice! Series is:
Reviewed-by: Eric Engestrom
> ---
> src/egl/d
Reviewed-by: Nicolai Hähnle
On 15.05.2017 17:33, Marek Olšák wrote:
From: Marek Olšák
---
src/amd/common/r600d_common.h | 11 +++
src/gallium/drivers/radeon/r600_query.c | 21 +++--
2 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/src/amd/comm
On 15.05.2017 16:57, Erik Faye-Lund wrote:
On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote:
Hi all,
This series aims to simplify how we handle unnamed struct types and fix some
bugs on the way. Some of the patches should be uncontroversial, and all of
them align with my understanding of
From: Marek Olšák
---
src/amd/common/r600d_common.h | 11 +++
src/gallium/drivers/radeon/r600_query.c | 21 +++--
2 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/src/amd/common/r600d_common.h b/src/amd/common/r600d_common.h
index 3fdfb7c..3374475
Analogous to previous commit.
Cc: Chad Versace
Cc: Gurchetan Singh
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_surfaceless.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_surfaceless.c
b/src/egl/drivers/dri2/platfor
From: Emil Velikov
Rather than misleadingly depending on DRI2 for the WL_DRM vs WL_SHM
formats, use the wl_drm and wl_shm interface respectively.
Fixes: a1727aa75ed ("egl/wayland: Don't use DRM format codes for SHM")
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 3 +
From: Emil Velikov
Strictly speaking __DRI_DRI2 implies __DRI2_FLUSH. Although since we're
using the latter in the callback, we want to use the correct guard.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
From: Emil Velikov
Analogous to previous commit.
Signed-off-by: Emil Velikov
---
If people prefer I can split the whitespace/indent changes in
this/previous path from the rest. Don't feel too strongly either way.
src/egl/drivers/dri2/platform_x11.c | 22 +-
1 file changed
From: Emil Velikov
Analogous to earlier commits - image_driver and image_loader are meant
to be used hand in hand.
v2: Rebase
Cc: Derek Foreman
Signed-off-by: Emil Velikov
---
Derek, can you try the v2 of the series with alongside git revert
534ea2b5ba0? A very quick test here showed no issue
From: Emil Velikov
The current __DRI_DRI2 imples __DRI2_FLUSH. At the same time, one can
use __DRI_IMAGE_DRIVER alongside the latter, so the current check is
confusing at best.
Check for what we use.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_drm.c | 41 +++-
From: Emil Velikov
They are meant to be used together. Otherwise we'll need workarounds
like egl/wayland. Namely register an image_loader_extension even thought
we should be using only DRI2.
v2: Add missing the bracket to fix the build (Tapani).
Signed-off-by: Emil Velikov
Reviewed-by: Tapani
From: Emil Velikov
With previous commit we'll error out should one be using the extension
when it's not available. Thus we no longer need to modify the vtbl.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
di
From: Emil Velikov
With the final place that modifies the vtbl removed as of last commit we
can annotate the symbols accordingly.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_android.c | 2 +-
src/egl/drivers/dri2/platform_drm.c | 2 +-
src/egl/drivers/dri2/platfor
From: Emil Velikov
Currently f one does the silly thing by probing the entry point w/o
checking the extension they will attempt to use the extension even
though it cannot work.
That is due our of of an assert which gets removed in release builds.
Simply error out if the extension is not enabled.
On Mon, May 15, 2017 at 07:55:46AM -0700, Jason Ekstrand wrote:
> We've discovered in the Vulkan driver that simply doing the end-of-pipe
> sync afterwards is insufficient. The specific requirement stated in the
> PRM is that you have to do one every time you transition between the
> tree modes of
On 12 May 2017 at 07:32, Tapani Pälli wrote:
> 1ce5853 broken compilation since LOG_ERROR is not defined and also
> macro expansion won't work as planned (expands to 'ANDROID_egl2alog[level]')
>
> v2: append 'ANDROID' to egl2alog table and use LOG_PRI
> (suggested by Chih-Wei Huang)
>
> Fixes:
On Monday, 2017-05-15 15:41:44 +0100, Emil Velikov wrote:
> On 8 May 2017 at 01:35, Eric Engestrom wrote:
> > I don't seem to have received patches 12-27 of this series though?
> >
> Git send-email tripped on a malformed email in 12. The rest of the
> series is was sent shortly after the first 11
---
src/intel/vulkan/anv_device.c | 4
src/intel/vulkan/anv_entrypoints_gen.py | 1 +
src/intel/vulkan/anv_wsi.c | 27 +++
3 files changed, 32 insertions(+)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 35e40
---
src/vulkan/wsi/wsi_common.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h
index 5e77518..8aee9c7 100644
--- a/src/vulkan/wsi/wsi_common.h
+++ b/src/vulkan/wsi/wsi_common.h
@@ -87,10 +87,18 @@ struct wsi_interface {
---
src/vulkan/wsi/wsi_common_wayland.c | 28 +---
src/vulkan/wsi/wsi_common_x11.c | 23 ---
2 files changed, 21 insertions(+), 30 deletions(-)
diff --git a/src/vulkan/wsi/wsi_common_wayland.c
b/src/vulkan/wsi/wsi_common_wayland.c
index 5613283..5c
---
src/vulkan/wsi/wsi_common_x11.c | 32
1 file changed, 32 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index 3580194..5be56f1 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -
---
src/vulkan/wsi/wsi_common_wayland.c | 38 +
1 file changed, 38 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_wayland.c
b/src/vulkan/wsi/wsi_common_wayland.c
index 5c72c8a..cb6dd79 100644
--- a/src/vulkan/wsi/wsi_common_wayland.c
+++ b/src/vulkan/wsi
---
include/vulkan/vulkan.h| 111 --
src/vulkan/registry/vk.xml | 167 +
2 files changed, 262 insertions(+), 16 deletions(-)
diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h
index ef0c246..51e5e9e 100644
---
On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote:
> Hi all,
>
> This series aims to simplify how we handle unnamed struct types and fix some
> bugs on the way. Some of the patches should be uncontroversial, and all of
> them align with my understanding of the GLSL spec, but the spec isn't
>
We've discovered in the Vulkan driver that simply doing the end-of-pipe
sync afterwards is insufficient. The specific requirement stated in the
PRM is that you have to do one every time you transition between the
tree modes of "clear", "render", and "resolve". This is GL, so we could
track it but
On 5 May 2017 at 12:44, Christian König wrote:
> Am 04.05.2017 um 18:33 schrieb Emil Velikov:
>>
>> From: Emil Velikov
>>
>> ... and make it const, since we shouldn't tinker with it.
>>
>> Signed-off-by: Emil Velikov
>> Reviewed-by: Nayan Deshmukh
>
>
> Patches #13 - #17 are Reviewed-by: Christ
1 - 100 of 181 matches
Mail list logo
