Re: [Mesa-dev] [PATCH 05/26] i965: Set fast clear state only once in render cycle

2016-10-28 Thread Jason Ekstrand
On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Blorp operations used to set it before rendering and again just > after. > I think this patche is definitely an improvement. 2-5 are Reviewed-by: Jason Ekstrand However, at some point I think we want to

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-28 Thread Kenneth Graunke
On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote: > On 10/28/2016 05:15 AM, Timothy Arceri wrote: > > On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: > >> On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: > >>> On Thu, 2016-10-27 at 12:37 +1100, Timothy Arce

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On Friday, 28 October 2016, Gurchetan Singh wrote: > I'm confused what the desired cleanup is. Do you want > > 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac > or > 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles > to be removed. In the cases where this breaks

Re: [Mesa-dev] [PATCH 01/26] i965/meta: Split conversion of color and setting it

2016-10-28 Thread Jason Ekstrand
On Wed, Oct 19, 2016 at 2:29 PM, Ben Widawsky wrote: > On 16-10-11 22:26:33, Topi Pohjolainen wrote: > >> And fix a mangled comment while at it. >> >> Signed-off-by: Topi Pohjolainen >> CC: Ben Widawsky >> CC: Jason Ekstrand >> --- >> src/mesa/drivers/dri/i965/brw_blorp.c | 7 +++- >> src/

Re: [Mesa-dev] [RFC 03/12] egl: add EGL_ANDROID_native_fence_sync

2016-10-28 Thread Rafael Antognolli
Hi Chad and Rob, I took the liberty to run the piglit tests that I submitted against this series, and it pointed out to a couple errors. Please disregard this if you already have a newer version of these patches laying around with those things fixed. On Mon, Oct 10, 2016 at 10:43:50AM -0700, Chad

Re: [Mesa-dev] [PATCH] i965/fs/generator: Don't use the address immediate for MOV_INDIRECT

2016-10-28 Thread Jason Ekstrand
On Fri, Oct 28, 2016 at 4:07 PM, Matt Turner wrote: > On Fri, Oct 28, 2016 at 2:53 PM, Jason Ekstrand > wrote: > > The address immediate field is only 9 bits and, since the value is in > > bytes, the highest GRF we can point to with it is g15. This makes it > > pretty close to useless for MOV_I

[Mesa-dev] [PATCH 4/7] glsl/lower_if: conditionally lower if-branches based on their size

2016-10-28 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/lower_if_to_cond_assign.cpp | 55 --- 2 files changed, 50 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH 7/7] radeonsi: set IF_THRESHOLD to 3

2016-10-28 Thread Marek Olšák
From: Marek Olšák Piglit regressions (radeonsi or LLVM bugs, they pass on softpipe): - glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr - glsl-1.10/execution/variable-indexing/vs-output-array-vec4-index-wr - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-col-row-

[Mesa-dev] [PATCH 1/7] glsl/lower_if: move and rename found_control_flow

2016-10-28 Thread Marek Olšák
From: Marek Olšák I'll want to update more variables in check_control_flow, so using the visitor is convenient. --- src/compiler/glsl/lower_if_to_cond_assign.cpp | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/lower_if_to_cond_assign.cpp

[Mesa-dev] [PATCH 3/7] glsl/lower_if: don't lower branches touching tess control outputs

2016-10-28 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_if_to_cond_assign.cpp | 23 --- src/compiler/glsl/test_optpass.cpp| 2 +- src/mesa/drivers/dri/i965/brw_link.cpp| 2 +- src/mesa/program/ir_to_mesa.cpp

[Mesa-dev] [PATCH 6/7] glsl_to_tgsi: lower small branches based on the CAP

2016-10-28 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 90e9e88..9e97b30 100644 --- a/src/mesa/state_tracker/st_glsl_to_

Re: [Mesa-dev] [RFC 00/11] i965: Remove our dependence on nir_shader::info

2016-10-28 Thread Jason Ekstrand
On Fri, Oct 28, 2016 at 4:01 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Fri, 2016-10-28 at 13:46 -0700, Jason Ekstrand wrote: > > Timothy's attempts to extract shader_info from nir_shader got me > > thinking, > > "What if shader_info were simply a byproduct of compilation?" Hi

[Mesa-dev] [PATCH 5/7] gallium: add PIPE_SHADER_CAP_LOWER_IF_THRESHOLD

2016-10-28 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/nouveau/nv30/nv30_screen.c

[Mesa-dev] [PATCH 0/7] GLSL: Lowering small conditional branches

2016-10-28 Thread Marek Olšák
Hi, this series enables lowering small branches for radeonsi, but other drivers can enable it too. The GLSL compiler computes a cost per branch and then either lowers the branch if the cost is low enough, or keeps it. It will take some time before LLVM learns to do this too and that seems to be m

[Mesa-dev] [PATCH 2/7] glsl/lower_if: check more node types in check_control_flow -> check_ir_node

2016-10-28 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/lower_if_to_cond_assign.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/lower_if_to_cond_assign.cpp b/src/compiler/glsl/lower_if_to_cond_assign.cpp index 2875e79..01a7335 100644 --- a/src/compiler/glsl/lo

Re: [Mesa-dev] [PATCH] i965/fs/generator: Don't use the address immediate for MOV_INDIRECT

2016-10-28 Thread Matt Turner
On Fri, Oct 28, 2016 at 2:53 PM, Jason Ekstrand wrote: > The address immediate field is only 9 bits and, since the value is in > bytes, the highest GRF we can point to with it is g15. This makes it > pretty close to useless for MOV_INDIRECT. There were already piles of > restrictions preventing

Re: [Mesa-dev] [RFC 00/11] i965: Remove our dependence on nir_shader::info

2016-10-28 Thread Timothy Arceri
On Fri, 2016-10-28 at 13:46 -0700, Jason Ekstrand wrote: > Timothy's attempts to extract shader_info from nir_shader got me > thinking, > "What if shader_info were simply a byproduct of compilation?"  His > last > patch series made nir_shader::info just a pointer to gl_program::info > in > most cas

Re: [Mesa-dev] [PATCH 09/18] anv/image: Rename hiz_surface to aux_surface

2016-10-28 Thread Nanley Chery
On Fri, Oct 28, 2016 at 03:28:27PM -0700, Jason Ekstrand wrote: > On Fri, Oct 28, 2016 at 3:06 PM, Nanley Chery wrote: > > > On Fri, Oct 28, 2016 at 02:17:05AM -0700, Jason Ekstrand wrote: > > > Signed-off-by: Jason Ekstrand > > > --- > > > src/intel/vulkan/anv_image.c | 16 --

Re: [Mesa-dev] [PATCH 09/18] anv/image: Rename hiz_surface to aux_surface

2016-10-28 Thread Jason Ekstrand
On Fri, Oct 28, 2016 at 3:06 PM, Nanley Chery wrote: > On Fri, Oct 28, 2016 at 02:17:05AM -0700, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/intel/vulkan/anv_image.c | 16 > > src/intel/vulkan/anv_private.h | 5 +++-- > > src/intel/vulkan/

Re: [Mesa-dev] [PATCH 08/18] anv/blorp: Ignore clears for attachments first used as resolve destinations

2016-10-28 Thread Jason Ekstrand
On Fri, Oct 28, 2016 at 3:00 PM, Nanley Chery wrote: > On Fri, Oct 28, 2016 at 02:17:04AM -0700, Jason Ekstrand wrote: > > Otherwise, we'll try to clear it the first time it's used as a draw so if > > you do some multisampled rendering, resolve to an attachment, and then > draw > > on top of the

Re: [Mesa-dev] [PATCH 09/18] anv/image: Rename hiz_surface to aux_surface

2016-10-28 Thread Nanley Chery
On Fri, Oct 28, 2016 at 02:17:05AM -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > src/intel/vulkan/anv_image.c | 16 > src/intel/vulkan/anv_private.h | 5 +++-- > src/intel/vulkan/genX_cmd_buffer.c | 10 +- > 3 files changed, 16 insertions

Re: [Mesa-dev] [PATCH 08/18] anv/blorp: Ignore clears for attachments first used as resolve destinations

2016-10-28 Thread Nanley Chery
On Fri, Oct 28, 2016 at 02:17:04AM -0700, Jason Ekstrand wrote: > Otherwise, we'll try to clear it the first time it's used as a draw so if > you do some multisampled rendering, resolve to an attachment, and then draw > on top of the single-sampled attachment, we might accidentally clear it. > > S

[Mesa-dev] [PATCH] i965/fs/generator: Don't use the address immediate for MOV_INDIRECT

2016-10-28 Thread Jason Ekstrand
The address immediate field is only 9 bits and, since the value is in bytes, the highest GRF we can point to with it is g15. This makes it pretty close to useless for MOV_INDIRECT. There were already piles of restrictions preventing us from using it prior to Broadwell, so let's get rid of the gen

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #7 from Ian Romanick --- So... how does it work if the linked libglapi and libGL provide different, incompatible implementations of, say, _glapi_set_dispatch? -- You are receiving this mail because: You are the QA Contact for the bu

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-28 Thread Matt Turner
On Fri, Oct 28, 2016 at 1:42 PM, Emil Velikov wrote: > On 28 October 2016 at 20:55, Emil Velikov wrote: >> On 28 October 2016 at 19:18, Lionel Landwerlin >> wrote: >>> On 28/10/16 19:12, Emil Velikov wrote: From: Emil Velikov There is nothing in here that would require it. >

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Vinson Lee changed: What|Removed |Added Depends on||97386 Referenced Bugs: https://bugs.freed

[Mesa-dev] [Bug 97386] [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg-float single-sample regression

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97386 Vinson Lee changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.freed

[Mesa-dev] [Bug 97386] [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg-float single-sample regression

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97386 Vinson Lee changed: What|Removed |Added Version|git |13.0 -- You are receiving this mail becaus

[Mesa-dev] [Bug 97569] [swrast] piglit getteximage-formats regression

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97569 Vinson Lee changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.freed

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Vinson Lee changed: What|Removed |Added Depends on||97569 Referenced Bugs: https://bugs.freed

[Mesa-dev] [Bug 97569] [swrast] piglit getteximage-formats regression

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97569 Vinson Lee changed: What|Removed |Added Version|git |13.0 -- You are receiving this mail becaus

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97967 Vinson Lee changed: What|Removed |Added Version|git |13.0 -- You are receiving this mail becaus

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Vinson Lee changed: What|Removed |Added Depends on||97967 Referenced Bugs: https://bugs.freed

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97967 Vinson Lee changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.freed

[Mesa-dev] [Bug 98485] test_vec4_cmod_propagation.cpp:372:26: error: ‘brw_reg’ is an inaccessible base of ‘brw?=::=?UTF-8?Q?dst_reg’

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98485 Bug ID: 98485 Summary: test_vec4_cmod_propagation.cpp:372:26: error: ‘brw_reg’ is an inaccessible base of ‘brw::dst_reg’ Product: Mesa Version: 13.0 Hardware: x86-64 (AMD64

[Mesa-dev] [PATCH] svga: collect stats for time spent in svga_context_finish()

2016-10-28 Thread Brian Paul
This should have appeared with commit "svga: add guest statistic gathering interface" from August 4, but was somehow lost. --- src/gallium/drivers/svga/svga_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/svga/svga_context.c b/src/gallium/drivers/svga/svga_co

[Mesa-dev] [RFC 11/11] i965/compiler: Take an explicit shader_info parameter in compile_cs

2016-10-28 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pipeline.c| 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_cs.c | 4 ++-- src/mesa/drivers/dri/i965/brw_fs.cpp | 25 + src/mesa/drivers/dri/i965/brw_nir.h

[Mesa-dev] [RFC 03/11] i965/fs: Use the new info field instead of nir->info

2016-10-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 44 ++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 18 ++-- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 12 src/mesa/drivers/dri/i965/brw_wm_iz.cpp | 2 +- 4 files changed, 38 insertions(+), 3

[Mesa-dev] [RFC 02/11] i965/shader: Add an explicit shader_info field

2016-10-28 Thread Jason Ekstrand
We also go through all the pain of plumbing it through all the constructors here so we don't have to later. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +- src/mesa/drivers/dri/i965/brw_fs.h| 2 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 -

[Mesa-dev] [RFC 09/11] i965/compiler: Take an explicit shader_info parameter in compile_gs

2016-10-28 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pipeline.c | 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_gs.c| 2 +- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 39 --- 4 files changed, 23 insertions(+), 21

[Mesa-dev] [RFC 10/11] i965/compiler: Take an explicit shader_info parameter in compile_fs

2016-10-28 Thread Jason Ekstrand
--- src/intel/blorp/blorp.c | 4 ++-- src/intel/vulkan/anv_pipeline.c | 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 33 src/mesa/drivers/dri/i965/brw_wm.c | 2 +- 5 files chang

[Mesa-dev] [RFC 08/11] i965/compiler: Take an explicit shader_info parameter in compile_tes

2016-10-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_shader.cpp | 26 +- src/mesa/drivers/dri/i965/brw_tes.c | 3 ++- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src/mesa/dr

[Mesa-dev] [RFC 01/11] i965: Pull shader_info out of gl_program rather than nir_shader

2016-10-28 Thread Jason Ekstrand
This commit modifies all of the state upload and codegen code to pull the shader_info out of gl_program rather than nir_shader. In the GL driver, the pointer in nir_shader just points to gl_program::shader_info anyway so there's no real point in pulling it from the nir_shader. --- src/mesa/driver

[Mesa-dev] [RFC 07/11] i965/compiler: Take an explicit shader_info parameter in compile_tcs

2016-10-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_tcs.c| 3 ++- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 28 ++-- 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src

[Mesa-dev] [RFC 04/11] i965/vec4: Use the new info field instead of nir->info

2016-10-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp| 8 src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp| 6 +++--- src/mesa/drivers/dri/i965/gen6_gs_visitor.cp

[Mesa-dev] [RFC 06/11] i965/compiler: Take an explicit shader_info parameter in compile_vs

2016-10-28 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pipeline.c | 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_nir.c | 3 ++- src/mesa/drivers/dri/i965/brw_nir.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 20 ++-- src/mesa/drivers/dri/i965/

[Mesa-dev] [RFC 05/11] i965/vec4: Make generate_assembly take an explicit shader_info parameter

2016-10-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 10 +- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cp

[Mesa-dev] [RFC 00/11] i965: Remove our dependence on nir_shader::info

2016-10-28 Thread Jason Ekstrand
Timothy's attempts to extract shader_info from nir_shader got me thinking, "What if shader_info were simply a byproduct of compilation?" His last patch series made nir_shader::info just a pointer to gl_program::info in most cases, so why don't we go all the way and just say that the shader_info li

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Gurchetan Singh
I'm confused what the desired cleanup is. Do you want 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac or 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles to be removed. In the cases where this breaks the build, PTHREAD_CFLAGS should be added to the AM_LDFLAGS. O

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 20:55, Emil Velikov wrote: > On 28 October 2016 at 19:18, Lionel Landwerlin > wrote: >> On 28/10/16 19:12, Emil Velikov wrote: >>> >>> From: Emil Velikov >>> >>> There is nothing in here that would require it. >>> >>> Cc: mesa-sta...@lists.freedesktop.org >>> Cc: Lionel Lan

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 Stefano Cipriani changed: What|Removed |Added CC||cip9...@gmail.com -- You are receivi

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 19:18, Lionel Landwerlin wrote: > On 28/10/16 19:12, Emil Velikov wrote: >> >> From: Emil Velikov >> >> There is nothing in here that would require it. >> >> Cc: mesa-sta...@lists.freedesktop.org >> Cc: Lionel Landwerlin >> Signed-off-by: Emil Velikov >> --- >> Not sure wh

Re: [Mesa-dev] [PATCH 21/25] anv/blorp: Break the guts of alloc_binding_table into a shared helper

2016-10-28 Thread Pohjolainen, Topi
On Fri, Oct 28, 2016 at 10:27:02PM +0300, Pohjolainen, Topi wrote: > On Sat, Oct 22, 2016 at 10:50:52AM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_blorp.c | 24 > > src/intel/vulkan/anv_private.h | 5 + > > src/intel/vulkan/genX_blorp_exec

Re: [Mesa-dev] [PATCH 21/25] anv/blorp: Break the guts of alloc_binding_table into a shared helper

2016-10-28 Thread Pohjolainen, Topi
On Sat, Oct 22, 2016 at 10:50:52AM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 24 > src/intel/vulkan/anv_private.h | 5 + > src/intel/vulkan/genX_blorp_exec.c | 18 ++ > 3 files changed, 31 insertions(+), 16 deletions

Re: [Mesa-dev] [PATCH 19/25] intel/blorp: Add a clear_attachments entrypoint

2016-10-28 Thread Pohjolainen, Topi
On Sat, Oct 22, 2016 at 10:50:50AM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 11 +++ > src/intel/blorp/blorp_clear.c | 162 > +- > src/intel/blorp/blorp_priv.h | 1 + > 3 files changed, 172 insertions(+), 2 deletions(-) > > d

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #6 from ajax at nwnk dot net --- (In reply to Emil Velikov from comment #5) > Are old xservers (ones which includes their own glapi dispatch) + glapi > linked dri modules going to work ? Who cares? Anyone still running 1.14 is alrea

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 19:35, Gurchetan Singh wrote: > Removing the entire hunk causes build failures on CrOS mesa. Refer to this > for more information: > > http://stackoverflow.com/questions/17055279/autotools-for-pthreads-not-setting-correct-linker-flags > > We can do one of the following: > >

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 18:24, Matt Turner wrote: > On Fri, Oct 28, 2016 at 8:06 AM, Emil Velikov > wrote: >> On 27 October 2016 at 17:06, Gurchetan Singh >> wrote: >>> In Android, the pthreads libs are in bionic. When building >>> Mesa for Android with the autotools workflow, we shouldn't >>> s

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Gurchetan Singh
Removing the entire hunk causes build failures on CrOS mesa. Refer to this for more information: http://stackoverflow.com/questions/17055279/autotools-for-pthreads-not-setting-correct-linker-flags We can do one of the following: (1) Keep as is, with special case for android (2) Set PTHREAD_LIBS

Re: [Mesa-dev] [PATCH 1/2] configure.ac: fold xxd's -i within XXD

2016-10-28 Thread Matt Turner
On Fri, Oct 28, 2016 at 11:12 AM, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we get annoying messages like the following when xxd is > missing. > > /bin/sh: line 2: -i: command not found That error is better than what we'd get after this patch. "cat ... | >> ..." looks like it genera

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-28 Thread Lionel Landwerlin
On 28/10/16 19:12, Emil Velikov wrote: From: Emil Velikov There is nothing in here that would require it. Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- Not sure why we got that dependency in the first place, Lionel ? Some of the Makefile's cont

[Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-28 Thread Emil Velikov
From: Emil Velikov There is nothing in here that would require it. Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- Not sure why we got that dependency in the first place, Lionel ? --- src/intel/Makefile.genxml.am | 2 -- 1 file changed, 2 deletions(

[Mesa-dev] [PATCH 1/2] configure.ac: fold xxd's -i within XXD

2016-10-28 Thread Emil Velikov
From: Emil Velikov Otherwise we get annoying messages like the following when xxd is missing. /bin/sh: line 2: -i: command not found Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- I'm wondering if we shouldn't give some form or warning/error messag

Re: [Mesa-dev] [PATCH] glsl: Improve accuracy of alpha scaling in advanced blend lowering.

2016-10-28 Thread Francisco Jerez
Kenneth Graunke writes: > When blending with GL_COLORBURN_KHR and these colors: > >dst = <0.372549027, 0.372549027, 0.372549027, 0.372549027> >src = <0.09375, 0.046875, 0.0, 0.375> > > the normalized dst value became 0.9994 (due to precision problems > in the floating point divide of

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Matt Turner
On Fri, Oct 28, 2016 at 8:06 AM, Emil Velikov wrote: > On 27 October 2016 at 17:06, Gurchetan Singh > wrote: >> In Android, the pthreads libs are in bionic. When building >> Mesa for Android with the autotools workflow, we shouldn't >> set -lpthread or -pthread. >> --- >> configure.ac | 7 +

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: Smplify implementation of vkGetPhysicalDeviceSurfaceFormatsKHR

2016-10-28 Thread Jason Ekstrand
This is nice. Both are Reviewed-by: Jason Ekstrand On Oct 28, 2016 5:55 AM, "Eduardo Lima Mitev" wrote: > This patch simplifies x11_surface_get_formats() and makes it more readable. > It is actually an improvement over the patch I provided earlier this week > (750d8cad72), which was not very

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98473 --- Comment #3 from Emil Velikov --- (In reply to Mike Lothian from comment #2) > Is this a blocker for 13? The release won't need flex to compile as it'll be > pre-generated for the tarball That's correct. Some distros still do autoreconf + fri

Re: [Mesa-dev] [PATCH 2/3] glx/glvnd: Fix dispatch function names and indices

2016-10-28 Thread Emil Velikov
On 19 October 2016 at 18:39, Adam Jackson wrote: > On Fri, 2016-09-16 at 19:07 +0100, Emil Velikov wrote: >> On 14 September 2016 at 19:06, Adam Jackson wrote: >> > As this array was not actually sorted, FindGLXFunction's binary search >> > would only sometimes work. >> > >> >> This commit messag

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #5 from Emil Velikov --- (In reply to ajax at nwnk dot net from comment #4) > (In reply to Emil Velikov from comment #3) > > On a more comprehensive note: > > > > One of the goals behind GLVND is to reuse mesa's GLAPI and allow us to

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Tomasz Figa
On Fri, Oct 28, 2016 at 11:33 PM, Rob Herring wrote: > On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov > wrote: >> On 28 October 2016 at 13:22, Rob Clark wrote: >>> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli >>> wrote: On 10/27/2016 01:48 PM, Rob Clark wrote: > > On Thu, Oct 27,

Re: [Mesa-dev] [PATCH 2/2] egl: Use pkg-config for Android NDK build

2016-10-28 Thread Emil Velikov
On 27 October 2016 at 17:07, Gurchetan Singh wrote: > It's possible to build Mesa for Android using the traditional > autotools workflow. To enable this, let's add the required > pkg-config checks and link against them. Does the upstream repositories have the files or one requires extra patches ?

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On 27 October 2016 at 17:06, Gurchetan Singh wrote: > In Android, the pthreads libs are in bionic. When building > Mesa for Android with the autotools workflow, we shouldn't > set -lpthread or -pthread. > --- > configure.ac | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 15:33, Rob Herring wrote: > On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov > wrote: >> On 28 October 2016 at 13:22, Rob Clark wrote: >>> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli >>> wrote: On 10/27/2016 01:48 PM, Rob Clark wrote: > > On Thu, Oct 27, 2016

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98473 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #2 from M

[Mesa-dev] [Bug 98474] Linking mesa against [non-standard prefixed] LLVM fails

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98474 Emil Velikov changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Emil Velikov changed: What|Removed |Added Depends on||98335, 98473, 98474 Referenced Bugs: ht

[Mesa-dev] [Bug 98474] Linking mesa against [non-standard prefixed] LLVM fails

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98474 Bug ID: 98474 Summary: Linking mesa against [non-standard prefixed] LLVM fails Product: Mesa Version: git Hardware: Other OS: All Status: NEW

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98473 Emil Velikov changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.fre

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Rob Herring
On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov wrote: > On 28 October 2016 at 13:22, Rob Clark wrote: >> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >>> On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: > > On 10/27/2016

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98473 --- Comment #1 from Emil Velikov --- The following should address the issue, although the question stands: are we doing something wrong or this is a flex bug. https://patchwork.freedesktop.org/series/14477/ -- You are receiving this mail becau

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98473 Bug ID: 98473 Summary: Mesa fails to build with flex 2.6.2 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prior

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Bug ID: 98471 Summary: [TRACKER] Mesa 13.0 release tracker Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prior

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 13:22, Rob Clark wrote: > On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >> On 10/27/2016 01:48 PM, Rob Clark wrote: >>> >>> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >>> wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: > > So, not quite sure if t

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Rob Herring
+Mauro, Chih-Wei On Fri, Oct 28, 2016 at 7:22 AM, Rob Clark wrote: > On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >> On 10/27/2016 01:48 PM, Rob Clark wrote: >>> >>> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >>> wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: > > S

Re: [Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

2016-10-28 Thread Eric Engestrom
On Wednesday, 2016-09-14 14:06:18 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- It has been pointed out recently [1] that this series hasn't landed yet. Has it simply fallen through the cracks, or is something holding it up? Cheers, Eric [1] https://bugs.freedesktop.org/show_

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfacePresentModesKHR

2016-10-28 Thread Eric Engestrom
On Friday, 2016-10-28 14:55:00 +0200, Eduardo Lima Mitev wrote: > x11_surface_get_present_modes() is currently asserting that the number of > elements in pPresentModeCount must be greater than or equal to the number > of present modes available. This is buggy because pPresentModeCount > elements ar

Re: [Mesa-dev] [PATCH 2/2] nir: Fix clone/sweep of info allocated by nir_builder_init_simple_shader().

2016-10-28 Thread Timothy Arceri
On Thu, 2016-10-27 at 15:23 -0700, Jason Ekstrand wrote: > On Thu, Oct 27, 2016 at 2:47 PM, Timothy Arceri bora.com> wrote: > > On Thu, 2016-10-27 at 13:57 -0700, Jason Ekstrand wrote: > > > On Thu, Oct 27, 2016 at 1:30 PM, Eric Anholt > > wrote: > > > > Fixes use-after-free-caused segfaults in t

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Tapani Pälli
On 10/28/2016 03:22 PM, Rob Clark wrote: On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: So, not quite sure if this is the *correct* solution, but it i

[Mesa-dev] [Bug 91631] Clang static analysis of libtess shows undefined values and use of memory after free

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91631 Frederic Devernay changed: What|Removed |Added CC||frederic.dever...@m4x.org -- You ar

[Mesa-dev] [PATCH 1/2] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfacePresentModesKHR

2016-10-28 Thread Eduardo Lima Mitev
x11_surface_get_present_modes() is currently asserting that the number of elements in pPresentModeCount must be greater than or equal to the number of present modes available. This is buggy because pPresentModeCount elements are later copied from the internal modes' array, so if pPresentModeCount i

[Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: Smplify implementation of vkGetPhysicalDeviceSurfaceFormatsKHR

2016-10-28 Thread Eduardo Lima Mitev
This patch simplifies x11_surface_get_formats() and makes it more readable. It is actually an improvement over the patch I provided earlier this week (750d8cad72), which was not very "good-tasting". I'm sorry for the noise. --- src/vulkan/wsi/wsi_common_x11.c | 11 +++ 1 file changed, 3 in

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #39 from Stefano Cipriani --- Playing against bots with an AMD r9 m265x (cape verde) using DRI_PRIME=1 rendered via Intel HD Graphics 4600 the game it's not playable for about 30+ seconds, bot cars start to one every 5~10 seconds. Whe

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #10 from Mike Lothian --- It's not documented very well either -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mai

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Rob Clark
On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: > On 10/27/2016 01:48 PM, Rob Clark wrote: >> >> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >> wrote: >>> >>> On 10/27/2016 12:16 AM, Rob Clark wrote: So, not quite sure if this is the *correct* solution, but it is at least *a

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #9 from Ernst Sjöstrand --- I don't think these patches are merged yet: https://patchwork.freedesktop.org/series/12471/ Sounds like it's not very well tested yet... -- You are receiving this mail because: You are the assignee for th

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #8 from Bastien Nocera --- (In reply to Mike Lothian from comment #7) > Mesa only supports glvnd for GLX, it doesn't work for anything else yet Noted, thanks. -- You are receiving this mail because: You are the QA Contact for the b

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-28 Thread Andy Furniss
Michel Dänzer wrote: On 27/10/16 07:52 PM, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox w

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #7 from Mike Lothian --- Mesa only supports glvnd for GLX, it doesn't work for anything else yet -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 Bastien Nocera changed: What|Removed |Added CC||bugzi...@hadess.net --- Comment #6 from

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-28 Thread Marek Olšák
On Oct 28, 2016 3:30 AM, "Michel Dänzer" wrote: > > On 28/10/16 03:08 AM, Marek Olšák wrote: > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov wrote: > >> On 17 October 2016 at 10:37, Marek Olšák wrote: > >>> Reverting the whole commit is too much. You can just remove the PIPE BIND > >>> SHARED

  1   2   >