Re: [Mesa-dev] [PATCH 1/2] [RFC] i965/vec4: Reward spills in if/else/endif blocks

2015-06-19 Thread Ben Widawsky
On Fri, Jun 19, 2015 at 08:04:51PM -0700, Matt Turner wrote: > On Fri, Jun 19, 2015 at 6:53 PM, Connor Abbott wrote: > > I don't think this is doing what you think it's doing. This code is > > for calculating the *cost* of spills, so a higher cost means a lower > > priority for choosing the regist

Re: [Mesa-dev] [Nouveau] [PATCH v3 0/2] nouveau: support for custom VRAM domains

2015-06-19 Thread Alexandre Courbot
On Fri, Jun 19, 2015 at 9:38 PM, Ben Skeggs wrote: > On 19 June 2015 at 21:51, Martin Peres wrote: >> On 19/06/2015 13:02, Alexandre Courbot wrote: >>> >>> New revision of this patchset that prevents VRAM objects from being >>> allocated on VRAM-less systems like Tegra. This is required for Mesa

Re: [Mesa-dev] [PATCH v3 2/2] nvc0: use NV_VRAM_DOMAIN() macro

2015-06-19 Thread Alexandre Courbot
On Fri, Jun 19, 2015 at 10:55 PM, Ilia Mirkin wrote: > On Fri, Jun 19, 2015 at 6:02 AM, Alexandre Courbot > wrote: >> Use the newly-introduced NV_VRAM_DOMAIN() macro to support alternative >> VRAM domains for chips that do not have dedicated video memory. >> >> Signed-off-by: Alexandre Courbot

Re: [Mesa-dev] [PATCH 1/2] [RFC] i965/vec4: Reward spills in if/else/endif blocks

2015-06-19 Thread Matt Turner
On Fri, Jun 19, 2015 at 6:53 PM, Connor Abbott wrote: > I don't think this is doing what you think it's doing. This code is > for calculating the *cost* of spills, so a higher cost means a lower > priority for choosing the register. We increase the cost for things > inside loops because we don't w

Re: [Mesa-dev] [PATCH 1/2] [RFC] i965/vec4: Reward spills in if/else/endif blocks

2015-06-19 Thread Ben Widawsky
I'm not seeing where it does anything other than what I say. Beforehand the cost is increased (*=) from DO->WHILE. Now it should be decreased (/= 10) from IF->ENDIF. The factor of 10 probably needs to be modified since I suspect Can you help me see what I'm not seeing? On Fri, Jun 19, 2015 at 06:

Re: [Mesa-dev] [PATCH 1/2] [RFC] i965/vec4: Reward spills in if/else/endif blocks

2015-06-19 Thread Connor Abbott
I don't think this is doing what you think it's doing. This code is for calculating the *cost* of spills, so a higher cost means a lower priority for choosing the register. We increase the cost for things inside loops because we don't want to spill inside loops, and by doing the same thing for if's

Re: [Mesa-dev] [PATCH v2 02/18] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

2015-06-19 Thread Jason Ekstrand
On Fri, Jun 19, 2015 at 1:51 PM, Matt Turner wrote: > On Fri, Jun 19, 2015 at 1:18 PM, Jason Ekstrand wrote: >> Previously, fs_inst::regs_read() fell back to depending on the register >> width for the second source. This isn't really correct since it isn't a >> SIMD8 value at all, but a SIMD4x2

[Mesa-dev] [PATCH 2/2] [RFC] i965/fs: Reward spills in if/else/endif blocks

2015-06-19 Thread Ben Widawsky
Just like the previous patch but for the FS. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index cd7881

[Mesa-dev] [PATCH 1/2] [RFC] i965/vec4: Reward spills in if/else/endif blocks

2015-06-19 Thread Ben Widawsky
If we have a register that needs spilling in an if/else block, there is a chance that we may not need to spill if we do[n't] take the branch. The downside of this patch is the case where the register being spilled ends up in both if/else blocks. For that case, preferring this path will increase co

[Mesa-dev] abundance of branches in mesa.git

2015-06-19 Thread Ilia Mirkin
Hello, There are a *ton* of branches in the upstream mesa git. Here is a full list: origin/10.0 origin/10.1 origin/10.2 origin/10.3 origin/10.4 origin/10.5 origin/10.6 origin/7.10 origin/7.11 origin/7.8 origin/7.8-gles origin/7.9 origin/8.0 origin/9.0 origin/9.1 or

Re: [Mesa-dev] [PATCH 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-06-19 Thread Anuj Phogat
On Thu, Jun 18, 2015 at 5:26 AM, Iago Toral wrote: > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> Without this patch, arb_color_buffer_float-readpixels test fails, when >> forced to use meta pbo path. >> >> Signed-off-by: Anuj Phogat >> Cc: >> --- >> src/mesa/drivers/common/meta_tex

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-19 Thread Rob Clark
On Fri, Jun 19, 2015 at 6:45 PM, Connor Abbott wrote: > On Thu, Jun 18, 2015 at 12:04 PM, Rob Clark wrote: >> It is only vaguely an issue at the moment >> because the priority-queue scheduler that replaced what is on master >> does very badly with wide/shallow shaders, ie. like >> glsl-fs-convolu

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-19 Thread Rob Clark
On Fri, Jun 19, 2015 at 6:21 PM, Connor Abbott wrote: >>> and the RA has to >>> split live-ranges of other things and deal with arrays specially too >>> in order to not introduce extra array copies. >> >> If I did spilling/rematerialization.. but I don't. > > If you force every array into a speci

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-19 Thread Rob Clark
On Fri, Jun 19, 2015 at 6:21 PM, Connor Abbott wrote: > On Thu, Jun 18, 2015 at 12:04 PM, Rob Clark wrote: >> On Thu, Jun 18, 2015 at 2:34 PM, Connor Abbott wrote: >>> On Thu, Jun 18, 2015 at 11:19 AM, Rob Clark wrote: On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott wrote: > On Thu, Ju

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-19 Thread Connor Abbott
On Thu, Jun 18, 2015 at 12:04 PM, Rob Clark wrote: > It is only vaguely an issue at the moment > because the priority-queue scheduler that replaced what is on master > does very badly with wide/shallow shaders, ie. like > glsl-fs-convolution-1... ie. shaders with a lot of instructions at > minimum

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-19 Thread Connor Abbott
On Thu, Jun 18, 2015 at 12:04 PM, Rob Clark wrote: > On Thu, Jun 18, 2015 at 2:34 PM, Connor Abbott wrote: >> On Thu, Jun 18, 2015 at 11:19 AM, Rob Clark wrote: >>> On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott wrote: On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark wrote: > On Thu, Jun 18

Re: [Mesa-dev] [PATCH 44/46] glsl: fix locations of 2-dimensional varyings without varying packing

2015-06-19 Thread Kenneth Graunke
On Wednesday, June 17, 2015 01:01:40 AM Marek Olšák wrote: > From: Marek Olšák > > --- > src/glsl/link_varyings.cpp | 37 - > 1 file changed, 28 insertions(+), 9 deletions(-) > > diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp > index 5fa

Re: [Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

2015-06-19 Thread Emil Velikov
On 19 June 2015 at 21:26, Jose Fonseca wrote: > On 19/06/15 20:56, Emil Velikov wrote: >> >> Hi all, >> >> A lovely series inspired (more like 'was awaken to send these out') by >> Pal Rohár, who was having issues when building xlib-libgl (plus the now >> enabled gles*) >> >> So here, we teach the

Re: [Mesa-dev] [PATCH 25/46] glsl: lower gl_TessLevel* from float[n] to vecn.

2015-06-19 Thread Kenneth Graunke
On Wednesday, June 17, 2015 01:01:21 AM Marek Olšák wrote: > From: Fabian Bieler > > Similar to gl_ClipDistance -> gl_ClipDistanceMESA > --- > src/glsl/Makefile.sources | 1 + > src/glsl/ir_optimization.h | 1 + > src/glsl/link_varyings.cpp | 51 +++-

[Mesa-dev] [Bug 91034] New account request

2015-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91034 --- Comment #1 from Sarah Sharp --- Created attachment 116604 --> https://bugs.freedesktop.org/attachment.cgi?id=116604&action=edit Public ssh key -- You are receiving this mail because: You are the QA Contact for the bug. You are the assigne

[Mesa-dev] [Bug 91034] New account request

2015-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91034 Bug ID: 91034 Summary: New account request Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: med

Re: [Mesa-dev] [PATCH 08/11] confiigure: drop unused variable GBM_BACKEND_DIRS

2015-06-19 Thread Eric Anholt
Emil Velikov writes: > Signed-off-by: Emil Velikov s/confiigure/configure/ in the subject. After that, and some cleanup of the commit message in 4, patches 1-8 will be: Reviewed-by: Eric Anholt I find 9/10 weird -- if the DRI drivers need libglapi, why aren't they just linking libglapi? si

Re: [Mesa-dev] [PATCH 4/5] i965/gen9: Add XY_FAST_COPY_BLT support to intelEmitCopyBlit()

2015-06-19 Thread Anuj Phogat
On Wed, Jun 10, 2015 at 3:34 PM, Anuj Phogat wrote: > This patch enables using XY_FAST_COPY_BLT only for Yf/Ys tiled buffers. > It can be later turned on for other tiling patterns (X,Y) too. > > V3: Flush in between sequential fast copy blits. > Fix src/dst alignment requirements. > Make c

Re: [Mesa-dev] [PATCH v2 02/18] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

2015-06-19 Thread Matt Turner
On Fri, Jun 19, 2015 at 1:18 PM, Jason Ekstrand wrote: > Previously, fs_inst::regs_read() fell back to depending on the register > width for the second source. This isn't really correct since it isn't a > SIMD8 value at all, but a SIMD4x2 value. This commit changes it to > explicitly be always o

Re: [Mesa-dev] [PATCH] i965: add EXT_polygon_offset_clamp support to gen4/gen5

2015-06-19 Thread Ilia Mirkin
On Fri, Jun 19, 2015 at 4:36 PM, Matt Turner wrote: > From: Ilia Mirkin > > Reviewed-by: Matt Turner > Signed-off-by: Ilia Mirkin > --- > mattst88: Changed BRW_CONDITIONAL_G -> BRW_CONDITIONAL_GE (see commit > 3b7f683f) > > Somewhat worryingly, I wasn't able to break any of the piglit tests by

Re: [Mesa-dev] [PATCH] i965/gen8: Use HALIGN_16 for single sample mcs buffers

2015-06-19 Thread Anuj Phogat
On Fri, Jun 19, 2015 at 10:05 AM, Mark Janes wrote: > Tested-by: Mark Janes > > Ben Widawsky writes: > >> The original code meant to do this, but was only checking num_samples == 1 to >> figure out if a surface was fast clear capable. However, we can allocate >> single >> sample miptrees with n

Re: [Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

2015-06-19 Thread Jason Ekstrand
On Fri, Jun 19, 2015 at 1:40 PM, Anuj Phogat wrote: > On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote: >> >> On Jun 16, 2015 11:15, "Anuj Phogat" wrote: >>> >>> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, >>> when >>> forced to use the meta pbo path. >>> >>> Sig

Re: [Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

2015-06-19 Thread Anuj Phogat
On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote: > > On Jun 16, 2015 11:15, "Anuj Phogat" wrote: >> >> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, >> when >> forced to use the meta pbo path. >> >> Signed-off-by: Anuj Phogat >> Cc: >> --- >> src/mesa/drivers/co

[Mesa-dev] [PATCH] i965: add EXT_polygon_offset_clamp support to gen4/gen5

2015-06-19 Thread Matt Turner
From: Ilia Mirkin Reviewed-by: Matt Turner Signed-off-by: Ilia Mirkin --- mattst88: Changed BRW_CONDITIONAL_G -> BRW_CONDITIONAL_GE (see commit 3b7f683f) Somewhat worryingly, I wasn't able to break any of the piglit tests by inverting the cmod on the CMP in brw_clip_unfilled.c. src/mesa/driv

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

2015-06-19 Thread Anuj Phogat
On Thu, Jun 18, 2015 at 11:41 PM, Iago Toral wrote: > On Thu, 2015-06-18 at 09:19 -0700, Anuj Phogat wrote: >> On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote: >> > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> >> Cc: >> >> --- >> >> src/mesa/main/

Re: [Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

2015-06-19 Thread Jose Fonseca
On 19/06/15 20:56, Emil Velikov wrote: Hi all, A lovely series inspired (more like 'was awaken to send these out') by Pal Rohár, who was having issues when building xlib-libgl (plus the now enabled gles*) So here, we teach the final two static glapi users about shared-glapi, plus some related f

[Mesa-dev] [PATCH v2 02/18] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

2015-06-19 Thread Jason Ekstrand
Previously, fs_inst::regs_read() fell back to depending on the register width for the second source. This isn't really correct since it isn't a SIMD8 value at all, but a SIMD4x2 value. This commit changes it to explicitly be always one register. Reviewed-by: Iago Toral Quiroga v2: Use mlen for

[Mesa-dev] [PATCH 01.9/18] i965/fs: Actually set/use the mlen for gen7 uniform pull constant loads

2015-06-19 Thread Jason Ekstrand
Previously, we were allocating the payload with different sizes per gen and then figuring out the mlen in the generator based on gen. This meant, among other things, that the higher level passes knew nothing about it. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 +- src/mes

Re: [Mesa-dev] [PATCH 3/3] egl/main: expose the EGL_RECORDABLE_ANDROID extension

2015-06-19 Thread Eric Anholt
Chih-Wei Huang writes: The commit message needs some explanation: Why are we doing this? What does EGL_ANDROID_recordable get us, if we don't have any configs exposing it? What tests do we have for it? > Signed-off-by: Chih-Wei Huang > --- > src/egl/main/eglconfig.c | 5 - > src/egl/main

[Mesa-dev] [PATCH 05/11] drivers/x11: drop unneeded HAVE_X11_DRIVER check

2015-06-19 Thread Emil Velikov
Already handled in the Makefile which includes the drivers/x11 subdir. Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am index a8847e8..ba79f69 100644 --- a/src

[Mesa-dev] [PATCH 08/11] confiigure: drop unused variable GBM_BACKEND_DIRS

2015-06-19 Thread Emil Velikov
Signed-off-by: Emil Velikov --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 56095ba..ddc757e 100644 --- a/configure.ac +++ b/configure.ac @@ -1507,7 +1507,6 @@ if test "x$enable_gbm" = xyes; then fi if test "x$enable_dri" = xyes; t

[Mesa-dev] [PATCH 03/11] targets/libgl-xlib: fix the build against shared_glapi

2015-06-19 Thread Emil Velikov
Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- src/gallium/targets/libgl-xlib/Makefile.am | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am index 33b0d13..d99caae 100644 --- a/src/

[Mesa-dev] [PATCH 01/11] configure: warn about shared_glapi & xlib-glx only when both are set

2015-06-19 Thread Emil Velikov
Printing out the message when shared_glapi is disabled only leads to confusion. Cc: "10.5 10.6" Signed-off-by: Emil Velikov --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 3c763c2..5161361 100644 --- a/configure.ac +++ b/con

[Mesa-dev] [PATCH 09/11] gbm: dlopen libglapi so gbm_create_device works

2015-06-19 Thread Emil Velikov
From: Frank Henigman Dri driver libs are not linked to pull in libglapi so gbm_create_device() fails when it tries to dlopen them (unless the application is linked with something that does pull in libglapi, like libGL). Until dri drivers can be fixed properly, dlopen libglapi before trying to dlo

[Mesa-dev] [PATCH 11/11] android: egl: do not link against libglapi

2015-06-19 Thread Emil Velikov
The only reason we touch glapi is to dlopen it to: - make sure that the unresolved _glapi* symbols in the dri modules are provided. - fetch glFlush() and use it at various stages in the dri2 driver. XXX: If anyone has suggestions why the latter is required (or can recommend any reading material)

[Mesa-dev] [PATCH 10/11] gbm: do not (over)link against libglapi.so

2015-06-19 Thread Emil Velikov
The whole of GBM does not rely on even a single symbol from the GL dispatch library, unsuprisingly. The only need for it comes from the unresolved symbols in the DRI modules, which are now correctly handled with Frank's commit. Cc: "10.5 10.6" Signed-off-by: Emil Velikov --- src/gbm/Makefile.am

[Mesa-dev] [PATCH 07/11] configure: error out when building libEGL without shared-glapi

2015-06-19 Thread Emil Velikov
The latter is a hard requirement and without it we'll error out later on in the build. Cc: "10.5 10.6" Signed-off-by: Emil Velikov --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 8e62bd8..56095ba 100644 --- a/configure.ac +++ b/configure

[Mesa-dev] [PATCH 04/11] configure: allow building shared-glapi powered libgl-xlib

2015-06-19 Thread Emil Velikov
XXX: With this one done, we can finally transition with enforcing shared-glapi, and - link the dri modules against libglapi.so, add --no-undefined to the LDFLAGS - drop the dlopen(libglapi.so/libGL.so, RTLD_GLOBAL) workarounds in the loaders - libGL, libEGL and libgbm. - start killing off/clean

[Mesa-dev] [PATCH 06/11] configure: error out when building backend-less libEGL

2015-06-19 Thread Emil Velikov
Signed-off-by: Emil Velikov --- configure.ac | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 677fb5b..8e62bd8 100644 --- a/configure.ac +++ b/configure.ac @@ -1542,8 +1542,12 @@ if test "x$enable_egl" = xyes; then if test "$enab

[Mesa-dev] [PATCH 02/11] drivers/x11: fix the build against shared_glapi

2015-06-19 Thread Emil Velikov
Cc: Brian Paul Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/Makefile.am | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am index c0596f8..a8847e8 100644 --- a/src/mesa/drivers/x11/Makefile.am +++ b/src/mesa/drive

[Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

2015-06-19 Thread Emil Velikov
Hi all, A lovely series inspired (more like 'was awaken to send these out') by Pal Rohár, who was having issues when building xlib-libgl (plus the now enabled gles*) So here, we teach the final two static glapi users about shared-glapi, plus some related fixes. After this is done we can finally

Re: [Mesa-dev] [PATCH] bugzilla_mesa.sh: sort the bugs list by number

2015-06-19 Thread Ilia Mirkin
I don't suppose you tested this... you probably just want 'sort -n -u' instead of 'sort-n (which doesn't exist) | uniq'. Double-check that it works though, not sure if it'll work with the number at the end. But it might. On Fri, Jun 19, 2015 at 3:41 PM, Emil Velikov wrote: > Cc: "10.5 10.6" > Su

[Mesa-dev] [PATCH] bugzilla_mesa.sh: sort the bugs list by number

2015-06-19 Thread Emil Velikov
Cc: "10.5 10.6" Suggested-by: Ilia Mirkin Signed-off-by: Emil Velikov --- bin/bugzilla_mesa.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/bugzilla_mesa.sh b/bin/bugzilla_mesa.sh index 491ca0e..9b0cbbc 100755 --- a/bin/bugzilla_mesa.sh +++ b/bin/bugzilla_mesa.sh @@ -

Re: [Mesa-dev] [PATCH 3/3] egl/main: expose the EGL_RECORDABLE_ANDROID extension

2015-06-19 Thread Emil Velikov
Hi Chih-Wei, On 19 June 2015 at 17:50, Chih-Wei Huang wrote: > Signed-off-by: Chih-Wei Huang > --- > src/egl/main/eglconfig.c | 5 - > src/egl/main/eglconfig.h | 2 ++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c > in

Re: [Mesa-dev] [PATCH v2 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Emil Velikov
Hi Chih-Wei, On 19 June 2015 at 19:00, Chih-Wei Huang wrote: > If build with C++11 standard, use std::unordered_set. > > Otherwise if build on old Android version with stlport, > use std::tr1::unordered_set with a wrapper class. > > Otherwise use std::tr1::unordered_set. > > Signed-off-by: Chih-We

Re: [Mesa-dev] [PATCH] gbm: dlopen libglapi so gbm_create_device works

2015-06-19 Thread Emil Velikov
Hi Franks, On 9 November 2014 at 15:17, Frank Henigman wrote: > On Sat, Nov 8, 2014 at 7:13 PM, Emil Velikov wrote: >> On 06/11/14 21:29, Frank Henigman wrote: >>> From: Frank Henigman >>> >>> Dri driver libs are not linked to pull in libglapi so gbm_create_device() >>> fails when it tries to d

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Dylan Baker
This one is reviewed too. I'm on my phone and typing the reviewed by is hard though, so you'll have to copy from the last one. I'm currently in the process of writing a series to replace the mesa XML with the khronos XML, and as part of that I was planning to rewrite the underlying representation

Re: [Mesa-dev] [PATCH 1/2] glapi: gl_table.py: remove unused variable 'es'

2015-06-19 Thread Dylan Baker
I was planning to do this too. Reviewed-by: Dylan Baker On Jun 19, 2015 5:17 AM, "Emil Velikov" wrote: > None of the three build systems ever set it, as such we can clear things > up a bit. > > Cc: Dylan Baker > Cc: Jose Fonseca > Signed-off-by: Emil Velikov > --- > src/mapi/glapi/gen/gl_

Re: [Mesa-dev] [PATCH v2 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Chih-Wei Huang
2015-06-20 2:05 GMT+08:00 Ilia Mirkin : > The nouveau bits are > > Reviewed-by: Ilia Mirkin > > If someone can say something non-negative-sounding about the > Android.mk change, happy to push this out. [I assume there's some > reason why it's part of this change.] About the Android.mk change, ori

Re: [Mesa-dev] [PATCH] mesa: move ARB_gs5 enums to core, EXT_polygon_offset_clamp to desktop

2015-06-19 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Ilia Mirkin
The nouveau bits are Reviewed-by: Ilia Mirkin If someone can say something non-negative-sounding about the Android.mk change, happy to push this out. [I assume there's some reason why it's part of this change.] On Fri, Jun 19, 2015 at 2:00 PM, Chih-Wei Huang wrote: > If build with C++11 standa

[Mesa-dev] [PATCH v2 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Chih-Wei Huang
If build with C++11 standard, use std::unordered_set. Otherwise if build on old Android version with stlport, use std::tr1::unordered_set with a wrapper class. Otherwise use std::tr1::unordered_set. Signed-off-by: Chih-Wei Huang --- Android.common.mk | 2 +- s

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix counting of varyings.

2015-06-19 Thread Brian Paul
Both look good to me, but perhaps Ian should check too. Reviewed-by: Brian Paul On 06/19/2015 07:08 AM, Jose Fonseca wrote: When input and output varyings started to be counted separately (commit 42305fb5) the is_varying_var function wasn't updated to return true for output varyings or input

[Mesa-dev] [PATCH v2 04/17] i965/fs: Explicitly set the exec_size on the add(32) in interpolation setup

2015-06-19 Thread Jason Ekstrand
Soon we will start using the builder to explicitly set all the execution sizes. We could make a 32-wide builder, but the builder asserts that we never grow it which is usually a reasonable assumption. Sinc this one instruction is a bit of an odd-ball, we just set the exec_size explicitly. v2: Ex

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Ilia Mirkin
On Fri, Jun 19, 2015 at 1:19 PM, Chih-Wei Huang wrote: > 2015-06-20 1:01 GMT+08:00 Ilia Mirkin : >> Wouldn't it be simpler to just have >> >> codegen/unordered_set.h >> >> which in turn has all the odd logic? I'm definitely a tad unhappy >> about adding "using" in a header, but if the using goes i

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Chih-Wei Huang
2015-06-20 1:01 GMT+08:00 Ilia Mirkin : > Wouldn't it be simpler to just have > > codegen/unordered_set.h > > which in turn has all the odd logic? I'm definitely a tad unhappy > about adding "using" in a header, but if the using goes inside the > nv50_ir namespace, I'm less weirded out by it. And t

Re: [Mesa-dev] [PATCH] i965/gen8: Use HALIGN_16 for single sample mcs buffers

2015-06-19 Thread Mark Janes
Tested-by: Mark Janes Ben Widawsky writes: > The original code meant to do this, but was only checking num_samples == 1 to > figure out if a surface was fast clear capable. However, we can allocate > single > sample miptrees with num_samples == 0 (when it's an internally created > buffer). >

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Ilia Mirkin
Wouldn't it be simpler to just have codegen/unordered_set.h which in turn has all the odd logic? I'm definitely a tad unhappy about adding "using" in a header, but if the using goes inside the nv50_ir namespace, I'm less weirded out by it. And then effectively all 3 become nv50_ir::unordered_set,

Re: [Mesa-dev] [PATCH v2 08/15] egl/main: let EGL_RECORDABLE_ANDROID be a valid attrib

2015-06-19 Thread Chih-Wei Huang
2015-06-09 4:17 GMT+08:00 Eric Anholt : > Chih-Wei Huang writes: >> --- >> src/egl/main/eglconfig.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h >> index 84cb227..7121b3d 100644 >> --- a/src/egl/main/eglconfig.h >> +++ b/src/egl

[Mesa-dev] [PATCH 2/3] android: avoid building errors with stlport

2015-06-19 Thread Chih-Wei Huang
The gallium debugging helpers have defined the assert macro. It causes some errors when build with Android stlport. To workaround it, do not include assert.h if the assert macro has been defined. Signed-off-by: Chih-Wei Huang --- src/gallium/auxiliary/util/u_math.h | 2 ++ src/util/list.h

Re: [Mesa-dev] [PATCH v2 12/15] nv50/ir: optimize the use of std::tr1::unordered_set

2015-06-19 Thread Chih-Wei Huang
2015-05-21 0:10 GMT+08:00 Ilia Mirkin : >> >> If this is required for compatibility reasons with old Android systems I >> suggest you wrap it under a preprocessor conditional like: >> >> #if __cplusplus >= 201103L >> using std::unordered_set; >> #elif building-on-old-android-version-with-broken-stl

[Mesa-dev] [PATCH 3/3] egl/main: expose the EGL_RECORDABLE_ANDROID extension

2015-06-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/main/eglconfig.c | 5 - src/egl/main/eglconfig.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c index cf65c69..d9971ed 100644 --- a/src/egl/main/eglconfig.c +++ b/src/egl/main/

[Mesa-dev] [PATCH 0/3] Updated Android patches

2015-06-19 Thread Chih-Wei Huang
Most of the Android patches I submitted last time were merged. The omitted patches are updated to address the review comments I got so far. Tested OK with Android-x86 lollipop-x86 and kitkat-x86 branches. Chih-Wei Huang (3): nv50/ir: support different unordered_set implementations android: av

[Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Chih-Wei Huang
If build with C++11 standard, use std::unordered_set. Otherwise if build on old Android version with stlport, use std::tr1::unordered_set with a wrapper class. Otherwise use std::tr1::unordered_set. Signed-off-by: Chih-Wei Huang --- Android.common.mk | 1 + sr

Re: [Mesa-dev] [PATCH] u_vbuf: fix src_offset alignment in u_vbuf_create_vertex_elements()

2015-06-19 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 19, 2015 at 4:39 PM, Brian Paul wrote: > If the driver says PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY=1, > the driver should never receive a pipe_vertex_element::src_offset value > that's not a multiple of four. But the vbuf code wasn't ac

[Mesa-dev] [PATCH] mesa: move ARB_gs5 enums to core, EXT_polygon_offset_clamp to desktop

2015-06-19 Thread Ilia Mirkin
When adding EXT_polygon_offset_clamp, I first made it core-only, and never moved the enum getter back to the GL/GL_CORE section. Similarly, ARB_gs5 is a core-only extension, so move its getters to the GL_CORE section. Signed-off-by: Ilia Mirkin --- src/mesa/main/get_hash_params.py | 16 -

[Mesa-dev] [PATCH] u_vbuf: fix src_offset alignment in u_vbuf_create_vertex_elements()

2015-06-19 Thread Brian Paul
If the driver says PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY=1, the driver should never receive a pipe_vertex_element::src_offset value that's not a multiple of four. But the vbuf code wasn't actually adjusting the src_offset value when creating the vertex element state object. We jus

Re: [Mesa-dev] [PATCH 04/17] i965/fs: Explicitly set the exec_size on the add(32) in interpolation setup

2015-06-19 Thread Jason Ekstrand
On Jun 19, 2015 5:09 AM, "Iago Toral" wrote: > > On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote: > > Soon we will start using the builder to explicitly set all the execution > > sizes. We could make a 32-wide builder, but the builder asserts that we > > never grow it which is usually a r

Re: [Mesa-dev] [PATCH v3 2/2] nvc0: use NV_VRAM_DOMAIN() macro

2015-06-19 Thread Ilia Mirkin
On Fri, Jun 19, 2015 at 6:02 AM, Alexandre Courbot wrote: > Use the newly-introduced NV_VRAM_DOMAIN() macro to support alternative > VRAM domains for chips that do not have dedicated video memory. > > Signed-off-by: Alexandre Courbot > --- > src/gallium/drivers/nouveau/nouveau_buffer.c

[Mesa-dev] [PATCH 1/2] glsl: Specify the shader stage in linker errors due to too many in/outputs.

2015-06-19 Thread Jose Fonseca
--- src/glsl/link_varyings.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 7b2d4bd..278a778 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -1540,13 +1540,15 @@ check_agai

[Mesa-dev] [PATCH 2/2] glsl: Fix counting of varyings.

2015-06-19 Thread Jose Fonseca
When input and output varyings started to be counted separately (commit 42305fb5) the is_varying_var function wasn't updated to return true for output varyings or input varyings for stages other than the fragment shader), effectively making the varying limit to never be checked. With this change,

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

2015-06-19 Thread Emil Velikov
On 18/06/15 23:35, Jason Ekstrand wrote: > We should also pull in Chris' 3-patch drawbuffers series if it applies: > > http://lists.freedesktop.org/archives/mesa-dev/2015-June/085851.html > Seems like these never made it to mesa-stable nor have 10.5 in the commit msg. So... I've missed them :-(

Re: [Mesa-dev] [Nouveau] [PATCH v3 0/2] nouveau: support for custom VRAM domains

2015-06-19 Thread Ben Skeggs
On 19 June 2015 at 21:51, Martin Peres wrote: > On 19/06/2015 13:02, Alexandre Courbot wrote: >> >> New revision of this patchset that prevents VRAM objects from being >> allocated on VRAM-less systems like Tegra. This is required for Mesa >> to work on such systems. >> >> Changes since v2: >> - U

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Jose Fonseca
I only did minor tweaks to these files, but the series LGTM. Reviewed-by: Jose Fonseca On 19/06/15 13:21, Emil Velikov wrote: Identical to the previous commit - unused by neither the Autotools, Android or SCons build. XXX: There are no more users of gl_api.filter_functions_by_api(). Should w

[Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Emil Velikov
Identical to the previous commit - unused by neither the Autotools, Android or SCons build. XXX: There are no more users of gl_api.filter_functions_by_api(). Should we just nuke it ? Cc: Dylan Baker Cc: Jose Fonseca Signed-off-by: Emil Velikov --- src/mapi/glapi/gen/remap_helper.py | 8

[Mesa-dev] [PATCH 1/2] glapi: gl_table.py: remove unused variable 'es'

2015-06-19 Thread Emil Velikov
None of the three build systems ever set it, as such we can clear things up a bit. Cc: Dylan Baker Cc: Jose Fonseca Signed-off-by: Emil Velikov --- src/mapi/glapi/gen/gl_table.py | 57 ++ 1 file changed, 8 insertions(+), 49 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH 04/17] i965/fs: Explicitly set the exec_size on the add(32) in interpolation setup

2015-06-19 Thread Iago Toral
On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote: > Soon we will start using the builder to explicitly set all the execution > sizes. We could make a 32-wide builder, but the builder asserts that we > never grow it which is usually a reasonable assumption. Sinc this one > instruction is a

[Mesa-dev] building mesa using gcc complier on windows

2015-06-19 Thread Sreerama V
Hi All, I am trying to build the mesa using scons on windows using gcc compiler but I am getting the error "The command line is too long". Can anyone help me in this? Regards Sreerama V [DISCLAIMER : This message is sent confidentially. It is for the use of the named recipient(s) only. If you

Re: [Mesa-dev] [PATCH v3 0/2] nouveau: support for custom VRAM domains

2015-06-19 Thread Martin Peres
On 19/06/2015 13:02, Alexandre Courbot wrote: New revision of this patchset that prevents VRAM objects from being allocated on VRAM-less systems like Tegra. This is required for Mesa to work on such systems. Changes since v2: - Use vram_size to detect systems without VRAM and set the correct

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-06-19 Thread Emil Velikov
On 19 June 2015 at 00:05, Julien Isorce wrote: > Sorry for removing the XXX line. Original message is here: > https://bugs.freedesktop.org/attachment.cgi?id=115539 > > At the time src/glx/apple/apple_glapi.c has been developed this patch was > not needed I guess so I wonder which change made the r

Re: [Mesa-dev] [PATCH] nvc0: create screen fence objects with coherent attribute

2015-06-19 Thread Martin Peres
On 19/06/2015 11:56, Alexandre Courbot wrote: This is required on non-coherent architectures to ensure the value of the fence is correct at all times. Failure to do this results in the display freezing for a few seconds every now and then on Tegra. The NOUVEAU_BO_COHERENT is a no-op for coherent

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

2015-06-19 Thread Emil Velikov
On 19 June 2015 at 00:23, Julien Isorce wrote: > On 18 June 2015 at 19:33, Emil Velikov wrote: >> >> On 18 June 2015 at 19:29, Emil Velikov wrote: >> Sorry about that. Unintentionally hit send ;-\ >> >> > On 18 June 2015 at 06:53, Julien Isorce wrote: >> >> CC egl_dri2.lo >> >> include/EG

Re: [Mesa-dev] [PATCH 3/5] egl/dri2: load libglapi.0.dylib on osx

2015-06-19 Thread Emil Velikov
On 19 June 2015 at 00:14, Julien Isorce wrote: > On 18 June 2015 at 19:29, Emil Velikov wrote: >> >> On 18 June 2015 at 06:53, Julien Isorce wrote: >> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90903 >> > Signed-off-by: Julien Isorce >> > --- >> > src/egl/drivers/dri2/egl_dri2.c

Re: [Mesa-dev] [PATCH 03/17] i965/fs: Report the right value in fs_inst::regs_read() for PIXEL_X/Y

2015-06-19 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index ce56657..4f

Re: [Mesa-dev] [PATCH 01/46] drirc: drop support for Heaven 3.0, fixes tessellation in 4.0

2015-06-19 Thread Kenneth Graunke
I made some comments, but assuming those are taken care of, patches 1-22 are: Reviewed-by: Kenneth Graunke I plan on reviewing the rest, but probably not tonight. Thanks for picking this up! signature.asc Description: This is a digitally signed message part. ___

Re: [Mesa-dev] [PATCH 03/46] mesa: add tessellation shader structs

2015-06-19 Thread Kenneth Graunke
On Wednesday, June 17, 2015 01:00:59 AM Marek Olšák wrote: > From: Fabian Bieler > > Marek: remove unused members, cleanup > --- > src/mesa/main/mtypes.h | 105 > + > 1 file changed, 105 insertions(+) > > diff --git a/src/mesa/main/mtypes.h b/src

Re: [Mesa-dev] [PATCH 22/46] glsl: add the patch in/out qualifier

2015-06-19 Thread Kenneth Graunke
On Wednesday, June 17, 2015 01:01:18 AM Marek Olšák wrote: > From: Fabian Bieler > > --- > src/glsl/ast.h| 1 + > src/glsl/ast_to_hir.cpp | 45 > src/glsl/ast_type.cpp | 3 +- > src/glsl/builtin_variables.cp

Re: [Mesa-dev] [PATCH 20/46] glsl: add tessellation shader parsing support.

2015-06-19 Thread Kenneth Graunke
On Wednesday, June 17, 2015 01:01:16 AM Marek Olšák wrote: > From: Fabian Bieler > > --- > src/glsl/ast.h | 54 +++- > src/glsl/ast_to_hir.cpp | 133 > +++- > src/glsl/ast_type.cpp | 112

[Mesa-dev] [PATCH v3 2/2] nvc0: use NV_VRAM_DOMAIN() macro

2015-06-19 Thread Alexandre Courbot
Use the newly-introduced NV_VRAM_DOMAIN() macro to support alternative VRAM domains for chips that do not have dedicated video memory. Signed-off-by: Alexandre Courbot --- src/gallium/drivers/nouveau/nouveau_buffer.c | 6 ++ src/gallium/drivers/nouveau/nv50/nv50_miptree.c|

[Mesa-dev] [PATCH v3 0/2] nouveau: support for custom VRAM domains

2015-06-19 Thread Alexandre Courbot
New revision of this patchset that prevents VRAM objects from being allocated on VRAM-less systems like Tegra. This is required for Mesa to work on such systems. Changes since v2: - Use vram_size to detect systems without VRAM and set the correct domain instead of expecting each chip to set its

[Mesa-dev] [PATCH v3 1/2] nouveau: support for custom VRAM domains

2015-06-19 Thread Alexandre Courbot
Some GPUs (e.g. GK20A, GM20B) do not embed VRAM of their own and use the system memory as a backend instead. For such systems, allocating objects in VRAM results in errors since the kernel will not allow VRAM objects allocations. This patch adds a vram_domain member to struct nouveau_screen that c

Re: [Mesa-dev] [PATCH 02/17] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

2015-06-19 Thread Iago Toral
On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote: > Previously, fs_inst::regs_read() fell back to depending on the register > width for the second source. This isn't really correct since it isn't a > SIMD8 value at all, but a SIMD4x2 value. This commit changes it to > explicitly be always

Re: [Mesa-dev] [PATCH 19/46] mesa: don't allow drawing with tess ctrl shader and without tess eval shader

2015-06-19 Thread Kenneth Graunke
On Wednesday, June 17, 2015 01:01:15 AM Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/api_validate.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c > index 401120a..9a5ac69 100644 > --- a

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-19 Thread Jose Fonseca
On 19/06/15 04:46, Ian Romanick wrote: On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa software rendere

Re: [Mesa-dev] [PATCH 01/17] i965/fs: Use a switch statement in fs_inst::regs_read()

2015-06-19 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote: > This makes things a little simpler, more efficient, and quite a bit more > readable. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 45 > ++-- > 1 file changed, 23 insertio

  1   2   >