2015-06-20 1:01 GMT+08:00 Ilia Mirkin <imir...@alum.mit.edu>: > Wouldn't it be simpler to just have > > codegen/unordered_set.h > > which in turn has all the odd logic? I'm definitely a tad unhappy > about adding "using" in a header, but if the using goes inside the > nv50_ir namespace, I'm less weirded out by it. And then effectively > all 3 become nv50_ir::unordered_set, instead of the current situation > with 2 ::unordered_set and 1 nv50_ir::unordered_set.
Well, I think the style is suggested by Francisco. Let me make sure. Do you hope me to move all #if ... #elif ... #else logic into codegen/unordered_set.h, and keep the "using" in nv50_ir namespace only? > By the way, I'm about to add some unordered_map usage. Is this going > to explode the world for android as well? Something like Probably... Will try it once it pushed. > https://github.com/imirkin/mesa/commit/c6dc6fd6ad19f152a53c58bac93c9aadd6958ae7 > but I'm still making sure I have a full understanding of the > underlying issue, so might be a little while before I push. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
