Chih-Wei Huang <cwhu...@android-x86.org> writes: The commit message needs some explanation: Why are we doing this? What does EGL_ANDROID_recordable get us, if we don't have any configs exposing it? What tests do we have for it?
> Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw>
> ---
> src/egl/main/eglconfig.c | 5 ++++-
> src/egl/main/eglconfig.h | 2 ++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c
> index cf65c69..d9971ed 100644
> --- a/src/egl/main/eglconfig.c
> +++ b/src/egl/main/eglconfig.c
> @@ -245,7 +245,10 @@ static const struct {
> /* extensions */
> { EGL_Y_INVERTED_NOK, ATTRIB_TYPE_BOOLEAN,
> ATTRIB_CRITERION_EXACT,
> - EGL_DONT_CARE }
> + EGL_DONT_CARE },
> + { EGL_RECORDABLE_ANDROID, ATTRIB_TYPE_BOOLEAN,
> + ATTRIB_CRITERION_EXACT,
> + EGL_DONT_CARE },
> };
>
>
> diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h
> index 84cb227..7121b3d 100644
> --- a/src/egl/main/eglconfig.h
> +++ b/src/egl/main/eglconfig.h
> @@ -86,6 +86,7 @@ struct _egl_config
>
> /* extensions */
> EGLint YInvertedNOK;
> + EGLint RecordableAndroid;
> };
>
>
> @@ -133,6 +134,7 @@ _eglOffsetOfConfig(EGLint attr)
> ATTRIB_MAP(EGL_CONFORMANT, Conformant);
> /* extensions */
> ATTRIB_MAP(EGL_Y_INVERTED_NOK, YInvertedNOK);
> + ATTRIB_MAP(EGL_RECORDABLE_ANDROID, RecordableAndroid);
> #undef ATTRIB_MAP
> default:
> return -1;
You're not exposing the extension in _eglCreateExtensionsString(), and
nobody should use (or be able to use) the extension without that.
It also looks like you're missing the bits _eglIsConfigAttribValid()
code to see if the extension is exposed before supporting the new enum.
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
