[Mesa-dev] [Bug 66806] [softpipe] glxgears floating point exception

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66806 j...@openbsd.org changed: What|Removed |Added CC||j...@openbsd.org --- Comment #11 from

[Mesa-dev] [Bug 67587] floating point exception with softpipe

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67587 j...@openbsd.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] draw: inject frontface info into wireframe outputs

2013-07-31 Thread Zack Rusin
> > + if (draw_will_inject_frontface(lp_context->draw) && > I think it's annoying you have to do these calls to determine if there's > a valid frontface here for each line instead of just per draw call but > it doesn't seem easy to avoid it. Yea, there's no trivial way of avoiding it. > Also, n

Re: [Mesa-dev] [PATCH 07/34] mesa: account for geometry shader texture fetches in update_texture_state

2013-07-31 Thread Paul Berry
On 31 July 2013 18:07, Ian Romanick wrote: > Patches 7, 9 (with Ken's suggestions), 10, 12, 13, 14, 15 (with the one > nit accounted... 18 and perhaps other have the same issue), 17, 18, 19, 20, > 21, 22, 27, 28, 29 (though my question may affect 29 & 30), 30, 31, 32 > (with minor nits), 33, and

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Paul Berry
On 31 July 2013 20:41, Kenneth Graunke wrote: > On 07/31/2013 05:16 PM, Ian Romanick wrote: > >> On 07/30/2013 03:16 PM, Kenneth Graunke wrote: >> >>> This code is getting ugly. It looks like the idea is to allocate two >>> (now three) separate arrays, but somebody decided to be "clever" and >>>

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Kenneth Graunke
On 07/31/2013 05:16 PM, Ian Romanick wrote: On 07/30/2013 03:16 PM, Kenneth Graunke wrote: This code is getting ugly. It looks like the idea is to allocate two (now three) separate arrays, but somebody decided to be "clever" and batch them into a single calloc/free big enough to hold all of the

Re: [Mesa-dev] [v8] EXT_image_dma_buf_import for intel

2013-07-31 Thread Ian Romanick
Patches 1-4 are Reviewed-by: Ian Romanick Since these patches have been through the wringer, you should go ahead and land these four... even if the other 5 still have to wait. On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: The set introduces new target for 'eglCreateImageKHR()' allowing on

[Mesa-dev] [Bug 66850] glGenerateMipmap crashes when using GL_TEXTURE_2D_ARRAY with compressed internal format

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66850 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] draw: inject frontface info into wireframe outputs

2013-07-31 Thread Roland Scheidegger
Am 31.07.2013 13:38, schrieb Zack Rusin: > Draw module can decompose primitives into wireframe models, which > is a fancy word for 'lines', unfortunately that decomposition means > that we weren't able to preserve the original front-face info which > could be derived from the original primitives (l

Re: [Mesa-dev] [PATCH 1/8] glsl: Change do_set_program_inouts' is_fragment_shader arg to shader_type.

2013-07-31 Thread Ian Romanick
Patches 1-7 (with some really minor comments) are Reviewed-by: Ian Romanick I need to finish cooking dinner, so I can't give patch 8 the attention that it deserves. On 07/31/2013 02:17 PM, Paul Berry wrote: This will allow us to add geometry shader support without having to add another bool

Re: [Mesa-dev] [PATCH 7/8] glsl: In ir_set_program_inouts, handle indexing outside array/matrix bounds.

2013-07-31 Thread Ian Romanick
On 07/31/2013 02:17 PM, Paul Berry wrote: According to GLSL, indexing into an array or matrix with an out-of-range constant results in a compile error. However, indexing with an out-of-range value that isn't constant merely results in undefined results. Since optimization passes (e.g. loop unro

Re: [Mesa-dev] [PATCH 32/34] glsl: Allow geometry shader input instance arrays to be unsized.

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:03 PM, Paul Berry wrote: --- src/glsl/ast.h | 24 src/glsl/ast_to_hir.cpp | 31 +-- src/glsl/glsl_parser.yy | 11 --- 3 files changed, 49 insertions(+), 17 deletions(-) diff --git a/src/glsl/ast.h b/src/g

Re: [Mesa-dev] [PATCH 5/8] glsl: Extract marking functions from ir_set_program_inouts.

2013-07-31 Thread Ian Romanick
On 07/31/2013 02:17 PM, Paul Berry wrote: This patch extracts the functions mark_whole_variable() and try_mark_partial_variable() from the ir_set_program_inouts visitor functions. This will make the code easier to follow when we add geometry shader support. --- src/glsl/ir_set_program_inouts.c

Re: [Mesa-dev] [PATCH 07/34] mesa: account for geometry shader texture fetches in update_texture_state

2013-07-31 Thread Ian Romanick
Patches 7, 9 (with Ken's suggestions), 10, 12, 13, 14, 15 (with the one nit accounted... 18 and perhaps other have the same issue), 17, 18, 19, 20, 21, 22, 27, 28, 29 (though my question may affect 29 & 30), 30, 31, 32 (with minor nits), 33, and 34 (with a minor nit). Reviewed-by: Ian Romanick

Re: [Mesa-dev] [PATCH 34/34] main: Warn that geometry shader support is experimental.

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:04 PM, Paul Berry wrote: Geometry shader support in the Mesa front end is still fairly preliminary. Many features are untested, and the following things are known not to work: - The gl_in interface block - The gl_ClipDistance input - Transform feedback of geometry shader output

Re: [Mesa-dev] [PATCH 33/34] glsl: Implement rules for geometry shader input sizes.

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:03 PM, Paul Berry wrote: Section 4.3.8.1 (Input Layout Qualifiers) of the GLSL 1.50 spec contains some tricky rules for how the sizes of geometry shader input arrays are related to the input layout specification. In essence, those rules boil down to the following: - If an input

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: make the front-face behavior match the gallium spec

2013-07-31 Thread Roland Scheidegger
Am 31.07.2013 13:38, schrieb Zack Rusin: > The spec says that front-face is true if the value is >0 and false > if it's <0. To make sure that we follow the spec, lets just > subtract 0.5 from our value (llvmpipe did 1 for frontface and 0 > otherwise), which will get us a positive num for frontface

Re: [Mesa-dev] [PATCH 29/34] glsl: Export the compiler's GS layout qualifiers to the gl_shader.

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:03 PM, Paul Berry wrote: From: Eric Anholt Next step is to validate them at link time. v2 (Paul Berry ): Don't attempt to export the layout qualifiers in the event of a compile error, since some of them are set up by ast_to_hir(), and ast_to_hir() isn't guaranteed to have run

[Mesa-dev] [PATCH 2/2] draw: inject frontface info into wireframe outputs

2013-07-31 Thread Zack Rusin
Draw module can decompose primitives into wireframe models, which is a fancy word for 'lines', unfortunately that decomposition means that we weren't able to preserve the original front-face info which could be derived from the original primitives (lines don't have a 'face'). To fix it allow draw m

[Mesa-dev] [PATCH 1/2] llvmpipe: make the front-face behavior match the gallium spec

2013-07-31 Thread Zack Rusin
The spec says that front-face is true if the value is >0 and false if it's <0. To make sure that we follow the spec, lets just subtract 0.5 from our value (llvmpipe did 1 for frontface and 0 otherwise), which will get us a positive num for frontface and negative for backface. Signed-off-by: Zack R

Re: [Mesa-dev] [PATCH 15/34] glsl/linker: Properly error check VS-GS linkage.

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:03 PM, Paul Berry wrote: From section 4.3.4 (Inputs) of the GLSL 1.50 spec: Geometry shader input variables get the per-vertex values written out by vertex shader output variables of the same names. Since a geometry shader operates on a set of vertices, each inpu

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Ian Romanick
On 07/30/2013 03:16 PM, Kenneth Graunke wrote: On 07/28/2013 11:03 PM, Paul Berry wrote: From: Bryan Cain This commit adds all of the parsing and semantics for GLSL 150 style geometry shaders. v2 (Paul Berry ): Adjust i965's brw_link_shader() to pass the new is_geometry_shader argument to do_

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:03 PM, Paul Berry wrote: From: Bryan Cain This commit adds all of the parsing and semantics for GLSL 150 style geometry shaders. v2 (Paul Berry ): Adjust i965's brw_link_shader() to pass the new is_geometry_shader argument to do_set_program_inouts. Add a few missing calls to

Re: [Mesa-dev] [PATCH] egl/dri2: support for creating images out of dma buffers

2013-07-31 Thread Chad Versace
On 07/31/2013 04:23 PM, Chad Versace wrote: On 07/29/2013 10:08 PM, Pohjolainen, Topi wrote: On Mon, Jul 29, 2013 at 11:59:08AM -0700, Chad Versace wrote: On 07/25/2013 11:17 PM, Topi Pohjolainen wrote: v2: - upon success close the given file descriptors v3: - use specific entry for d

Re: [Mesa-dev] [PATCH] egl/dri2: support for creating images out of dma buffers

2013-07-31 Thread Chad Versace
On 07/29/2013 10:08 PM, Pohjolainen, Topi wrote: On Mon, Jul 29, 2013 at 11:59:08AM -0700, Chad Versace wrote: On 07/25/2013 11:17 PM, Topi Pohjolainen wrote: v2: - upon success close the given file descriptors v3: - use specific entry for dma buffers instead of the basic for pri

Re: [Mesa-dev] [PATCH 05/34] main: Allow for the possibility of GL 3.2 without ARB_geometry_shader4.

2013-07-31 Thread Paul Berry
On 31 July 2013 16:09, Ian Romanick wrote: > On 07/30/2013 09:25 PM, Kenneth Graunke wrote: > >> On 07/30/2013 07:30 PM, Paul Berry wrote: >> >>> On 29 July 2013 11:17, Kenneth Graunke >> **> wrote: >>> >>> On 07/28/2013 11:03 PM, Paul Berry wrote: >>> >>>

Re: [Mesa-dev] [PATCH 01/34] glsl/linker: Make update_array_sizes apply to just uniforms.

2013-07-31 Thread Ian Romanick
Patches 1-5 are Reviewed-by: Ian Romanick On 07/28/2013 11:03 PM, Paul Berry wrote: Commit 586b4b5 (glsl: Also update implicit sizes of varyings at link time) extended update_array_sizes() to apply to both uniforms and shader ins/outs. However, doing creates problems for geometry shaders, bec

Re: [Mesa-dev] [PATCH 05/34] main: Allow for the possibility of GL 3.2 without ARB_geometry_shader4.

2013-07-31 Thread Ian Romanick
On 07/30/2013 09:25 PM, Kenneth Graunke wrote: On 07/30/2013 07:30 PM, Paul Berry wrote: On 29 July 2013 11:17, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: On 07/28/2013 11:03 PM, Paul Berry wrote: +/** + * Checks if the context supports geometry shaders.

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vs: set up sampler state pointer for Gen4/5.

2013-07-31 Thread Carl Worth
Chris Forbes writes: > Fixes broken filter and lod selection for vertex texturing. > (txs/txf only worked properly because they ignore the sampler state > completely) > > Signed-off-by: Chris Forbes > Cc: mesa-sta...@lists.freedesktop.org Thanks, Chris. I'd like to pick this (and the following

Re: [Mesa-dev] [PATCH] glsl: Remove shader stage checking for extension handling.

2013-07-31 Thread Ian Romanick
On 07/29/2013 03:33 PM, Matt Turner wrote: On Mon, Jul 29, 2013 at 10:55 AM, Kenneth Graunke wrote: Fixes Piglit tests glslparsertest/glsl2/draw_buffers-05.vert and ARB_draw_instanced/preprocessor/feature-macro-enabled.frag. Let's delete these tests too. I don't think they're useful. I didn

Re: [Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Carl Worth
Kenneth Graunke writes: > commit eed0a80137dfac641adfd39ce316938dbcf2be10 > Author: Eric Anholt > Date: Fri Jun 21 15:34:52 2013 -0700 > > egl: Restore "bogus" DRI2 invalidate event code. > [...] > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63435 > > That fixes a long

Re: [Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Carl Worth
Brian Paul writes: > I think you could also grab this one (which I just pushed): > > commit e5f32a0b3a9f8541f0c8ffc5f303612ac9963bb1 > Author: Brian Paul > Date: Fri Jul 26 09:50:36 2013 -0600 > > mesa: improve free() cleanup in generate_mipmap_compressed() > > Though, it would only matter

Re: [Mesa-dev] [PATCH 13/15] mesa, glsl, st/dri: add a new driconf option force_glsl_version for Unigine

2013-07-31 Thread Marek Olšák
On Wed, Jul 31, 2013 at 12:10 AM, Kenneth Graunke wrote: > On 07/30/2013 02:11 PM, Marek Olšák wrote: >> >> Hi Kenneth, >> >> Sorry I haven't had time to test Heaven 4.0 and I'm currently using >> the radeonsi driver, which only supports GL 2.1, GLSL 1.30, and it >> isn't in good shape to run Heav

Re: [Mesa-dev] [PATCH 6/7] mesa: Validate the layer selection of an array texture too

2013-07-31 Thread Ian Romanick
On 07/31/2013 03:07 PM, Marek Olšák wrote: I think we should also validate the layer for GL_TEXTURE_CUBE_MAP_ARRAY. You are correct. I'll update the patch and the test case. Marek On Wed, Jul 31, 2013 at 10:29 PM, Ian Romanick wrote: From: Ian Romanick Previously only the slice of a 3D

Re: [Mesa-dev] [PATCH 6/7] mesa: Validate the layer selection of an array texture too

2013-07-31 Thread Marek Olšák
I think we should also validate the layer for GL_TEXTURE_CUBE_MAP_ARRAY. Marek On Wed, Jul 31, 2013 at 10:29 PM, Ian Romanick wrote: > From: Ian Romanick > > Previously only the slice of a 3D texture was validated in the FBO > completeness check. This fixes the failure in the 'invalid layer of

[Mesa-dev] [PATCH 6/8] glsl: Fallback gracefully if ir_set_program_inouts sees unexpected indexing.

2013-07-31 Thread Paul Berry
The code in ir_set_program_inouts that marks just a portion of a variable as used (rather than the whole variable) only works on a few kinds of indexing operations: - Indexing into matrices - Indexing into arrays of matrices, vectors, or scalars. Fortunately these are the only kinds of indexing o

[Mesa-dev] [PATCH 8/8] glsl: Modify ir_set_program_inouts to handle geometry shaders.

2013-07-31 Thread Paul Berry
--- src/glsl/ir_set_program_inouts.cpp | 85 -- 1 file changed, 73 insertions(+), 12 deletions(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index 018342b..8f96324 100644 --- a/src/glsl/ir_set_program_inouts.cpp +++ b/

[Mesa-dev] [PATCH 7/8] glsl: In ir_set_program_inouts, handle indexing outside array/matrix bounds.

2013-07-31 Thread Paul Berry
According to GLSL, indexing into an array or matrix with an out-of-range constant results in a compile error. However, indexing with an out-of-range value that isn't constant merely results in undefined results. Since optimization passes (e.g. loop unrolling) can convert non-constant array indice

[Mesa-dev] [PATCH 5/8] glsl: Extract marking functions from ir_set_program_inouts.

2013-07-31 Thread Paul Berry
This patch extracts the functions mark_whole_variable() and try_mark_partial_variable() from the ir_set_program_inouts visitor functions. This will make the code easier to follow when we add geometry shader support. --- src/glsl/ir_set_program_inouts.cpp | 59 +

[Mesa-dev] [PATCH 3/8] glsl: Expand count_attribute_slots() to cover structs.

2013-07-31 Thread Paul Berry
--- src/glsl/glsl_types.cpp | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index 0c639b3..0c7e8eb 100644 --- a/src/glsl/glsl_types.cpp +++ b/src/glsl/glsl_types.cpp @@ -846,13 +846,40 @@ g

[Mesa-dev] [PATCH 4/8] glsl: Use count_attribute_slots() in ir_set_program_inouts.

2013-07-31 Thread Paul Berry
--- src/glsl/ir_set_program_inouts.cpp | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index ef95cbe..351f65b 100644 --- a/src/glsl/ir_set_program_inouts.cpp +++ b/src/glsl/ir_set_program_inouts

[Mesa-dev] [PATCH 2/8] Move count_attribute_slots() out of the linker and into glsl_type.

2013-07-31 Thread Paul Berry
Our previous justification for leaving this function out of glsl_type was that it implemented counting rules that were specific to GLSL 1.50. However, these counting rules also describe the number of varying slots that Mesa will assign to a varying in the absence of varying packing. That's useful

[Mesa-dev] [PATCH 1/8] glsl: Change do_set_program_inouts' is_fragment_shader arg to shader_type.

2013-07-31 Thread Paul Berry
This will allow us to add geometry shader support without having to add another boolean argument. --- src/glsl/ir.h | 2 +- src/glsl/ir_set_program_inouts.cpp | 24 src/mesa/drivers/dri/i965/brw_shader.cpp | 3 +-- src/mesa/program/

Re: [Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Carl Worth
Ian Romanick writes: >> Carl Worth (4): >>docs: Add 9.1.5 release md5sums >>Merge 'origin/9.1' into stable > > What happened here? I had a local "stable" branch from origin/9.1 from which I did all my testing, made the release, and added a commit with the md5sums, etc. In the mea

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Paul Berry
On 30 July 2013 15:16, Kenneth Graunke wrote: > On 07/28/2013 11:03 PM, Paul Berry wrote: > >> @@ -112,14 +111,24 @@ >> ir_set_program_inouts_visitor::visit(ir_dereference_variable *ir) >> return visit_continue; >> >> if (ir->type->is_array()) { >> - mark(this->prog, ir->var, 0,

[Mesa-dev] [PATCH 6/7] mesa: Validate the layer selection of an array texture too

2013-07-31 Thread Ian Romanick
From: Ian Romanick Previously only the slice of a 3D texture was validated in the FBO completeness check. This fixes the failure in the 'invalid layer of an array texture' subtest of piglit's fbo-incomplete test. v2: 1D_ARRAY textures have Depth == 1. Instead, compare against Height. Signed-o

[Mesa-dev] [PATCH 1/7] mesa: Treat glBindRenderbuffer and glBindRenderbufferEXT correctly

2013-07-31 Thread Ian Romanick
From: Ian Romanick Allow user-generated names for glBindRenderbufferEXT on desktop GL. Disallow its use altogether for core profiles. v2: Disallow glBindRenderbufferEXT in 3.1 by not installing it in the dispatch table. Suggested by Jordan. Signed-off-by: Ian Romanick Reviewed-by: Kenneth Gra

[Mesa-dev] [PATCH 3/7] mesa: Remove stray debug printfs in attachment completeness code

2013-07-31 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 0b1e9d8..5d0dff7 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 4/7] mesa: Don't call driver RenderTexture for really broken textures

2013-07-31 Thread Ian Romanick
From: Ian Romanick This fixes the segfault in the '0x0 texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 22 -- 1 file changed, 20 insertions(+), 2

[Mesa-dev] [PATCH 7/7] mesa: Generate a renderbuffer wrapper even if the texture has no image

2013-07-31 Thread Ian Romanick
From: Ian Romanick This prevents a segfault in check_begin_texture_render when an FBO is rebound while in this state. This fixes the piglit test fbo-incomplete-invalid-texture. Signed-off-by: Ian Romanick Acked-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobj

[Mesa-dev] [PATCH 5/7] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-31 Thread Ian Romanick
From: Ian Romanick This fixes the segfault in the 'invalid slice of 3D texture' and 'invalid layer of an array texture' subtests of piglit's fbo-incomplete test. The 'invalid layer of an array texture' subtest still fails. v2: Fix off-by-one comparison error noticed by Chris Forbes. Also, 1D_A

[Mesa-dev] [PATCH 2/7] mesa: Treat glBindFramebuffer and glBindFramebufferEXT more correctly

2013-07-31 Thread Ian Romanick
From: Ian Romanick Allow user-generated names for glBindFramebufferEXT on desktop GL. Disallow its use altogether for core profiles. Names bound with glBindFramebuffer in desktop OpenGL are still (incorrectly) shared across the share group instead of being per-context. This gets us a bit closer

Re: [Mesa-dev] [PATCH] i965: Delete the BATCH_LOCALS macro.

2013-07-31 Thread Matt Turner
On Wed, Jul 31, 2013 at 1:05 PM, Kenneth Graunke wrote: > This hasn't done anything in a long time, and it's only used in a couple > places...which means we couldn't use it without doing a bunch of work > anyway. Reviewed-by: Matt Turner ___ mesa-dev m

[Mesa-dev] [PATCH] i965: Delete the BATCH_LOCALS macro.

2013-07-31 Thread Kenneth Graunke
This hasn't done anything in a long time, and it's only used in a couple places...which means we couldn't use it without doing a bunch of work anyway. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_batchbuffer.h | 4 src/mesa/drivers/dri/i965/intel_blit.c| 2 --

Re: [Mesa-dev] [PATCH 1/4] glsl: Change the lexer's namespace.

2013-07-31 Thread Kenneth Graunke
On 07/31/2013 12:08 AM, Laurent Carlier wrote: Le lundi 29 juillet 2013 16:07:35 Kenneth Graunke a écrit : Bison 3.0 removes the YYLEX_PARAM macro. In preparation for handling this using %lex-param, the parser needs a wrapper function for the actual Flex lex() function. Bugzilla: https://bugs.

Re: [Mesa-dev] [PATCH V5 5/6] i965 Gen4/5: clip: Add support for noperspective varyings

2013-07-31 Thread Chris Forbes
> Your comment here stops mid-sentence. It looks that way, but it's actually complete. I'll reword it so that it doesn't look wrong at a first glance though :) > bools Bad C89 habit... will fix those up :) -- Chris ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Ian Romanick
On 07/30/2013 11:01 PM, Carl Worth wrote: I've just pushed out some updates to the 9.1 branch in preparation for a 9.1.6 release, which I would like to release on August 1, (in two days). A shortlog of the commits on this branch since the 9.1.5 release are included below. I've done my usual rev

Re: [Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Kenneth Graunke
On 07/30/2013 11:01 PM, Carl Worth wrote: I've just pushed out some updates to the 9.1 branch in preparation for a 9.1.6 release, which I would like to release on August 1, (in two days). A shortlog of the commits on this branch since the 9.1.5 release are included below. I've done my usual rev

Re: [Mesa-dev] [PATCH] egl: Restore "bogus" DRI2 invalidate event code.

2013-07-31 Thread Kenneth Graunke
On 06/21/2013 03:34 PM, Eric Anholt wrote: I had removed it in commit 1e7776ca2bc59a6978d9b933d23852d47078dfa8 because it was obviously wrong -- why do we care whether the server is a version that emits events, if we're not watching for the server's events, anyway? And why would you only invalid

Re: [Mesa-dev] [PATCH V5 5/6] i965 Gen4/5: clip: Add support for noperspective varyings

2013-07-31 Thread Kenneth Graunke
On 07/31/2013 04:07 AM, Chris Forbes wrote: [snip] @@ -148,12 +150,107 @@ void brw_clip_interp_vertex( struct brw_clip_compile *c, */ brw_copy_indirect_to_indirect(p, dest_ptr, v0_ptr, 1); - /* Iterate over each attribute (could be done in pairs?) + + /* First handle the 3D and ND

Re: [Mesa-dev] Fwd: [Mesa-users] 9.1.5 ES3 context only supports GLSL ES 1.00 but claims 3.00

2013-07-31 Thread Ian Romanick
On 07/31/2013 06:06 AM, Brian Paul wrote: Original Message Subject: [Mesa-users] 9.1.5 ES3 context only supports GLSL ES 1.00 but claims 3.00 Date: Tue, 30 Jul 2013 20:58:54 + From: To: Hello. The ES3 context in 9.1.5 claims to support GLSL ES 3.0, but actually only supp

[Mesa-dev] [Bug 55503] Constant vertex attributes broken

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55503 Neil Roberts changed: What|Removed |Added CC||n...@linux.intel.com -- You are receivin

[Mesa-dev] [Bug 67587] floating point exception with softpipe

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67587 --- Comment #1 from Roland Scheidegger --- I don't know why 1e003b44e83dde3912ec48eb3df0e25802b5101e wouldn't fix this but since 63386b2f66a6d450889cd5368bc599beb7f1efbf which caused this is in 9.2 branch (I missed this before otherwise I've anno

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-07-31 Thread Tom Stellard
On Wed, Jul 31, 2013 at 01:04:01PM +0200, Michel Dänzer wrote: > > LLVM revision 187139 ('Allocate local registers in order for optimal > coloring.') broke some derivative related piglit tests with the radeonsi > driver. > > I'm attaching a diff between the bad and good generated code (as printe

[Mesa-dev] [Bug 67587] New: floating point exception with softpipe

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67587 Priority: medium Bug ID: 67587 Assignee: mesa-dev@lists.freedesktop.org Summary: floating point exception with softpipe Severity: normal Classification: Unclassified OS: Open

[Mesa-dev] [PATCH v2 2/2] Correct clamping of TEXTURE_{MAX, BASE}_LEVEL

2013-07-31 Thread Corey Richardson
Previously, if TEXTURE_IMMUTABLE_FORMAT was TRUE, the levels were allowed to be set like usual, but ARB_texture_storage states: > if TEXTURE_IMMUTABLE_FORMAT is TRUE, then level_base is clamped to the range > [0, - 1] and level_max is then clamped to the range [level_base, > - 1], where is the

Re: [Mesa-dev] [PATCH v2 1/2] De-tab and align comments in gl_texture_object

2013-07-31 Thread Brian Paul
On 07/31/2013 08:14 AM, Corey Richardson wrote: Signed-off-by: Corey Richardson --- src/mesa/main/mtypes.h | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index aba7d84..97c4dd7

[Mesa-dev] [PATCH v2 1/2] De-tab and align comments in gl_texture_object

2013-07-31 Thread Corey Richardson
Signed-off-by: Corey Richardson --- src/mesa/main/mtypes.h | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index aba7d84..97c4dd7 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/

[Mesa-dev] [Eric Anholt] [PATCH] egl: Restore "bogus" DRI2 invalidate event code.

2013-07-31 Thread anholt
--- Begin Message --- I had removed it in commit 1e7776ca2bc59a6978d9b933d23852d47078dfa8 because it was obviously wrong -- why do we care whether the server is a version that emits events, if we're not watching for the server's events, anyway? And why would you only invalidate on a server that em

Re: [Mesa-dev] [PATCH V5 4/6] i965 Gen4/5: clip: correctly handle flat varyings

2013-07-31 Thread Paul Berry
On 31 July 2013 04:07, Chris Forbes wrote: > Previously we only gave special treatment to the builtin color varyings. > This patch adds support for arbitrary flat-shaded varyings, which is > required for GLSL 1.30. > > Based on Olivier Galibert's patch from last year: > http://lists.freedesktop.o

Re: [Mesa-dev] [PATCH V5 3/6] i965 Gen4/5: Generalize SF interpolation setup for GLSL1.3

2013-07-31 Thread Paul Berry
On 31 July 2013 04:07, Chris Forbes wrote: > Previously the SF only handled the builtin color varying specially. > This patch generalizes that support to cover user-defined varyings, > driven by the interpolation mode array set up alongside the VUE map. > > Based on the following patches from Oli

[Mesa-dev] [PATCH] gallivm: use nearest rounding for float->unorm24 conversion

2013-07-31 Thread sroland
From: Roland Scheidegger Previously we were using truncation, which gives the correct result only for numbers in [0.5-1.0] range (because there's no mantissa bits to do any rounding there). This is frequently hit (and probably only used there) when converting fragment depth to depth format (d24s8

Re: [Mesa-dev] [PATCH V5 2/6] i965: Add helper functions for interpolation map

2013-07-31 Thread Paul Berry
On 31 July 2013 04:07, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_context.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_context.h > b/src/mesa/drivers/dri/i965/brw_context.h > index 7b5fd

Re: [Mesa-dev] [PATCH 2/2] Correct clamping of TEXTURE_{MAX, BASE}_LEVEL

2013-07-31 Thread Brian Paul
On 07/31/2013 05:19 AM, Corey Richardson wrote: Previously, if TEXTURE_IMMUTABLE_FORMAT was TRUE, the levels were allowed to be set like usual, but ARB_texture_storage states: if TEXTURE_IMMUTABLE_FORMAT is TRUE, then level_base is clamped to the range [0, - 1] and level_max is then clamped to

Re: [Mesa-dev] [PATCH 1/2] De-tab and align comments in gl_texture_object

2013-07-31 Thread Brian Paul
On 07/31/2013 05:19 AM, Corey Richardson wrote: Signed-off-by: Corey Richardson --- src/mesa/main/mtypes.h | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index aba7d84..6113410

[Mesa-dev] [Bug 67516] glTexStorage*() functions don't work properly with proxy textures

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67516 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 4/4] mesa/program: Switch from the deprecated YYLEX_PARAM to %lex-param.

2013-07-31 Thread Laurent Carlier
Attached patch fixes latest failure: program_parse.tab.c:1958:3: error: implicit declaration of function 'YYID' [- Werror=implicit-function-declaration] YYLLOC_DEFAULT (yyloc, (yylsp - yylen), yylen); ^ -- Laurent Carlier ArchLinux Developer http://www.archlinux.org>From e3c19953c2f8ab5afe

Re: [Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Brian Paul
On 07/31/2013 12:01 AM, Carl Worth wrote: I've just pushed out some updates to the 9.1 branch in preparation for a 9.1.6 release, which I would like to release on August 1, (in two days). A shortlog of the commits on this branch since the 9.1.5 release are included below. I've done my usual rev

[Mesa-dev] Candidate branch for upcoming 9.1.6

2013-07-31 Thread Carl Worth
I've just pushed out some updates to the 9.1 branch in preparation for a 9.1.6 release, which I would like to release on August 1, (in two days). A shortlog of the commits on this branch since the 9.1.5 release are included below. I've done my usual review and testing of this branch, (where my te

[Mesa-dev] Fwd: [Mesa-users] 9.1.5 ES3 context only supports GLSL ES 1.00 but claims 3.00

2013-07-31 Thread Brian Paul
Original Message Subject: [Mesa-users] 9.1.5 ES3 context only supports GLSL ES 1.00 but claims 3.00 Date: Tue, 30 Jul 2013 20:58:54 + From: To: Hello. The ES3 context in 9.1.5 claims to support GLSL ES 3.0, but actually only supports ES 1.00. This is quite irritating

Re: [Mesa-dev] [PATCH] mesa: improve free() cleanup in generate_mipmap_compressed()

2013-07-31 Thread Brian Paul
On 07/31/2013 01:50 AM, Vinson Lee wrote: On Fri, Jul 26, 2013 at 8:54 AM, Brian Paul wrote: Free all our temporary buffers in one place at the end of the function. Fixes memory leak detected by Coverity. Note: This is a candidate for the 9.x branches Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 2/2] Correct clamping of TEXTURE_{MAX, BASE}_LEVEL

2013-07-31 Thread Corey Richardson
Previously, if TEXTURE_IMMUTABLE_FORMAT was TRUE, the levels were allowed to be set like usual, but ARB_texture_storage states: > if TEXTURE_IMMUTABLE_FORMAT is TRUE, then level_base is clamped to the range > [0, - 1] and level_max is then clamped to the range [level_base, > - 1], where is the

[Mesa-dev] [PATCH 1/2] De-tab and align comments in gl_texture_object

2013-07-31 Thread Corey Richardson
Signed-off-by: Corey Richardson --- src/mesa/main/mtypes.h | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index aba7d84..6113410 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/m

[Mesa-dev] [PATCH V5 6/6] i965 Gen4/5: clip: Don't mangle flat varyings

2013-07-31 Thread Chris Forbes
This patch ensures that integers will pass through unscathed. Doing (useless) computations on them is risky, especially when their bit patterns correspond to values like inf or nan. [V1-2]: Signed-off-by: Olivier Galibert Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/driver

[Mesa-dev] [PATCH V5 5/6] i965 Gen4/5: clip: Add support for noperspective varyings

2013-07-31 Thread Chris Forbes
Adds support for interpolating noperspective varyings linearly in screen space when clipping. Based on Olivier Galibert's patch from last year: http://lists.freedesktop.org/archives/mesa-dev/2012-July/024341.html At this point all -fixed and -vertex interpolation tests work. V5: Add brw_clip_com

[Mesa-dev] [PATCH V5 4/6] i965 Gen4/5: clip: correctly handle flat varyings

2013-07-31 Thread Chris Forbes
Previously we only gave special treatment to the builtin color varyings. This patch adds support for arbitrary flat-shaded varyings, which is required for GLSL 1.30. Based on Olivier Galibert's patch from last year: http://lists.freedesktop.org/archives/mesa-dev/2012-July/024340.html V5: Move key

[Mesa-dev] [PATCH V5 3/6] i965 Gen4/5: Generalize SF interpolation setup for GLSL1.3

2013-07-31 Thread Chris Forbes
Previously the SF only handled the builtin color varying specially. This patch generalizes that support to cover user-defined varyings, driven by the interpolation mode array set up alongside the VUE map. Based on the following patches from Olivier Galibert: - http://lists.freedesktop.org/archives

[Mesa-dev] [PATCH V5 2/6] i965: Add helper functions for interpolation map

2013-07-31 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_context.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index 7b5fd13..9580f29 100644 --- a/src/mesa/drivers/dri/i965/brw_cont

[Mesa-dev] [PATCH V5 1/6] i965 Gen4/5: Introduce 'interpolation map' alongside the VUE map

2013-07-31 Thread Chris Forbes
The interpolation map (in brw->interpolation_mode) is a new auxiliary structure alongside the post-GS VUE map, which describes the interpolation modes for each VUE slot, for use by the clip and SF stages. This patch introduces a new state atom to compute the interpolation map, and adjusts the prog

[Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-07-31 Thread Michel Dänzer
LLVM revision 187139 ('Allocate local registers in order for optimal coloring.') broke some derivative related piglit tests with the radeonsi driver. I'm attaching a diff between the bad and good generated code (as printed with RADEON_DUMP_SHADERS=1) for the glsl-derivs test. The only difference

Re: [Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-31 Thread Jose Fonseca
- Original Message - > On Tue, Jul 30, 2013 at 8:46 PM, Paul Berry wrote: > > On 29 July 2013 11:09, Zack Rusin wrote: > >> > >> That looks wrong to me. We already account for the "other fields" in the > >> vertex_size. > > > > > > This patch came from Bryan Cain's original geometry shade

Re: [Mesa-dev] [PATCH] tgsi: add ucmp to the list of opcodes

2013-07-31 Thread Jose Fonseca
- Original Message - > we forgot to add ucmp to the list of opcodes, so it was never > generated for ureg. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_o

Re: [Mesa-dev] [PATCH] gallivm: obey clarified shift behavior

2013-07-31 Thread Jose Fonseca
- Original Message - > > From: Roland Scheidegger > > > > llvm shifts are undefined for shift counts exceeding (or matching) bit > > width, > > so need to apply a mask for the tgsi shift instructions. > > > > v2: only use mask for the tgsi shift instructions, not for the build shift >

[Mesa-dev] [Bug 55503] Constant vertex attributes broken

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55503 --- Comment #3 from Tapani Pälli --- seems related to bug #66292 -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

[Mesa-dev] [Bug 55503] Constant vertex attributes broken

2013-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55503 --- Comment #2 from Robert Bragg --- Ping? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.o

Re: [Mesa-dev] [PATCH] mesa: improve free() cleanup in generate_mipmap_compressed()

2013-07-31 Thread Vinson Lee
On Fri, Jul 26, 2013 at 8:54 AM, Brian Paul wrote: > Free all our temporary buffers in one place at the end of the > function. Fixes memory leak detected by Coverity. > > Note: This is a candidate for the 9.x branches > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/main/mipmap.c | 17

Re: [Mesa-dev] [PATCH 1/4] glsl: Change the lexer's namespace.

2013-07-31 Thread Laurent Carlier
Le lundi 29 juillet 2013 16:07:35 Kenneth Graunke a écrit : > Bison 3.0 removes the YYLEX_PARAM macro. In preparation for handling > this using %lex-param, the parser needs a wrapper function for the > actual Flex lex() function. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67354 >