On 07/29/2013 10:08 PM, Pohjolainen, Topi wrote:
On Mon, Jul 29, 2013 at 11:59:08AM -0700, Chad Versace wrote:
On 07/25/2013 11:17 PM, Topi Pohjolainen wrote:
v2:
- upon success close the given file descriptors
v3:
- use specific entry for dma buffers instead of the basic for
primes, and enable the extension based on the availability
of the hook
v4 (Chad):
- use ARRAY_SIZE
- improve the comment about the number of file descriptors
- in case of invalid format report EGL_BAD_ATTRIBUTE instead
of EGL_BAD_MATCH
- take into account specific error set by the driver.
v5:
- fix error handling
v6 (Chad):
- fix invalid plane count checking
v7 (Chad):
- fix indentation and reset loop counter before checking
for excess attributes
Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com>
---
src/egl/drivers/dri2/egl_dri2.c | 262 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 262 insertions(+)
Reviewed-by: Chad Versace <chad.vers...@linux.intel.com>
Did I miss review on any of the patches? I think I reviewed them all.
Yes you did, thank you! I guess you'd like to finish reviewing the tests before
I push the series to the master?
The usual routine for committing is:
- Get a reviewed-by by a lead developer on every patch.
- Ensure that no one has a strong objection to the patches.
- Check that the patches do not regress any Piglit tests on
a reasonable set of hardware (where "reasonable" has a very
loose definition).
- If the patches fix a bug or add a new feature, ensure that Piglit
patches have been submitted and that review has begun on them.
Also, check that the Mesa patches make most (preferably all) of
the new tests pass.
It's ok to commit to Mesa before the Piglit tests get committed, as long
as review is going well on the Piglit tests. So...
Commit!
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
