On 07/29/2013 03:33 PM, Matt Turner wrote:
On Mon, Jul 29, 2013 at 10:55 AM, Kenneth Graunke <kenn...@whitecape.org> wrote:
Fixes Piglit tests glslparsertest/glsl2/draw_buffers-05.vert and
ARB_draw_instanced/preprocessor/feature-macro-enabled.frag.
Let's delete these tests too. I don't think they're useful.
I didn't look at draw_buffers-05.vert, but we should keep the other for
sure. We are required to have the preprocessor macro. It must be a
#define, and it must be 1. I like it's model a bit better than the
tests that do
float foo[GL_ARB_draw_instanced == 1 ? 1 : -1];
because those tests would pass if GL_ARB_draw_instanced was a constant
instead of a define. It's a really fine hair to split, but that's a
tests job. :)
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
