Re: [Mesa-dev] [PATCH] i965: Mask the cut index based on the index buffer type in 3DSTATE_VF.

2013-05-24 Thread Kenneth Graunke
On 05/23/2013 03:46 PM, Kenneth Graunke wrote: According to the documentation: "The Cut Index is compared to the fetched (and possibly-sign-extended) vertex index, and if these values are equal, the current primitive topology is terminated. Note that, for index buffers <32bpp, it is possible to

Re: [Mesa-dev] [PATCH 5/5] i965 gen7: use SURFACE_STATE fields to select render level/layer

2013-05-24 Thread Jordan Justen
On Fri, May 24, 2013 at 2:17 PM, Paul Berry wrote: > On 22 May 2013 20:00, Jordan Justen wrote: >> On Wed, May 22, 2013 at 3:56 PM, Eric Anholt wrote: >> > Jordan Justen writes: >> >> - surf[0] = BRW_SURFACE_2D << BRW_SURFACE_TYPE_SHIFT | >> >> + switch (gl_target) { >> >> + case GL_TEXTU

[Mesa-dev] [PATCH 0/7] Beginnings of ARB_shading_language_420pack

2013-05-24 Thread Matt Turner
I'm on vacation for the next week, so in case anyone else wants to finish off ARB_shading_language_420pack, here are the tests and patches I've done so far. They cover - Swizzles on scalars - .length() method of matrices and vectors - gl_{Max,Min}ProgramTexelOffset built-in constants (needs a p

[Mesa-dev] [PATCH 7/7] glsl: Disallow return with a void argument from void functions.

2013-05-24 Thread Matt Turner
NOTE: This is a candidate for the stable branches. --- src/glsl/ast_to_hir.cpp | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 6b56e87..6ee50f5 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_

[Mesa-dev] [PATCH 6/7] glsl: Allow non-constant expression initializers of const-qualified vars.

2013-05-24 Thread Matt Turner
Required by ARB_shading_language_420pack. --- src/glsl/ast_to_hir.cpp | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 6e689b4..6b56e87 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/as

[Mesa-dev] [PATCH 5/7] glsl: Allow implicit conversion of return values.

2013-05-24 Thread Matt Turner
Required by ARB_shading_language_420pack. --- src/glsl/ast_to_hir.cpp | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index b206380..6e689b4 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/as

[Mesa-dev] [PATCH 4/7] glsl: Add gl_{Max, Min}ProgramTexelOffset built-in constants.

2013-05-24 Thread Matt Turner
Required by ARB_shading_language_420pack. Note that the 420pack spec incorrectly specifies their values as (Min, Max) = (-7, 8) when they should be (-8, 7) as listed in the GLSL 4.30 and ESSL 3.0 specs. --- src/glsl/builtin_variables.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/s

[Mesa-dev] [PATCH 3/7] glsl: Allow swizzles on scalars.

2013-05-24 Thread Matt Turner
Required by ARB_shading_language_420pack. --- src/glsl/hir_field_selection.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/hir_field_selection.cpp b/src/glsl/hir_field_selection.cpp index cc7ba61..ceb0a4c 100644 --- a/src/glsl/hir_field_selection.cpp +++ b/src/g

[Mesa-dev] [PATCH 2/7] glsl: Allow .length() method on vectors and matrices.

2013-05-24 Thread Matt Turner
Required by ARB_shading_language_420pack. --- src/glsl/hir_field_selection.cpp | 58 ++-- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/src/glsl/hir_field_selection.cpp b/src/glsl/hir_field_selection.cpp index 0035a5f..cc7ba61 100644 --- a/src/

[Mesa-dev] [PATCH 1/7] mesa: Add infrastructure for ARB_shading_language_420pack.

2013-05-24 Thread Matt Turner
From: Todd Previte v2 [mattst88] - Split infrastructure into separate patch. - Add preprocessor #define. --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h

Re: [Mesa-dev] libclc: vload/vstore initial implementation

2013-05-24 Thread Tom Stellard
On Thu, May 23, 2013 at 07:49:39PM -0500, Aaron Watry wrote: > I've implemented the OpenCL vload/vstore builtin functions in two parts. > 1) Pure CL C implementation. No Assembly > 2) Add assembly optimizations for 32-bit int/uint loads/stores of 4+ component >vectors > > Note: The vstore impl

Re: [Mesa-dev] intel driver blit rework

2013-05-24 Thread Ian Romanick
On 05/24/2013 01:56 PM, Eric Anholt wrote: Here's a big rework of blitting. It's a followon to some of the work I started back in February to make struct intel_region die in a fire. It's not a reduction in code like I hoped, but it's a reduction in a lot of bugs and it should help make extensio

Re: [Mesa-dev] [PATCH 14/17] intel: Rebuild PBO blit glTexImage() on top of miptrees.

2013-05-24 Thread Eric Anholt
Ian Romanick writes: > On 05/24/2013 01:56 PM, Eric Anholt wrote: >> This will ensure that we have resolves if we ever extend this to >> glTexSubImage(), and fixes missing image start offset handling. >> >> The texture buffer alloc ended up getting moved up, because we want to >> look at the form

Re: [Mesa-dev] [PATCH 14/17] intel: Rebuild PBO blit glTexImage() on top of miptrees.

2013-05-24 Thread Ian Romanick
On 05/24/2013 01:56 PM, Eric Anholt wrote: This will ensure that we have resolves if we ever extend this to glTexSubImage(), and fixes missing image start offset handling. The texture buffer alloc ended up getting moved up, because we want to look at the format of the image's actual mt to see if

Re: [Mesa-dev] [PATCH 10/17] intel: Make a temporary miptree when doing blit uploads for glTexSubImage().

2013-05-24 Thread Ian Romanick
On 05/24/2013 01:56 PM, Eric Anholt wrote: While this is a bit more CPU work, it also is less code to handle this path, and fixes problems with 32k-pitch textures and missing resolves. --- src/mesa/drivers/dri/intel/intel_tex_subimage.c | 62 +++-- 1 file changed, 18 insert

Re: [Mesa-dev] [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

2013-05-24 Thread Ian Romanick
On 05/24/2013 01:56 PM, Eric Anholt wrote: For a blit-uploaded temporary, it's faster on current hardware to memcpy the data into a linear CPU mapping than to go through the GTT. --- src/mesa/drivers/dri/intel/intel_fbo.c | 2 +- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 22 +

Re: [Mesa-dev] [PATCH 08/17] intle: Add an assert for glCopyTexSubImage() being called on MSAA buffers.

2013-05-24 Thread Ian Romanick
On 05/24/2013 01:56 PM, Eric Anholt wrote: s/intle/intel/ in the title. This is just in case someone else trips over this due to our weird reuse of this code in glBlitFramebuffer(). --- src/mesa/drivers/dri/intel/intel_tex_copy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/

Re: [Mesa-dev] [PATCH 0/4] V2 Multiple viewports in Gallium

2013-05-24 Thread Roland Scheidegger
Am 24.05.2013 23:41, schrieb Zack Rusin: >> There's no documentation of PIPE_CAP_MAX_VIEWPORTS but otherwise the >> series looks good. > > I've just sent another patch with it. Let me know if that's enough. > > z > Thanks! That's certainly enough. Roland ___

Re: [Mesa-dev] [PATCH 00/12] i965/gen7+: Implement fast color clears.

2013-05-24 Thread Eric Anholt
Ian Romanick writes: > On 05/21/2013 04:52 PM, Paul Berry wrote: >> This series implements fast color clears, a Gen7+ feature which >> reduces memory bandwidth by deferring the memory writes involved in a >> glClear() until the same memory is later touched during rendering. >> >> From a broad ov

Re: [Mesa-dev] [PATCH V2 4/4] i965: Enable ext_framebuffer_multisample_blit_scaled on intel h/w

2013-05-24 Thread Eric Anholt
Paul Berry writes: > On 16 May 2013 11:44, Anuj Phogat wrote: > >> This patch enables ext_framebuffer_multisample_blit_scaled extension >> on intel h/w >= gen6. >> >> Note: Patches for piglit tests to verify this functionality are out >> for review on piglit mailing list. Tests pass for all of t

Re: [Mesa-dev] [PATCH 0/4] V2 Multiple viewports in Gallium

2013-05-24 Thread Zack Rusin
> There's no documentation of PIPE_CAP_MAX_VIEWPORTS but otherwise the > series looks good. I've just sent another patch with it. Let me know if that's enough. z ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH] gallium/docs: adds documentation for multi viewport cap

2013-05-24 Thread Zack Rusin
Signed-off-by: Zack Rusin --- src/gallium/docs/source/screen.rst |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index 2630491..0957e56 100644 --- a/src/gallium/docs/source/screen.rst +++ b/src/gallium/docs/sourc

Re: [Mesa-dev] [PATCH 5/5] i965 gen7: use SURFACE_STATE fields to select render level/layer

2013-05-24 Thread Paul Berry
On 22 May 2013 20:00, Jordan Justen wrote: > On Wed, May 22, 2013 at 3:56 PM, Eric Anholt wrote: > > Jordan Justen writes: > >> - surf[0] = BRW_SURFACE_2D << BRW_SURFACE_TYPE_SHIFT | > >> + switch (gl_target) { > >> + case GL_TEXTURE_CUBE_MAP_ARRAY: > >> + case GL_TEXTURE_CUBE_MAP: > >>

Re: [Mesa-dev] [PATCH 0/4] V2 Multiple viewports in Gallium

2013-05-24 Thread Roland Scheidegger
Am 24.05.2013 22:56, schrieb Zack Rusin: > This series adds support for multiple viewports/scissors > to gallium and implements it in llvmpipe. All the other > drivers still support just a single viewport/scissor > combo and their behavior should be exactly the same as > it was. > > I think this o

[Mesa-dev] [PATCH 16/17] intel: Fix format handling of blit glBitmap()

2013-05-24 Thread Eric Anholt
Any 32-bit format got ARGB handling (including, say, GL_RG1616), and anything else got 16-bit (including, say, GL_R8), which could potentially hang the GPU by writing out of bounds. NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/dri/intel/intel_pixel_bitmap.c | 15 +++

[Mesa-dev] [PATCH 15/17] intel: Fix MRT handling of glBitmap().

2013-05-24 Thread Eric Anholt
We'd only hit color buffer 0 even if multiple draw buffers were bound. NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/dri/intel/intel_pixel_bitmap.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/intel/int

[Mesa-dev] [PATCH 17/17] intel: Remove dead intel_drawbuf_region().

2013-05-24 Thread Eric Anholt
Since the glBitmap() MRT change, it's unused. There was basically no way to responsibly use this function since MRT was introduced. --- src/mesa/drivers/dri/intel/intel_buffers.c | 14 -- src/mesa/drivers/dri/intel/intel_buffers.h | 2 -- 2 files changed, 16 deletions(-) diff --git

[Mesa-dev] [PATCH 11/17] intel: Make a temporary miptree for the blit path of miptree mapping.

2013-05-24 Thread Eric Anholt
In a bit of debug code, we no longer have the inter-slice x/y to print. But I think the level/slice is more useful in this case for looking at what's getting mapped, especially given that INTEL_DEBUG=blit will tell you the other value. --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 99 ++

[Mesa-dev] [PATCH 14/17] intel: Rebuild PBO blit glTexImage() on top of miptrees.

2013-05-24 Thread Eric Anholt
This will ensure that we have resolves if we ever extend this to glTexSubImage(), and fixes missing image start offset handling. The texture buffer alloc ended up getting moved up, because we want to look at the format of the image's actual mt to see if we'll end up blitting the right thing, in th

[Mesa-dev] [PATCH 08/17] intle: Add an assert for glCopyTexSubImage() being called on MSAA buffers.

2013-05-24 Thread Eric Anholt
This is just in case someone else trips over this due to our weird reuse of this code in glBlitFramebuffer(). --- src/mesa/drivers/dri/intel/intel_tex_copy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_tex_copy.c b/src/mesa/drivers/dri/intel/intel_te

[Mesa-dev] [PATCH 12/17] intel: Rework intel_miptree_create_for_region() to wrap a BO.

2013-05-24 Thread Eric Anholt
I needed to do this for the PBO blit cases to use intel_miptree_blit(). But this also actually partially fixes a bug in EGLImage handling: We can't share regions across contexts, because regions have a refcount that isn't protected by a mutex, and different contexts can be simulataneously accessed

[Mesa-dev] [PATCH 13/17] intel: Rebuild PBO blit glReadPixels() on top of miptrees.

2013-05-24 Thread Eric Anholt
The previous code was missing depth resolves, that had only been prevented due to no blitting of Y tiling. The pair of flip args in the new blit function means that we can just drop the pack->Invert fallback. --- src/mesa/drivers/dri/intel/intel_pixel_read.c | 48 +-- 1 fi

[Mesa-dev] [PATCH 07/17] i965: Allow glCopyTexSubImage() on depth textures.

2013-05-24 Thread Eric Anholt
If the hw is pre-gen5 and can't blit depth, it'll cleanly error out. --- src/mesa/drivers/dri/intel/intel_tex_copy.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_copy.c b/src/mesa/drivers/dri/intel/intel_tex_copy.c index 7a38082..94e90da 100644 ---

[Mesa-dev] [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

2013-05-24 Thread Eric Anholt
For a blit-uploaded temporary, it's faster on current hardware to memcpy the data into a linear CPU mapping than to go through the GTT. --- src/mesa/drivers/dri/intel/intel_fbo.c | 2 +- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 22 +- src/mesa/drivers/dri/int

[Mesa-dev] [PATCH 10/17] intel: Make a temporary miptree when doing blit uploads for glTexSubImage().

2013-05-24 Thread Eric Anholt
While this is a bit more CPU work, it also is less code to handle this path, and fixes problems with 32k-pitch textures and missing resolves. --- src/mesa/drivers/dri/intel/intel_tex_subimage.c | 62 +++-- 1 file changed, 18 insertions(+), 44 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 06/17] i965: Prefer blorp glBlitFramebuffer() to the glCopyTexSubImage-based blit.

2013-05-24 Thread Eric Anholt
I think we've measured no performance difference from this in the past, except that the blorp code can do things like multisample resolves. Prevents piglit regression in the next commit when a testcase started trying to do a multisampled resolve through the old glCopyTexSubImage() path. --- src/me

[Mesa-dev] [PATCH 05/17] i965: Consistently do depth resolves before blitting.

2013-05-24 Thread Eric Anholt
We were protected for a long time by the fact that depth was Y tiled and you couldn't blit Y. Now that we can blit Y, we were failing to resolve depth in glCopyPixels(). Note in the comment about swrast, that the swrast map path does resolves appropriately already. --- src/mesa/drivers/dri/intel

[Mesa-dev] [PATCH 02/17] intel: Reduce intel_renderbuffer_tile_offsets to a thin wrapper.

2013-05-24 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_fbo.c | 26 -- src/mesa/drivers/dri/intel/intel_fbo.h | 9 +++-- 2 files changed, 7 insertions(+), 28 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index 69f8629..34f31fb

[Mesa-dev] [PATCH 01/17] intel: Make intel_miptree_get_tile_offsets return a page offset.

2013-05-24 Thread Eric Anholt
Right now, the callers in i965 don't expect a nonzero page offset to actually occur (since that's being handled elsewhere), but it seems like a trap to leave it this way. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 +++--- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 7 -

[Mesa-dev] [PATCH 04/17] intel: Make a wrapper for intelEmitCopyBlit using miptrees.

2013-05-24 Thread Eric Anholt
I had previously asserted that it was hard to write a useful, simpler blit function, but I think this might be it. This has the side effect of extending the 32k pitch check to a few more places that were missing it. --- src/mesa/drivers/dri/intel/intel_blit.c| 91 +

[Mesa-dev] [PATCH 03/17] intel: Rename intel_renderbuffer_tile_offsets.

2013-05-24 Thread Eric Anholt
This makes it more consistent with intel_miptree_get_tile_offsets(). --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 4 ++-- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 2 +- src/mesa/drivers/dri/intel/intel_fbo.h| 6 +++--- 3 files changed, 6 insertions(+), 6 deletions

[Mesa-dev] intel driver blit rework

2013-05-24 Thread Eric Anholt
Here's a big rework of blitting. It's a followon to some of the work I started back in February to make struct intel_region die in a fire. It's not a reduction in code like I hoped, but it's a reduction in a lot of bugs and it should help make extension of our driver to support fast color clears

[Mesa-dev] [PATCH 4/4] draw: fixup draw_find_shader_output

2013-05-24 Thread Zack Rusin
draw_find_shader_output like most of the code in draw used to depend on position always being at output slot 0. which meant that any other attribute being at 0 could signify an error. unfortunately position can be at any of the output slots, thus other attributes can occupy slot 0 and we need to ma

[Mesa-dev] [PATCH 3/4] llvmpipe: implement support for multiple viewports

2013-05-24 Thread Zack Rusin
Largely related to making sure the rasterizer can correctly pick out the correct scissor box for the current viewport. Signed-off-by: Zack Rusin --- src/gallium/drivers/llvmpipe/lp_context.h |7 -- src/gallium/drivers/llvmpipe/lp_screen.c|2 +- src/gallium/drivers/llvmp

[Mesa-dev] [PATCH 2/4] draw: implement support for multiple viewports

2013-05-24 Thread Zack Rusin
This adds support for multiple viewports to the draw module. Multiple viewports depend on the presence of geometry shaders which can write the viewport index. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_cliptest_tmp.h | 10 +++- src/gallium/auxiliary/draw/draw_context.c

[Mesa-dev] [PATCH 0/4] V2 Multiple viewports in Gallium

2013-05-24 Thread Zack Rusin
This series adds support for multiple viewports/scissors to gallium and implements it in llvmpipe. All the other drivers still support just a single viewport/scissor combo and their behavior should be exactly the same as it was. I think this one takes care of all the comments. I think it addre

Re: [Mesa-dev] [PATCH] i965: Mask the cut index based on the index buffer type in 3DSTATE_VF.

2013-05-24 Thread Paul Berry
On 24 May 2013 12:23, Ian Romanick wrote: > On 05/23/2013 03:46 PM, Kenneth Graunke wrote: > >> According to the documentation: "The Cut Index is compared to the >> fetched (and possibly-sign-extended) vertex index, and if these values >> > > Which documentation is this? The only types that are

[Mesa-dev] [PATCH] radeonsi/compute: Pass kernel arguments in a buffer v2

2013-05-24 Thread Tom Stellard
From: Tom Stellard v2: - Fix memory leak in si_set_constant_buffer() --- src/gallium/drivers/radeonsi/r600_buffer.c | 29 + src/gallium/drivers/radeonsi/radeonsi_compute.c | 26 ++ src/gallium/drivers/radeonsi/si_state.c | 23 ++-

Re: [Mesa-dev] [PATCH 4/5] radeonsi/compute: Pass kernel arguments in a buffer

2013-05-24 Thread Tom Stellard
On Fri, May 24, 2013 at 01:32:20PM -0500, Patrick Baggett wrote: > The only difference I could see is that in the old code you passed > &cb->buffer (which maybe points to a value?) directly into u_upload_data() > where as in the new code, you do pass &cb->buffer as the parameter rbuffer > to r600_u

Re: [Mesa-dev] [PATCH 10/12] sso: update glGet: GL_PROGRAM_PIPELINE_BINDING

2013-05-24 Thread gregory hainaut
On Sat, 4 May 2013 11:35:22 +0200 gregory hainaut wrote: > On Fri, 3 May 2013 12:04:48 -0700 > Matt Turner wrote: > > > On Fri, May 3, 2013 at 10:44 AM, Gregory Hainaut > > wrote: > > > --- > > > src/mesa/main/get.c |9 + > > > src/mesa/main/get_hash_params.py |3

Re: [Mesa-dev] [PATCH 00/12] i965/gen7+: Implement fast color clears.

2013-05-24 Thread Ian Romanick
On 05/21/2013 04:52 PM, Paul Berry wrote: This series implements fast color clears, a Gen7+ feature which reduces memory bandwidth by deferring the memory writes involved in a glClear() until the same memory is later touched during rendering. From a broad overview point of view, fast color clea

Re: [Mesa-dev] [PATCH] i965: Mask the cut index based on the index buffer type in 3DSTATE_VF.

2013-05-24 Thread Ian Romanick
On 05/23/2013 03:46 PM, Kenneth Graunke wrote: According to the documentation: "The Cut Index is compared to the fetched (and possibly-sign-extended) vertex index, and if these values Which documentation is this? The only types that are valid for index buffers are unsigned, so what does "poss

Re: [Mesa-dev] [PATCH V2 4/4] i965: Enable ext_framebuffer_multisample_blit_scaled on intel h/w

2013-05-24 Thread Paul Berry
On 16 May 2013 11:44, Anuj Phogat wrote: > This patch enables ext_framebuffer_multisample_blit_scaled extension > on intel h/w >= gen6. > > Note: Patches for piglit tests to verify this functionality are out > for review on piglit mailing list. Tests pass for all of the scaling > factors from 0.1

Re: [Mesa-dev] [PATCH V2 3/4] intel: Add multisample scaled blitting in blorp engine

2013-05-24 Thread Paul Berry
On 16 May 2013 11:44, Anuj Phogat wrote: > In traditional multisampled framebuffer rendering, color samples must be > explicitly resolved via BlitFramebuffer before doing the scaled blitting > of the framebuffer. So, scaled blitting of a multisample framebuffer > takes two separate calls to BlitF

Re: [Mesa-dev] [PATCH V2 2/4] intel: Change the register type from UW to UD in blorp engine

2013-05-24 Thread Paul Berry
On 16 May 2013 11:44, Anuj Phogat wrote: > These changes are required to implement scaled blitting in blorp > in my next patch. > > No regressions observed in piglit quick-driver.tests with this patch. > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_blorp.h| 15 ++-

Re: [Mesa-dev] [PATCH 4/5] radeonsi/compute: Pass kernel arguments in a buffer

2013-05-24 Thread Patrick Baggett
The only difference I could see is that in the old code you passed &cb->buffer (which maybe points to a value?) directly into u_upload_data() where as in the new code, you do pass &cb->buffer as the parameter rbuffer to r600_upload_const_buffer(), but then inside that function, you do *rbuffer = NU

Re: [Mesa-dev] [PATCH v2 1/4] mesa: Implement ext_framebuffer_multisample_blit_scaled extension

2013-05-24 Thread Paul Berry
On 16 May 2013 11:44, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > Reviewed-by: Paul Berry > Reviewed-by: Brian Paul > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/fbobject.c | 30 +++--- > src/mesa/main/mtypes.h | 1 + > 3 files changed, 29 ins

[Mesa-dev] [PATCH 5/5] radeonsi/compute: Upload work group, work item size in input buffer

2013-05-24 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 38 ++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index 035076d..3abf50b 100644

[Mesa-dev] [PATCH 2/5] radeonsi/compute: Support multiple kernels in a compute program

2013-05-24 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 27 - 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index e67d127..1ae7d9b 100644 -

[Mesa-dev] [PATCH 4/5] radeonsi/compute: Pass kernel arguments in a buffer

2013-05-24 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/r600_buffer.c | 31 + src/gallium/drivers/radeonsi/radeonsi_compute.c | 26 ++--- src/gallium/drivers/radeonsi/si_state.c | 29 +++ 3 files changed, 51 insertions(+), 35 d

[Mesa-dev] [PATCH 3/5] radeonsi/compute: Implement un-binding of global buffers

2013-05-24 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 31 +++-- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index 1ae7d9b..3fb6eb1 100644

[Mesa-dev] [PATCH 1/5] radeonsi/compute: Add missing PIPE_COMPUTE caps

2013-05-24 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_pipe.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src/gallium/drivers/radeonsi/radeonsi_pipe.c index b988e72..7a79db3 100644 --- a/src/gallium/drivers/radeonsi/

[Mesa-dev] radeonsi compute improvements

2013-05-24 Thread Tom Stellard
Hi, These patches along with the associated LLVM changes improve compute support on radeonsi to the point were it can run a number of simple apps, including the bitcoin mining program bfgminer. Patch #4 re-introduces the r600_upload_const_buffer() function that was removed in eb19163a4dd3d7bfeed

Re: [Mesa-dev] [PATCH] i965: Mask the cut index based on the index buffer type in 3DSTATE_VF.

2013-05-24 Thread Kenneth Graunke
On 05/23/2013 04:14 PM, Jordan Justen wrote: On Thu, May 23, 2013 at 3:46 PM, Kenneth Graunke wrote: According to the documentation: "The Cut Index is compared to the fetched (and possibly-sign-extended) vertex index, and if these values are equal, the current primitive topology is terminated.

[Mesa-dev] [PATCH 7/7] radeonsi: Enable GLSL 1.30

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src/gallium/drivers/radeonsi/radeonsi_pipe.c index b988e72..30254a8 100644 --- a/

[Mesa-dev] [PATCH 6/7] radeonsi: Handle TGSI_SEMANTIC_CLIPDIST

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c index 5

[Mesa-dev] [PATCH 5/7] radeonsi: Handle TGSI TXQ opcode

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c in

[Mesa-dev] [PATCH 2/7] radeonsi: Make border colour state handling safe for integer textures

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_pipe.h | 2 +- src/gallium/drivers/radeonsi/si_state.c | 45 2 files changed, 27 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.

[Mesa-dev] [PATCH 0/7] radeonsi: GLSL 1.30 support

2013-05-24 Thread Michel Dänzer
This series fixes a couple of problems in preparation, then adds the missing functionality for GLSL 1.30 and finally enables it. This enables around 800 more piglit tests, keeping the overall passrate about the same as before. [PATCH 1/7] radeonsi: Fix hardware state for dual source blending [PATC

[Mesa-dev] [PATCH 3/7] radeonsi: Use tgsi_util_get_texture_coord_dim()

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 32 ++ 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c in

[Mesa-dev] [PATCH 1/7] radeonsi: Fix hardware state for dual source blending

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Set up CB_SHADER_MASK register according to pixel shader exports, and enable some minimal state for colour buffer 1 in case dual source blending is used. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 5 + src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 4/7] radeonsi: Add support for TGSI TXF opcode

2013-05-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 63 -- 1 file changed, 50 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c i

[Mesa-dev] [Bug 64959] New: Cannot build against EGL without X11

2013-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64959 Priority: medium Bug ID: 64959 Assignee: mesa-dev@lists.freedesktop.org Summary: Cannot build against EGL without X11 Severity: normal Classification: Unclassified OS: All

Re: [Mesa-dev] [PATCH 03/13] gallium: Introduce 32-bit bytewise format names

2013-05-24 Thread Jose Fonseca
- Original Message - > Michel Dänzer writes: > >> > For packed formats such as RGBA, the order used in these patches > >> > (which is what I suggested in my proposal) matches the order humans use > >> > for digits of numbers, as well as the Mesa formats. That seems more > >> > import

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-24 Thread Brian Paul
On 05/23/2013 03:02 PM, Roland Scheidegger wrote: Am 23.05.2013 22:33, schrieb Zack Rusin: Gallium supported only a single viewport/scissor combination. This commit changes the interface to allow us to add support for multiple viewports/scissors. Signed-off-by: Zack Rusin --- diff --git a/src/

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-24 Thread Brian Paul
Just some minor formatting nits below... On 05/23/2013 02:33 PM, Zack Rusin wrote: Gallium supported only a single viewport/scissor combination. This commit changes the interface to allow us to add support for multiple viewports/scissors. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH 2/2] xlib: add null ctx check in glXDestroyContext()

2013-05-24 Thread Jose Fonseca
- Original Message - > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64934 > NOTE: This is a candidate for the stable branches. > --- > src/mesa/drivers/x11/fakeglx.c | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/dr

Re: [Mesa-dev] [v4 10/10] egl: dri2: support for creating images out of dma buffers

2013-05-24 Thread Chad Versace
On 05/23/2013 10:15 PM, Pohjolainen, Topi wrote: On Thu, May 23, 2013 at 09:39:30PM -0700, Chad Versace wrote: When touching the src/egl/drivers/dri2 directory, use a commit subject that looks like "egl/dri2: STUFF", not "egl: dri2: STUFF". [snip] +/** + * The spec says: + * + * "If eglCreat

[Mesa-dev] [Bug 64934] [llvmpipe] SIGSEGV src/gallium/state_trackers/glx/xlib/glx_api.c:1363

2013-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64934 --- Comment #1 from Brian Paul --- I've posted patches to add null pointer checking in glXDestroyContext. But the latest build of glxinfo wouldn't call glXDestroyContext with a null context either. In any case, I'm not sure why context creation

[Mesa-dev] [PATCH 2/2] xlib: add null ctx check in glXDestroyContext()

2013-05-24 Thread Brian Paul
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64934 NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/x11/fakeglx.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fa

[Mesa-dev] [PATCH 1/2] st/glx: add null ctx check in glXDestroyContext()

2013-05-24 Thread Brian Paul
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64934 NOTE: This is a candidate for the stable branches. --- src/gallium/state_trackers/glx/xlib/glx_api.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/glx/xlib/glx_a

[Mesa-dev] [Bug 64952] Build failure in egl-static when using llvm-3.3

2013-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64952 --- Comment #1 from Gustav Petersson --- Created attachment 79759 --> https://bugs.freedesktop.org/attachment.cgi?id=79759&action=edit Proposed patch for building egl-static -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 64952] New: Build failure in egl-static when using llvm-3.3

2013-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64952 Priority: medium Bug ID: 64952 Assignee: mesa-dev@lists.freedesktop.org Summary: Build failure in egl-static when using llvm-3.3 Severity: normal Classification: Unclassified

Re: [Mesa-dev] [v4 06/10] intel: prepare for dri images having more than one plane

2013-05-24 Thread Pohjolainen, Topi
On Thu, May 23, 2013 at 09:39:57PM -0700, Chad Versace wrote: > On 05/02/2013 12:08 AM, Topi Pohjolainen wrote: > >v2 (as advised by Eric): > >- use ARRAY_SIZE > >- re-use 'image_destroy' for cleaning up after failure > >- check directly the region pointer instead of the buffer object >

[Mesa-dev] [PATCH 3/3] st/vdpau: destroy handle table only when it's empty

2013-05-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/htab.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/htab.c b/src/gallium/state_trackers/vdpau/htab.c index 39ff7be..8b809f2 100644 --- a/src/gall

[Mesa-dev] [PATCH 1/3] st/vdpau: invalidate the handles on destruction

2013-05-24 Thread Christian König
From: Christian König Fixes a problem with xbmc when switching channels. Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/decode.c |1 + src/gallium/state_trackers/vdpau/device.c |1 + src/gallium/state_trackers/vdpau/surface.c |2 ++ 3 files changed, 4 inserti

[Mesa-dev] [PATCH 2/3] st/vdpau: remove vlCreateHTAB from surface functions

2013-05-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/surface.c |9 - 1 file changed, 9 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/gallium/state_trackers/vdpau/surface.c index 135eb85..bd11fc3 100644 --- a/src/gal