Ian Romanick <i...@freedesktop.org> writes: > On 05/24/2013 01:56 PM, Eric Anholt wrote: >> This will ensure that we have resolves if we ever extend this to >> glTexSubImage(), and fixes missing image start offset handling. >> >> The texture buffer alloc ended up getting moved up, because we want to >> look at the format of the image's actual mt to see if we'll end up >> blitting the right thing, in the case of packed depth/stencil uploads. >> >> This is the last caller of intelEmitCopyBlit() on a miptree-wrapped BO. > > It looks like after this the two remaining callers are all in > intel_blit.c. Should intelEmitCopyBlit be static? > > Looking at what's left, it looks like there should be some more > refactoring of intelEmitCopyBlit after this commit. A bunch of the > checks, etc. in intelEmitCopyBlit are only relevant for one of the > callers. That can happen later, if there's value.
I thought about doing so, but the aperture check is painful enough I decided not to duplicate it.
pgpIMP1X7ncvj.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
