Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-17 Thread Milan Kostić
It is weird, i am not sure what happens neither. I assume because in emit_cb_setup XRGB is mapped to dst_format R200_COLOR_FORMAT_ARGB, but in emit_tx_setup XRGB src_mesa_format not have alpha. It looks OK but does not work good for some reason, so i added R200_TXFORMAT_ALPHA_IN_MAP to

Re: [Mesa-dev] [PATCH 5/7] glsl/build: Don't build builtin_compiler separately if not cross compiling

2013-01-17 Thread Thierry Reding
On Thu, Jan 17, 2013 at 02:59:49PM -0800, Matt Turner wrote: > On Thu, Jan 17, 2013 at 1:42 PM, Matt Turner wrote: > > On Wed, Jan 16, 2013 at 10:55 PM, Thierry Reding > > wrote: > >> On Wed, Jan 16, 2013 at 03:14:14PM -0800, Matt Turner wrote: > >> [...] > >>> diff --git a/src/glsl/Makefile.am b

[Mesa-dev] [Bug 59541] New: [swrast] pigit fbo-blit regression

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59541 Priority: medium Bug ID: 59541 Keywords: regression CC: anuj.pho...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [swrast] pigit fbo-blit regression Sever

Re: [Mesa-dev] [PATCH] gallium: Remove ppc asm backend

2013-01-17 Thread Brian Paul
On 01/17/2013 01:00 PM, Adam Jackson wrote: The vs part hasn't been wired up since tgsi_sse2 was disabled in: commit 4eb3225b38ce12cb34ab3d90804c9683bd7b4ed3 Author: José Fonseca Date: Tue Nov 8 00:10:47 2011 + Remove tgsi_sse2. And it would certainly not work corr

[Mesa-dev] [PATCH] glxinfo: add support for creating/querying core-profile contexts (v3)

2013-01-17 Thread Dave Airlie
From: Brian Paul [airlied: Based on Brian's patch, I've fixed it up to always report a non-core and core profile, after each other, and dropped the -c flag as its redunant now] The -c flag says to try to create a core profile (no legacy features) using glXCreateContextAttribsARB(). A core profi

Re: [Mesa-dev] [PATCH 5/7] glsl/build: Don't build builtin_compiler separately if not cross compiling

2013-01-17 Thread Matt Turner
On Thu, Jan 17, 2013 at 1:42 PM, Matt Turner wrote: > On Wed, Jan 16, 2013 at 10:55 PM, Thierry Reding > wrote: >> On Wed, Jan 16, 2013 at 03:14:14PM -0800, Matt Turner wrote: >> [...] >>> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am >>> index fa09c5e..07fcf96 100644 >>> --- a/src/gls

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Alex Deucher
On Thu, Jan 17, 2013 at 12:32 PM, Michel Dänzer wrote: > On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer wrote: >> On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: >> > Forking r600g was obviously a bad idea, because now radeonsi is just >> > as horrible as r600g used to be. >> >> What do yo

[Mesa-dev] [Bug 59534] Automake Regression: Erroneous errors messages printed when using clover

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59534 Tom Stellard changed: What|Removed |Added Blocks||59304 -- You are receiving this mail bec

[Mesa-dev] [Bug 59304] Meta Bug for regressions caused by automake conversion

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59304 Tom Stellard changed: What|Removed |Added Depends on||59534 -- You are receiving this mail bec

[Mesa-dev] [Bug 59534] New: Automake Regression: Erroneous errors messages printed when using clover

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59534 Priority: medium Bug ID: 59534 Assignee: mesa-dev@lists.freedesktop.org Summary: Automake Regression: Erroneous errors messages printed when using clover Severity: normal

[Mesa-dev] [Bug 59334] Automake Regression - Clover: Assertion failures when loading pipe_r600.so driver

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59334 --- Comment #4 from Tom Stellard --- (In reply to comment #3) > Created attachment 73013 [details] > Work around for bug > > This patch works around the bug by linking against libgallium.a rather than > libgallium.la. However, this is not a goo

Re: [Mesa-dev] [PATCH 5/7] glsl/build: Don't build builtin_compiler separately if not cross compiling

2013-01-17 Thread Matt Turner
On Wed, Jan 16, 2013 at 10:55 PM, Thierry Reding wrote: > On Wed, Jan 16, 2013 at 03:14:14PM -0800, Matt Turner wrote: > [...] >> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am >> index fa09c5e..07fcf96 100644 >> --- a/src/glsl/Makefile.am >> +++ b/src/glsl/Makefile.am >> @@ -19,7 +19,11

Re: [Mesa-dev] [PATCH 1/3] i965/vs: Create a 'lod_type' temporary for ir->lod_info.lod->type.

2013-01-17 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick You should add the stable branch annotation to patch 1 as well. Without that, automatic picker scripts won't pick it. On 01/16/2013 09:15 PM, Kenneth Graunke wrote: This is purely a refactor. However, in a moment, we'll want to set lod_type to float for

Re: [Mesa-dev] [PATCH] mesa: Only mark textures as mipmap incomplete on MAX_LEVEL issues.

2013-01-17 Thread Ian Romanick
On 01/17/2013 09:58 AM, Kenneth Graunke wrote: According to the OpenGL 3.2 Core Profile specification, section 3.8.12: "For one-, two-, and three-dimensional and one-and two-dimensional array textures, a texture is mipmap complete if all of the following conditions hold true: - [...] - l

[Mesa-dev] [PATCH 3/3] radeonsi: More assorted depth/stencil changes ported from r600g.

2013-01-17 Thread Michel Dänzer
From: Michel Dänzer [ Squashed port of the following r600g commits: - Michel Dänzer ] commit 428e37c2da420f7dc14a2ea265f2387270f9bee1 Author: Marek Olšák Date: Tue Oct 2 22:02:54 2012 +0200 r600g: add in-place DB decompression and texturing with DB tiling The decompression is done i

[Mesa-dev] [PATCH 1/3] radeonsi: Assorted depth/stencil changes ported from r600g.

2013-01-17 Thread Michel Dänzer
From: Marek Olšák [ Squashed port of the following r600g commits: - Michel Dänzer ] commit c1e8c845ea9c6f843cc5bba5974668c007799bbc Author: Marek Olšák Date: Sat Jul 7 19:10:00 2012 +0200 r600g: inline r600_hw_copy_region commit 4891c5dc64ccd8cf2bf8a8550ae23e1a61806a7d Author: Marek Olš

[Mesa-dev] [PATCH 2/3] radeonsi: improve flushed depth texture handling

2013-01-17 Thread Michel Dänzer
From: Vadim Girlin Use r600_resource_texture::flished_depth_texture for GPU access, and allocate it in the VRAM. For transfers we'll allocate texture in the GTT and store it in the r600_transfer::staging. Improves performance when flushed depth texture is frequently used by the GPU, e.g. in Ligh

Re: [Mesa-dev] [PATCH] (9.0) gallivm: support more immediates in lp_build_tgsi_info()

2013-01-17 Thread Brian Paul
On 01/17/2013 11:07 AM, Andreas Boll wrote: From: Brian Paul Bump limit from 32 to 128. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=58545 (cherry picked from commit 1b6ba9c4c840e291cbbe19a8601b56d1d103179c) --- Fixes the following crashing piglit tests on 9.0 with llvmpipe: ./bin/varyin

[Mesa-dev] [PATCH 1/2] radeonsi: Fix 1D tiling mode index for non-scanout resources.

2013-01-17 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_state.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f7fe603..ee353ed 100644 --- a/src/gall

[Mesa-dev] [PATCH 2/2] radeonsi: Enable 1D tiling for non-depth resources as well.

2013-01-17 Thread Michel Dänzer
From: Michel Dänzer No piglit regressions anymore thanks to fixes in libdrm_radeon and here. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/r600_texture.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/r600_texture.c b/src/

[Mesa-dev] [PATCH] (9.0) gallivm: support more immediates in lp_build_tgsi_info()

2013-01-17 Thread Andreas Boll
From: Brian Paul Bump limit from 32 to 128. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=58545 (cherry picked from commit 1b6ba9c4c840e291cbbe19a8601b56d1d103179c) --- Fixes the following crashing piglit tests on 9.0 with llvmpipe: ./bin/varying-packing-simple mat2x4 array -auto -fbo ./bi

[Mesa-dev] [PATCH] mesa: Only mark textures as mipmap incomplete on MAX_LEVEL issues.

2013-01-17 Thread Kenneth Graunke
According to the OpenGL 3.2 Core Profile specification, section 3.8.12: "For one-, two-, and three-dimensional and one-and two-dimensional array textures, a texture is mipmap complete if all of the following conditions hold true: - [...] - levelbase <= levelmax [...] Using the preceding defi

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Michel Dänzer
On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer wrote: > On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: > > Forking r600g was obviously a bad idea, because now radeonsi is just > > as horrible as r600g used to be. > > What do you suggest? That's an honest question, BTW. It's certainly b

Re: [Mesa-dev] use of likey() / unlikely() macros

2013-01-17 Thread Patrick Baggett
On Thu, Jan 17, 2013 at 10:37 AM, Brian Paul wrote: > > In compiler.h we define the likely(), unlikely() macros which wrap GCC's > __builtin_expect(). But we only use them in a handful of places. > > It seems to me that an obvious place to possibly use these would be for GL > error testing. For

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Michel Dänzer
On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: > This is a pretty ugly hack. It won't work if a depth texture is set in > a fragment shader and a non-depth texture is later set in a vertex > shader. That will cause have_depth_texture to be false. > > The proper solution is to port the dept

Re: [Mesa-dev] [PATCH 2/2] es3: Don't check dimensions in _mesa_es3_error_check_format_and_type

2013-01-17 Thread Anuj Phogat
On Thu, Jan 17, 2013 at 5:06 AM, Ian Romanick wrote: > From: Ian Romanick > > Filtering of DEPTH_COMPONENT and DEPTH_STENCIL for TEXTURE_3D is already > done in texture_error_check because these combinations aren't allowed on > desktop GL either. > > Signed-off-by: Ian Romanick > --- > src/mesa

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Marek Olšák
This is a pretty ugly hack. It won't work if a depth texture is set in a fragment shader and a non-depth texture is later set in a vertex shader. That will cause have_depth_texture to be false. The proper solution is to port the depth-texture tracking from r600g, well, ideally the whole r600_textu

[Mesa-dev] [Bug 59499] SIGSEGV src/mesa/swrast/s_blit.c:546

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59499 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] use of likey() / unlikely() macros

2013-01-17 Thread Brian Paul
In compiler.h we define the likely(), unlikely() macros which wrap GCC's __builtin_expect(). But we only use them in a handful of places. It seems to me that an obvious place to possibly use these would be for GL error testing. For example, in glDrawArrays(): if (unlikely(count <= 0))

Re: [Mesa-dev] [PATCH] swrast: fix assorted bugs in software blit code

2013-01-17 Thread Anuj Phogat
On Thu, Jan 17, 2013 at 9:37 PM, Brian Paul wrote: > 1. The loop over dest buffers in blit_linear() needed a null pointer > check. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=59499 > > 2. The code to grab the drawRb's format needs to be inside the drawing loop. > > 3. An equality test was

Re: [Mesa-dev] [PATCH] i965: Lower textureGrad() with samplerCubeShadow on pre-Haswell.

2013-01-17 Thread Anuj Phogat
On Thu, Jan 17, 2013 at 12:56 AM, Kenneth Graunke wrote: > Fixes regressions since commit 899017fc54c40c969b5239b33f3a17b311878b0d > Author: Kenneth Graunke > Date: Fri Jan 4 07:53:09 2013 -0800 > > i965: Use Haswell's sample_d_c for textureGrad with shadow samplers. > > That patch assumed

Re: [Mesa-dev] [PATCH] swrast: fix assorted bugs in software blit code

2013-01-17 Thread Kenneth Graunke
On 01/17/2013 08:07 AM, Brian Paul wrote: 1. The loop over dest buffers in blit_linear() needed a null pointer check. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=59499 2. The code to grab the drawRb's format needs to be inside the drawing loop. 3. An equality test was using = instead of

Re: [Mesa-dev] [PATCH] mesa: add missing ASSERT_OUTSIDE_BEGIN_END() in _mesa_GetInternalformativ()

2013-01-17 Thread Eric Anholt
Reviewed-by: Eric Anholt I'm actually in the process of trying out using dispatch tables to take care of ASSERT_OUTSIDE_BEGIN_END, since I'm pretty sure we forget them all the time, and it's extra overhead in all of our core GL entrypoints. pgpcbkM639B71.pgp Description: PGP signature _

Re: [Mesa-dev] [PATCH] swrast: Initialize drawFormat in blit_linear after drawRb is initialized

2013-01-17 Thread Brian Paul
I just posted a patch that fixes this and several other issues in that code. I didn't see your patch until just now. I think we should go with mine. -Brian On Thu, Jan 17, 2013 at 7:43 AM, Anuj Phogat wrote: > This fixes a segfault in blit_linear() function: > https://bugs.freedesktop.org/sho

[Mesa-dev] [PATCH] swrast: fix assorted bugs in software blit code

2013-01-17 Thread Brian Paul
1. The loop over dest buffers in blit_linear() needed a null pointer check. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=59499 2. The code to grab the drawRb's format needs to be inside the drawing loop. 3. An equality test was using = instead of == thus messing up a renderbuffer attachmen

Re: [Mesa-dev] [PATCH 02/10] glsl: Track UBO block names in the symbol table.

2013-01-17 Thread Ian Romanick
On 01/16/2013 11:56 PM, Pohjolainen, Topi wrote: On Wed, Jan 16, 2013 at 03:03:41PM -0800, Ian Romanick wrote: From: Kenneth Graunke The GLSL 1.40 spec says: "Uniform block names and variable names declared within uniform blocks are scoped at the program level." Track the block nam

[Mesa-dev] [PATCH V5 6/7] intel: Create a miptree using offsets in intel_set_texture_image_region

2013-01-17 Thread Abdiel Janulgue
When binding a region to a texture image, re-create the miptree base-level considering the offset and dimension information exported by DRIImage. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/intel/intel_tex_image.c | 31 -- 1 file changed, 24 insertions(+), 7

[Mesa-dev] [PATCH V5 5/7] i965: Account for offsets when updating SURFACE_STATE.

2013-01-17 Thread Abdiel Janulgue
If the offsets are present, this lets us specify a particular level and slice in a shared region using the base level of an exported mip-map tree. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 +++- src/mesa/drivers/dri/i965/gen7_wm_surface_s

[Mesa-dev] [PATCH V5 7/7] intel: implement create image from texture

2013-01-17 Thread Abdiel Janulgue
Save miptree level info to DRIImage: - Appropriately-aligned base offset pointing to the image - x/y offsets from miptree's base address In non-tile-aligned surface cases where resolving back to the original image located in mip-levels higher than the base level proves problematic due to offset al

[Mesa-dev] [PATCH V5 4/7] intel: add pixel offset calculator for miptree levels

2013-01-17 Thread Abdiel Janulgue
Add helper to calculate fine-grained x and y adjustment pixels to an image within a miptree level for tiled regions. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 15 +++ src/mesa/drivers/dri/intel/intel_mipmap_tree.h |6 ++ 2 files cha

[Mesa-dev] [PATCH V5 3/7] intel: Expose intel_miptree_create_internal as intel_miptree_create_layout.

2013-01-17 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 37 src/mesa/drivers/dri/intel/intel_mipmap_tree.h | 14 - 2 files changed, 31 insertions(+), 20 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_mipmap_tree.c b/sr

[Mesa-dev] [PATCH V5 1/7] dri2: Create image from texture

2013-01-17 Thread Abdiel Janulgue
Add create image from texture extension and bump version. Signed-off-by: Abdiel Janulgue --- include/GL/internal/dri_interface.h | 14 +- src/egl/drivers/dri2/egl_dri2.c | 85 +++ 2 files changed, 98 insertions(+), 1 deletion(-) diff --git a/include/G

[Mesa-dev] [PATCH V5 2/7] intel: expose dimensions and offsets of a miptree level in DRIImage

2013-01-17 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/intel/intel_regions.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_regions.h b/src/mesa/drivers/dri/intel/intel_regions.h index 8737a6d..95b65de 100644 --- a/src/mesa/drivers/dri/intel/intel

[Mesa-dev] [PATCH V5 0/7]intel: add support for EGL_KHR_gl_image

2013-01-17 Thread Abdiel Janulgue
Changes since v4: * Drop texture 3D support for now (until we test it with piglit). I plan to add it incrementally as soon as piglit tests for it are done. * Drop useless errors warnings and report proper EGL errors. * Expose intel_miptree_create_internal as intel_miptree_create_layout * Simplif

Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-17 Thread Roland Scheidegger
Am 16.01.2013 17:52, schrieb Milan Kostić: > No, no regress in piglit i've seen at all, only better... i even > played whole Drawn 2 game: > http://www.drawngame.com/games/dark-flight > under wine in OpenGL mode, it works perfectly now, needs culling under > fbo which is fixed now and this fix to

[Mesa-dev] [PATCH] swrast: Initialize drawFormat in blit_linear after drawRb is initialized

2013-01-17 Thread Anuj Phogat
This fixes a segfault in blit_linear() function: https://bugs.freedesktop.org/show_bug.cgi?id=59499 Signed-off-by: Anuj Phogat --- src/mesa/swrast/s_blit.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/swrast/s_blit.c b/src/mesa/swrast/s_blit.c index 043b578

Re: [Mesa-dev] [PATCH] radeonsi/vdpau: remove nonsense state tracker dep

2013-01-17 Thread Christian König
Am 16.01.2013 19:05, schrieb Matt Turner: On Wed, Jan 16, 2013 at 6:18 AM, Christian König wrote: From: Christian König Added with automake conversion, but makes no sense at all. Not according to git...? See e3b2160a1ffcfba0ff60cb47c17bd1a41afb63db. It looks like it was in the old Makefile t

[Mesa-dev] [Bug 59501] mesa/main/api_exec.c:286: undefined reference to `SET_GetInternalformativ'

2013-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59501 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---